[PATCH 1/2] xfs: Add realtime group

[PATCH 1/2] xfs: Add realtime group

[Chandan Babu R]

This commit adds a new group to classify tests that can work with
realtime devices.

Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
---
 tests/xfs/group | 52 ++++++++++++++++++++++++-------------------------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/tests/xfs/group b/tests/xfs/group
index ed0d389e..3bb0f674 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -67,7 +67,7 @@
 067 acl attr auto quick
 068 auto stress dump
 069 ioctl auto quick
-070 auto quick repair
+070 auto quick repair realtime
 071 rw auto
 072 rw auto prealloc quick
 073 copy auto
@@ -87,11 +87,11 @@
 087 fuzzers
 088 fuzzers
 089 fuzzers
-090 rw auto
+090 rw auto realtime
 091 fuzzers
 092 other auto quick
 093 fuzzers
-094 metadata dir ioctl auto
+094 metadata dir ioctl auto realtime
 095 log v2log auto
 096 mkfs v2log auto quick
 097 fuzzers
@@ -119,7 +119,7 @@
 119 log v2log auto freeze
 120 fuzzers
 121 shutdown log auto quick
-122 other auto quick clone
+122 other auto quick clone realtime
 123 fuzzers
 124 fuzzers
 125 fuzzers
@@ -128,7 +128,7 @@
 128 auto quick clone fsr
 129 auto quick clone
 130 fuzzers clone
-131 auto quick clone
+131 auto quick clone realtime
 132 auto quick
 133 dangerous_fuzzers
 134 dangerous_fuzzers
@@ -188,7 +188,7 @@
 188 ci dir auto
 189 mount auto quick
 190 rw auto quick
-191-input-validation auto quick mkfs
+191-input-validation auto quick mkfs realtime
 192 auto quick clone
 193 auto quick clone
 194 rw auto
@@ -272,7 +272,7 @@
 273 auto rmap fsmap
 274 auto quick rmap fsmap
 275 auto quick rmap fsmap
-276 auto quick rmap fsmap
+276 auto quick rmap fsmap realtime
 277 auto quick rmap fsmap
 278 repair auto
 279 auto mkfs
@@ -287,7 +287,7 @@
 288 auto quick repair fuzzers
 289 growfs auto quick
 290 auto rw prealloc quick ioctl zero
-291 auto repair
+291 auto repair realtime
 292 auto mkfs quick
 293 auto quick
 294 auto dir metadata
@@ -329,17 +329,17 @@
 330 auto quick clone fsr quota
 331 auto quick rmap clone
 332 auto quick rmap clone collapse punch insert zero
-333 auto quick rmap
-334 auto quick rmap
-335 auto rmap
-336 auto rmap
-337 fuzzers rmap
-338 auto quick rmap
-339 auto quick rmap
-340 auto quick rmap
-341 auto quick rmap
-342 auto quick rmap
-343 auto quick rmap collapse punch insert zero
+333 auto quick rmap realtime
+334 auto quick rmap realtime
+335 auto rmap realtime
+336 auto rmap realtime
+337 fuzzers rmap realtime
+338 auto quick rmap realtime
+339 auto quick rmap realtime
+340 auto quick rmap realtime
+341 auto quick rmap realtime
+342 auto quick rmap realtime
+343 auto quick rmap collapse punch insert zero realtime
 344 auto quick clone
 345 auto quick clone
 346 auto quick clone
@@ -402,10 +402,10 @@
 403 dangerous_fuzzers dangerous_scrub dangerous_online_repair
 404 dangerous_fuzzers dangerous_scrub dangerous_repair
 405 dangerous_fuzzers dangerous_scrub dangerous_online_repair
-406 dangerous_fuzzers dangerous_scrub dangerous_repair
-407 dangerous_fuzzers dangerous_scrub dangerous_online_repair
-408 dangerous_fuzzers dangerous_scrub dangerous_repair
-409 dangerous_fuzzers dangerous_scrub dangerous_online_repair
+406 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
+407 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
+408 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
+409 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
 410 dangerous_fuzzers dangerous_scrub dangerous_repair
 411 dangerous_fuzzers dangerous_scrub dangerous_online_repair
 412 dangerous_fuzzers dangerous_scrub dangerous_repair
@@ -415,7 +415,7 @@
 416 dangerous_fuzzers dangerous_scrub dangerous_repair
 417 dangerous_fuzzers dangerous_scrub dangerous_online_repair
 418 dangerous_fuzzers dangerous_scrub dangerous_repair
-419 auto quick swap
+419 auto quick swap realtime
 420 auto quick clone punch seek
 421 auto quick clone punch seek
 422 dangerous_scrub dangerous_online_repair
@@ -477,8 +477,8 @@
 478 dangerous_fuzzers dangerous_norepair
 479 dangerous_fuzzers dangerous_norepair
 480 dangerous_fuzzers dangerous_norepair
-481 dangerous_fuzzers dangerous_norepair
-482 dangerous_fuzzers dangerous_norepair
+481 dangerous_fuzzers dangerous_norepair realtime
+482 dangerous_fuzzers dangerous_norepair realtime
 483 dangerous_fuzzers dangerous_norepair
 484 dangerous_fuzzers dangerous_norepair
 485 dangerous_fuzzers dangerous_norepair
-- 
2.28.0

[PATCH V2 2/2] xfs: Check if rt summary/bitmap buffers are logged with correct xfs_buf type

[Chandan Babu R]

This commit adds a test to check if growing a real-time device can end
up logging an xfs_buf with the "type" subfield of
bip->bli_formats->blf_flags set to XFS_BLFT_UNKNOWN_BUF. When this
occurs the following call trace is printed on the console,

XFS: Assertion failed: (bip->bli_flags & XFS_BLI_STALE) || (xfs_blft_from_flags(&bip->__bli_format) > XFS_BLFT_UNKNOWN_BUF && xfs_blft_from_flags(&bip->__bli_format) < XFS_BLFT_MAX_BUF), file: fs/xfs/xfs_buf_item.c, line: 331
Call Trace:
 xfs_buf_item_format+0x632/0x680
 ? kmem_alloc_large+0x29/0x90
 ? kmem_alloc+0x70/0x120
 ? xfs_log_commit_cil+0x132/0x940
 xfs_log_commit_cil+0x26f/0x940
 ? xfs_buf_item_init+0x1ad/0x240
 ? xfs_growfs_rt_alloc+0x1fc/0x280
 __xfs_trans_commit+0xac/0x370
 xfs_growfs_rt_alloc+0x1fc/0x280
 xfs_growfs_rt+0x1a0/0x5e0
 xfs_file_ioctl+0x3fd/0xc70
 ? selinux_file_ioctl+0x174/0x220
 ksys_ioctl+0x87/0xc0
 __x64_sys_ioctl+0x16/0x20
 do_syscall_64+0x3e/0x70
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

The kernel patch "xfs: Set xfs_buf type flag when growing summary/bitmap
files" is required to fix this issue.

Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
---
 tests/xfs/260     | 53 +++++++++++++++++++++++++++++++++++++++++++++++
 tests/xfs/260.out |  2 ++
 tests/xfs/group   |  1 +
 3 files changed, 56 insertions(+)
 create mode 100755 tests/xfs/260
 create mode 100644 tests/xfs/260.out

diff --git a/tests/xfs/260 b/tests/xfs/260
new file mode 100755
index 00000000..078d4a11
--- /dev/null
+++ b/tests/xfs/260
@@ -0,0 +1,53 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2020 Chandan Babu R.  All Rights Reserved.
+#
+# FS QA Test 260
+#
+# Test to check if growing a real-time device can end up logging an xfs_buf with
+# the "type" subfield of bip->bli_formats->blf_flags set to
+# XFS_BLFT_UNKNOWN_BUF.
+#
+# This is a regression test for the kernel patch "xfs: Set xfs_buf type flag
+# when growing summary/bitmap files".
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+_supported_fs xfs
+_supported_os Linux
+_require_realtime
+
+_scratch_mkfs -r size=10M  >> $seqres.full
+
+_scratch_mount >> $seqres.full
+
+$XFS_GROWFS_PROG $SCRATCH_MNT >> $seqres.full
+
+_scratch_unmount
+
+echo "Silence is golden"
+
+# success, all done
+status=0
+exit
diff --git a/tests/xfs/260.out b/tests/xfs/260.out
new file mode 100644
index 00000000..18ca517c
--- /dev/null
+++ b/tests/xfs/260.out
@@ -0,0 +1,2 @@
+QA output created by 260
+Silence is golden
diff --git a/tests/xfs/group b/tests/xfs/group
index 3bb0f674..a3f5c81a 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -257,6 +257,7 @@
 257 auto quick clone
 258 auto quick clone
 259 auto quick
+260 auto quick growfs realtime
 261 auto quick quota
 262 dangerous_fuzzers dangerous_scrub dangerous_online_repair
 263 auto quick quota
-- 
2.28.0

Re: [PATCH V2 2/2] xfs: Check if rt summary/bitmap buffers are logged with correct xfs_buf type

[Chandan Babu R]

On Wednesday 16 September 2020 11:04:07 AM IST Chandan Babu R wrote:
> This commit adds a test to check if growing a real-time device can end
> up logging an xfs_buf with the "type" subfield of
> bip->bli_formats->blf_flags set to XFS_BLFT_UNKNOWN_BUF. When this
> occurs the following call trace is printed on the console,
> 
> XFS: Assertion failed: (bip->bli_flags & XFS_BLI_STALE) || (xfs_blft_from_flags(&bip->__bli_format) > XFS_BLFT_UNKNOWN_BUF && xfs_blft_from_flags(&bip->__bli_format) < XFS_BLFT_MAX_BUF), file: fs/xfs/xfs_buf_item.c, line: 331
> Call Trace:
>  xfs_buf_item_format+0x632/0x680
>  ? kmem_alloc_large+0x29/0x90
>  ? kmem_alloc+0x70/0x120
>  ? xfs_log_commit_cil+0x132/0x940
>  xfs_log_commit_cil+0x26f/0x940
>  ? xfs_buf_item_init+0x1ad/0x240
>  ? xfs_growfs_rt_alloc+0x1fc/0x280
>  __xfs_trans_commit+0xac/0x370
>  xfs_growfs_rt_alloc+0x1fc/0x280
>  xfs_growfs_rt+0x1a0/0x5e0
>  xfs_file_ioctl+0x3fd/0xc70
>  ? selinux_file_ioctl+0x174/0x220
>  ksys_ioctl+0x87/0xc0
>  __x64_sys_ioctl+0x16/0x20
>  do_syscall_64+0x3e/0x70
>  entry_SYSCALL_64_after_hwframe+0x44/0xa9
> 
> The kernel patch "xfs: Set xfs_buf type flag when growing summary/bitmap
> files" is required to fix this issue.
>

Eryu,

Sorry, I forgot to add Darrick's RVB tag. Please let me know if I have to
resend the patch with the missing RVB.

> Reviewed-by: Zorro Lang <zlang@redhat.com>
> Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>

-- 
chandan

Re: [PATCH 1/2] xfs: Add realtime group

[Darrick J. Wong]

On Wed, Sep 16, 2020 at 11:04:06AM +0530, Chandan Babu R wrote:
> This commit adds a new group to classify tests that can work with
> realtime devices.
> 
> Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
> ---
>  tests/xfs/group | 52 ++++++++++++++++++++++++-------------------------
>  1 file changed, 26 insertions(+), 26 deletions(-)
> 
> diff --git a/tests/xfs/group b/tests/xfs/group
> index ed0d389e..3bb0f674 100644
> --- a/tests/xfs/group
> +++ b/tests/xfs/group
> @@ -67,7 +67,7 @@
>  067 acl attr auto quick
>  068 auto stress dump
>  069 ioctl auto quick
> -070 auto quick repair
> +070 auto quick repair realtime

This test has an open-coded call to repair + rt volume, but is not
itself a test of rt functionality.

>  071 rw auto
>  072 rw auto prealloc quick
>  073 copy auto
> @@ -87,11 +87,11 @@
>  087 fuzzers
>  088 fuzzers
>  089 fuzzers
> -090 rw auto
> +090 rw auto realtime
>  091 fuzzers
>  092 other auto quick
>  093 fuzzers
> -094 metadata dir ioctl auto
> +094 metadata dir ioctl auto realtime
>  095 log v2log auto
>  096 mkfs v2log auto quick
>  097 fuzzers
> @@ -119,7 +119,7 @@
>  119 log v2log auto freeze
>  120 fuzzers
>  121 shutdown log auto quick
> -122 other auto quick clone
> +122 other auto quick clone realtime

This is an ondisk structure size check.  It doesn't test rt
functionality, but I guess it doesn't really harm things to throw it on
the 'realtime' pile.  I'm not objecting to this; it's just a funny
thought I had while reading this patch.

(Not sure why it's in 'clone' either...)

>  123 fuzzers
>  124 fuzzers
>  125 fuzzers
> @@ -128,7 +128,7 @@
>  128 auto quick clone fsr
>  129 auto quick clone
>  130 fuzzers clone
> -131 auto quick clone
> +131 auto quick clone realtime
>  132 auto quick
>  133 dangerous_fuzzers
>  134 dangerous_fuzzers
> @@ -188,7 +188,7 @@
>  188 ci dir auto
>  189 mount auto quick
>  190 rw auto quick
> -191-input-validation auto quick mkfs
> +191-input-validation auto quick mkfs realtime
>  192 auto quick clone
>  193 auto quick clone
>  194 rw auto
> @@ -272,7 +272,7 @@
>  273 auto rmap fsmap
>  274 auto quick rmap fsmap
>  275 auto quick rmap fsmap
> -276 auto quick rmap fsmap
> +276 auto quick rmap fsmap realtime
>  277 auto quick rmap fsmap
>  278 repair auto
>  279 auto mkfs
> @@ -287,7 +287,7 @@
>  288 auto quick repair fuzzers
>  289 growfs auto quick
>  290 auto rw prealloc quick ioctl zero
> -291 auto repair
> +291 auto repair realtime

This is a directory repair test, which doesn't exercise any rt volume
functionality.

...

FWIW I checked all the other tests that you added to the realtime group,
and the changes I don't have any comments about all look ok to me.

--D

>  292 auto mkfs quick
>  293 auto quick
>  294 auto dir metadata
> @@ -329,17 +329,17 @@
>  330 auto quick clone fsr quota
>  331 auto quick rmap clone
>  332 auto quick rmap clone collapse punch insert zero
> -333 auto quick rmap
> -334 auto quick rmap
> -335 auto rmap
> -336 auto rmap
> -337 fuzzers rmap
> -338 auto quick rmap
> -339 auto quick rmap
> -340 auto quick rmap
> -341 auto quick rmap
> -342 auto quick rmap
> -343 auto quick rmap collapse punch insert zero
> +333 auto quick rmap realtime
> +334 auto quick rmap realtime
> +335 auto rmap realtime
> +336 auto rmap realtime
> +337 fuzzers rmap realtime
> +338 auto quick rmap realtime
> +339 auto quick rmap realtime
> +340 auto quick rmap realtime
> +341 auto quick rmap realtime
> +342 auto quick rmap realtime
> +343 auto quick rmap collapse punch insert zero realtime
>  344 auto quick clone
>  345 auto quick clone
>  346 auto quick clone
> @@ -402,10 +402,10 @@
>  403 dangerous_fuzzers dangerous_scrub dangerous_online_repair
>  404 dangerous_fuzzers dangerous_scrub dangerous_repair
>  405 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> -406 dangerous_fuzzers dangerous_scrub dangerous_repair
> -407 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> -408 dangerous_fuzzers dangerous_scrub dangerous_repair
> -409 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> +406 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
> +407 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
> +408 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
> +409 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
>  410 dangerous_fuzzers dangerous_scrub dangerous_repair
>  411 dangerous_fuzzers dangerous_scrub dangerous_online_repair
>  412 dangerous_fuzzers dangerous_scrub dangerous_repair
> @@ -415,7 +415,7 @@
>  416 dangerous_fuzzers dangerous_scrub dangerous_repair
>  417 dangerous_fuzzers dangerous_scrub dangerous_online_repair
>  418 dangerous_fuzzers dangerous_scrub dangerous_repair
> -419 auto quick swap
> +419 auto quick swap realtime
>  420 auto quick clone punch seek
>  421 auto quick clone punch seek
>  422 dangerous_scrub dangerous_online_repair
> @@ -477,8 +477,8 @@
>  478 dangerous_fuzzers dangerous_norepair
>  479 dangerous_fuzzers dangerous_norepair
>  480 dangerous_fuzzers dangerous_norepair
> -481 dangerous_fuzzers dangerous_norepair
> -482 dangerous_fuzzers dangerous_norepair
> +481 dangerous_fuzzers dangerous_norepair realtime
> +482 dangerous_fuzzers dangerous_norepair realtime
>  483 dangerous_fuzzers dangerous_norepair
>  484 dangerous_fuzzers dangerous_norepair
>  485 dangerous_fuzzers dangerous_norepair
> -- 
> 2.28.0
> 

Re: [PATCH V2 2/2] xfs: Check if rt summary/bitmap buffers are logged with correct xfs_buf type

[Darrick J. Wong]

On Wed, Sep 16, 2020 at 11:04:07AM +0530, Chandan Babu R wrote:
> This commit adds a test to check if growing a real-time device can end
> up logging an xfs_buf with the "type" subfield of
> bip->bli_formats->blf_flags set to XFS_BLFT_UNKNOWN_BUF. When this
> occurs the following call trace is printed on the console,
> 
> XFS: Assertion failed: (bip->bli_flags & XFS_BLI_STALE) || (xfs_blft_from_flags(&bip->__bli_format) > XFS_BLFT_UNKNOWN_BUF && xfs_blft_from_flags(&bip->__bli_format) < XFS_BLFT_MAX_BUF), file: fs/xfs/xfs_buf_item.c, line: 331
> Call Trace:
>  xfs_buf_item_format+0x632/0x680
>  ? kmem_alloc_large+0x29/0x90
>  ? kmem_alloc+0x70/0x120
>  ? xfs_log_commit_cil+0x132/0x940
>  xfs_log_commit_cil+0x26f/0x940
>  ? xfs_buf_item_init+0x1ad/0x240
>  ? xfs_growfs_rt_alloc+0x1fc/0x280
>  __xfs_trans_commit+0xac/0x370
>  xfs_growfs_rt_alloc+0x1fc/0x280
>  xfs_growfs_rt+0x1a0/0x5e0
>  xfs_file_ioctl+0x3fd/0xc70
>  ? selinux_file_ioctl+0x174/0x220
>  ksys_ioctl+0x87/0xc0
>  __x64_sys_ioctl+0x16/0x20
>  do_syscall_64+0x3e/0x70
>  entry_SYSCALL_64_after_hwframe+0x44/0xa9
> 
> The kernel patch "xfs: Set xfs_buf type flag when growing summary/bitmap
> files" is required to fix this issue.
> 
> Reviewed-by: Zorro Lang <zlang@redhat.com>
> Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
> ---
>  tests/xfs/260     | 53 +++++++++++++++++++++++++++++++++++++++++++++++
>  tests/xfs/260.out |  2 ++
>  tests/xfs/group   |  1 +
>  3 files changed, 56 insertions(+)
>  create mode 100755 tests/xfs/260
>  create mode 100644 tests/xfs/260.out
> 
> diff --git a/tests/xfs/260 b/tests/xfs/260
> new file mode 100755
> index 00000000..078d4a11
> --- /dev/null
> +++ b/tests/xfs/260
> @@ -0,0 +1,53 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2020 Chandan Babu R.  All Rights Reserved.
> +#
> +# FS QA Test 260
> +#
> +# Test to check if growing a real-time device can end up logging an xfs_buf with
> +# the "type" subfield of bip->bli_formats->blf_flags set to
> +# XFS_BLFT_UNKNOWN_BUF.
> +#
> +# This is a regression test for the kernel patch "xfs: Set xfs_buf type flag
> +# when growing summary/bitmap files".
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1	# failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> +	cd /
> +	rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +# real QA test starts here
> +_supported_fs xfs
> +_supported_os Linux
> +_require_realtime
> +
> +_scratch_mkfs -r size=10M  >> $seqres.full
> +
> +_scratch_mount >> $seqres.full
> +
> +$XFS_GROWFS_PROG $SCRATCH_MNT >> $seqres.full
> +
> +_scratch_unmount

Is this unmount crucial to exposing the bug?  Or does this post-test
unmount and fsck suffice?

(The rest of the logic looks ok to me.)

--D

> +
> +echo "Silence is golden"
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/xfs/260.out b/tests/xfs/260.out
> new file mode 100644
> index 00000000..18ca517c
> --- /dev/null
> +++ b/tests/xfs/260.out
> @@ -0,0 +1,2 @@
> +QA output created by 260
> +Silence is golden
> diff --git a/tests/xfs/group b/tests/xfs/group
> index 3bb0f674..a3f5c81a 100644
> --- a/tests/xfs/group
> +++ b/tests/xfs/group
> @@ -257,6 +257,7 @@
>  257 auto quick clone
>  258 auto quick clone
>  259 auto quick
> +260 auto quick growfs realtime
>  261 auto quick quota
>  262 dangerous_fuzzers dangerous_scrub dangerous_online_repair
>  263 auto quick quota
> -- 
> 2.28.0
> 

Re: [PATCH V2 2/2] xfs: Check if rt summary/bitmap buffers are logged with correct xfs_buf type

[Chandan Babu R]

On Wednesday 16 September 2020 10:23:33 PM IST Darrick J. Wong wrote:
> On Wed, Sep 16, 2020 at 11:04:07AM +0530, Chandan Babu R wrote:
> > This commit adds a test to check if growing a real-time device can end
> > up logging an xfs_buf with the "type" subfield of
> > bip->bli_formats->blf_flags set to XFS_BLFT_UNKNOWN_BUF. When this
> > occurs the following call trace is printed on the console,
> > 
> > XFS: Assertion failed: (bip->bli_flags & XFS_BLI_STALE) || (xfs_blft_from_flags(&bip->__bli_format) > XFS_BLFT_UNKNOWN_BUF && xfs_blft_from_flags(&bip->__bli_format) < XFS_BLFT_MAX_BUF), file: fs/xfs/xfs_buf_item.c, line: 331
> > Call Trace:
> >  xfs_buf_item_format+0x632/0x680
> >  ? kmem_alloc_large+0x29/0x90
> >  ? kmem_alloc+0x70/0x120
> >  ? xfs_log_commit_cil+0x132/0x940
> >  xfs_log_commit_cil+0x26f/0x940
> >  ? xfs_buf_item_init+0x1ad/0x240
> >  ? xfs_growfs_rt_alloc+0x1fc/0x280
> >  __xfs_trans_commit+0xac/0x370
> >  xfs_growfs_rt_alloc+0x1fc/0x280
> >  xfs_growfs_rt+0x1a0/0x5e0
> >  xfs_file_ioctl+0x3fd/0xc70
> >  ? selinux_file_ioctl+0x174/0x220
> >  ksys_ioctl+0x87/0xc0
> >  __x64_sys_ioctl+0x16/0x20
> >  do_syscall_64+0x3e/0x70
> >  entry_SYSCALL_64_after_hwframe+0x44/0xa9
> > 
> > The kernel patch "xfs: Set xfs_buf type flag when growing summary/bitmap
> > files" is required to fix this issue.
> > 
> > Reviewed-by: Zorro Lang <zlang@redhat.com>
> > Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
> > ---
> >  tests/xfs/260     | 53 +++++++++++++++++++++++++++++++++++++++++++++++
> >  tests/xfs/260.out |  2 ++
> >  tests/xfs/group   |  1 +
> >  3 files changed, 56 insertions(+)
> >  create mode 100755 tests/xfs/260
> >  create mode 100644 tests/xfs/260.out
> > 
> > diff --git a/tests/xfs/260 b/tests/xfs/260
> > new file mode 100755
> > index 00000000..078d4a11
> > --- /dev/null
> > +++ b/tests/xfs/260
> > @@ -0,0 +1,53 @@
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2020 Chandan Babu R.  All Rights Reserved.
> > +#
> > +# FS QA Test 260
> > +#
> > +# Test to check if growing a real-time device can end up logging an xfs_buf with
> > +# the "type" subfield of bip->bli_formats->blf_flags set to
> > +# XFS_BLFT_UNKNOWN_BUF.
> > +#
> > +# This is a regression test for the kernel patch "xfs: Set xfs_buf type flag
> > +# when growing summary/bitmap files".
> > +
> > +seq=`basename $0`
> > +seqres=$RESULT_DIR/$seq
> > +echo "QA output created by $seq"
> > +
> > +here=`pwd`
> > +tmp=/tmp/$$
> > +status=1	# failure is the default!
> > +trap "_cleanup; exit \$status" 0 1 2 3 15
> > +
> > +_cleanup()
> > +{
> > +	cd /
> > +	rm -f $tmp.*
> > +}
> > +
> > +# get standard environment, filters and checks
> > +. ./common/rc
> > +. ./common/filter
> > +
> > +# remove previous $seqres.full before test
> > +rm -f $seqres.full
> > +
> > +# real QA test starts here
> > +_supported_fs xfs
> > +_supported_os Linux
> > +_require_realtime
> > +
> > +_scratch_mkfs -r size=10M  >> $seqres.full
> > +
> > +_scratch_mount >> $seqres.full
> > +
> > +$XFS_GROWFS_PROG $SCRATCH_MNT >> $seqres.full
> > +
> > +_scratch_unmount
> 
> Is this unmount crucial to exposing the bug?  Or does this post-test
> unmount and fsck suffice?

No, the above call to _scratch_unmount isn't required for recreating the
bug. I will remove it and post the patch once again.

> 
> (The rest of the logic looks ok to me.)
> 
> --D

-- 
chandan

Re: [PATCH 1/2] xfs: Add realtime group

[Chandan Babu R]

On Wednesday 16 September 2020 10:21:42 PM IST Darrick J. Wong wrote:
> On Wed, Sep 16, 2020 at 11:04:06AM +0530, Chandan Babu R wrote:
> > This commit adds a new group to classify tests that can work with
> > realtime devices.
> > 
> > Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
> > ---
> >  tests/xfs/group | 52 ++++++++++++++++++++++++-------------------------
> >  1 file changed, 26 insertions(+), 26 deletions(-)
> > 
> > diff --git a/tests/xfs/group b/tests/xfs/group
> > index ed0d389e..3bb0f674 100644
> > --- a/tests/xfs/group
> > +++ b/tests/xfs/group
> > @@ -67,7 +67,7 @@
> >  067 acl attr auto quick
> >  068 auto stress dump
> >  069 ioctl auto quick
> > -070 auto quick repair
> > +070 auto quick repair realtime
> 
> This test has an open-coded call to repair + rt volume, but is not
> itself a test of rt functionality.

That is true. I had decided to include this since it executed xfs_repair if
the scratch fs had a realtime device associated with it. I will remove it.

> 
> >  071 rw auto
> >  072 rw auto prealloc quick
> >  073 copy auto
> > @@ -87,11 +87,11 @@
> >  087 fuzzers
> >  088 fuzzers
> >  089 fuzzers
> > -090 rw auto
> > +090 rw auto realtime
> >  091 fuzzers
> >  092 other auto quick
> >  093 fuzzers
> > -094 metadata dir ioctl auto
> > +094 metadata dir ioctl auto realtime
> >  095 log v2log auto
> >  096 mkfs v2log auto quick
> >  097 fuzzers
> > @@ -119,7 +119,7 @@
> >  119 log v2log auto freeze
> >  120 fuzzers
> >  121 shutdown log auto quick
> > -122 other auto quick clone
> > +122 other auto quick clone realtime
> 
> This is an ondisk structure size check.  It doesn't test rt
> functionality, but I guess it doesn't really harm things to throw it on
> the 'realtime' pile.  I'm not objecting to this; it's just a funny
> thought I had while reading this patch.

I had decided to add this test to "realtime" group since it was checking sizes
of structures associated with realtime functionality. For
e.g. tests/xfs/122.out has,

sizeof(struct xfs_rtrmap_key) = 24                                                                       
sizeof(struct xfs_rtrmap_rec) = 32                                                                       
sizeof(struct xfs_rtrmap_root) = 4 

However, I think these structures are associated with a Btree that hasn't been
merged into the mainline kernel yet since I couldn't find them in the source
code. I was of the opinion that adding this test will be useful when the
corresponding patches get merged into mainline and test suite is invoked for
"realtime" group only.

> 
> (Not sure why it's in 'clone' either...)
> 
> >  123 fuzzers
> >  124 fuzzers
> >  125 fuzzers
> > @@ -128,7 +128,7 @@
> >  128 auto quick clone fsr
> >  129 auto quick clone
> >  130 fuzzers clone
> > -131 auto quick clone
> > +131 auto quick clone realtime
> >  132 auto quick
> >  133 dangerous_fuzzers
> >  134 dangerous_fuzzers
> > @@ -188,7 +188,7 @@
> >  188 ci dir auto
> >  189 mount auto quick
> >  190 rw auto quick
> > -191-input-validation auto quick mkfs
> > +191-input-validation auto quick mkfs realtime
> >  192 auto quick clone
> >  193 auto quick clone
> >  194 rw auto
> > @@ -272,7 +272,7 @@
> >  273 auto rmap fsmap
> >  274 auto quick rmap fsmap
> >  275 auto quick rmap fsmap
> > -276 auto quick rmap fsmap
> > +276 auto quick rmap fsmap realtime
> >  277 auto quick rmap fsmap
> >  278 repair auto
> >  279 auto mkfs
> > @@ -287,7 +287,7 @@
> >  288 auto quick repair fuzzers
> >  289 growfs auto quick
> >  290 auto rw prealloc quick ioctl zero
> > -291 auto repair
> > +291 auto repair realtime
> 
> This is a directory repair test, which doesn't exercise any rt volume
> functionality.
> 
> ...
> 
> FWIW I checked all the other tests that you added to the realtime group,
> and the changes I don't have any comments about all look ok to me.

Thanks for going through the list of tests.

-- 
chandan

Re: [PATCH 1/2] xfs: Add realtime group

[Darrick J. Wong]

On Thu, Sep 17, 2020 at 10:01:14AM +0530, Chandan Babu R wrote:
> On Thursday 17 September 2020 9:58:43 AM IST Chandan Babu R wrote:
> > This commit adds a new group to classify tests that can work with
> > realtime devices.
> > 
> > Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
> > ---
> 
> Sorry, I forgot to add version number and also a changelog.
> 
> V1 -> V2:
>   Remove xfs/070 from realtime group.

I think you missed my comment in the last thread about xfs/291 being a
directory repair test.

--D

> >  tests/xfs/group | 50 ++++++++++++++++++++++++-------------------------
> >  1 file changed, 25 insertions(+), 25 deletions(-)
> > 
> > diff --git a/tests/xfs/group b/tests/xfs/group
> > index ed0d389e..b99ca082 100644
> > --- a/tests/xfs/group
> > +++ b/tests/xfs/group
> > @@ -87,11 +87,11 @@
> >  087 fuzzers
> >  088 fuzzers
> >  089 fuzzers
> > -090 rw auto
> > +090 rw auto realtime
> >  091 fuzzers
> >  092 other auto quick
> >  093 fuzzers
> > -094 metadata dir ioctl auto
> > +094 metadata dir ioctl auto realtime
> >  095 log v2log auto
> >  096 mkfs v2log auto quick
> >  097 fuzzers
> > @@ -119,7 +119,7 @@
> >  119 log v2log auto freeze
> >  120 fuzzers
> >  121 shutdown log auto quick
> > -122 other auto quick clone
> > +122 other auto quick clone realtime
> >  123 fuzzers
> >  124 fuzzers
> >  125 fuzzers
> > @@ -128,7 +128,7 @@
> >  128 auto quick clone fsr
> >  129 auto quick clone
> >  130 fuzzers clone
> > -131 auto quick clone
> > +131 auto quick clone realtime
> >  132 auto quick
> >  133 dangerous_fuzzers
> >  134 dangerous_fuzzers
> > @@ -188,7 +188,7 @@
> >  188 ci dir auto
> >  189 mount auto quick
> >  190 rw auto quick
> > -191-input-validation auto quick mkfs
> > +191-input-validation auto quick mkfs realtime
> >  192 auto quick clone
> >  193 auto quick clone
> >  194 rw auto
> > @@ -272,7 +272,7 @@
> >  273 auto rmap fsmap
> >  274 auto quick rmap fsmap
> >  275 auto quick rmap fsmap
> > -276 auto quick rmap fsmap
> > +276 auto quick rmap fsmap realtime
> >  277 auto quick rmap fsmap
> >  278 repair auto
> >  279 auto mkfs
> > @@ -287,7 +287,7 @@
> >  288 auto quick repair fuzzers
> >  289 growfs auto quick
> >  290 auto rw prealloc quick ioctl zero
> > -291 auto repair
> > +291 auto repair realtime
> >  292 auto mkfs quick
> >  293 auto quick
> >  294 auto dir metadata
> > @@ -329,17 +329,17 @@
> >  330 auto quick clone fsr quota
> >  331 auto quick rmap clone
> >  332 auto quick rmap clone collapse punch insert zero
> > -333 auto quick rmap
> > -334 auto quick rmap
> > -335 auto rmap
> > -336 auto rmap
> > -337 fuzzers rmap
> > -338 auto quick rmap
> > -339 auto quick rmap
> > -340 auto quick rmap
> > -341 auto quick rmap
> > -342 auto quick rmap
> > -343 auto quick rmap collapse punch insert zero
> > +333 auto quick rmap realtime
> > +334 auto quick rmap realtime
> > +335 auto rmap realtime
> > +336 auto rmap realtime
> > +337 fuzzers rmap realtime
> > +338 auto quick rmap realtime
> > +339 auto quick rmap realtime
> > +340 auto quick rmap realtime
> > +341 auto quick rmap realtime
> > +342 auto quick rmap realtime
> > +343 auto quick rmap collapse punch insert zero realtime
> >  344 auto quick clone
> >  345 auto quick clone
> >  346 auto quick clone
> > @@ -402,10 +402,10 @@
> >  403 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> >  404 dangerous_fuzzers dangerous_scrub dangerous_repair
> >  405 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> > -406 dangerous_fuzzers dangerous_scrub dangerous_repair
> > -407 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> > -408 dangerous_fuzzers dangerous_scrub dangerous_repair
> > -409 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> > +406 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
> > +407 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
> > +408 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
> > +409 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
> >  410 dangerous_fuzzers dangerous_scrub dangerous_repair
> >  411 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> >  412 dangerous_fuzzers dangerous_scrub dangerous_repair
> > @@ -415,7 +415,7 @@
> >  416 dangerous_fuzzers dangerous_scrub dangerous_repair
> >  417 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> >  418 dangerous_fuzzers dangerous_scrub dangerous_repair
> > -419 auto quick swap
> > +419 auto quick swap realtime
> >  420 auto quick clone punch seek
> >  421 auto quick clone punch seek
> >  422 dangerous_scrub dangerous_online_repair
> > @@ -477,8 +477,8 @@
> >  478 dangerous_fuzzers dangerous_norepair
> >  479 dangerous_fuzzers dangerous_norepair
> >  480 dangerous_fuzzers dangerous_norepair
> > -481 dangerous_fuzzers dangerous_norepair
> > -482 dangerous_fuzzers dangerous_norepair
> > +481 dangerous_fuzzers dangerous_norepair realtime
> > +482 dangerous_fuzzers dangerous_norepair realtime
> >  483 dangerous_fuzzers dangerous_norepair
> >  484 dangerous_fuzzers dangerous_norepair
> >  485 dangerous_fuzzers dangerous_norepair
> > 
> 
> 
> -- 
> chandan
> 
> 
> 

Re: [PATCH 1/2] xfs: Add realtime group

[Chandan Babu R]

On Thursday 17 September 2020 9:58:43 AM IST Chandan Babu R wrote:
> This commit adds a new group to classify tests that can work with
> realtime devices.
> 
> Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
> ---

Sorry, I forgot to add version number and also a changelog.

V1 -> V2:
  Remove xfs/070 from realtime group.
  
>  tests/xfs/group | 50 ++++++++++++++++++++++++-------------------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/tests/xfs/group b/tests/xfs/group
> index ed0d389e..b99ca082 100644
> --- a/tests/xfs/group
> +++ b/tests/xfs/group
> @@ -87,11 +87,11 @@
>  087 fuzzers
>  088 fuzzers
>  089 fuzzers
> -090 rw auto
> +090 rw auto realtime
>  091 fuzzers
>  092 other auto quick
>  093 fuzzers
> -094 metadata dir ioctl auto
> +094 metadata dir ioctl auto realtime
>  095 log v2log auto
>  096 mkfs v2log auto quick
>  097 fuzzers
> @@ -119,7 +119,7 @@
>  119 log v2log auto freeze
>  120 fuzzers
>  121 shutdown log auto quick
> -122 other auto quick clone
> +122 other auto quick clone realtime
>  123 fuzzers
>  124 fuzzers
>  125 fuzzers
> @@ -128,7 +128,7 @@
>  128 auto quick clone fsr
>  129 auto quick clone
>  130 fuzzers clone
> -131 auto quick clone
> +131 auto quick clone realtime
>  132 auto quick
>  133 dangerous_fuzzers
>  134 dangerous_fuzzers
> @@ -188,7 +188,7 @@
>  188 ci dir auto
>  189 mount auto quick
>  190 rw auto quick
> -191-input-validation auto quick mkfs
> +191-input-validation auto quick mkfs realtime
>  192 auto quick clone
>  193 auto quick clone
>  194 rw auto
> @@ -272,7 +272,7 @@
>  273 auto rmap fsmap
>  274 auto quick rmap fsmap
>  275 auto quick rmap fsmap
> -276 auto quick rmap fsmap
> +276 auto quick rmap fsmap realtime
>  277 auto quick rmap fsmap
>  278 repair auto
>  279 auto mkfs
> @@ -287,7 +287,7 @@
>  288 auto quick repair fuzzers
>  289 growfs auto quick
>  290 auto rw prealloc quick ioctl zero
> -291 auto repair
> +291 auto repair realtime
>  292 auto mkfs quick
>  293 auto quick
>  294 auto dir metadata
> @@ -329,17 +329,17 @@
>  330 auto quick clone fsr quota
>  331 auto quick rmap clone
>  332 auto quick rmap clone collapse punch insert zero
> -333 auto quick rmap
> -334 auto quick rmap
> -335 auto rmap
> -336 auto rmap
> -337 fuzzers rmap
> -338 auto quick rmap
> -339 auto quick rmap
> -340 auto quick rmap
> -341 auto quick rmap
> -342 auto quick rmap
> -343 auto quick rmap collapse punch insert zero
> +333 auto quick rmap realtime
> +334 auto quick rmap realtime
> +335 auto rmap realtime
> +336 auto rmap realtime
> +337 fuzzers rmap realtime
> +338 auto quick rmap realtime
> +339 auto quick rmap realtime
> +340 auto quick rmap realtime
> +341 auto quick rmap realtime
> +342 auto quick rmap realtime
> +343 auto quick rmap collapse punch insert zero realtime
>  344 auto quick clone
>  345 auto quick clone
>  346 auto quick clone
> @@ -402,10 +402,10 @@
>  403 dangerous_fuzzers dangerous_scrub dangerous_online_repair
>  404 dangerous_fuzzers dangerous_scrub dangerous_repair
>  405 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> -406 dangerous_fuzzers dangerous_scrub dangerous_repair
> -407 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> -408 dangerous_fuzzers dangerous_scrub dangerous_repair
> -409 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> +406 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
> +407 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
> +408 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
> +409 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
>  410 dangerous_fuzzers dangerous_scrub dangerous_repair
>  411 dangerous_fuzzers dangerous_scrub dangerous_online_repair
>  412 dangerous_fuzzers dangerous_scrub dangerous_repair
> @@ -415,7 +415,7 @@
>  416 dangerous_fuzzers dangerous_scrub dangerous_repair
>  417 dangerous_fuzzers dangerous_scrub dangerous_online_repair
>  418 dangerous_fuzzers dangerous_scrub dangerous_repair
> -419 auto quick swap
> +419 auto quick swap realtime
>  420 auto quick clone punch seek
>  421 auto quick clone punch seek
>  422 dangerous_scrub dangerous_online_repair
> @@ -477,8 +477,8 @@
>  478 dangerous_fuzzers dangerous_norepair
>  479 dangerous_fuzzers dangerous_norepair
>  480 dangerous_fuzzers dangerous_norepair
> -481 dangerous_fuzzers dangerous_norepair
> -482 dangerous_fuzzers dangerous_norepair
> +481 dangerous_fuzzers dangerous_norepair realtime
> +482 dangerous_fuzzers dangerous_norepair realtime
>  483 dangerous_fuzzers dangerous_norepair
>  484 dangerous_fuzzers dangerous_norepair
>  485 dangerous_fuzzers dangerous_norepair
> 


-- 
chandan

[PATCH 1/2] xfs: Add realtime group

[Chandan Babu R]

This commit adds a new group to classify tests that can work with
realtime devices.

Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
---
 tests/xfs/group | 50 ++++++++++++++++++++++++-------------------------
 1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/tests/xfs/group b/tests/xfs/group
index ed0d389e..b99ca082 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -87,11 +87,11 @@
 087 fuzzers
 088 fuzzers
 089 fuzzers
-090 rw auto
+090 rw auto realtime
 091 fuzzers
 092 other auto quick
 093 fuzzers
-094 metadata dir ioctl auto
+094 metadata dir ioctl auto realtime
 095 log v2log auto
 096 mkfs v2log auto quick
 097 fuzzers
@@ -119,7 +119,7 @@
 119 log v2log auto freeze
 120 fuzzers
 121 shutdown log auto quick
-122 other auto quick clone
+122 other auto quick clone realtime
 123 fuzzers
 124 fuzzers
 125 fuzzers
@@ -128,7 +128,7 @@
 128 auto quick clone fsr
 129 auto quick clone
 130 fuzzers clone
-131 auto quick clone
+131 auto quick clone realtime
 132 auto quick
 133 dangerous_fuzzers
 134 dangerous_fuzzers
@@ -188,7 +188,7 @@
 188 ci dir auto
 189 mount auto quick
 190 rw auto quick
-191-input-validation auto quick mkfs
+191-input-validation auto quick mkfs realtime
 192 auto quick clone
 193 auto quick clone
 194 rw auto
@@ -272,7 +272,7 @@
 273 auto rmap fsmap
 274 auto quick rmap fsmap
 275 auto quick rmap fsmap
-276 auto quick rmap fsmap
+276 auto quick rmap fsmap realtime
 277 auto quick rmap fsmap
 278 repair auto
 279 auto mkfs
@@ -287,7 +287,7 @@
 288 auto quick repair fuzzers
 289 growfs auto quick
 290 auto rw prealloc quick ioctl zero
-291 auto repair
+291 auto repair realtime
 292 auto mkfs quick
 293 auto quick
 294 auto dir metadata
@@ -329,17 +329,17 @@
 330 auto quick clone fsr quota
 331 auto quick rmap clone
 332 auto quick rmap clone collapse punch insert zero
-333 auto quick rmap
-334 auto quick rmap
-335 auto rmap
-336 auto rmap
-337 fuzzers rmap
-338 auto quick rmap
-339 auto quick rmap
-340 auto quick rmap
-341 auto quick rmap
-342 auto quick rmap
-343 auto quick rmap collapse punch insert zero
+333 auto quick rmap realtime
+334 auto quick rmap realtime
+335 auto rmap realtime
+336 auto rmap realtime
+337 fuzzers rmap realtime
+338 auto quick rmap realtime
+339 auto quick rmap realtime
+340 auto quick rmap realtime
+341 auto quick rmap realtime
+342 auto quick rmap realtime
+343 auto quick rmap collapse punch insert zero realtime
 344 auto quick clone
 345 auto quick clone
 346 auto quick clone
@@ -402,10 +402,10 @@
 403 dangerous_fuzzers dangerous_scrub dangerous_online_repair
 404 dangerous_fuzzers dangerous_scrub dangerous_repair
 405 dangerous_fuzzers dangerous_scrub dangerous_online_repair
-406 dangerous_fuzzers dangerous_scrub dangerous_repair
-407 dangerous_fuzzers dangerous_scrub dangerous_online_repair
-408 dangerous_fuzzers dangerous_scrub dangerous_repair
-409 dangerous_fuzzers dangerous_scrub dangerous_online_repair
+406 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
+407 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
+408 dangerous_fuzzers dangerous_scrub dangerous_repair realtime
+409 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime
 410 dangerous_fuzzers dangerous_scrub dangerous_repair
 411 dangerous_fuzzers dangerous_scrub dangerous_online_repair
 412 dangerous_fuzzers dangerous_scrub dangerous_repair
@@ -415,7 +415,7 @@
 416 dangerous_fuzzers dangerous_scrub dangerous_repair
 417 dangerous_fuzzers dangerous_scrub dangerous_online_repair
 418 dangerous_fuzzers dangerous_scrub dangerous_repair
-419 auto quick swap
+419 auto quick swap realtime
 420 auto quick clone punch seek
 421 auto quick clone punch seek
 422 dangerous_scrub dangerous_online_repair
@@ -477,8 +477,8 @@
 478 dangerous_fuzzers dangerous_norepair
 479 dangerous_fuzzers dangerous_norepair
 480 dangerous_fuzzers dangerous_norepair
-481 dangerous_fuzzers dangerous_norepair
-482 dangerous_fuzzers dangerous_norepair
+481 dangerous_fuzzers dangerous_norepair realtime
+482 dangerous_fuzzers dangerous_norepair realtime
 483 dangerous_fuzzers dangerous_norepair
 484 dangerous_fuzzers dangerous_norepair
 485 dangerous_fuzzers dangerous_norepair
-- 
2.28.0