All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <mlureau@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, peter.maydell@linaro.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] tests: fix small leak in test-io-channel-command
Date: Tue, 6 Sep 2016 09:47:05 -0400 (EDT)	[thread overview]
Message-ID: <1903802153.27873.1473169625794.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160906134407.GJ10095@redhat.com>

Hi

----- Original Message -----
> On Tue, Sep 06, 2016 at 05:36:37PM +0400, Marc-André Lureau wrote:
> > srcfifo && dstfifo must still be freed if socat is not present.
> > 
> > Only unlink if the fifo was actually created.
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  tests/test-io-channel-command.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> 
> I'll add this to my I/O queue unless you respin your current PULL request
> with this included.

I don't know what's best. Peter, should I send a new pull request with the new patch? Or send a new one without it? Or you can pull the current request without this patch?

thanks

> 
> Regards,
> Daniel
> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|
> 

      reply	other threads:[~2016-09-06 13:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 13:36 [Qemu-devel] [PATCH v3] tests: fix small leak in test-io-channel-command Marc-André Lureau
2016-09-06 13:44 ` Daniel P. Berrange
2016-09-06 13:47   ` Marc-André Lureau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1903802153.27873.1473169625794.JavaMail.zimbra@redhat.com \
    --to=mlureau@redhat.com \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.