[Qemu-devel] [PATCH v3] tests: fix small leak in test-io-channel-command

* [Qemu-devel] [PATCH v3] tests: fix small leak in test-io-channel-command
@ 2016-09-06 13:36 Marc-André Lureau
  2016-09-06 13:44 ` Daniel P. Berrange
  0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2016-09-06 13:36 UTC (permalink / raw)
  To: qemu-devel; +Cc: berrange, Marc-André Lureau

srcfifo && dstfifo must still be freed if socat is not present.

Only unlink if the fifo was actually created.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/test-io-channel-command.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/test-io-channel-command.c b/tests/test-io-channel-command.c
index 1d1f461..4fc1732 100644
--- a/tests/test-io-channel-command.c
+++ b/tests/test-io-channel-command.c
@@ -40,7 +40,7 @@ static void test_io_channel_command_fifo(bool async)
 
     unlink(TEST_FIFO);
     if (access("/bin/socat", X_OK) < 0) {
-        return; /* Pretend success if socat is not present */
+        goto end; /* Pretend success if socat is not present */
     }
     if (mkfifo(TEST_FIFO, 0600) < 0) {
         abort();
@@ -59,9 +59,11 @@ static void test_io_channel_command_fifo(bool async)
     object_unref(OBJECT(src));
     object_unref(OBJECT(dst));
 
+    unlink(TEST_FIFO);
+
+end:
     g_free(srcfifo);
     g_free(dstfifo);
-    unlink(TEST_FIFO);
 }
 
 
-- 
2.10.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread