[PATCH] some cleanups

[PATCH] some cleanups

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]


Hi!

Attached patch alphabetize object files and guest config options for better 
readability.
It also removes svm interrupt prototypes which do not exist.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

[-- Attachment #2: xen_cleanup.diff --]
[-- Type: text/x-diff, Size: 3224 bytes --]

# HG changeset patch
# User Christoph Egger
# Date 1258018826 -3600
Cleanup:
Alphabetize object files and guest config options for better readability.
Remove svm interrupt prototypes which do not exist.

diff -r 01a941f2c9f5 -r 41a4fdd6b698 tools/python/xen/xm/create.py
--- a/tools/python/xen/xm/create.py
+++ b/tools/python/xen/xm/create.py
@@ -997,15 +997,27 @@ def configure_vifs(config_devs, vals):
 def configure_hvm(config_image, vals):
     """Create the config for HVM devices.
     """
-    args = [ 'device_model', 'pae', 'vcpus', 'boot', 'fda', 'fdb', 'timer_mode',
-             'localtime', 'serial', 'stdvga', 'isa', 'nographic', 'soundhw',
-             'vnc', 'vncdisplay', 'vncunused', 'vncconsole', 'vnclisten',
-             'sdl', 'display', 'xauthority', 'rtc_timeoffset', 'monitor',
-             'acpi', 'apic', 'usb', 'usbdevice', 'keymap', 'pci', 'hpet',
-             'guest_os_type', 'hap', 'oos', 'opengl', 'cpuid', 'cpuid_check',
-             'viridian', 'xen_extended_power_mgmt', 'pci_msitranslate',
-             'vpt_align', 'pci_power_mgmt', 'xen_platform_pci',
-             'gfx_passthru', 'description' ]
+    args = [ 'acpi', 'apic',
+             'boot',
+             'cpuid', 'cpuid_check',
+             'description', 'device_model', 'display',
+             'fda', 'fdb',
+             'gfx_passthru', 'guest_os_type',
+             'hap', 'hpet',
+             'isa',
+             'keymap',
+             'localtime',
+             'monitor',
+             'nographic',
+             'opengl', 'oos',
+             'pae', 'pci', 'pci_msitranslate', 'pci_power_mgmt',
+             'rtc_timeoffset',
+             'sdl', 'serial', 'soundhw', 'stdvga',
+             'timer_mode',
+             'usb', 'usbdevice',
+             'vcpus', 'vnc', 'vncconsole', 'vncdisplay', 'vnclisten',
+             'vncunused', 'viridian', 'vpt_align',
+             'xauthority', 'xen_extended_power_mgmt', 'xen_platform_pci' ]
 
     for a in args:
         if a in vals.__dict__ and vals.__dict__[a] is not None:
diff -r 01a941f2c9f5 -r 41a4fdd6b698 xen/arch/x86/hvm/Makefile
--- a/xen/arch/x86/hvm/Makefile
+++ b/xen/arch/x86/hvm/Makefile
@@ -2,6 +2,7 @@ subdir-y += svm
 subdir-y += vmx
 
 obj-y += emulate.o
+obj-y += hpet.o
 obj-y += hvm.o
 obj-y += i8254.o
 obj-y += intercept.o
@@ -11,12 +12,11 @@ obj-y += mtrr.o
 obj-y += pmtimer.o
 obj-y += quirks.o
 obj-y += rtc.o
-obj-y += hpet.o
+obj-y += save.o
+obj-y += stdvga.o
+obj-y += vioapic.o
+obj-y += viridian.o
+obj-y += vlapic.o
+obj-y += vmsi.o
+obj-y += vpic.o
 obj-y += vpt.o
-obj-y += vioapic.o
-obj-y += vlapic.o
-obj-y += vpic.o
-obj-y += save.o
-obj-y += vmsi.o
-obj-y += stdvga.o
-obj-y += viridian.o
diff -r 01a941f2c9f5 -r 41a4fdd6b698 xen/include/asm-x86/hvm/svm/intr.h
--- a/xen/include/asm-x86/hvm/svm/intr.h
+++ b/xen/include/asm-x86/hvm/svm/intr.h
@@ -21,9 +21,6 @@
 #ifndef __ASM_X86_HVM_SVM_INTR_H__
 #define __ASM_X86_HVM_SVM_INTR_H__
 
-extern void svm_intr_assist(void);
-extern void svm_intr_assist_update(struct vcpu *v, int highest_vector);
-extern void svm_intr_assist_test_valid(struct vcpu *v, 
-        unsigned long *intr_result);
+void svm_intr_assist(void);
 
 #endif /* __ASM_X86_HVM_SVM_INTR_H__ */

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] some cleanups

[Ian Jackson]

Christoph Egger writes ("[Xen-devel] [PATCH] some cleanups"):
> Attached patch alphabetize object files and guest config options for better 
> readability.
> It also removes svm interrupt prototypes which do not exist.

I don't think we should be encouraging gratuitous changes like
alphabetising object files!

Ian.