All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 19/88] sh-pfc: r8a7779: Add USB pin groups and functions
@ 2013-03-13 22:59 Laurent Pinchart
  2013-03-14 15:00 ` Linus Walleij
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Laurent Pinchart @ 2013-03-13 22:59 UTC (permalink / raw)
  To: linux-sh

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 42 ++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
index 946572bc..6043d2c 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
@@ -2198,6 +2198,30 @@ static const unsigned int sdhi3_wp_pins[] = {
 static const unsigned int sdhi3_wp_mux[] = {
 	SD3_WP_MARK,
 };
+/* - USB0 ------------------------------------------------------------------- */
+static const unsigned int usb0_pins[] = {
+	/* OVC */
+	150, 154,
+};
+static const unsigned int usb0_mux[] = {
+	USB_OVC0_MARK, USB_PENC0_MARK,
+};
+/* - USB1 ------------------------------------------------------------------- */
+static const unsigned int usb1_pins[] = {
+	/* OVC */
+	152, 155,
+};
+static const unsigned int usb1_mux[] = {
+	USB_OVC1_MARK, USB_PENC1_MARK,
+};
+/* - USB2 ------------------------------------------------------------------- */
+static const unsigned int usb2_pins[] = {
+	/* OVC, PENC */
+	125, 156,
+};
+static const unsigned int usb2_mux[] = {
+	USB_OVC2_MARK, USB_PENC2_MARK,
+};
 
 static const struct sh_pfc_pin_group pinmux_groups[] = {
 	SH_PFC_PIN_GROUP(du0_rgb666),
@@ -2301,6 +2325,9 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {
 	SH_PFC_PIN_GROUP(sdhi3_ctrl),
 	SH_PFC_PIN_GROUP(sdhi3_cd),
 	SH_PFC_PIN_GROUP(sdhi3_wp),
+	SH_PFC_PIN_GROUP(usb0),
+	SH_PFC_PIN_GROUP(usb1),
+	SH_PFC_PIN_GROUP(usb2),
 };
 
 static const char * const du0_groups[] = {
@@ -2455,6 +2482,18 @@ static const char * const sdhi3_groups[] = {
 	"sdhi3_wp",
 };
 
+static const char * const usb0_groups[] = {
+	"usb0",
+};
+
+static const char * const usb1_groups[] = {
+	"usb1",
+};
+
+static const char * const usb2_groups[] = {
+	"usb2",
+};
+
 static const struct sh_pfc_function pinmux_functions[] = {
 	SH_PFC_FUNCTION(du0),
 	SH_PFC_FUNCTION(du1),
@@ -2473,6 +2512,9 @@ static const struct sh_pfc_function pinmux_functions[] = {
 	SH_PFC_FUNCTION(scif3),
 	SH_PFC_FUNCTION(scif4),
 	SH_PFC_FUNCTION(scif5),
+	SH_PFC_FUNCTION(usb0),
+	SH_PFC_FUNCTION(usb1),
+	SH_PFC_FUNCTION(usb2),
 };
 
 #define PINMUX_FN_BASE	ARRAY_SIZE(pinmux_pins)
-- 
1.8.1.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v4 19/88] sh-pfc: r8a7779: Add USB pin groups and functions
  2013-03-13 22:59 [PATCH v4 19/88] sh-pfc: r8a7779: Add USB pin groups and functions Laurent Pinchart
@ 2013-03-14 15:00 ` Linus Walleij
  2013-05-06 22:50 ` Sergei Shtylyov
  2013-05-07  6:36 ` Laurent Pinchart
  2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-03-14 15:00 UTC (permalink / raw)
  To: linux-sh

On Wed, Mar 13, 2013 at 11:59 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v4 19/88] sh-pfc: r8a7779: Add USB pin groups and functions
  2013-03-13 22:59 [PATCH v4 19/88] sh-pfc: r8a7779: Add USB pin groups and functions Laurent Pinchart
  2013-03-14 15:00 ` Linus Walleij
@ 2013-05-06 22:50 ` Sergei Shtylyov
  2013-05-07  6:36 ` Laurent Pinchart
  2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2013-05-06 22:50 UTC (permalink / raw)
  To: linux-sh

Hello.

On 03/14/2013 01:59 AM, Laurent Pinchart wrote:

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>   drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 42 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 42 insertions(+)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> index 946572bc..6043d2c 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> @@ -2198,6 +2198,30 @@ static const unsigned int sdhi3_wp_pins[] = {
>   static const unsigned int sdhi3_wp_mux[] = {
>   	SD3_WP_MARK,
>   };
> +/* - USB0 ------------------------------------------------------------------- */
> +static const unsigned int usb0_pins[] = {
> +	/* OVC */
> +	150, 154,
> +};
> +static const unsigned int usb0_mux[] = {
> +	USB_OVC0_MARK, USB_PENC0_MARK,
> +};
> +/* - USB1 ------------------------------------------------------------------- */
> +static const unsigned int usb1_pins[] = {
> +	/* OVC */
> +	152, 155,
> +};
> +static const unsigned int usb1_mux[] = {
> +	USB_OVC1_MARK, USB_PENC1_MARK,
> +};
> +/* - USB2 ------------------------------------------------------------------- */
> +static const unsigned int usb2_pins[] = {
> +	/* OVC, PENC */
> +	125, 156,
> +};
> +static const unsigned int usb2_mux[] = {
> +	USB_OVC2_MARK, USB_PENC2_MARK,
> +};
>   

    The PENCn and USB_OVCn were erroneously grouped together (I've already
explained that the latter is usually unused 3.3V signal). This causes 
the following
(false) error messages when booting on Marzen:

sh-pfc pfc-r8a7779: pin GP_4_22 already requested by sh-hspi.0; cannot 
claim for
  ehci-platform.0
sh-pfc pfc-r8a7779: pin-150 (ehci-platform.0) status -22
sh-pfc pfc-r8a7779: could not request pin 150 on device sh-pfc

     GP_4_22 is multiplexed with USB_OVC0 (unused on Marzen) and HSPI_CLK0.
This needs fixing.

WBR, Sergei


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v4 19/88] sh-pfc: r8a7779: Add USB pin groups and functions
  2013-03-13 22:59 [PATCH v4 19/88] sh-pfc: r8a7779: Add USB pin groups and functions Laurent Pinchart
  2013-03-14 15:00 ` Linus Walleij
  2013-05-06 22:50 ` Sergei Shtylyov
@ 2013-05-07  6:36 ` Laurent Pinchart
  2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2013-05-07  6:36 UTC (permalink / raw)
  To: linux-sh

Hi Sergei,

On Tuesday 07 May 2013 02:50:36 Sergei Shtylyov wrote:
> On 03/14/2013 01:59 AM, Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >   drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 42 ++++++++++++++++++++++++++++++
> >   1 file changed, 42 insertions(+)
> > 
> > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> > b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index 946572bc..6043d2c 100644
> > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> > @@ -2198,6 +2198,30 @@ static const unsigned int sdhi3_wp_pins[] = {
> >   static const unsigned int sdhi3_wp_mux[] = {
> >   	SD3_WP_MARK,
> >   };
> > 
> > +/* - USB0 ------------------------------------------------------------ */
> > +static const unsigned int usb0_pins[] = {
> > +	/* OVC */
> > +	150, 154,
> > +};
> > +static const unsigned int usb0_mux[] = {
> > +	USB_OVC0_MARK, USB_PENC0_MARK,
> > +};
> > +/* - USB1 ------------------------------------------------------------ */
> > +static const unsigned int usb1_pins[] = {
> > +	/* OVC */
> > +	152, 155,
> > +};
> > +static const unsigned int usb1_mux[] = {
> > +	USB_OVC1_MARK, USB_PENC1_MARK,
> > +};
> > +/* - USB2 ------------------------------------------------------------ */
> > +static const unsigned int usb2_pins[] = {
> > +	/* OVC, PENC */
> > +	125, 156,
> > +};
> > +static const unsigned int usb2_mux[] = {
> > +	USB_OVC2_MARK, USB_PENC2_MARK,
> > +};
> 
> The PENCn and USB_OVCn were erroneously grouped together (I've already
> explained that the latter is usually unused 3.3V signal). This causes
> the following (false) error messages when booting on Marzen:
> 
> sh-pfc pfc-r8a7779: pin GP_4_22 already requested by sh-hspi.0; cannot
> claim for ehci-platform.0
> sh-pfc pfc-r8a7779: pin-150 (ehci-platform.0) status -22
> sh-pfc pfc-r8a7779: could not request pin 150 on device sh-pfc
> 
> GP_4_22 is multiplexed with USB_OVC0 (unused on Marzen) and HSPI_CLK0. This
> needs fixing.

Thank you for the explanation. I've sent a patch to fix this issue, could you 
please review it ?

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-07  6:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-13 22:59 [PATCH v4 19/88] sh-pfc: r8a7779: Add USB pin groups and functions Laurent Pinchart
2013-03-14 15:00 ` Linus Walleij
2013-05-06 22:50 ` Sergei Shtylyov
2013-05-07  6:36 ` Laurent Pinchart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.