All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Sandy Huang <hjc@rock-chips.com>,
	kernel-janitors@vger.kernel.org, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] drm/rockchip: lvds: add missing of_node_put
Date: Sat, 16 Jun 2018 14:24:09 +0200	[thread overview]
Message-ID: <1948755.WvuARZiism@diego> (raw)
In-Reply-To: <1527102436-13447-6-git-send-email-Julia.Lawall@lip6.fr>

Hi Julia,

Am Mittwoch, 23. Mai 2018, 21:07:16 CEST schrieb Julia Lawall:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
> 
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> +  of_node_put(child);
> ?  break;
>    ...
> }
> ... when != child
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

thanks for catching this. I've added a "Fixes"-tag and
applied the patch to drm-misc-next 


Thanks
Heiko



WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: David Airlie <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] drm/rockchip: lvds: add missing of_node_put
Date: Sat, 16 Jun 2018 12:24:09 +0000	[thread overview]
Message-ID: <1948755.WvuARZiism@diego> (raw)
In-Reply-To: <1527102436-13447-6-git-send-email-Julia.Lawall@lip6.fr>

Hi Julia,

Am Mittwoch, 23. Mai 2018, 21:07:16 CEST schrieb Julia Lawall:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
> 
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> +  of_node_put(child);
> ?  break;
>    ...
> }
> ... when != child
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

thanks for catching this. I've added a "Fixes"-tag and
applied the patch to drm-misc-next 


Thanks
Heiko



WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: David Airlie <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] drm/rockchip: lvds: add missing of_node_put
Date: Sat, 16 Jun 2018 14:24:09 +0200	[thread overview]
Message-ID: <1948755.WvuARZiism@diego> (raw)
In-Reply-To: <1527102436-13447-6-git-send-email-Julia.Lawall@lip6.fr>

Hi Julia,

Am Mittwoch, 23. Mai 2018, 21:07:16 CEST schrieb Julia Lawall:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
> 
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> +  of_node_put(child);
> ?  break;
>    ...
> }
> ... when != child
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

thanks for catching this. I've added a "Fixes"-tag and
applied the patch to drm-misc-next 


Thanks
Heiko


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] drm/rockchip: lvds: add missing of_node_put
Date: Sat, 16 Jun 2018 14:24:09 +0200	[thread overview]
Message-ID: <1948755.WvuARZiism@diego> (raw)
In-Reply-To: <1527102436-13447-6-git-send-email-Julia.Lawall@lip6.fr>

Hi Julia,

Am Mittwoch, 23. Mai 2018, 21:07:16 CEST schrieb Julia Lawall:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
> 
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> +  of_node_put(child);
> ?  break;
>    ...
> }
> ... when != child
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

thanks for catching this. I've added a "Fixes"-tag and
applied the patch to drm-misc-next 


Thanks
Heiko

  reply	other threads:[~2018-06-16 12:24 UTC|newest]

Thread overview: 183+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 19:07 [PATCH 0/5] add missing of_node_put Julia Lawall
2018-05-23 19:07 ` Julia Lawall
2018-05-23 19:07 ` Julia Lawall
2018-05-23 19:07 ` Julia Lawall
2018-05-23 19:07 ` [PATCH 1/5] pinctrl: at91-pio4: " Julia Lawall
2018-05-23 19:07   ` Julia Lawall
2018-05-23 19:07   ` Julia Lawall
2018-05-24  7:59   ` Ludovic Desroches
2018-05-24  7:59     ` Ludovic Desroches
2018-05-24  7:59     ` Ludovic Desroches
2018-05-24  7:59     ` Ludovic Desroches
2018-05-24  8:30   ` Linus Walleij
2018-05-24  8:30     ` Linus Walleij
2018-05-24  8:30     ` Linus Walleij
2018-05-23 19:07 ` [PATCH 2/5] phy: " Julia Lawall
2018-05-23 19:07   ` Julia Lawall
2018-05-23 19:07 ` [PATCH 3/5] soc: ti: knav_dma: " Julia Lawall
2018-05-23 19:07   ` Julia Lawall
2018-05-23 19:07   ` Julia Lawall
2018-05-23 19:07 ` [PATCH 4/5] pci/hotplug/pnv-php: " Julia Lawall
2018-05-23 19:07   ` Julia Lawall
2018-05-23 21:50   ` Bjorn Helgaas
2018-05-23 21:50     ` Bjorn Helgaas
2018-05-23 19:07 ` [PATCH 5/5] drm/rockchip: lvds: " Julia Lawall
2018-05-23 19:07   ` Julia Lawall
2018-05-23 19:07   ` Julia Lawall
2018-05-23 19:07   ` Julia Lawall
2018-06-16 12:24   ` Heiko Stübner [this message]
2018-06-16 12:24     ` Heiko Stübner
2018-06-16 12:24     ` Heiko Stübner
2018-06-16 12:24     ` Heiko Stübner
  -- strict thread matches above, loose matches on Subject: below --
2015-12-21 16:39 [PATCH 0/5] " Julia Lawall
2015-12-21 16:39 ` Julia Lawall
2015-12-21 16:39 ` Julia Lawall
2015-12-21 16:39 ` Julia Lawall
2015-12-21 16:39 ` [PATCH 1/5] pinctrl-tegra: " Julia Lawall
2015-12-21 16:39   ` Julia Lawall
2015-12-22 12:44   ` Linus Walleij
2015-12-22 12:44     ` Linus Walleij
2015-12-21 16:39 ` [PATCH 2/5] pinctrl: sirf: " Julia Lawall
2015-12-21 16:39   ` Julia Lawall
2015-12-21 16:39   ` Julia Lawall
2015-12-22 12:45   ` Linus Walleij
2015-12-22 12:45     ` Linus Walleij
2015-12-22 12:45     ` Linus Walleij
2015-12-22 12:45     ` Linus Walleij
2015-12-21 16:39 ` [PATCH 3/5] pinctrl: sh-pfc: " Julia Lawall
2015-12-21 16:39   ` Julia Lawall
2015-12-21 20:46   ` Laurent Pinchart
2015-12-21 20:46     ` Laurent Pinchart
2015-12-22 12:47   ` Linus Walleij
2015-12-22 12:47     ` Linus Walleij
2015-12-22 13:23     ` Geert Uytterhoeven
2015-12-22 13:23       ` Geert Uytterhoeven
2015-12-21 16:39 ` [PATCH 4/5] pinctrl: rockchip: " Julia Lawall
2015-12-21 16:39   ` Julia Lawall
2015-12-21 16:39   ` Julia Lawall
     [not found]   ` <1450715988-4770-5-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2015-12-21 21:20     ` Heiko Stübner
2015-12-21 21:20       ` Heiko Stübner
2015-12-21 21:20       ` Heiko Stübner
2015-12-21 21:20       ` Heiko Stübner
2015-12-22 12:48   ` Linus Walleij
2015-12-22 12:48     ` Linus Walleij
2015-12-22 12:48     ` Linus Walleij
2015-12-22 12:48     ` Linus Walleij
2015-12-21 16:39 ` [PATCH 5/5] pinctrl: mediatek: " Julia Lawall
2015-12-21 16:39   ` Julia Lawall
2015-12-21 16:39   ` Julia Lawall
2015-12-22 12:49   ` Linus Walleij
2015-12-22 12:49     ` Linus Walleij
2015-12-22 12:49     ` Linus Walleij
2015-12-22 12:49     ` Linus Walleij
2015-10-21 20:41 [PATCH 0/5] " Julia Lawall
2015-10-21 20:41 ` Julia Lawall
2015-10-21 20:41 ` Julia Lawall
2015-10-21 20:41 ` [PATCH 1/5] clk: " Julia Lawall
2015-10-21 20:41   ` Julia Lawall
2015-10-21 23:13   ` Stephen Boyd
2015-10-21 23:13     ` Stephen Boyd
2015-10-22  5:52     ` Julia Lawall
2015-10-22  5:52       ` Julia Lawall
2015-10-21 20:41 ` [PATCH 2/5] clk: si5351: " Julia Lawall
2015-10-21 20:41   ` Julia Lawall
2015-10-21 23:14   ` Stephen Boyd
2015-10-21 23:14     ` Stephen Boyd
2015-10-21 20:41 ` [PATCH 3/5] clk: imx27: " Julia Lawall
2015-10-21 20:41   ` Julia Lawall
2015-10-21 20:41   ` Julia Lawall
2015-10-21 23:15   ` Stephen Boyd
2015-10-21 23:15     ` Stephen Boyd
2015-10-21 23:15     ` Stephen Boyd
2015-10-21 20:41 ` [PATCH 4/5] clk: imx31: " Julia Lawall
2015-10-21 20:41   ` Julia Lawall
2015-10-21 20:41   ` Julia Lawall
2015-10-21 23:15   ` Stephen Boyd
2015-10-21 23:15     ` Stephen Boyd
2015-10-21 23:15     ` Stephen Boyd
2015-10-21 20:41 ` [PATCH 5/5] clk: scpi: " Julia Lawall
2015-10-21 20:41   ` Julia Lawall
2015-10-21 20:41   ` Julia Lawall
2015-10-21 23:17   ` Stephen Boyd
2015-10-21 23:17     ` Stephen Boyd
2015-10-21 23:17     ` Stephen Boyd
2015-10-22  9:21   ` Sudeep Holla
2015-10-22  9:21     ` Sudeep Holla
2015-10-22  9:21     ` Sudeep Holla
2015-11-26 17:29     ` Sudeep Holla
2015-11-26 17:29       ` Sudeep Holla
2015-11-26 17:29       ` Sudeep Holla
2015-12-01  0:28       ` Stephen Boyd
2015-12-01  0:28         ` Stephen Boyd
2015-12-01  0:28         ` Stephen Boyd
2015-12-01  0:29   ` Stephen Boyd
2015-12-01  0:29     ` Stephen Boyd
2015-12-01  0:29     ` Stephen Boyd
2015-10-10 12:30 [PATCH 0/5] " Julia Lawall
2015-10-10 12:30 ` Julia Lawall
2015-10-10 12:30 ` Julia Lawall
2015-10-10 12:30 ` [PATCH 1/5] backlight: 88pm860x_bl: " Julia Lawall
2015-10-10 12:30   ` Julia Lawall
2015-10-13  8:15   ` Lee Jones
2015-10-13  8:15     ` Lee Jones
2015-10-13  8:15     ` Lee Jones
2015-10-10 12:30 ` [PATCH 2/5] power_supply: charger-manager: " Julia Lawall
2015-10-10 12:30   ` Julia Lawall
2015-10-12  2:20   ` Krzysztof Kozlowski
2015-10-12  2:20     ` Krzysztof Kozlowski
2015-10-15  8:56   ` Sebastian Reichel
2015-10-15  8:56     ` Sebastian Reichel
2015-10-10 12:30 ` [PATCH 3/5] ARM: shmobile: R-Mobile: " Julia Lawall
2015-10-10 12:30   ` Julia Lawall
2015-10-10 12:30   ` Julia Lawall
2015-10-12  0:16   ` Simon Horman
2015-10-12  0:16     ` Simon Horman
2015-10-12  0:16     ` Simon Horman
2015-10-12  7:18   ` Geert Uytterhoeven
2015-10-12  7:18     ` Geert Uytterhoeven
2015-10-12  7:18     ` Geert Uytterhoeven
2015-10-12  7:24     ` Julia Lawall
2015-10-12  7:24       ` Julia Lawall
2015-10-12  7:24       ` Julia Lawall
2015-10-12  7:26       ` Geert Uytterhoeven
2015-10-12  7:26         ` Geert Uytterhoeven
2015-10-12  7:26         ` Geert Uytterhoeven
2015-10-12  7:29     ` Thomas Petazzoni
2015-10-12  7:29       ` Thomas Petazzoni
2015-10-12  7:29       ` Thomas Petazzoni
2015-10-12  7:30       ` Geert Uytterhoeven
2015-10-12  7:30         ` Geert Uytterhoeven
2015-10-12  7:30         ` Geert Uytterhoeven
2015-10-10 12:30 ` [PATCH 4/5] regulator: of: " Julia Lawall
2015-10-10 12:30   ` Julia Lawall
2015-10-12  0:33   ` Krzysztof Kozlowski
2015-10-12  0:33     ` Krzysztof Kozlowski
2015-10-12  5:35     ` Julia Lawall
2015-10-12  5:35       ` Julia Lawall
2015-10-12 12:44     ` Julia Lawall
2015-10-12 12:44       ` Julia Lawall
2015-10-12 12:58       ` Krzysztof Kozlowski
2015-10-12 12:58         ` Krzysztof Kozlowski
2018-02-12 12:09   ` Applied "regulator: of: Add a missing 'of_node_put()' in an error handling path of 'of_regulator_match()'" to the regulator tree Mark Brown
2018-02-12 12:09     ` Applied "regulator: of: Add a missing 'of_node_put()' in an error handling path of 'of_regulator_mat Mark Brown
2015-10-10 12:30 ` [PATCH 5/5] arm: add missing of_node_put Julia Lawall
2015-10-10 12:30   ` Julia Lawall
2015-10-10 12:30   ` Julia Lawall
2015-10-10 21:02   ` Arnd Bergmann
2015-10-10 21:02     ` Arnd Bergmann
2015-10-10 21:02     ` Arnd Bergmann
2015-10-10 21:08     ` Thomas Petazzoni
2015-10-10 21:08       ` Thomas Petazzoni
2015-10-10 21:08       ` Thomas Petazzoni
2015-10-10 21:12       ` Julia Lawall
2015-10-10 21:12         ` Julia Lawall
2015-10-10 21:12         ` Julia Lawall
2015-10-10 21:10     ` Julia Lawall
2015-10-10 21:10       ` Julia Lawall
2015-10-10 21:10       ` Julia Lawall
2015-10-10 21:15       ` Arnd Bergmann
2015-10-10 21:15         ` Arnd Bergmann
2015-10-10 21:15         ` Arnd Bergmann
2015-10-10 21:41         ` [PATCH 5/5 v2] " Julia Lawall
2015-10-10 21:41           ` Julia Lawall
2015-10-10 21:41           ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1948755.WvuARZiism@diego \
    --to=heiko@sntech.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.