All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: "Florian Fainelli" <f.fainelli@gmail.com>,
	"Michal Suchánek" <msuchanek@suse.de>
Cc: Scott Branden <sbranden@broadcom.com>,
	linux-rpi-kernel@lists.infradead.org,
	Eric Anholt <eric@anholt.net>,
	bcm-kernel-feedback-list@broadcom.com,
	Gerd Hoffmann <kraxel@redhat.com>,
	linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
	linux-kernel@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
	"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] mmc: bcm2835: print some informational messages during reset
Date: Thu, 15 Feb 2018 19:22:00 +0100 (CET)	[thread overview]
Message-ID: <1950058855.86123.1518718920111@email.1und1.de> (raw)
In-Reply-To: <20180214204733.7987d16c@naga.suse.cz>

Hi Michal,

> Michal Suchánek <msuchanek@suse.de> hat am 14. Februar 2018 um 20:47 geschrieben:
> 
> 
> On Wed, 14 Feb 2018 08:50:16 -0800
> Florian Fainelli <f.fainelli@gmail.com> wrote:
> 
> > On February 14, 2018 6:38:58 AM PST, Michal Suchanek
> > <msuchanek@suse.de> wrote:
> > >The previous patch does reset during hardware error so make the reset
> > >progress more visible.  
> > 
> > Based on your previous email it looks like this can happen quite
> > frequently so we might be spamming the kernel log with such reset
> > messages. Turning this into a debug print would not be great either,
> > how about a custom sysfs attribute counting the number of times a
> > reset was done?
> 
> Since every such message happens when the system stalls for like half a
> minute I don't think there will be that many until somebody notices
> something is amiss. It might be also helpful in diagnosing if other
> cards lock up in different way - for me the DMA shutdown is short so I
> guess it's the mmc host that is locked up and the DMA engine is fine.
> It might look differently on different systems, though.

FWIW according to your dmesg your RPi doesn't use the DMA engine:

[ 5.004609] sdhost-bcm2835 3f202000.sdhost: unable to initialise DMA channel. Falling back to PIO
[ 5.154518] sdhost-bcm2835 3f202000.sdhost: loaded - DMA disabled

For me it's a chicken and egg problem if the DMA driver is build as a kernel module.

Stefan

> 
> I understand that adding messages it somewhat controversial so I added
> them in separate patch.
> 
> Thanks
> 
> Michal

WARNING: multiple messages have this Message-ID (diff)
From: stefan.wahren@i2se.com (Stefan Wahren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mmc: bcm2835: print some informational messages during reset
Date: Thu, 15 Feb 2018 19:22:00 +0100 (CET)	[thread overview]
Message-ID: <1950058855.86123.1518718920111@email.1und1.de> (raw)
In-Reply-To: <20180214204733.7987d16c@naga.suse.cz>

Hi Michal,

> Michal Such?nek <msuchanek@suse.de> hat am 14. Februar 2018 um 20:47 geschrieben:
> 
> 
> On Wed, 14 Feb 2018 08:50:16 -0800
> Florian Fainelli <f.fainelli@gmail.com> wrote:
> 
> > On February 14, 2018 6:38:58 AM PST, Michal Suchanek
> > <msuchanek@suse.de> wrote:
> > >The previous patch does reset during hardware error so make the reset
> > >progress more visible.  
> > 
> > Based on your previous email it looks like this can happen quite
> > frequently so we might be spamming the kernel log with such reset
> > messages. Turning this into a debug print would not be great either,
> > how about a custom sysfs attribute counting the number of times a
> > reset was done?
> 
> Since every such message happens when the system stalls for like half a
> minute I don't think there will be that many until somebody notices
> something is amiss. It might be also helpful in diagnosing if other
> cards lock up in different way - for me the DMA shutdown is short so I
> guess it's the mmc host that is locked up and the DMA engine is fine.
> It might look differently on different systems, though.

FWIW according to your dmesg your RPi doesn't use the DMA engine:

[ 5.004609] sdhost-bcm2835 3f202000.sdhost: unable to initialise DMA channel. Falling back to PIO
[ 5.154518] sdhost-bcm2835 3f202000.sdhost: loaded - DMA disabled

For me it's a chicken and egg problem if the DMA driver is build as a kernel module.

Stefan

> 
> I understand that adding messages it somewhat controversial so I added
> them in separate patch.
> 
> Thanks
> 
> Michal

  reply	other threads:[~2018-02-15 18:22 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 14:38 [PATCH 1/2] mmc: bcm2835: reset host on timeout Michal Suchanek
2018-02-14 14:38 ` Michal Suchanek
2018-02-14 14:38 ` [PATCH 2/2] mmc: bcm2835: print some informational messages during reset Michal Suchanek
2018-02-14 14:38   ` Michal Suchanek
2018-02-14 16:50   ` Florian Fainelli
2018-02-14 16:50     ` Florian Fainelli
2018-02-14 16:50   ` Florian Fainelli
2018-02-14 16:50     ` Florian Fainelli
2018-02-14 19:47     ` Michal Suchánek
2018-02-14 19:47       ` Michal Suchánek
2018-02-15 18:22       ` Stefan Wahren [this message]
2018-02-15 18:22         ` Stefan Wahren
2018-03-04 15:46         ` Michal Suchánek
2018-03-04 15:46           ` Michal Suchánek
2018-02-14 14:58 ` [PATCH 1/2] mmc: bcm2835: reset host on timeout Stefan Wahren
2018-02-14 14:58   ` Stefan Wahren
2018-02-14 15:36   ` Michal Suchánek
2018-02-14 15:36     ` Michal Suchánek
2018-02-14 15:58     ` Michal Suchánek
2018-02-14 16:13       ` Michal Suchánek
2018-02-14 16:49       ` Stefan Wahren
2018-02-14 16:49         ` Stefan Wahren
2018-02-14 19:24         ` Michal Suchánek
2018-02-14 19:24           ` Michal Suchánek
2018-02-14 20:30           ` Stefan Wahren
2018-02-14 20:30             ` Stefan Wahren
2018-03-04 15:57             ` Michal Suchánek
2018-03-04 15:57               ` Michal Suchánek
2018-03-04 18:11               ` Stefan Wahren
2018-03-04 18:11                 ` Stefan Wahren
2018-03-04 18:11                 ` Stefan Wahren
2018-03-04 18:44                 ` Michal Suchánek
2018-03-04 18:44                   ` Michal Suchánek
2018-03-03 13:58           ` Stefan Wahren
2018-03-03 13:58             ` Stefan Wahren
2018-03-04 16:04             ` Michal Suchánek
2018-03-04 16:04               ` Michal Suchánek
2018-03-04 16:36             ` Michal Suchánek
2018-03-04 16:36               ` Michal Suchánek
2018-03-04 18:15               ` Stefan Wahren
2018-03-04 18:15                 ` Stefan Wahren
2018-03-04 18:15                 ` Stefan Wahren
2018-03-06 19:21             ` Michal Suchánek
2018-03-06 19:21               ` Michal Suchánek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1950058855.86123.1518718920111@email.1und1.de \
    --to=stefan.wahren@i2se.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=garsilva@embeddedor.com \
    --cc=kraxel@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=msuchanek@suse.de \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.