From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Patrick Ohly <patrick.ohly@intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 09/11] lib/bb/siggen: add collapsed mode to compare_sigfiles()
Date: Fri, 07 Apr 2017 20:26:37 +1200 [thread overview]
Message-ID: <1955431.r1d7W8j1YV@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <1491547069.10884.55.camel@intel.com>
On Friday, 7 April 2017 6:37:49 PM NZST Patrick Ohly wrote:
> On Fri, 2017-04-07 at 09:52 +1200, Paul Eggleton wrote:
> > If we just want to drill down to the actual differences then we don't
> > need to see certain things in the output, e.g. basehash changing or the
> > signature of dependent tasks. This will be used for comparing signatures
> > within buildhistory-diff in OE-Core; the default mode as used by
> > bitbake-diffsigs and bitbake -S printdiff remains unchanged for the
> > moment.
>
> This sounds interesting. The bitbake-diffsigs output I got for the
> yocto-compat-layer had such useless "basehash changed" comments. Should
> we add a mode parameter to bitbake-diffsigs that allows choosing this
> collapsed mode?
We could, but to be effective the caller needs to handle the output in a
particular way (see what I've done in the buildhistory-diff patchset I sent
today).
FYI my plan for 2.4 is to evaluate whether this collapsed mode or something
like it is better as a default display mode.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2017-04-07 8:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 21:52 [PATCH 00/11] bitbake-diffsigs fixes/improvements Paul Eggleton
2017-04-06 21:52 ` [PATCH 01/11] bitbake-diffsigs: fix -t picking wrong files to compare Paul Eggleton
2017-04-06 21:52 ` [PATCH 02/11] lib/bb/siggen: add missing path separator to cleaned paths Paul Eggleton
2017-04-06 21:52 ` [PATCH 03/11] bitbake-diffsigs: properly report which signature is missing Paul Eggleton
2017-04-07 16:25 ` Patrick Ohly
2017-04-06 21:52 ` [PATCH 04/11] bitbake-diffsigs: drop naive logic for removing duplicate files Paul Eggleton
2017-04-06 21:52 ` [PATCH 05/11] lib/bb/siggen: show a diff when dumping changes to multi-line values Paul Eggleton
2017-04-06 21:52 ` [PATCH 06/11] lib/bb/siggen: don't show unchanged runtaskdeps list Paul Eggleton
2017-04-06 21:52 ` [PATCH 07/11] bitbake-diffsigs: change to use argparse Paul Eggleton
2017-04-06 21:52 ` [PATCH 08/11] bitbake-diffsigs: add an option to find and compare specific signatures Paul Eggleton
2017-04-06 21:52 ` [PATCH 09/11] lib/bb/siggen: add collapsed mode to compare_sigfiles() Paul Eggleton
2017-04-07 6:37 ` Patrick Ohly
2017-04-07 8:26 ` Paul Eggleton [this message]
2017-04-06 21:52 ` [PATCH 10/11] lib/bb/siggen: show word-diff for single-line values containing spaces Paul Eggleton
2017-04-06 21:52 ` [PATCH 11/11] bitbake-diffsigs: colourise output Paul Eggleton
2017-04-07 7:56 ` [PATCH 00/11] bitbake-diffsigs fixes/improvements Patrick Ohly
2017-04-07 8:29 ` Paul Eggleton
2017-04-07 8:32 ` Paul Eggleton
2017-04-07 8:54 ` Patrick Ohly
2017-04-07 9:48 ` Paul Eggleton
2017-04-07 12:20 ` Peter Kjellerstedt
2017-04-07 16:46 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1955431.r1d7W8j1YV@peggleto-mobl.ger.corp.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.