All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: [PATCH 06/11] lib/bb/siggen: don't show unchanged runtaskdeps list
Date: Fri,  7 Apr 2017 09:52:06 +1200	[thread overview]
Message-ID: <916b4b9af0e3ffd88312745ebfadce51a8dfee04.1491514854.git.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <cover.1491514854.git.paul.eggleton@linux.intel.com>

If the runtaskdeps list hasn't actually changed (but the signatures of
some of the tasks did) then it doesn't make sense to print out the old
and new lists as they are both the same and may be very long, e.g. for
do_rootfs in OE.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 lib/bb/siggen.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index f497fb9..c6b14c2 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -506,10 +506,14 @@ def compare_sigfiles(a, b, recursecb = None):
                 changed.append("%s with hash %s\n changed to\n%s with hash %s" % (a, a_data['runtaskhashes'][a], b, b_data['runtaskhashes'][b]))
 
     if changed:
-        output.append("runtaskdeps changed from %s to %s" % (clean_basepaths_list(a_data['runtaskdeps']), clean_basepaths_list(b_data['runtaskdeps'])))
+        clean_a = clean_basepaths_list(a_data['runtaskdeps'])
+        clean_b = clean_basepaths_list(b_data['runtaskdeps'])
+        if clean_a != clean_b:
+            output.append("runtaskdeps changed from %s to %s" % (clean_a, clean_b))
+        else:
+            output.append("runtaskdeps changed:")
         output.append("\n".join(changed))
 
-
     if 'runtaskhashes' in a_data and 'runtaskhashes' in b_data:
         a = a_data['runtaskhashes']
         b = b_data['runtaskhashes']
-- 
2.9.3



  parent reply	other threads:[~2017-04-06 21:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 21:52 [PATCH 00/11] bitbake-diffsigs fixes/improvements Paul Eggleton
2017-04-06 21:52 ` [PATCH 01/11] bitbake-diffsigs: fix -t picking wrong files to compare Paul Eggleton
2017-04-06 21:52 ` [PATCH 02/11] lib/bb/siggen: add missing path separator to cleaned paths Paul Eggleton
2017-04-06 21:52 ` [PATCH 03/11] bitbake-diffsigs: properly report which signature is missing Paul Eggleton
2017-04-07 16:25   ` Patrick Ohly
2017-04-06 21:52 ` [PATCH 04/11] bitbake-diffsigs: drop naive logic for removing duplicate files Paul Eggleton
2017-04-06 21:52 ` [PATCH 05/11] lib/bb/siggen: show a diff when dumping changes to multi-line values Paul Eggleton
2017-04-06 21:52 ` Paul Eggleton [this message]
2017-04-06 21:52 ` [PATCH 07/11] bitbake-diffsigs: change to use argparse Paul Eggleton
2017-04-06 21:52 ` [PATCH 08/11] bitbake-diffsigs: add an option to find and compare specific signatures Paul Eggleton
2017-04-06 21:52 ` [PATCH 09/11] lib/bb/siggen: add collapsed mode to compare_sigfiles() Paul Eggleton
2017-04-07  6:37   ` Patrick Ohly
2017-04-07  8:26     ` Paul Eggleton
2017-04-06 21:52 ` [PATCH 10/11] lib/bb/siggen: show word-diff for single-line values containing spaces Paul Eggleton
2017-04-06 21:52 ` [PATCH 11/11] bitbake-diffsigs: colourise output Paul Eggleton
2017-04-07  7:56 ` [PATCH 00/11] bitbake-diffsigs fixes/improvements Patrick Ohly
2017-04-07  8:29   ` Paul Eggleton
2017-04-07  8:32     ` Paul Eggleton
2017-04-07  8:54       ` Patrick Ohly
2017-04-07  9:48         ` Paul Eggleton
2017-04-07 12:20 ` Peter Kjellerstedt
2017-04-07 16:46   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=916b4b9af0e3ffd88312745ebfadce51a8dfee04.1491514854.git.paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.