All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shreeya Patel <shreeya.patel@collabora.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	jic23@kernel.org, heiko@sntech.de,
	sebastian.reichel@collabora.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	lars@metafoo.de, linux-arm-kernel@lists.infradead.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com, gustavo.padovan@collabora.com,
	serge.broslavsky@collabora.com
Subject: Re: [PATCH v2 3/8] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled
Date: Mon, 29 May 2023 02:52:26 +0530	[thread overview]
Message-ID: <196486e3-a6e4-d330-6193-6eff248bdefb@collabora.com> (raw)
In-Reply-To: <a7e0d4f0-a497-8697-e108-5247e11abc41@collabora.com>

Hi Dmitry,


On 26/05/23 06:12, Dmitry Osipenko wrote:
> On 5/26/23 00:27, Shreeya Patel wrote:
>> @@ -600,8 +560,6 @@ static int rockchip_saradc_suspend(struct device *dev)
>>   	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>>   	struct rockchip_saradc *info = iio_priv(indio_dev);
>>   
>> -	clk_disable_unprepare(info->clk);
>> -	clk_disable_unprepare(info->pclk);
>>   	regulator_disable(info->vref);
> Why clocks need to be enabled during suspend?

They don't need to be enabled during suspend. Thanks for pointing it 
out, I'll add them again in v3.


Thanks,
Shreeya Patel


WARNING: multiple messages have this Message-ID (diff)
From: Shreeya Patel <shreeya.patel@collabora.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	jic23@kernel.org, heiko@sntech.de,
	sebastian.reichel@collabora.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	lars@metafoo.de, linux-arm-kernel@lists.infradead.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com, gustavo.padovan@collabora.com,
	serge.broslavsky@collabora.com
Subject: Re: [PATCH v2 3/8] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled
Date: Mon, 29 May 2023 02:52:26 +0530	[thread overview]
Message-ID: <196486e3-a6e4-d330-6193-6eff248bdefb@collabora.com> (raw)
In-Reply-To: <a7e0d4f0-a497-8697-e108-5247e11abc41@collabora.com>

Hi Dmitry,


On 26/05/23 06:12, Dmitry Osipenko wrote:
> On 5/26/23 00:27, Shreeya Patel wrote:
>> @@ -600,8 +560,6 @@ static int rockchip_saradc_suspend(struct device *dev)
>>   	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>>   	struct rockchip_saradc *info = iio_priv(indio_dev);
>>   
>> -	clk_disable_unprepare(info->clk);
>> -	clk_disable_unprepare(info->pclk);
>>   	regulator_disable(info->vref);
> Why clocks need to be enabled during suspend?

They don't need to be enabled during suspend. Thanks for pointing it 
out, I'll add them again in v3.


Thanks,
Shreeya Patel


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Shreeya Patel <shreeya.patel@collabora.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	jic23@kernel.org, heiko@sntech.de,
	sebastian.reichel@collabora.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	lars@metafoo.de, linux-arm-kernel@lists.infradead.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com, gustavo.padovan@collabora.com,
	serge.broslavsky@collabora.com
Subject: Re: [PATCH v2 3/8] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled
Date: Mon, 29 May 2023 02:52:26 +0530	[thread overview]
Message-ID: <196486e3-a6e4-d330-6193-6eff248bdefb@collabora.com> (raw)
In-Reply-To: <a7e0d4f0-a497-8697-e108-5247e11abc41@collabora.com>

Hi Dmitry,


On 26/05/23 06:12, Dmitry Osipenko wrote:
> On 5/26/23 00:27, Shreeya Patel wrote:
>> @@ -600,8 +560,6 @@ static int rockchip_saradc_suspend(struct device *dev)
>>   	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>>   	struct rockchip_saradc *info = iio_priv(indio_dev);
>>   
>> -	clk_disable_unprepare(info->clk);
>> -	clk_disable_unprepare(info->pclk);
>>   	regulator_disable(info->vref);
> Why clocks need to be enabled during suspend?

They don't need to be enabled during suspend. Thanks for pointing it 
out, I'll add them again in v3.


Thanks,
Shreeya Patel


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-05-28 21:22 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 21:27 [PATCH v2 0/8] RK3588 ADC support Shreeya Patel
2023-05-25 21:27 ` Shreeya Patel
2023-05-25 21:27 ` Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 1/8] iio: adc: rockchip_saradc: Add callback functions Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 2/8] iio: adc: rockchip_saradc: Add support for RK3588 Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-26  6:01   ` kernel test robot
2023-05-26  6:01     ` kernel test robot
2023-05-26  8:36   ` AngeloGioacchino Del Regno
2023-05-26  8:36     ` AngeloGioacchino Del Regno
2023-05-26  8:36     ` AngeloGioacchino Del Regno
2023-05-25 21:27 ` [PATCH v2 3/8] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-26  0:42   ` Dmitry Osipenko
2023-05-26  0:42     ` Dmitry Osipenko
2023-05-26  0:42     ` Dmitry Osipenko
2023-05-28 21:22     ` Shreeya Patel [this message]
2023-05-28 21:22       ` Shreeya Patel
2023-05-28 21:22       ` Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 4/8] iio: adc: rockchip_saradc: Use of_device_get_match_data Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 5/8] iio: adc: rockchip_saradc: Match alignment with open parenthesis Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 6/8] iio: adc: rockchip_saradc: Use dev_err_probe Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 7/8] arm64: dts: rockchip: Add DT node for ADC support in RK3588 Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 8/8] dt-bindings: iio: adc: Add rockchip,rk3588-saradc string Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-25 21:27   ` Shreeya Patel
2023-05-28 16:46 ` [PATCH v2 0/8] RK3588 ADC support Jonathan Cameron
2023-05-28 16:46   ` Jonathan Cameron
2023-05-28 16:46   ` Jonathan Cameron
2023-05-28 21:25   ` Shreeya Patel
2023-05-28 21:25     ` Shreeya Patel
2023-05-28 21:25     ` Shreeya Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=196486e3-a6e4-d330-6193-6eff248bdefb@collabora.com \
    --to=shreeya.patel@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.osipenko@collabora.com \
    --cc=gustavo.padovan@collabora.com \
    --cc=heiko@sntech.de \
    --cc=jic23@kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=serge.broslavsky@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.