* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE
@ 2016-01-19 11:27 ` kbuild test robot
0 siblings, 0 replies; 41+ messages in thread
From: kbuild test robot @ 2016-01-19 11:27 UTC (permalink / raw)
To: James Hogan
Cc: linux-mips, linux-arch, linux-kbuild, Florian Fainelli,
Paul Burton, Ralf Baechle, Arnd Bergmann, James Hogan,
Heinrich Schuchardt, linux-kernel, linux-mips, linux-arch,
linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle,
Arnd Bergmann, James Hogan, Heinrich Schuchardt, linux-kernel,
Michal Marek
https://github.com/0day-ci/linux James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642
d979f99e9cc14e2667e9b6e268db695977e4197a kbuild: Remove stale asm-generic wrappers
arch/x86/include/asm/unistd.h:15:29: fatal error: asm/unistd_32.h: No such file or directory
arch/x86/kernel/asm-offsets_32.c:12:29: fatal error: asm/syscalls_32.h: No such file or directory
arch/x86/kernel/asm-offsets_64.c:15:29: fatal error: asm/syscalls_64.h: No such file or directory
/bin/sh: line 0: [: -ge: unary operator expected
Error ids grouped by kconfigs:
recent_errors
├── i386-alldefconfig
│ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory
├── i386-allmodconfig
│ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory
├── i386-allyesconfig
│ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory
├── i386-defconfig
│ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory
├── i386-randconfig-a0-201603
│ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory
├── i386-randconfig-b0-01191831
│ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory
├── i386-randconfig-i0-201603
│ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory
├── i386-randconfig-i1-201603
│ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory
├── i386-randconfig-r0-201603
│ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory
├── i386-randconfig-s1-201603
│ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory
├── i386-randconfig-x002-01181631
│ └── bin-sh:line::ge:unary-operator-expected
├── i386-tinyconfig
│ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory
└── x86_64-randconfig-s3-01191831
└── arch-x86-kernel-asm-offsets_64.c:fatal-error:asm-syscalls_64.h:No-such-file-or-directory
elapsed time: 50m
configs tested: 118
i386 randconfig-a0-201603
x86_64 acpi-redef
x86_64 allyesdebian
x86_64 nfsroot
blackfin BF526-EZBRD_defconfig
blackfin BF533-EZKIT_defconfig
blackfin BF561-EZKIT-SMP_defconfig
blackfin TCM-BF537_defconfig
cris etrax-100lx_v2_defconfig
sh allnoconfig
sh rsk7269_defconfig
sh sh7785lcr_32bit_defconfig
sh titan_defconfig
arm allnoconfig
arm at91_dt_defconfig
arm at_hdmac
arm ep93xx
arm imx_v6_v7_defconfig
arm iop-adma
arm marzen_defconfig
arm prima2_defconfig
arm sa1100
arm samsung
arm sh
arm spear13xx_defconfig
powerpc allnoconfig
powerpc defconfig
powerpc ppc64_defconfig
m32r m32104ut_defconfig
m32r mappi3.smp_defconfig
m32r opsput_defconfig
m32r usrv_defconfig
xtensa common_defconfig
xtensa iss_defconfig
alpha defconfig
parisc allnoconfig
parisc b180_defconfig
parisc c3000_defconfig
parisc defconfig
avr32 hammerhead_defconfig
m32r m32700ut.up_defconfig
mips bcm47xx_defconfig
mips capcella_defconfig
powerpc bluestone_defconfig
i386 alldefconfig
i386 allnoconfig
i386 defconfig
m68k m5475evb_defconfig
m68k multi_defconfig
m68k sun3_defconfig
i386 randconfig-s0-201603
i386 randconfig-s1-201603
x86_64 randconfig-s0-01191831
x86_64 randconfig-s1-01191831
x86_64 randconfig-s2-01191831
x86_64 allmodconfig
x86_64 randconfig-s3-01191831
x86_64 randconfig-s4-01191831
x86_64 randconfig-s5-01191831
avr32 atngw100_defconfig
avr32 atstk1006_defconfig
frv defconfig
mn10300 asb2364_defconfig
openrisc or1ksim_defconfig
tile tilegx_defconfig
um i386_defconfig
um x86_64_defconfig
m68k alldefconfig
mips db1xxx_defconfig
mips malta_qemu_32r6_defconfig
sh landisk_defconfig
mips allnoconfig
mips fuloong2e_defconfig
mips jz4740
mips txx9
x86_64 randconfig-i0-201603
i386 randconfig-b0-01191831
sparc defconfig
sparc64 allnoconfig
sparc64 defconfig
microblaze mmu_defconfig
microblaze nommu_defconfig
i386 randconfig-i0-201603
i386 randconfig-i1-201603
i386 allyesconfig
x86_64 randconfig-b0-01191744
i386 tinyconfig
i386 randconfig-n0-201603
ia64 alldefconfig
ia64 allnoconfig
ia64 defconfig
x86_64 rhel
ia64 tiger_defconfig
x86_64 randconfig-x000-201603
x86_64 randconfig-x001-201603
x86_64 randconfig-x002-201603
x86_64 randconfig-x003-201603
x86_64 randconfig-x004-201603
x86_64 randconfig-x005-201603
x86_64 randconfig-x006-201603
x86_64 randconfig-x007-201603
x86_64 randconfig-x008-201603
x86_64 randconfig-x009-201603
i386 randconfig-r0-201603
i386 allmodconfig
m68k sun3x_defconfig
mips mips_paravirt_defconfig
powerpc ppa8548_defconfig
i386 randconfig-x000-01181631
i386 randconfig-x001-01181631
i386 randconfig-x002-01181631
i386 randconfig-x003-01181631
i386 randconfig-x004-01181631
i386 randconfig-x005-01181631
i386 randconfig-x006-01181631
i386 randconfig-x007-01181631
i386 randconfig-x008-01181631
i386 randconfig-x009-01181631
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 41+ messages in thread* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-19 11:27 ` kbuild test robot 0 siblings, 0 replies; 41+ messages in thread From: kbuild test robot @ 2016-01-19 11:27 UTC (permalink / raw) Cc: linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Arnd Bergmann, James Hogan, Heinrich Schuchardt, linux-kernel https://github.com/0day-ci/linux James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642 d979f99e9cc14e2667e9b6e268db695977e4197a kbuild: Remove stale asm-generic wrappers arch/x86/include/asm/unistd.h:15:29: fatal error: asm/unistd_32.h: No such file or directory arch/x86/kernel/asm-offsets_32.c:12:29: fatal error: asm/syscalls_32.h: No such file or directory arch/x86/kernel/asm-offsets_64.c:15:29: fatal error: asm/syscalls_64.h: No such file or directory /bin/sh: line 0: [: -ge: unary operator expected Error ids grouped by kconfigs: recent_errors ├── i386-alldefconfig │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-allmodconfig │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-allyesconfig │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-defconfig │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-randconfig-a0-201603 │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory ├── i386-randconfig-b0-01191831 │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory ├── i386-randconfig-i0-201603 │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-randconfig-i1-201603 │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-randconfig-r0-201603 │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory ├── i386-randconfig-s1-201603 │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory ├── i386-randconfig-x002-01181631 │ └── bin-sh:line::ge:unary-operator-expected ├── i386-tinyconfig │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory └── x86_64-randconfig-s3-01191831 └── arch-x86-kernel-asm-offsets_64.c:fatal-error:asm-syscalls_64.h:No-such-file-or-directory elapsed time: 50m configs tested: 118 i386 randconfig-a0-201603 x86_64 acpi-redef x86_64 allyesdebian x86_64 nfsroot blackfin BF526-EZBRD_defconfig blackfin BF533-EZKIT_defconfig blackfin BF561-EZKIT-SMP_defconfig blackfin TCM-BF537_defconfig cris etrax-100lx_v2_defconfig sh allnoconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig sh titan_defconfig arm allnoconfig arm at91_dt_defconfig arm at_hdmac arm ep93xx arm imx_v6_v7_defconfig arm iop-adma arm marzen_defconfig arm prima2_defconfig arm sa1100 arm samsung arm sh arm spear13xx_defconfig powerpc allnoconfig powerpc defconfig powerpc ppc64_defconfig m32r m32104ut_defconfig m32r mappi3.smp_defconfig m32r opsput_defconfig m32r usrv_defconfig xtensa common_defconfig xtensa iss_defconfig alpha defconfig parisc allnoconfig parisc b180_defconfig parisc c3000_defconfig parisc defconfig avr32 hammerhead_defconfig m32r m32700ut.up_defconfig mips bcm47xx_defconfig mips capcella_defconfig powerpc bluestone_defconfig i386 alldefconfig i386 allnoconfig i386 defconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig i386 randconfig-s0-201603 i386 randconfig-s1-201603 x86_64 randconfig-s0-01191831 x86_64 randconfig-s1-01191831 x86_64 randconfig-s2-01191831 x86_64 allmodconfig x86_64 randconfig-s3-01191831 x86_64 randconfig-s4-01191831 x86_64 randconfig-s5-01191831 avr32 atngw100_defconfig avr32 atstk1006_defconfig frv defconfig mn10300 asb2364_defconfig openrisc or1ksim_defconfig tile tilegx_defconfig um i386_defconfig um x86_64_defconfig m68k alldefconfig mips db1xxx_defconfig mips malta_qemu_32r6_defconfig sh landisk_defconfig mips allnoconfig mips fuloong2e_defconfig mips jz4740 mips txx9 x86_64 randconfig-i0-201603 i386 randconfig-b0-01191831 sparc defconfig sparc64 allnoconfig sparc64 defconfig microblaze mmu_defconfig microblaze nommu_defconfig i386 randconfig-i0-201603 i386 randconfig-i1-201603 i386 allyesconfig x86_64 randconfig-b0-01191744 i386 tinyconfig i386 randconfig-n0-201603 ia64 alldefconfig ia64 allnoconfig ia64 defconfig x86_64 rhel ia64 tiger_defconfig x86_64 randconfig-x000-201603 x86_64 randconfig-x001-201603 x86_64 randconfig-x002-201603 x86_64 randconfig-x003-201603 x86_64 randconfig-x004-201603 x86_64 randconfig-x005-201603 x86_64 randconfig-x006-201603 x86_64 randconfig-x007-201603 x86_64 randconfig-x008-201603 x86_64 randconfig-x009-201603 i386 randconfig-r0-201603 i386 allmodconfig m68k sun3x_defconfig mips mips_paravirt_defconfig powerpc ppa8548_defconfig i386 randconfig-x000-01181631 i386 randconfig-x001-01181631 i386 randconfig-x002-01181631 i386 randconfig-x003-01181631 i386 randconfig-x004-01181631 i386 randconfig-x005-01181631 i386 randconfig-x006-01181631 i386 randconfig-x007-01181631 i386 randconfig-x008-01181631 i386 randconfig-x009-01181631 Thanks, Fengguang ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-19 11:27 ` kbuild test robot 0 siblings, 0 replies; 41+ messages in thread From: kbuild test robot @ 2016-01-19 11:27 UTC (permalink / raw) To: James Hogan Cc: linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Arnd Bergmann, Heinrich Schuchardt, linux-kernel https://github.com/0day-ci/linux James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642 d979f99e9cc14e2667e9b6e268db695977e4197a kbuild: Remove stale asm-generic wrappers arch/x86/include/asm/unistd.h:15:29: fatal error: asm/unistd_32.h: No such file or directory arch/x86/kernel/asm-offsets_32.c:12:29: fatal error: asm/syscalls_32.h: No such file or directory arch/x86/kernel/asm-offsets_64.c:15:29: fatal error: asm/syscalls_64.h: No such file or directory /bin/sh: line 0: [: -ge: unary operator expected Error ids grouped by kconfigs: recent_errors ├── i386-alldefconfig │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-allmodconfig │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-allyesconfig │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-defconfig │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-randconfig-a0-201603 │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory ├── i386-randconfig-b0-01191831 │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory ├── i386-randconfig-i0-201603 │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-randconfig-i1-201603 │ └── arch-x86-include-asm-unistd.h:fatal-error:asm-unistd_32.h:No-such-file-or-directory ├── i386-randconfig-r0-201603 │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory ├── i386-randconfig-s1-201603 │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory ├── i386-randconfig-x002-01181631 │ └── bin-sh:line::ge:unary-operator-expected ├── i386-tinyconfig │ └── arch-x86-kernel-asm-offsets_32.c:fatal-error:asm-syscalls_32.h:No-such-file-or-directory └── x86_64-randconfig-s3-01191831 └── arch-x86-kernel-asm-offsets_64.c:fatal-error:asm-syscalls_64.h:No-such-file-or-directory elapsed time: 50m configs tested: 118 i386 randconfig-a0-201603 x86_64 acpi-redef x86_64 allyesdebian x86_64 nfsroot blackfin BF526-EZBRD_defconfig blackfin BF533-EZKIT_defconfig blackfin BF561-EZKIT-SMP_defconfig blackfin TCM-BF537_defconfig cris etrax-100lx_v2_defconfig sh allnoconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig sh titan_defconfig arm allnoconfig arm at91_dt_defconfig arm at_hdmac arm ep93xx arm imx_v6_v7_defconfig arm iop-adma arm marzen_defconfig arm prima2_defconfig arm sa1100 arm samsung arm sh arm spear13xx_defconfig powerpc allnoconfig powerpc defconfig powerpc ppc64_defconfig m32r m32104ut_defconfig m32r mappi3.smp_defconfig m32r opsput_defconfig m32r usrv_defconfig xtensa common_defconfig xtensa iss_defconfig alpha defconfig parisc allnoconfig parisc b180_defconfig parisc c3000_defconfig parisc defconfig avr32 hammerhead_defconfig m32r m32700ut.up_defconfig mips bcm47xx_defconfig mips capcella_defconfig powerpc bluestone_defconfig i386 alldefconfig i386 allnoconfig i386 defconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig i386 randconfig-s0-201603 i386 randconfig-s1-201603 x86_64 randconfig-s0-01191831 x86_64 randconfig-s1-01191831 x86_64 randconfig-s2-01191831 x86_64 allmodconfig x86_64 randconfig-s3-01191831 x86_64 randconfig-s4-01191831 x86_64 randconfig-s5-01191831 avr32 atngw100_defconfig avr32 atstk1006_defconfig frv defconfig mn10300 asb2364_defconfig openrisc or1ksim_defconfig tile tilegx_defconfig um i386_defconfig um x86_64_defconfig m68k alldefconfig mips db1xxx_defconfig mips malta_qemu_32r6_defconfig sh landisk_defconfig mips allnoconfig mips fuloong2e_defconfig mips jz4740 mips txx9 x86_64 randconfig-i0-201603 i386 randconfig-b0-01191831 sparc defconfig sparc64 allnoconfig sparc64 defconfig microblaze mmu_defconfig microblaze nommu_defconfig i386 randconfig-i0-201603 i386 randconfig-i1-201603 i386 allyesconfig x86_64 randconfig-b0-01191744 i386 tinyconfig i386 randconfig-n0-201603 ia64 alldefconfig ia64 allnoconfig ia64 defconfig x86_64 rhel ia64 tiger_defconfig x86_64 randconfig-x000-201603 x86_64 randconfig-x001-201603 x86_64 randconfig-x002-201603 x86_64 randconfig-x003-201603 x86_64 randconfig-x004-201603 x86_64 randconfig-x005-201603 x86_64 randconfig-x006-201603 x86_64 randconfig-x007-201603 x86_64 randconfig-x008-201603 x86_64 randconfig-x009-201603 i386 randconfig-r0-201603 i386 allmodconfig m68k sun3x_defconfig mips mips_paravirt_defconfig powerpc ppa8548_defconfig i386 randconfig-x000-01181631 i386 randconfig-x001-01181631 i386 randconfig-x002-01181631 i386 randconfig-x003-01181631 i386 randconfig-x004-01181631 i386 randconfig-x005-01181631 i386 randconfig-x006-01181631 i386 randconfig-x007-01181631 i386 randconfig-x008-01181631 i386 randconfig-x009-01181631 Thanks, Fengguang ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-19 11:27 ` kbuild test robot (?) (?) @ 2016-01-19 14:26 ` Arnd Bergmann 2016-01-26 5:30 ` Fengguang Wu -1 siblings, 1 reply; 41+ messages in thread From: Arnd Bergmann @ 2016-01-19 14:26 UTC (permalink / raw) To: kbuild test robot Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek On Tuesday 19 January 2016 19:27:55 kbuild test robot wrote: > arm allnoconfig > arm at91_dt_defconfig > arm at_hdmac > arm ep93xx > arm imx_v6_v7_defconfig > arm iop-adma > arm marzen_defconfig > arm prima2_defconfig > arm sa1100 > arm samsung > arm sh > arm spear13xx_defconfig > Hi Fengguang, Sorry for hijacking this thread. I have never seen the list of arm defconfigs you are building before, and it seems to be a surprising selection, as a number of platforms (ep93xx, iop, sa1100, spear13xx) are rather obscure, but the configurations that I tend to use most (multi_v7_defconfig, multi_v5_defconfig, allmodconfig) are not included. Do you always build the same set of configurations, or is this a different each time? Can you always include the three I mentioned? Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-19 14:26 ` Arnd Bergmann @ 2016-01-26 5:30 ` Fengguang Wu 2016-01-26 5:35 ` Fengguang Wu 0 siblings, 1 reply; 41+ messages in thread From: Fengguang Wu @ 2016-01-26 5:30 UTC (permalink / raw) To: Arnd Bergmann Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek Hi Arnd, Sorry for the delay! I lost access to my email account for some week. On Tue, Jan 19, 2016 at 03:26:16PM +0100, Arnd Bergmann wrote: > On Tuesday 19 January 2016 19:27:55 kbuild test robot wrote: > > arm allnoconfig > > arm at91_dt_defconfig > > arm at_hdmac > > arm ep93xx > > arm imx_v6_v7_defconfig > > arm iop-adma > > arm marzen_defconfig > > arm prima2_defconfig > > arm sa1100 > > arm samsung > > arm sh > > arm spear13xx_defconfig > > > > Hi Fengguang, > > Sorry for hijacking this thread. I have never seen the list of arm defconfigs > you are building before, and it seems to be a surprising selection, as a number > of platforms (ep93xx, iop, sa1100, spear13xx) are rather obscure, but the > configurations that I tend to use most (multi_v7_defconfig, multi_v5_defconfig, > allmodconfig) are not included. > > Do you always build the same set of configurations, or is this a different > each time? There are a fixed set of config files for fast build tests (which I selected randomly, feel free to ask me to change the list to more reasonable ones): arm-allnoconfig arm-at91_dt_defconfig arm-at_hdmac arm-ep93xx arm-imx_v6_v7_defconfig arm-iop-adma arm-marzen_defconfig arm-prima2_defconfig arm-sa1100 arm-samsung arm-sh arm-spear13xx_defconfig The more configs included in arch/*/configs will be tested in a more slow pace. So not included in this email does not mean they are not tested -- they are likely not quick enough to catch this notification email. > Can you always include the three I mentioned? Sure. Thanks, Fengguang ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-26 5:30 ` Fengguang Wu @ 2016-01-26 5:35 ` Fengguang Wu 2016-01-26 16:27 ` Arnd Bergmann 0 siblings, 1 reply; 41+ messages in thread From: Fengguang Wu @ 2016-01-26 5:35 UTC (permalink / raw) To: Arnd Bergmann Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek On Tue, Jan 26, 2016 at 01:30:50PM +0800, Fengguang Wu wrote: > Hi Arnd, > > Sorry for the delay! I lost access to my email account for some week. > > On Tue, Jan 19, 2016 at 03:26:16PM +0100, Arnd Bergmann wrote: > > On Tuesday 19 January 2016 19:27:55 kbuild test robot wrote: > > > arm allnoconfig > > > arm at91_dt_defconfig > > > arm at_hdmac > > > arm ep93xx > > > arm imx_v6_v7_defconfig > > > arm iop-adma > > > arm marzen_defconfig > > > arm prima2_defconfig > > > arm sa1100 > > > arm samsung > > > arm sh > > > arm spear13xx_defconfig > > > > > > > Hi Fengguang, > > > > Sorry for hijacking this thread. I have never seen the list of arm defconfigs > > you are building before, and it seems to be a surprising selection, as a number > > of platforms (ep93xx, iop, sa1100, spear13xx) are rather obscure, but the > > configurations that I tend to use most (multi_v7_defconfig, multi_v5_defconfig, > > allmodconfig) are not included. > > > > Do you always build the same set of configurations, or is this a different > > each time? > > There are a fixed set of config files for fast build tests (which I > selected randomly, feel free to ask me to change the list to more > reasonable ones): > > arm-allnoconfig > arm-at91_dt_defconfig > arm-at_hdmac > arm-ep93xx > arm-imx_v6_v7_defconfig > arm-iop-adma > arm-marzen_defconfig > arm-prima2_defconfig > arm-sa1100 > arm-samsung > arm-sh > arm-spear13xx_defconfig And there is another set of best effort configs whose priority is in-between the above list and the arch/*/configs/* ones. arm-arm5 arm-arm67 arm-mmp arm-omap2plus_defconfig arm-s3c2410_defconfig arm-tegra_defconfig Thanks, Fengguang > The more configs included in arch/*/configs will be tested in a more > slow pace. So not included in this email does not mean they are not > tested -- they are likely not quick enough to catch this notification > email. > > > Can you always include the three I mentioned? > > Sure. > > Thanks, > Fengguang ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-26 5:35 ` Fengguang Wu @ 2016-01-26 16:27 ` Arnd Bergmann 2016-01-27 8:37 ` Fengguang Wu 0 siblings, 1 reply; 41+ messages in thread From: Arnd Bergmann @ 2016-01-26 16:27 UTC (permalink / raw) To: Fengguang Wu Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek On Tuesday 26 January 2016 13:35:04 Fengguang Wu wrote: > > There are a fixed set of config files for fast build tests (which I > > selected randomly, feel free to ask me to change the list to more > > reasonable ones): > > > > arm-allnoconfig > > arm-at91_dt_defconfig > > arm-at_hdmac > > arm-ep93xx > > arm-imx_v6_v7_defconfig > > arm-iop-adma > > arm-marzen_defconfig > > arm-prima2_defconfig > > arm-sa1100 > > arm-samsung > > arm-sh > > arm-spear13xx_defconfig > > And there is another set of best effort configs whose priority is > in-between the above list and the arch/*/configs/* ones. > > arm-arm5 > arm-arm67 > arm-mmp > arm-omap2plus_defconfig > arm-s3c2410_defconfig > arm-tegra_defconfig > I think we want at least one ARMv7-M NOMMU target in the list, I'd pick efm32_defconfig as it has the least overlap with the drivers in the other configs. I don't know what arm-sh is, but I assume it's a superset of marzen, so you can probably drop marzen or move it down to the low-prio set. Similarly, the at_hdmac is likely a subset of at91_dt_defconfig and could be dropped. prima2, ep93xx and spear13xx, mmp and s3c2410 are all slow-moving platforms, I would not expect to see much results from running those compared to the more active platforms. The platforms with the most changes these days are omap2plus, sunxi, shmobile, and exynos (samsung), followed by some that are widely used but not changed as much including tegra, imx_v6_v7, mvebu_v7, and qcom (previously msm). iop and sa1100 are rather old and won't change much, but it can be good to keep them in there because they are for older CPU architectures and behave a little different from the modern ones. It might be better to replace iop with ixp4xx, as this one is the only big-endian defconfig build we have, and that sometimes catches build-time bugs. Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-26 16:27 ` Arnd Bergmann @ 2016-01-27 8:37 ` Fengguang Wu 2016-01-27 9:11 ` Arnd Bergmann 0 siblings, 1 reply; 41+ messages in thread From: Fengguang Wu @ 2016-01-27 8:37 UTC (permalink / raw) To: Arnd Bergmann Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek Hi Arnd, Thank you for the tips! I've updated the lists accordingly. 1st priority ============ arm-allmodconfig arm-allnoconfig arm-at91_dt_defconfig arm-efm32_defconfig arm-exynos_defconfig arm-multi_v7_defconfig arm-multi_v8_defconfig arm-shmobile_defconfig arm-sunxi_defconfig 2nd priority ============ arm-arm5 arm-arm67 arm-imx_v6_v7_defconfig arm-ixp4xx_defconfig arm-mvebu_v7_defconfig arm-omap2plus_defconfig arm-sa1100 arm-samsung arm-sh arm-tegra_defconfig 3nd priority ============ arch/*/configs/* Thanks, Fengguang On Tue, Jan 26, 2016 at 05:27:46PM +0100, Arnd Bergmann wrote: > On Tuesday 26 January 2016 13:35:04 Fengguang Wu wrote: > > > There are a fixed set of config files for fast build tests (which I > > > selected randomly, feel free to ask me to change the list to more > > > reasonable ones): > > > > > > arm-allnoconfig > > > arm-at91_dt_defconfig > > > arm-at_hdmac > > > arm-ep93xx > > > arm-imx_v6_v7_defconfig > > > arm-iop-adma > > > arm-marzen_defconfig > > > arm-prima2_defconfig > > > arm-sa1100 > > > arm-samsung > > > arm-sh > > > arm-spear13xx_defconfig > > > > And there is another set of best effort configs whose priority is > > in-between the above list and the arch/*/configs/* ones. > > > > arm-arm5 > > arm-arm67 > > arm-mmp > > arm-omap2plus_defconfig > > arm-s3c2410_defconfig > > arm-tegra_defconfig > > > > I think we want at least one ARMv7-M NOMMU target in the list, > I'd pick efm32_defconfig as it has the least overlap with the > drivers in the other configs. > > I don't know what arm-sh is, but I assume it's a superset of > marzen, so you can probably drop marzen or move it down to the > low-prio set. Similarly, the at_hdmac is likely a subset of > at91_dt_defconfig and could be dropped. > > prima2, ep93xx and spear13xx, mmp and s3c2410 are all > slow-moving platforms, I would not expect to see much > results from running those compared to the more active > platforms. > > The platforms with the most changes these days are omap2plus, > sunxi, shmobile, and exynos (samsung), followed by some > that are widely used but not changed as much including > tegra, imx_v6_v7, mvebu_v7, and qcom (previously msm). > > iop and sa1100 are rather old and won't change much, but it > can be good to keep them in there because they are for older > CPU architectures and behave a little different from the > modern ones. It might be better to replace iop with ixp4xx, > as this one is the only big-endian defconfig build we have, > and that sometimes catches build-time bugs. > > Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-27 8:37 ` Fengguang Wu @ 2016-01-27 9:11 ` Arnd Bergmann 2016-01-27 9:30 ` Fengguang Wu 0 siblings, 1 reply; 41+ messages in thread From: Arnd Bergmann @ 2016-01-27 9:11 UTC (permalink / raw) To: Fengguang Wu Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek On Wednesday 27 January 2016 16:37:45 Fengguang Wu wrote: > > Thank you for the tips! I've updated the lists accordingly. > > 1st priority > ============ > > arm-allmodconfig > arm-allnoconfig > arm-at91_dt_defconfig > arm-efm32_defconfig > arm-exynos_defconfig > arm-multi_v7_defconfig > arm-multi_v8_defconfig > arm-shmobile_defconfig > arm-sunxi_defconfig > > 2nd priority > ============ > > arm-arm5 > arm-arm67 > arm-imx_v6_v7_defconfig > arm-ixp4xx_defconfig > arm-mvebu_v7_defconfig > arm-omap2plus_defconfig > arm-sa1100 > arm-samsung > arm-sh > arm-tegra_defconfig > > 3nd priority > ============ > > arch/*/configs/* Looks good, I'm just unsure about "multi_v8_defconfig", this does not exist. Do you mean multi_v5_defconfig? I also wonder if you include 'randconfig' builds for some architectures. I have patches for all remaining errors and warnings that I see with ARM randconfig builds today. Not all of them are merged yet, but I could probably come up with a file to be used as input to KCONFIG_ALLCONFIG to eliminate the known-broken configurations, if you are interested. Thanks! Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-27 9:11 ` Arnd Bergmann @ 2016-01-27 9:30 ` Fengguang Wu 2016-01-27 9:44 ` Arnd Bergmann 0 siblings, 1 reply; 41+ messages in thread From: Fengguang Wu @ 2016-01-27 9:30 UTC (permalink / raw) To: Arnd Bergmann Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek On Wed, Jan 27, 2016 at 10:11:47AM +0100, Arnd Bergmann wrote: > On Wednesday 27 January 2016 16:37:45 Fengguang Wu wrote: > > > > Thank you for the tips! I've updated the lists accordingly. > > > > 1st priority > > ============ > > > > arm-allmodconfig > > arm-allnoconfig > > arm-at91_dt_defconfig > > arm-efm32_defconfig > > arm-exynos_defconfig > > arm-multi_v7_defconfig > > arm-multi_v8_defconfig > > arm-shmobile_defconfig > > arm-sunxi_defconfig > > > > 2nd priority > > ============ > > > > arm-arm5 > > arm-arm67 > > arm-imx_v6_v7_defconfig > > arm-ixp4xx_defconfig > > arm-mvebu_v7_defconfig > > arm-omap2plus_defconfig > > arm-sa1100 > > arm-samsung > > arm-sh > > arm-tegra_defconfig > > > > 3nd priority > > ============ > > > > arch/*/configs/* > > Looks good, I'm just unsure about "multi_v8_defconfig", this does not > exist. Do you mean multi_v5_defconfig? Ah yes, multi_v8_defconfig does not exist actually. > I also wonder if you include 'randconfig' builds for some architectures. > I have patches for all remaining errors and warnings that I see with > ARM randconfig builds today. Not all of them are merged yet, but I could > probably come up with a file to be used as input to KCONFIG_ALLCONFIG > to eliminate the known-broken configurations, if you are interested. If the are mostly ready for upstream, it may be easier to wait until upstream randconfig works just fine for ARM. Thanks, Fengguang ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-27 9:30 ` Fengguang Wu @ 2016-01-27 9:44 ` Arnd Bergmann 0 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-27 9:44 UTC (permalink / raw) To: Fengguang Wu Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek, linux-arm-kernel On Wednesday 27 January 2016 17:30:18 Fengguang Wu wrote: > > Looks good, I'm just unsure about "multi_v8_defconfig", this does not > > exist. Do you mean multi_v5_defconfig? > Ah yes, multi_v8_defconfig does not exist actually. Ok, can you include multi_v5_defconfig than? I see you have one named "arm-arm5", which may be the same. > > I also wonder if you include 'randconfig' builds for some architectures. > > I have patches for all remaining errors and warnings that I see with > > ARM randconfig builds today. Not all of them are merged yet, but I could > > probably come up with a file to be used as input to KCONFIG_ALLCONFIG > > to eliminate the known-broken configurations, if you are interested. > > If the are mostly ready for upstream, it may be easier to wait until > upstream randconfig works just fine for ARM. I have around 130 patches for warnings that I'm submitting at the moment, but there are a couple of really tricky ones that I don't currently have a good plan for: - in some configurations, you end up without any boards selected, hitting an #error in the final link - ARMv3 support in gcc is rather broken and causes internal compiler errors among other things - the old ELF format (OABI) doesn't work in some cases - GCOV_PROFILE_ALL causes problems that need to be debugged - XIP_KERNEL sometimes causes kallsyms to fail - not all platforms implement the complete clk API, if they don't use CONFIG_COMMON_CLK (I have patch for that we can probably merge) - CONFIG_PHYS_OFFSET needs to be entered manually to be a number in 'make config' - same for DEBUG_LL Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-27 9:44 ` Arnd Bergmann 0 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-27 9:44 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 27 January 2016 17:30:18 Fengguang Wu wrote: > > Looks good, I'm just unsure about "multi_v8_defconfig", this does not > > exist. Do you mean multi_v5_defconfig? > Ah yes, multi_v8_defconfig does not exist actually. Ok, can you include multi_v5_defconfig than? I see you have one named "arm-arm5", which may be the same. > > I also wonder if you include 'randconfig' builds for some architectures. > > I have patches for all remaining errors and warnings that I see with > > ARM randconfig builds today. Not all of them are merged yet, but I could > > probably come up with a file to be used as input to KCONFIG_ALLCONFIG > > to eliminate the known-broken configurations, if you are interested. > > If the are mostly ready for upstream, it may be easier to wait until > upstream randconfig works just fine for ARM. I have around 130 patches for warnings that I'm submitting at the moment, but there are a couple of really tricky ones that I don't currently have a good plan for: - in some configurations, you end up without any boards selected, hitting an #error in the final link - ARMv3 support in gcc is rather broken and causes internal compiler errors among other things - the old ELF format (OABI) doesn't work in some cases - GCOV_PROFILE_ALL causes problems that need to be debugged - XIP_KERNEL sometimes causes kallsyms to fail - not all platforms implement the complete clk API, if they don't use CONFIG_COMMON_CLK (I have patch for that we can probably merge) - CONFIG_PHYS_OFFSET needs to be entered manually to be a number in 'make config' - same for DEBUG_LL Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-27 9:44 ` Arnd Bergmann @ 2016-01-28 3:14 ` Fengguang Wu -1 siblings, 0 replies; 41+ messages in thread From: Fengguang Wu @ 2016-01-28 3:14 UTC (permalink / raw) To: Arnd Bergmann Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek, linux-arm-kernel On Wed, Jan 27, 2016 at 10:44:01AM +0100, Arnd Bergmann wrote: > On Wednesday 27 January 2016 17:30:18 Fengguang Wu wrote: > > > > Looks good, I'm just unsure about "multi_v8_defconfig", this does not > > > exist. Do you mean multi_v5_defconfig? > > > Ah yes, multi_v8_defconfig does not exist actually. > > Ok, can you include multi_v5_defconfig than? OK, done. > I see you have one named "arm-arm5", which may be the same. Yes, looks so -- it's provided by someone else long time ago. > > > I also wonder if you include 'randconfig' builds for some architectures. > > > I have patches for all remaining errors and warnings that I see with > > > ARM randconfig builds today. Not all of them are merged yet, but I could > > > probably come up with a file to be used as input to KCONFIG_ALLCONFIG > > > to eliminate the known-broken configurations, if you are interested. > > > > If the are mostly ready for upstream, it may be easier to wait until > > upstream randconfig works just fine for ARM. > > I have around 130 patches for warnings that I'm submitting at the moment, but > there are a couple of really tricky ones that I don't currently have > a good plan for: > > - in some configurations, you end up without any boards selected, hitting > an #error in the final link > - ARMv3 support in gcc is rather broken and causes internal compiler errors > among other things > - the old ELF format (OABI) doesn't work in some cases > - GCOV_PROFILE_ALL causes problems that need to be debugged > - XIP_KERNEL sometimes causes kallsyms to fail > - not all platforms implement the complete clk API, if they don't > use CONFIG_COMMON_CLK (I have patch for that we can probably merge) The robot may explicitly enable/disable some CONFIG_* after randconfig to workaround known problems. > - CONFIG_PHYS_OFFSET needs to be entered manually to be a number > in 'make config' That's a problem for auto tests. > - same for DEBUG_LL Thanks, Fengguang ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-28 3:14 ` Fengguang Wu 0 siblings, 0 replies; 41+ messages in thread From: Fengguang Wu @ 2016-01-28 3:14 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jan 27, 2016 at 10:44:01AM +0100, Arnd Bergmann wrote: > On Wednesday 27 January 2016 17:30:18 Fengguang Wu wrote: > > > > Looks good, I'm just unsure about "multi_v8_defconfig", this does not > > > exist. Do you mean multi_v5_defconfig? > > > Ah yes, multi_v8_defconfig does not exist actually. > > Ok, can you include multi_v5_defconfig than? OK, done. > I see you have one named "arm-arm5", which may be the same. Yes, looks so -- it's provided by someone else long time ago. > > > I also wonder if you include 'randconfig' builds for some architectures. > > > I have patches for all remaining errors and warnings that I see with > > > ARM randconfig builds today. Not all of them are merged yet, but I could > > > probably come up with a file to be used as input to KCONFIG_ALLCONFIG > > > to eliminate the known-broken configurations, if you are interested. > > > > If the are mostly ready for upstream, it may be easier to wait until > > upstream randconfig works just fine for ARM. > > I have around 130 patches for warnings that I'm submitting at the moment, but > there are a couple of really tricky ones that I don't currently have > a good plan for: > > - in some configurations, you end up without any boards selected, hitting > an #error in the final link > - ARMv3 support in gcc is rather broken and causes internal compiler errors > among other things > - the old ELF format (OABI) doesn't work in some cases > - GCOV_PROFILE_ALL causes problems that need to be debugged > - XIP_KERNEL sometimes causes kallsyms to fail > - not all platforms implement the complete clk API, if they don't > use CONFIG_COMMON_CLK (I have patch for that we can probably merge) The robot may explicitly enable/disable some CONFIG_* after randconfig to workaround known problems. > - CONFIG_PHYS_OFFSET needs to be entered manually to be a number > in 'make config' That's a problem for auto tests. > - same for DEBUG_LL Thanks, Fengguang ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-28 3:14 ` Fengguang Wu @ 2016-01-28 12:07 ` Arnd Bergmann -1 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-28 12:07 UTC (permalink / raw) To: Fengguang Wu Cc: James Hogan, linux-mips, linux-arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek, linux-arm-kernel, rmk On Thursday 28 January 2016 11:14:35 Fengguang Wu wrote: > > - CONFIG_PHYS_OFFSET needs to be entered manually to be a number > > in 'make config' > > That's a problem for auto tests. Ok, I'll try to revisit this one. Maybe I can turn it into a 'default 0xffffffff' with a compile-time warning, or make 'default 0' the fallback when it's not specified otherwise. Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-28 12:07 ` Arnd Bergmann 0 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-28 12:07 UTC (permalink / raw) To: linux-arm-kernel On Thursday 28 January 2016 11:14:35 Fengguang Wu wrote: > > - CONFIG_PHYS_OFFSET needs to be entered manually to be a number > > in 'make config' > > That's a problem for auto tests. Ok, I'll try to revisit this one. Maybe I can turn it into a 'default 0xffffffff' with a compile-time warning, or make 'default 0' the fallback when it's not specified otherwise. Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-28 3:14 ` Fengguang Wu @ 2016-01-28 17:42 ` Russell King - ARM Linux -1 siblings, 0 replies; 41+ messages in thread From: Russell King - ARM Linux @ 2016-01-28 17:42 UTC (permalink / raw) To: Fengguang Wu Cc: Arnd Bergmann, linux-arch, linux-mips, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel On Thu, Jan 28, 2016 at 11:14:35AM +0800, Fengguang Wu wrote: > On Wed, Jan 27, 2016 at 10:44:01AM +0100, Arnd Bergmann wrote: > > - CONFIG_PHYS_OFFSET needs to be entered manually to be a number > > in 'make config' > > That's a problem for auto tests. I'm really against the idea of providing some kind of "default" to it. Not providing a default means that people _have_ to do some research for their particular system in order to provide a value, and they're more likely to get the right value. Providing a default will lead to the assumption that the value is okay, and then we'll end up with people complaining that their kernel doesn't boot, and is totally silent. The only default I'd accept is one based on the rest of the config - in other words, re-introducing all the physical address of RAM that we used to have in the mach/memory.h files... There's other ways around these kinds of things, the Kconfig system does allow a Kconfig fragment which can be used to pre-set some configuration options to particular values - and so which can be used to set CONFIG_PHYS_OFFSET prior to an allrandconfig or similar. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-28 17:42 ` Russell King - ARM Linux 0 siblings, 0 replies; 41+ messages in thread From: Russell King - ARM Linux @ 2016-01-28 17:42 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 28, 2016 at 11:14:35AM +0800, Fengguang Wu wrote: > On Wed, Jan 27, 2016 at 10:44:01AM +0100, Arnd Bergmann wrote: > > - CONFIG_PHYS_OFFSET needs to be entered manually to be a number > > in 'make config' > > That's a problem for auto tests. I'm really against the idea of providing some kind of "default" to it. Not providing a default means that people _have_ to do some research for their particular system in order to provide a value, and they're more likely to get the right value. Providing a default will lead to the assumption that the value is okay, and then we'll end up with people complaining that their kernel doesn't boot, and is totally silent. The only default I'd accept is one based on the rest of the config - in other words, re-introducing all the physical address of RAM that we used to have in the mach/memory.h files... There's other ways around these kinds of things, the Kconfig system does allow a Kconfig fragment which can be used to pre-set some configuration options to particular values - and so which can be used to set CONFIG_PHYS_OFFSET prior to an allrandconfig or similar. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-28 17:42 ` Russell King - ARM Linux @ 2016-01-28 23:07 ` Arnd Bergmann -1 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-28 23:07 UTC (permalink / raw) To: Russell King - ARM Linux, Fengguang Wu, linux-arch, linux-mips, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel On Thursday 28 January 2016 17:42:41 you wrote: > On Thu, Jan 28, 2016 at 11:14:35AM +0800, Fengguang Wu wrote: > > On Wed, Jan 27, 2016 at 10:44:01AM +0100, Arnd Bergmann wrote: > > > - CONFIG_PHYS_OFFSET needs to be entered manually to be a number > > > in 'make config' > > > > That's a problem for auto tests. > > I'm really against the idea of providing some kind of "default" to it. > Not providing a default means that people _have_ to do some research > for their particular system in order to provide a value, and they're > more likely to get the right value. Providing a default will lead to > the assumption that the value is okay, and then we'll end up with > people complaining that their kernel doesn't boot, and is totally > silent. > > The only default I'd accept is one based on the rest of the config - > in other words, re-introducing all the physical address of RAM that > we used to have in the mach/memory.h files... This doesn't sound too hard. I've picked the defaults out of the git history in the patch below. The only tricky part was davinci, which has two different addresses and requires a little rework to avoid circular dependencies. Most platforms these days hardcode ARCH_PATCH_PHS_VIRT anyway, so we only need to list the bunch of remaining ones. > There's other ways around these kinds of things, the Kconfig system > does allow a Kconfig fragment which can be used to pre-set some > configuration options to particular values - and so which can be used > to set CONFIG_PHYS_OFFSET prior to an allrandconfig or similar. I don't know what Fenguang's problem was with that approach, but at least at the moment he's using a fixup after running randconfig. In my own tests, I'm doing yet another approach by marking a handful of symbols as 'depends on BROKEN' in my testing patches, but clearly that does not work when building other people's trees. The other related issue is the DEBUG_UART_{VIRT,PHYS} setting, where there is no safe platform-specific default. I have two ideas for working around that, maybe one of them sounds ok to you: a) find a way to warn and/or disable DEBUG_LL when no address is set, rather than failing the build b) add 'default 0 if COMPILE_TEST' to make it harder to get this wrong by accident (hopefully nobody tries to run a COMPILE_TEST kernel). Also maybe add a #warning if DEBUG_UART_VIRT is outside of VMALLOC_START...PCI_IOBASE area, which would cover this case as well. Arnd diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2217ec9726c9..1d2b5e6cab14 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -273,15 +273,29 @@ config PHYS_OFFSET depends on !ARM_PATCH_PHYS_VIRT default DRAM_BASE if !MMU default 0x00000000 if ARCH_EBSA110 || \ + ARCH_DOVE || \ ARCH_FOOTBRIDGE || \ + (ARCH_GEMINI && GEMINI_MEM_SWAP) || \ ARCH_INTEGRATOR || \ + ARCH_IOP33X || \ ARCH_IOP13XX || \ + ARCH_IXP4XX || \ ARCH_KS8695 || \ - (ARCH_REALVIEW && !REALVIEW_HIGH_PHYS_OFFSET) - default 0x10000000 if ARCH_OMAP1 || ARCH_RPC + (ARCH_REALVIEW && !REALVIEW_HIGH_PHYS_OFFSET) || \ + ARCH_W90X900 + default 0x10000000 if (ARCH_GEMINI && !GEMINI_MEM_SWAP) || \ + ARCH_OMAP1 || \ + ARCH_RPC default 0x20000000 if ARCH_S5PV210 + default 0x30000000 if ARCH_S3C24XX default 0x70000000 if REALVIEW_HIGH_PHYS_OFFSET - default 0xc0000000 if ARCH_SA1100 + default 0x80000000 if (ARCH_DAVINCI_DMx && !ARCH_DAVINCI_DA8XX) || \ + ARCH_NETX || \ + ARCH_LPC32XX + default 0xa0000000 if ARCH_IOP32X || ARCH_PXA + default 0xc0000000 if (ARCH_DAVINCI_DA8XX && !ARCH_DAVINCI_DMx) || \ + ARCH_CLPS711X || \ + ARCH_SA1100 help Please provide the physical address corresponding to the location of main memory in your system. @@ -627,6 +641,7 @@ config ARCH_DAVINCI select ARCH_HAS_HOLES_MEMORYMODEL select ARCH_REQUIRE_GPIOLIB select CLKDEV_LOOKUP + select CPU_ARM926T select GENERIC_ALLOCATOR select GENERIC_CLOCKEVENTS select GENERIC_IRQ_CHIP diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig index 7a9f2b8c0a42..36c8f5324e43 100644 --- a/arch/arm/mach-davinci/Kconfig +++ b/arch/arm/mach-davinci/Kconfig @@ -9,7 +9,6 @@ config CP_INTC config ARCH_DAVINCI_DMx bool - select CPU_ARM926T menu "TI DaVinci Implementations" @@ -32,7 +31,7 @@ config ARCH_DAVINCI_DM646x config ARCH_DAVINCI_DA830 bool "DA830/OMAP-L137/AM17x based system" - depends on !ARCH_DAVINCI_DMx || AUTO_ZRELADDR + depends on !ARCH_DAVINCI_DMx || (AUTO_ZRELADDR && ARM_PATCH_PHYS_VIRT) select ARCH_DAVINCI_DA8XX # needed on silicon revs 1.0, 1.1: select CPU_DCACHE_WRITETHROUGH if !CPU_DCACHE_DISABLE @@ -40,13 +39,12 @@ config ARCH_DAVINCI_DA830 config ARCH_DAVINCI_DA850 bool "DA850/OMAP-L138/AM18x based system" - depends on !ARCH_DAVINCI_DMx || AUTO_ZRELADDR + depends on !ARCH_DAVINCI_DMx || (AUTO_ZRELADDR && ARM_PATCH_PHYS_VIRT) select ARCH_DAVINCI_DA8XX select CP_INTC config ARCH_DAVINCI_DA8XX bool - select CPU_ARM926T config ARCH_DAVINCI_DM365 bool "DaVinci 365 based system" ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-28 23:07 ` Arnd Bergmann 0 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-28 23:07 UTC (permalink / raw) To: linux-arm-kernel On Thursday 28 January 2016 17:42:41 you wrote: > On Thu, Jan 28, 2016 at 11:14:35AM +0800, Fengguang Wu wrote: > > On Wed, Jan 27, 2016 at 10:44:01AM +0100, Arnd Bergmann wrote: > > > - CONFIG_PHYS_OFFSET needs to be entered manually to be a number > > > in 'make config' > > > > That's a problem for auto tests. > > I'm really against the idea of providing some kind of "default" to it. > Not providing a default means that people _have_ to do some research > for their particular system in order to provide a value, and they're > more likely to get the right value. Providing a default will lead to > the assumption that the value is okay, and then we'll end up with > people complaining that their kernel doesn't boot, and is totally > silent. > > The only default I'd accept is one based on the rest of the config - > in other words, re-introducing all the physical address of RAM that > we used to have in the mach/memory.h files... This doesn't sound too hard. I've picked the defaults out of the git history in the patch below. The only tricky part was davinci, which has two different addresses and requires a little rework to avoid circular dependencies. Most platforms these days hardcode ARCH_PATCH_PHS_VIRT anyway, so we only need to list the bunch of remaining ones. > There's other ways around these kinds of things, the Kconfig system > does allow a Kconfig fragment which can be used to pre-set some > configuration options to particular values - and so which can be used > to set CONFIG_PHYS_OFFSET prior to an allrandconfig or similar. I don't know what Fenguang's problem was with that approach, but at least at the moment he's using a fixup after running randconfig. In my own tests, I'm doing yet another approach by marking a handful of symbols as 'depends on BROKEN' in my testing patches, but clearly that does not work when building other people's trees. The other related issue is the DEBUG_UART_{VIRT,PHYS} setting, where there is no safe platform-specific default. I have two ideas for working around that, maybe one of them sounds ok to you: a) find a way to warn and/or disable DEBUG_LL when no address is set, rather than failing the build b) add 'default 0 if COMPILE_TEST' to make it harder to get this wrong by accident (hopefully nobody tries to run a COMPILE_TEST kernel). Also maybe add a #warning if DEBUG_UART_VIRT is outside of VMALLOC_START...PCI_IOBASE area, which would cover this case as well. Arnd diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2217ec9726c9..1d2b5e6cab14 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -273,15 +273,29 @@ config PHYS_OFFSET depends on !ARM_PATCH_PHYS_VIRT default DRAM_BASE if !MMU default 0x00000000 if ARCH_EBSA110 || \ + ARCH_DOVE || \ ARCH_FOOTBRIDGE || \ + (ARCH_GEMINI && GEMINI_MEM_SWAP) || \ ARCH_INTEGRATOR || \ + ARCH_IOP33X || \ ARCH_IOP13XX || \ + ARCH_IXP4XX || \ ARCH_KS8695 || \ - (ARCH_REALVIEW && !REALVIEW_HIGH_PHYS_OFFSET) - default 0x10000000 if ARCH_OMAP1 || ARCH_RPC + (ARCH_REALVIEW && !REALVIEW_HIGH_PHYS_OFFSET) || \ + ARCH_W90X900 + default 0x10000000 if (ARCH_GEMINI && !GEMINI_MEM_SWAP) || \ + ARCH_OMAP1 || \ + ARCH_RPC default 0x20000000 if ARCH_S5PV210 + default 0x30000000 if ARCH_S3C24XX default 0x70000000 if REALVIEW_HIGH_PHYS_OFFSET - default 0xc0000000 if ARCH_SA1100 + default 0x80000000 if (ARCH_DAVINCI_DMx && !ARCH_DAVINCI_DA8XX) || \ + ARCH_NETX || \ + ARCH_LPC32XX + default 0xa0000000 if ARCH_IOP32X || ARCH_PXA + default 0xc0000000 if (ARCH_DAVINCI_DA8XX && !ARCH_DAVINCI_DMx) || \ + ARCH_CLPS711X || \ + ARCH_SA1100 help Please provide the physical address corresponding to the location of main memory in your system. @@ -627,6 +641,7 @@ config ARCH_DAVINCI select ARCH_HAS_HOLES_MEMORYMODEL select ARCH_REQUIRE_GPIOLIB select CLKDEV_LOOKUP + select CPU_ARM926T select GENERIC_ALLOCATOR select GENERIC_CLOCKEVENTS select GENERIC_IRQ_CHIP diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig index 7a9f2b8c0a42..36c8f5324e43 100644 --- a/arch/arm/mach-davinci/Kconfig +++ b/arch/arm/mach-davinci/Kconfig @@ -9,7 +9,6 @@ config CP_INTC config ARCH_DAVINCI_DMx bool - select CPU_ARM926T menu "TI DaVinci Implementations" @@ -32,7 +31,7 @@ config ARCH_DAVINCI_DM646x config ARCH_DAVINCI_DA830 bool "DA830/OMAP-L137/AM17x based system" - depends on !ARCH_DAVINCI_DMx || AUTO_ZRELADDR + depends on !ARCH_DAVINCI_DMx || (AUTO_ZRELADDR && ARM_PATCH_PHYS_VIRT) select ARCH_DAVINCI_DA8XX # needed on silicon revs 1.0, 1.1: select CPU_DCACHE_WRITETHROUGH if !CPU_DCACHE_DISABLE @@ -40,13 +39,12 @@ config ARCH_DAVINCI_DA830 config ARCH_DAVINCI_DA850 bool "DA850/OMAP-L138/AM18x based system" - depends on !ARCH_DAVINCI_DMx || AUTO_ZRELADDR + depends on !ARCH_DAVINCI_DMx || (AUTO_ZRELADDR && ARM_PATCH_PHYS_VIRT) select ARCH_DAVINCI_DA8XX select CP_INTC config ARCH_DAVINCI_DA8XX bool - select CPU_ARM926T config ARCH_DAVINCI_DM365 bool "DaVinci 365 based system" ^ permalink raw reply related [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-28 23:07 ` Arnd Bergmann (?) @ 2016-01-29 8:01 ` Geert Uytterhoeven -1 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-29 8:01 UTC (permalink / raw) To: Arnd Bergmann Cc: Russell King - ARM Linux, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel Hi Arnd, On Fri, Jan 29, 2016 at 12:07 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The other related issue is the DEBUG_UART_{VIRT,PHYS} setting, > where there is no safe platform-specific default. I have two > ideas for working around that, maybe one of them sounds ok to > you: > > a) find a way to warn and/or disable DEBUG_LL when no address > is set, rather than failing the build > > b) add 'default 0 if COMPILE_TEST' to make it harder to get this > wrong by accident (hopefully nobody tries to run a COMPILE_TEST > kernel). Also maybe add a #warning if DEBUG_UART_VIRT is Make sure to add it at the end of the list, so enabling COMPILE_TEST in a working .config should give another working .config. Perhaps you can use 0xdeadbeef instead of 0, and add #if DEBUG_UART_PHYS == 0xdeadbeed #warning Broken value of DEBUG_UART_PHYS. #endif somewhere? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 8:01 ` Geert Uytterhoeven 0 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-29 8:01 UTC (permalink / raw) To: linux-arm-kernel Hi Arnd, On Fri, Jan 29, 2016 at 12:07 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The other related issue is the DEBUG_UART_{VIRT,PHYS} setting, > where there is no safe platform-specific default. I have two > ideas for working around that, maybe one of them sounds ok to > you: > > a) find a way to warn and/or disable DEBUG_LL when no address > is set, rather than failing the build > > b) add 'default 0 if COMPILE_TEST' to make it harder to get this > wrong by accident (hopefully nobody tries to run a COMPILE_TEST > kernel). Also maybe add a #warning if DEBUG_UART_VIRT is Make sure to add it at the end of the list, so enabling COMPILE_TEST in a working .config should give another working .config. Perhaps you can use 0xdeadbeef instead of 0, and add #if DEBUG_UART_PHYS == 0xdeadbeed #warning Broken value of DEBUG_UART_PHYS. #endif somewhere? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 8:01 ` Geert Uytterhoeven 0 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-29 8:01 UTC (permalink / raw) To: Arnd Bergmann Cc: Russell King - ARM Linux, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel Hi Arnd, On Fri, Jan 29, 2016 at 12:07 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The other related issue is the DEBUG_UART_{VIRT,PHYS} setting, > where there is no safe platform-specific default. I have two > ideas for working around that, maybe one of them sounds ok to > you: > > a) find a way to warn and/or disable DEBUG_LL when no address > is set, rather than failing the build > > b) add 'default 0 if COMPILE_TEST' to make it harder to get this > wrong by accident (hopefully nobody tries to run a COMPILE_TEST > kernel). Also maybe add a #warning if DEBUG_UART_VIRT is Make sure to add it at the end of the list, so enabling COMPILE_TEST in a working .config should give another working .config. Perhaps you can use 0xdeadbeef instead of 0, and add #if DEBUG_UART_PHYS == 0xdeadbeed #warning Broken value of DEBUG_UART_PHYS. #endif somewhere? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-29 8:01 ` Geert Uytterhoeven (?) @ 2016-01-29 20:44 ` Arnd Bergmann -1 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-29 20:44 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Russell King - ARM Linux, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel On Friday 29 January 2016 09:01:31 Geert Uytterhoeven wrote: > Hi Arnd, > > On Fri, Jan 29, 2016 at 12:07 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > The other related issue is the DEBUG_UART_{VIRT,PHYS} setting, > > where there is no safe platform-specific default. I have two > > ideas for working around that, maybe one of them sounds ok to > > you: > > > > a) find a way to warn and/or disable DEBUG_LL when no address > > is set, rather than failing the build > > > > b) add 'default 0 if COMPILE_TEST' to make it harder to get this > > wrong by accident (hopefully nobody tries to run a COMPILE_TEST > > kernel). Also maybe add a #warning if DEBUG_UART_VIRT is > > Make sure to add it at the end of the list, so enabling COMPILE_TEST in a > working .config should give another working .config. Sure, I've just done a largish series of patches in 4.5 to fix that bug where we had it already. > Perhaps you can use 0xdeadbeef instead of 0, and add > > #if DEBUG_UART_PHYS == 0xdeadbeed > #warning Broken value of DEBUG_UART_PHYS. > #endif > > somewhere? I can do that, though I don't see much of an advantage, as zero is no more likely to be a real address than 0xdeadbeed. How about the version below? Arnd diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index c6b6175d0203..6cc09cf8618f 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -1526,6 +1526,7 @@ config DEBUG_UART_PHYS default 0xfffb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 default 0xfffe8600 if DEBUG_BCM63XX_UART default 0xfffff700 if ARCH_IOP33X + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 depends on ARCH_EP93XX || \ DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ DEBUG_LL_UART_EFM32 || \ @@ -1628,6 +1629,7 @@ config DEBUG_UART_VIRT default 0xff003000 if DEBUG_U300_UART default 0xffd01000 if DEBUG_HIP01_UART default DEBUG_UART_PHYS if !MMU + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ DEBUG_UART_8250 || DEBUG_UART_PL01X || DEBUG_MESON_UARTAO || \ DEBUG_NETX_UART || \ diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S index 7f7446f6f806..1191b1458586 100644 --- a/arch/arm/include/debug/8250.S +++ b/arch/arm/include/debug/8250.S @@ -9,6 +9,9 @@ */ #include <linux/serial_reg.h> +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 +#include "none.S" +#else .macro addruart, rp, rv, tmp ldr \rp, =CONFIG_DEBUG_UART_PHYS ldr \rv, =CONFIG_DEBUG_UART_VIRT @@ -55,3 +58,5 @@ beq 1001b #endif .endm + +#endif diff --git a/arch/arm/include/debug/efm32.S b/arch/arm/include/debug/efm32.S index 660fa1e4b77b..537021761e4a 100644 --- a/arch/arm/include/debug/efm32.S +++ b/arch/arm/include/debug/efm32.S @@ -6,6 +6,9 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 +#include "none.S" +#else #define UARTn_CMD 0x000c #define UARTn_CMD_TXEN 0x0004 @@ -43,3 +46,5 @@ tst \rd, #UARTn_STATUS_TXC bne 1001b .endm + +#endif diff --git a/arch/arm/include/debug/none.S b/arch/arm/include/debug/none.S new file mode 100644 index 000000000000..75cd1bbee5c4 --- /dev/null +++ b/arch/arm/include/debug/none.S @@ -0,0 +1,16 @@ + +#warning DEBUG_LL not configured, disabling + + .macro addruart, rp, rv, tmp + ldr \rp, =0 + ldr \rv, =0 + .endm + + .macro senduart,rd,rx + .endm + + .macro busyuart,rd,rx + .endm + + .macro waituart,rd,rx + .endm diff --git a/arch/arm/include/debug/pl01x.S b/arch/arm/include/debug/pl01x.S index f7d8323cefcc..fbe0cad32be0 100644 --- a/arch/arm/include/debug/pl01x.S +++ b/arch/arm/include/debug/pl01x.S @@ -10,6 +10,9 @@ * published by the Free Software Foundation. * */ +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 +#include "none.S" +#else #include <linux/amba/serial.h> #ifdef CONFIG_DEBUG_ZTE_ZX @@ -43,3 +46,4 @@ tst \rd, #UART01x_FR_BUSY bne 1001b .endm +#endif ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 20:44 ` Arnd Bergmann 0 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-29 20:44 UTC (permalink / raw) To: linux-arm-kernel On Friday 29 January 2016 09:01:31 Geert Uytterhoeven wrote: > Hi Arnd, > > On Fri, Jan 29, 2016 at 12:07 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > The other related issue is the DEBUG_UART_{VIRT,PHYS} setting, > > where there is no safe platform-specific default. I have two > > ideas for working around that, maybe one of them sounds ok to > > you: > > > > a) find a way to warn and/or disable DEBUG_LL when no address > > is set, rather than failing the build > > > > b) add 'default 0 if COMPILE_TEST' to make it harder to get this > > wrong by accident (hopefully nobody tries to run a COMPILE_TEST > > kernel). Also maybe add a #warning if DEBUG_UART_VIRT is > > Make sure to add it at the end of the list, so enabling COMPILE_TEST in a > working .config should give another working .config. Sure, I've just done a largish series of patches in 4.5 to fix that bug where we had it already. > Perhaps you can use 0xdeadbeef instead of 0, and add > > #if DEBUG_UART_PHYS == 0xdeadbeed > #warning Broken value of DEBUG_UART_PHYS. > #endif > > somewhere? I can do that, though I don't see much of an advantage, as zero is no more likely to be a real address than 0xdeadbeed. How about the version below? Arnd diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index c6b6175d0203..6cc09cf8618f 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -1526,6 +1526,7 @@ config DEBUG_UART_PHYS default 0xfffb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 default 0xfffe8600 if DEBUG_BCM63XX_UART default 0xfffff700 if ARCH_IOP33X + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 depends on ARCH_EP93XX || \ DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ DEBUG_LL_UART_EFM32 || \ @@ -1628,6 +1629,7 @@ config DEBUG_UART_VIRT default 0xff003000 if DEBUG_U300_UART default 0xffd01000 if DEBUG_HIP01_UART default DEBUG_UART_PHYS if !MMU + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ DEBUG_UART_8250 || DEBUG_UART_PL01X || DEBUG_MESON_UARTAO || \ DEBUG_NETX_UART || \ diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S index 7f7446f6f806..1191b1458586 100644 --- a/arch/arm/include/debug/8250.S +++ b/arch/arm/include/debug/8250.S @@ -9,6 +9,9 @@ */ #include <linux/serial_reg.h> +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 +#include "none.S" +#else .macro addruart, rp, rv, tmp ldr \rp, =CONFIG_DEBUG_UART_PHYS ldr \rv, =CONFIG_DEBUG_UART_VIRT @@ -55,3 +58,5 @@ beq 1001b #endif .endm + +#endif diff --git a/arch/arm/include/debug/efm32.S b/arch/arm/include/debug/efm32.S index 660fa1e4b77b..537021761e4a 100644 --- a/arch/arm/include/debug/efm32.S +++ b/arch/arm/include/debug/efm32.S @@ -6,6 +6,9 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 +#include "none.S" +#else #define UARTn_CMD 0x000c #define UARTn_CMD_TXEN 0x0004 @@ -43,3 +46,5 @@ tst \rd, #UARTn_STATUS_TXC bne 1001b .endm + +#endif diff --git a/arch/arm/include/debug/none.S b/arch/arm/include/debug/none.S new file mode 100644 index 000000000000..75cd1bbee5c4 --- /dev/null +++ b/arch/arm/include/debug/none.S @@ -0,0 +1,16 @@ + +#warning DEBUG_LL not configured, disabling + + .macro addruart, rp, rv, tmp + ldr \rp, =0 + ldr \rv, =0 + .endm + + .macro senduart,rd,rx + .endm + + .macro busyuart,rd,rx + .endm + + .macro waituart,rd,rx + .endm diff --git a/arch/arm/include/debug/pl01x.S b/arch/arm/include/debug/pl01x.S index f7d8323cefcc..fbe0cad32be0 100644 --- a/arch/arm/include/debug/pl01x.S +++ b/arch/arm/include/debug/pl01x.S @@ -10,6 +10,9 @@ * published by the Free Software Foundation. * */ +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 +#include "none.S" +#else #include <linux/amba/serial.h> #ifdef CONFIG_DEBUG_ZTE_ZX @@ -43,3 +46,4 @@ tst \rd, #UART01x_FR_BUSY bne 1001b .endm +#endif ^ permalink raw reply related [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 20:44 ` Arnd Bergmann 0 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-29 20:44 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Russell King - ARM Linux, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel On Friday 29 January 2016 09:01:31 Geert Uytterhoeven wrote: > Hi Arnd, > > On Fri, Jan 29, 2016 at 12:07 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > The other related issue is the DEBUG_UART_{VIRT,PHYS} setting, > > where there is no safe platform-specific default. I have two > > ideas for working around that, maybe one of them sounds ok to > > you: > > > > a) find a way to warn and/or disable DEBUG_LL when no address > > is set, rather than failing the build > > > > b) add 'default 0 if COMPILE_TEST' to make it harder to get this > > wrong by accident (hopefully nobody tries to run a COMPILE_TEST > > kernel). Also maybe add a #warning if DEBUG_UART_VIRT is > > Make sure to add it at the end of the list, so enabling COMPILE_TEST in a > working .config should give another working .config. Sure, I've just done a largish series of patches in 4.5 to fix that bug where we had it already. > Perhaps you can use 0xdeadbeef instead of 0, and add > > #if DEBUG_UART_PHYS == 0xdeadbeed > #warning Broken value of DEBUG_UART_PHYS. > #endif > > somewhere? I can do that, though I don't see much of an advantage, as zero is no more likely to be a real address than 0xdeadbeed. How about the version below? Arnd diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index c6b6175d0203..6cc09cf8618f 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -1526,6 +1526,7 @@ config DEBUG_UART_PHYS default 0xfffb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 default 0xfffe8600 if DEBUG_BCM63XX_UART default 0xfffff700 if ARCH_IOP33X + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 depends on ARCH_EP93XX || \ DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ DEBUG_LL_UART_EFM32 || \ @@ -1628,6 +1629,7 @@ config DEBUG_UART_VIRT default 0xff003000 if DEBUG_U300_UART default 0xffd01000 if DEBUG_HIP01_UART default DEBUG_UART_PHYS if !MMU + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ DEBUG_UART_8250 || DEBUG_UART_PL01X || DEBUG_MESON_UARTAO || \ DEBUG_NETX_UART || \ diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S index 7f7446f6f806..1191b1458586 100644 --- a/arch/arm/include/debug/8250.S +++ b/arch/arm/include/debug/8250.S @@ -9,6 +9,9 @@ */ #include <linux/serial_reg.h> +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 +#include "none.S" +#else .macro addruart, rp, rv, tmp ldr \rp, =CONFIG_DEBUG_UART_PHYS ldr \rv, =CONFIG_DEBUG_UART_VIRT @@ -55,3 +58,5 @@ beq 1001b #endif .endm + +#endif diff --git a/arch/arm/include/debug/efm32.S b/arch/arm/include/debug/efm32.S index 660fa1e4b77b..537021761e4a 100644 --- a/arch/arm/include/debug/efm32.S +++ b/arch/arm/include/debug/efm32.S @@ -6,6 +6,9 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 +#include "none.S" +#else #define UARTn_CMD 0x000c #define UARTn_CMD_TXEN 0x0004 @@ -43,3 +46,5 @@ tst \rd, #UARTn_STATUS_TXC bne 1001b .endm + +#endif diff --git a/arch/arm/include/debug/none.S b/arch/arm/include/debug/none.S new file mode 100644 index 000000000000..75cd1bbee5c4 --- /dev/null +++ b/arch/arm/include/debug/none.S @@ -0,0 +1,16 @@ + +#warning DEBUG_LL not configured, disabling + + .macro addruart, rp, rv, tmp + ldr \rp, =0 + ldr \rv, =0 + .endm + + .macro senduart,rd,rx + .endm + + .macro busyuart,rd,rx + .endm + + .macro waituart,rd,rx + .endm diff --git a/arch/arm/include/debug/pl01x.S b/arch/arm/include/debug/pl01x.S index f7d8323cefcc..fbe0cad32be0 100644 --- a/arch/arm/include/debug/pl01x.S +++ b/arch/arm/include/debug/pl01x.S @@ -10,6 +10,9 @@ * published by the Free Software Foundation. * */ +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 +#include "none.S" +#else #include <linux/amba/serial.h> #ifdef CONFIG_DEBUG_ZTE_ZX @@ -43,3 +46,4 @@ tst \rd, #UART01x_FR_BUSY bne 1001b .endm +#endif ^ permalink raw reply related [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-29 20:44 ` Arnd Bergmann (?) (?) @ 2016-01-29 21:24 ` Geert Uytterhoeven -1 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-29 21:24 UTC (permalink / raw) To: Arnd Bergmann Cc: Russell King - ARM Linux, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel Hi Arnd, On Fri, Jan 29, 2016 at 9:44 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index c6b6175d0203..6cc09cf8618f 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -1526,6 +1526,7 @@ config DEBUG_UART_PHYS > default 0xfffb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 > default 0xfffe8600 if DEBUG_BCM63XX_UART > default 0xfffff700 if ARCH_IOP33X > + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 > depends on ARCH_EP93XX || \ > DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ > DEBUG_LL_UART_EFM32 || \ > @@ -1628,6 +1629,7 @@ config DEBUG_UART_VIRT > default 0xff003000 if DEBUG_U300_UART > default 0xffd01000 if DEBUG_HIP01_UART > default DEBUG_UART_PHYS if !MMU > + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 > depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ > DEBUG_UART_8250 || DEBUG_UART_PL01X || DEBUG_MESON_UARTAO || \ > DEBUG_NETX_UART || \ > diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S > index 7f7446f6f806..1191b1458586 100644 > --- a/arch/arm/include/debug/8250.S > +++ b/arch/arm/include/debug/8250.S > @@ -9,6 +9,9 @@ > */ > #include <linux/serial_reg.h> > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 Any special reason for 0xe0000000 vs ... > --- a/arch/arm/include/debug/efm32.S > +++ b/arch/arm/include/debug/efm32.S > @@ -6,6 +6,9 @@ > * it under the terms of the GNU General Public License version 2 as > * published by the Free Software Foundation. > */ > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 0xf0000000? > --- a/arch/arm/include/debug/pl01x.S > +++ b/arch/arm/include/debug/pl01x.S > @@ -10,6 +10,9 @@ > * published by the Free Software Foundation. > * > */ > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 Likewise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 21:24 ` Geert Uytterhoeven 0 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-29 21:24 UTC (permalink / raw) To: linux-arm-kernel Hi Arnd, On Fri, Jan 29, 2016 at 9:44 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index c6b6175d0203..6cc09cf8618f 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -1526,6 +1526,7 @@ config DEBUG_UART_PHYS > default 0xfffb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 > default 0xfffe8600 if DEBUG_BCM63XX_UART > default 0xfffff700 if ARCH_IOP33X > + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 > depends on ARCH_EP93XX || \ > DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ > DEBUG_LL_UART_EFM32 || \ > @@ -1628,6 +1629,7 @@ config DEBUG_UART_VIRT > default 0xff003000 if DEBUG_U300_UART > default 0xffd01000 if DEBUG_HIP01_UART > default DEBUG_UART_PHYS if !MMU > + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 > depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ > DEBUG_UART_8250 || DEBUG_UART_PL01X || DEBUG_MESON_UARTAO || \ > DEBUG_NETX_UART || \ > diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S > index 7f7446f6f806..1191b1458586 100644 > --- a/arch/arm/include/debug/8250.S > +++ b/arch/arm/include/debug/8250.S > @@ -9,6 +9,9 @@ > */ > #include <linux/serial_reg.h> > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 Any special reason for 0xe0000000 vs ... > --- a/arch/arm/include/debug/efm32.S > +++ b/arch/arm/include/debug/efm32.S > @@ -6,6 +6,9 @@ > * it under the terms of the GNU General Public License version 2 as > * published by the Free Software Foundation. > */ > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 0xf0000000? > --- a/arch/arm/include/debug/pl01x.S > +++ b/arch/arm/include/debug/pl01x.S > @@ -10,6 +10,9 @@ > * published by the Free Software Foundation. > * > */ > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 Likewise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 21:24 ` Geert Uytterhoeven 0 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-29 21:24 UTC (permalink / raw) To: Arnd Bergmann Cc: Russell King - ARM Linux, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel Hi Arnd, On Fri, Jan 29, 2016 at 9:44 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index c6b6175d0203..6cc09cf8618f 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -1526,6 +1526,7 @@ config DEBUG_UART_PHYS > default 0xfffb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 > default 0xfffe8600 if DEBUG_BCM63XX_UART > default 0xfffff700 if ARCH_IOP33X > + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 > depends on ARCH_EP93XX || \ > DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ > DEBUG_LL_UART_EFM32 || \ > @@ -1628,6 +1629,7 @@ config DEBUG_UART_VIRT > default 0xff003000 if DEBUG_U300_UART > default 0xffd01000 if DEBUG_HIP01_UART > default DEBUG_UART_PHYS if !MMU > + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 > depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ > DEBUG_UART_8250 || DEBUG_UART_PL01X || DEBUG_MESON_UARTAO || \ > DEBUG_NETX_UART || \ > diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S > index 7f7446f6f806..1191b1458586 100644 > --- a/arch/arm/include/debug/8250.S > +++ b/arch/arm/include/debug/8250.S > @@ -9,6 +9,9 @@ > */ > #include <linux/serial_reg.h> > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 Any special reason for 0xe0000000 vs ... > --- a/arch/arm/include/debug/efm32.S > +++ b/arch/arm/include/debug/efm32.S > @@ -6,6 +6,9 @@ > * it under the terms of the GNU General Public License version 2 as > * published by the Free Software Foundation. > */ > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 0xf0000000? > --- a/arch/arm/include/debug/pl01x.S > +++ b/arch/arm/include/debug/pl01x.S > @@ -10,6 +10,9 @@ > * published by the Free Software Foundation. > * > */ > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 Likewise. Gr{oetje,eeting}s, Geert ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 21:24 ` Geert Uytterhoeven 0 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-29 21:24 UTC (permalink / raw) To: Arnd Bergmann Cc: Russell King - ARM Linux, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel Hi Arnd, On Fri, Jan 29, 2016 at 9:44 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index c6b6175d0203..6cc09cf8618f 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -1526,6 +1526,7 @@ config DEBUG_UART_PHYS > default 0xfffb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 > default 0xfffe8600 if DEBUG_BCM63XX_UART > default 0xfffff700 if ARCH_IOP33X > + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 > depends on ARCH_EP93XX || \ > DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ > DEBUG_LL_UART_EFM32 || \ > @@ -1628,6 +1629,7 @@ config DEBUG_UART_VIRT > default 0xff003000 if DEBUG_U300_UART > default 0xffd01000 if DEBUG_HIP01_UART > default DEBUG_UART_PHYS if !MMU > + default 0xdeadbeef if DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || DEBUG_LL_UART_EFM32 > depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ > DEBUG_UART_8250 || DEBUG_UART_PL01X || DEBUG_MESON_UARTAO || \ > DEBUG_NETX_UART || \ > diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S > index 7f7446f6f806..1191b1458586 100644 > --- a/arch/arm/include/debug/8250.S > +++ b/arch/arm/include/debug/8250.S > @@ -9,6 +9,9 @@ > */ > #include <linux/serial_reg.h> > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 Any special reason for 0xe0000000 vs ... > --- a/arch/arm/include/debug/efm32.S > +++ b/arch/arm/include/debug/efm32.S > @@ -6,6 +6,9 @@ > * it under the terms of the GNU General Public License version 2 as > * published by the Free Software Foundation. > */ > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 0xf0000000? > --- a/arch/arm/include/debug/pl01x.S > +++ b/arch/arm/include/debug/pl01x.S > @@ -10,6 +10,9 @@ > * published by the Free Software Foundation. > * > */ > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 Likewise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-29 21:24 ` Geert Uytterhoeven (?) @ 2016-01-29 21:54 ` Arnd Bergmann -1 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-29 21:54 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Russell King - ARM Linux, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel On Friday 29 January 2016 22:24:31 Geert Uytterhoeven wrote: > > diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S > > index 7f7446f6f806..1191b1458586 100644 > > --- a/arch/arm/include/debug/8250.S > > +++ b/arch/arm/include/debug/8250.S > > @@ -9,6 +9,9 @@ > > */ > > #include <linux/serial_reg.h> > > > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 > > Any special reason for 0xe0000000 vs ... > > > --- a/arch/arm/include/debug/efm32.S > > +++ b/arch/arm/include/debug/efm32.S > > @@ -6,6 +6,9 @@ > > * it under the terms of the GNU General Public License version 2 as > > * published by the Free Software Foundation. > > */ > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 > > 0xf0000000? We have one platform that uses a 8250 at address 0xe0010fe0, and one using the netx UART at virtual address 0xe0000a00, everything else uses 0xf0000000 or higher. The 0xf0000000 address seems like a better default cutoff, because that is close to the VMALLOC_START value for systems with 768MB of RAM or more. Picking a lower number can easily get you in trouble here. Now that I think about it, I guess platforms that use values above 0xfee00000 can also easily get into trouble as that conflicts with the PCI I/O space, the fixmap or other special areas documented in Documentation/arm/memory.txt. We have a bunch of those: default 0xfee003f8 if DEBUG_FOOTBRIDGE_COM1 default 0xfee20000 if DEBUG_NSPIRE_CLASSIC_UART || DEBUG_NSPIRE_CX_UART default 0xfee82340 if ARCH_IOP13XX default 0xfef00000 if ARCH_IXP4XX && !CPU_BIG_ENDIAN default 0xfef00003 if ARCH_IXP4XX && CPU_BIG_ENDIAN default 0xfef36000 if DEBUG_HIGHBANK_UART default 0xfefb0000 if DEBUG_OMAP1UART1 || DEBUG_OMAP7XXUART1 default 0xfefb0800 if DEBUG_OMAP1UART2 || DEBUG_OMAP7XXUART2 default 0xfefb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 default 0xfefff700 if ARCH_IOP33X default 0xff003000 if DEBUG_U300_UART default 0xffd01000 if DEBUG_HIP01_UART The HIP01 is the only one that looks actively dangerous here (clashes with fixmap), the others are probably all fine but it would be nice to stay out of that area completely. Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 21:54 ` Arnd Bergmann 0 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-29 21:54 UTC (permalink / raw) To: linux-arm-kernel On Friday 29 January 2016 22:24:31 Geert Uytterhoeven wrote: > > diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S > > index 7f7446f6f806..1191b1458586 100644 > > --- a/arch/arm/include/debug/8250.S > > +++ b/arch/arm/include/debug/8250.S > > @@ -9,6 +9,9 @@ > > */ > > #include <linux/serial_reg.h> > > > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 > > Any special reason for 0xe0000000 vs ... > > > --- a/arch/arm/include/debug/efm32.S > > +++ b/arch/arm/include/debug/efm32.S > > @@ -6,6 +6,9 @@ > > * it under the terms of the GNU General Public License version 2 as > > * published by the Free Software Foundation. > > */ > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 > > 0xf0000000? We have one platform that uses a 8250 at address 0xe0010fe0, and one using the netx UART at virtual address 0xe0000a00, everything else uses 0xf0000000 or higher. The 0xf0000000 address seems like a better default cutoff, because that is close to the VMALLOC_START value for systems with 768MB of RAM or more. Picking a lower number can easily get you in trouble here. Now that I think about it, I guess platforms that use values above 0xfee00000 can also easily get into trouble as that conflicts with the PCI I/O space, the fixmap or other special areas documented in Documentation/arm/memory.txt. We have a bunch of those: default 0xfee003f8 if DEBUG_FOOTBRIDGE_COM1 default 0xfee20000 if DEBUG_NSPIRE_CLASSIC_UART || DEBUG_NSPIRE_CX_UART default 0xfee82340 if ARCH_IOP13XX default 0xfef00000 if ARCH_IXP4XX && !CPU_BIG_ENDIAN default 0xfef00003 if ARCH_IXP4XX && CPU_BIG_ENDIAN default 0xfef36000 if DEBUG_HIGHBANK_UART default 0xfefb0000 if DEBUG_OMAP1UART1 || DEBUG_OMAP7XXUART1 default 0xfefb0800 if DEBUG_OMAP1UART2 || DEBUG_OMAP7XXUART2 default 0xfefb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 default 0xfefff700 if ARCH_IOP33X default 0xff003000 if DEBUG_U300_UART default 0xffd01000 if DEBUG_HIP01_UART The HIP01 is the only one that looks actively dangerous here (clashes with fixmap), the others are probably all fine but it would be nice to stay out of that area completely. Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 21:54 ` Arnd Bergmann 0 siblings, 0 replies; 41+ messages in thread From: Arnd Bergmann @ 2016-01-29 21:54 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Russell King - ARM Linux, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel On Friday 29 January 2016 22:24:31 Geert Uytterhoeven wrote: > > diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S > > index 7f7446f6f806..1191b1458586 100644 > > --- a/arch/arm/include/debug/8250.S > > +++ b/arch/arm/include/debug/8250.S > > @@ -9,6 +9,9 @@ > > */ > > #include <linux/serial_reg.h> > > > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xe0000000 > > Any special reason for 0xe0000000 vs ... > > > --- a/arch/arm/include/debug/efm32.S > > +++ b/arch/arm/include/debug/efm32.S > > @@ -6,6 +6,9 @@ > > * it under the terms of the GNU General Public License version 2 as > > * published by the Free Software Foundation. > > */ > > +#if CONFIG_DEBUG_UART_PHYS == 0xdeadbeef || CONFIG_DEBUG_UART_VIRT < 0xf0000000 > > 0xf0000000? We have one platform that uses a 8250 at address 0xe0010fe0, and one using the netx UART at virtual address 0xe0000a00, everything else uses 0xf0000000 or higher. The 0xf0000000 address seems like a better default cutoff, because that is close to the VMALLOC_START value for systems with 768MB of RAM or more. Picking a lower number can easily get you in trouble here. Now that I think about it, I guess platforms that use values above 0xfee00000 can also easily get into trouble as that conflicts with the PCI I/O space, the fixmap or other special areas documented in Documentation/arm/memory.txt. We have a bunch of those: default 0xfee003f8 if DEBUG_FOOTBRIDGE_COM1 default 0xfee20000 if DEBUG_NSPIRE_CLASSIC_UART || DEBUG_NSPIRE_CX_UART default 0xfee82340 if ARCH_IOP13XX default 0xfef00000 if ARCH_IXP4XX && !CPU_BIG_ENDIAN default 0xfef00003 if ARCH_IXP4XX && CPU_BIG_ENDIAN default 0xfef36000 if DEBUG_HIGHBANK_UART default 0xfefb0000 if DEBUG_OMAP1UART1 || DEBUG_OMAP7XXUART1 default 0xfefb0800 if DEBUG_OMAP1UART2 || DEBUG_OMAP7XXUART2 default 0xfefb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 default 0xfefff700 if ARCH_IOP33X default 0xff003000 if DEBUG_U300_UART default 0xffd01000 if DEBUG_HIP01_UART The HIP01 is the only one that looks actively dangerous here (clashes with fixmap), the others are probably all fine but it would be nice to stay out of that area completely. Arnd ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-29 21:54 ` Arnd Bergmann (?) @ 2016-01-29 23:15 ` Russell King - ARM Linux -1 siblings, 0 replies; 41+ messages in thread From: Russell King - ARM Linux @ 2016-01-29 23:15 UTC (permalink / raw) To: Arnd Bergmann Cc: Geert Uytterhoeven, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel On Fri, Jan 29, 2016 at 10:54:02PM +0100, Arnd Bergmann wrote: > Now that I think about it, I guess platforms that use values above > 0xfee00000 can also easily get into trouble as that conflicts with the > PCI I/O space, the fixmap or other special areas documented in > Documentation/arm/memory.txt. We have a bunch of those: > > default 0xfee003f8 if DEBUG_FOOTBRIDGE_COM1 > default 0xfee20000 if DEBUG_NSPIRE_CLASSIC_UART || DEBUG_NSPIRE_CX_UART > default 0xfee82340 if ARCH_IOP13XX > default 0xfef00000 if ARCH_IXP4XX && !CPU_BIG_ENDIAN > default 0xfef00003 if ARCH_IXP4XX && CPU_BIG_ENDIAN > default 0xfef36000 if DEBUG_HIGHBANK_UART > default 0xfefb0000 if DEBUG_OMAP1UART1 || DEBUG_OMAP7XXUART1 > default 0xfefb0800 if DEBUG_OMAP1UART2 || DEBUG_OMAP7XXUART2 > default 0xfefb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 > default 0xfefff700 if ARCH_IOP33X > default 0xff003000 if DEBUG_U300_UART > default 0xffd01000 if DEBUG_HIP01_UART > > The HIP01 is the only one that looks actively dangerous here (clashes with > fixmap), the others are probably all fine but it would be nice to stay out > of that area completely. That's wrong. Given it's PCI bus architecture and it's IO space, at least one of those above is perfectly valid. 0x3f8 into IO space might ring a bell... if not the COM1 certainly should. :) -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 23:15 ` Russell King - ARM Linux 0 siblings, 0 replies; 41+ messages in thread From: Russell King - ARM Linux @ 2016-01-29 23:15 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jan 29, 2016 at 10:54:02PM +0100, Arnd Bergmann wrote: > Now that I think about it, I guess platforms that use values above > 0xfee00000 can also easily get into trouble as that conflicts with the > PCI I/O space, the fixmap or other special areas documented in > Documentation/arm/memory.txt. We have a bunch of those: > > default 0xfee003f8 if DEBUG_FOOTBRIDGE_COM1 > default 0xfee20000 if DEBUG_NSPIRE_CLASSIC_UART || DEBUG_NSPIRE_CX_UART > default 0xfee82340 if ARCH_IOP13XX > default 0xfef00000 if ARCH_IXP4XX && !CPU_BIG_ENDIAN > default 0xfef00003 if ARCH_IXP4XX && CPU_BIG_ENDIAN > default 0xfef36000 if DEBUG_HIGHBANK_UART > default 0xfefb0000 if DEBUG_OMAP1UART1 || DEBUG_OMAP7XXUART1 > default 0xfefb0800 if DEBUG_OMAP1UART2 || DEBUG_OMAP7XXUART2 > default 0xfefb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 > default 0xfefff700 if ARCH_IOP33X > default 0xff003000 if DEBUG_U300_UART > default 0xffd01000 if DEBUG_HIP01_UART > > The HIP01 is the only one that looks actively dangerous here (clashes with > fixmap), the others are probably all fine but it would be nice to stay out > of that area completely. That's wrong. Given it's PCI bus architecture and it's IO space, at least one of those above is perfectly valid. 0x3f8 into IO space might ring a bell... if not the COM1 certainly should. :) -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 23:15 ` Russell King - ARM Linux 0 siblings, 0 replies; 41+ messages in thread From: Russell King - ARM Linux @ 2016-01-29 23:15 UTC (permalink / raw) To: Arnd Bergmann Cc: Geert Uytterhoeven, Fengguang Wu, Linux-Arch, Linux MIPS Mailing List, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel On Fri, Jan 29, 2016 at 10:54:02PM +0100, Arnd Bergmann wrote: > Now that I think about it, I guess platforms that use values above > 0xfee00000 can also easily get into trouble as that conflicts with the > PCI I/O space, the fixmap or other special areas documented in > Documentation/arm/memory.txt. We have a bunch of those: > > default 0xfee003f8 if DEBUG_FOOTBRIDGE_COM1 > default 0xfee20000 if DEBUG_NSPIRE_CLASSIC_UART || DEBUG_NSPIRE_CX_UART > default 0xfee82340 if ARCH_IOP13XX > default 0xfef00000 if ARCH_IXP4XX && !CPU_BIG_ENDIAN > default 0xfef00003 if ARCH_IXP4XX && CPU_BIG_ENDIAN > default 0xfef36000 if DEBUG_HIGHBANK_UART > default 0xfefb0000 if DEBUG_OMAP1UART1 || DEBUG_OMAP7XXUART1 > default 0xfefb0800 if DEBUG_OMAP1UART2 || DEBUG_OMAP7XXUART2 > default 0xfefb9800 if DEBUG_OMAP1UART3 || DEBUG_OMAP7XXUART3 > default 0xfefff700 if ARCH_IOP33X > default 0xff003000 if DEBUG_U300_UART > default 0xffd01000 if DEBUG_HIP01_UART > > The HIP01 is the only one that looks actively dangerous here (clashes with > fixmap), the others are probably all fine but it would be nice to stay out > of that area completely. That's wrong. Given it's PCI bus architecture and it's IO space, at least one of those above is perfectly valid. 0x3f8 into IO space might ring a bell... if not the COM1 certainly should. :) -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-28 23:07 ` Arnd Bergmann @ 2016-01-29 21:46 ` Russell King - ARM Linux -1 siblings, 0 replies; 41+ messages in thread From: Russell King - ARM Linux @ 2016-01-29 21:46 UTC (permalink / raw) To: Arnd Bergmann Cc: Fengguang Wu, linux-arch, linux-mips, James Hogan, Paul Burton, linux-kbuild, Heinrich Schuchardt, linux-kernel, Ralf Baechle, Florian Fainelli, Michal Marek, linux-arm-kernel On Fri, Jan 29, 2016 at 12:07:21AM +0100, Arnd Bergmann wrote: > This doesn't sound too hard. I've picked the defaults out of the > git history in the patch below. The only tricky part was davinci, > which has two different addresses and requires a little rework > to avoid circular dependencies. I think there's a much better way to solve this. How about we have an architecture-defined way to provide all*config with a set of settings to be used with Kconfig to define these integer settings, rather than papering over the problem making up random addresses (like you're doing for the debug stuff.) Eg, a default architecture-provided setting for KCONFIG_ALLCONFIG that defines things such as the physical offset and the debug addresses to be used for all*config targets? Surely that's better than hacking around with the Kconfig files trying to frig something into working, which can potentially confuse people. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-29 21:46 ` Russell King - ARM Linux 0 siblings, 0 replies; 41+ messages in thread From: Russell King - ARM Linux @ 2016-01-29 21:46 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jan 29, 2016 at 12:07:21AM +0100, Arnd Bergmann wrote: > This doesn't sound too hard. I've picked the defaults out of the > git history in the patch below. The only tricky part was davinci, > which has two different addresses and requires a little rework > to avoid circular dependencies. I think there's a much better way to solve this. How about we have an architecture-defined way to provide all*config with a set of settings to be used with Kconfig to define these integer settings, rather than papering over the problem making up random addresses (like you're doing for the debug stuff.) Eg, a default architecture-provided setting for KCONFIG_ALLCONFIG that defines things such as the physical offset and the debug addresses to be used for all*config targets? Surely that's better than hacking around with the Kconfig files trying to frig something into working, which can potentially confuse people. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE 2016-01-27 9:44 ` Arnd Bergmann (?) @ 2016-01-28 18:00 ` Geert Uytterhoeven -1 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-28 18:00 UTC (permalink / raw) To: Arnd Bergmann Cc: Fengguang Wu, James Hogan, Linux MIPS Mailing List, Linux-Arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek, linux-arm-kernel Hi Arnd, On Wed, Jan 27, 2016 at 10:44 AM, Arnd Bergmann <arnd@arndb.de> wrote: > - in some configurations, you end up without any boards selected, hitting > an #error in the final link FWIW, I have a similar problem with m68k+MMU=y randconfig... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 41+ messages in thread
* [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-28 18:00 ` Geert Uytterhoeven 0 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-28 18:00 UTC (permalink / raw) To: linux-arm-kernel Hi Arnd, On Wed, Jan 27, 2016 at 10:44 AM, Arnd Bergmann <arnd@arndb.de> wrote: > - in some configurations, you end up without any boards selected, hitting > an #error in the final link FWIW, I have a similar problem with m68k+MMU=y randconfig... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE @ 2016-01-28 18:00 ` Geert Uytterhoeven 0 siblings, 0 replies; 41+ messages in thread From: Geert Uytterhoeven @ 2016-01-28 18:00 UTC (permalink / raw) To: Arnd Bergmann Cc: Fengguang Wu, James Hogan, Linux MIPS Mailing List, Linux-Arch, linux-kbuild, Florian Fainelli, Paul Burton, Ralf Baechle, Heinrich Schuchardt, linux-kernel, Michal Marek, linux-arm-kernel Hi Arnd, On Wed, Jan 27, 2016 at 10:44 AM, Arnd Bergmann <arnd@arndb.de> wrote: > - in some configurations, you end up without any boards selected, hitting > an #error in the final link FWIW, I have a similar problem with m68k+MMU=y randconfig... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 41+ messages in thread
end of thread, other threads:[~2016-01-29 23:15 UTC | newest] Thread overview: 41+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-01-19 11:27 [linux-review:James-Hogan/kbuild-Remove-stale-asm-generic-wrappers/20160119-183642] d979f99e9cc14e2667e9b6e268db695977e4197a BUILD DONE kbuild test robot 2016-01-19 11:27 ` kbuild test robot 2016-01-19 11:27 ` kbuild test robot 2016-01-19 14:26 ` Arnd Bergmann 2016-01-26 5:30 ` Fengguang Wu 2016-01-26 5:35 ` Fengguang Wu 2016-01-26 16:27 ` Arnd Bergmann 2016-01-27 8:37 ` Fengguang Wu 2016-01-27 9:11 ` Arnd Bergmann 2016-01-27 9:30 ` Fengguang Wu 2016-01-27 9:44 ` Arnd Bergmann 2016-01-27 9:44 ` Arnd Bergmann 2016-01-28 3:14 ` Fengguang Wu 2016-01-28 3:14 ` Fengguang Wu 2016-01-28 12:07 ` Arnd Bergmann 2016-01-28 12:07 ` Arnd Bergmann 2016-01-28 17:42 ` Russell King - ARM Linux 2016-01-28 17:42 ` Russell King - ARM Linux 2016-01-28 23:07 ` Arnd Bergmann 2016-01-28 23:07 ` Arnd Bergmann 2016-01-29 8:01 ` Geert Uytterhoeven 2016-01-29 8:01 ` Geert Uytterhoeven 2016-01-29 8:01 ` Geert Uytterhoeven 2016-01-29 20:44 ` Arnd Bergmann 2016-01-29 20:44 ` Arnd Bergmann 2016-01-29 20:44 ` Arnd Bergmann 2016-01-29 21:24 ` Geert Uytterhoeven 2016-01-29 21:24 ` Geert Uytterhoeven 2016-01-29 21:24 ` Geert Uytterhoeven 2016-01-29 21:24 ` Geert Uytterhoeven 2016-01-29 21:54 ` Arnd Bergmann 2016-01-29 21:54 ` Arnd Bergmann 2016-01-29 21:54 ` Arnd Bergmann 2016-01-29 23:15 ` Russell King - ARM Linux 2016-01-29 23:15 ` Russell King - ARM Linux 2016-01-29 23:15 ` Russell King - ARM Linux 2016-01-29 21:46 ` Russell King - ARM Linux 2016-01-29 21:46 ` Russell King - ARM Linux 2016-01-28 18:00 ` Geert Uytterhoeven 2016-01-28 18:00 ` Geert Uytterhoeven 2016-01-28 18:00 ` Geert Uytterhoeven
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.