* [PATCH] xen: xenbus_dev.h: delete incorrect file name
@ 2022-01-30 19:17 Randy Dunlap
2022-01-31 6:46 ` Juergen Gross
2022-02-04 9:23 ` Juergen Gross
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-01-30 19:17 UTC (permalink / raw)
To: patches
Cc: Randy Dunlap, Boris Ostrovsky, Juergen Gross, Stefano Stabellini,
xen-devel
It is better/preferred not to include file names in source files
because (a) they are not needed and (b) they can be incorrect,
so just delete this incorrect file name.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org
---
include/xen/xenbus_dev.h | 1 -
1 file changed, 1 deletion(-)
--- linux-next-20220128.orig/include/xen/xenbus_dev.h
+++ linux-next-20220128/include/xen/xenbus_dev.h
@@ -1,5 +1,4 @@
/******************************************************************************
- * evtchn.h
*
* Interface to /dev/xen/xenbus_backend.
*
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: xenbus_dev.h: delete incorrect file name
2022-01-30 19:17 [PATCH] xen: xenbus_dev.h: delete incorrect file name Randy Dunlap
@ 2022-01-31 6:46 ` Juergen Gross
2022-01-31 16:06 ` Randy Dunlap
2022-02-04 9:23 ` Juergen Gross
1 sibling, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2022-01-31 6:46 UTC (permalink / raw)
To: Randy Dunlap, patches; +Cc: Boris Ostrovsky, Stefano Stabellini, xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 986 bytes --]
On 30.01.22 20:17, Randy Dunlap wrote:
> It is better/preferred not to include file names in source files
> because (a) they are not needed and (b) they can be incorrect,
> so just delete this incorrect file name.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: xen-devel@lists.xenproject.org
> ---
> include/xen/xenbus_dev.h | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20220128.orig/include/xen/xenbus_dev.h
> +++ linux-next-20220128/include/xen/xenbus_dev.h
> @@ -1,5 +1,4 @@
> /******************************************************************************
> - * evtchn.h
I think the following line should be deleted, too (can be done while
committing).
> *
> * Interface to /dev/xen/xenbus_backend.
> *
>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: xenbus_dev.h: delete incorrect file name
2022-01-31 6:46 ` Juergen Gross
@ 2022-01-31 16:06 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-01-31 16:06 UTC (permalink / raw)
To: Juergen Gross, patches; +Cc: Boris Ostrovsky, Stefano Stabellini, xen-devel
On 1/30/22 22:46, Juergen Gross wrote:
> On 30.01.22 20:17, Randy Dunlap wrote:
>> It is better/preferred not to include file names in source files
>> because (a) they are not needed and (b) they can be incorrect,
>> so just delete this incorrect file name.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: Juergen Gross <jgross@suse.com>
>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>> Cc: xen-devel@lists.xenproject.org
>> ---
>> include/xen/xenbus_dev.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- linux-next-20220128.orig/include/xen/xenbus_dev.h
>> +++ linux-next-20220128/include/xen/xenbus_dev.h
>> @@ -1,5 +1,4 @@
>> /******************************************************************************
>> - * evtchn.h
>
> I think the following line should be deleted, too (can be done while
> committing).
>
Sounds good. Thanks.
>> *
>> * Interface to /dev/xen/xenbus_backend.
>> *
>>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
>
> Juergen
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: xenbus_dev.h: delete incorrect file name
2022-01-30 19:17 [PATCH] xen: xenbus_dev.h: delete incorrect file name Randy Dunlap
2022-01-31 6:46 ` Juergen Gross
@ 2022-02-04 9:23 ` Juergen Gross
1 sibling, 0 replies; 4+ messages in thread
From: Juergen Gross @ 2022-02-04 9:23 UTC (permalink / raw)
To: Randy Dunlap, patches; +Cc: Boris Ostrovsky, Stefano Stabellini, xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 333 bytes --]
On 30.01.22 20:17, Randy Dunlap wrote:
> It is better/preferred not to include file names in source files
> because (a) they are not needed and (b) they can be incorrect,
> so just delete this incorrect file name.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Pushed to xen/tip.git for-linus-5.17a
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-04 9:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-30 19:17 [PATCH] xen: xenbus_dev.h: delete incorrect file name Randy Dunlap
2022-01-31 6:46 ` Juergen Gross
2022-01-31 16:06 ` Randy Dunlap
2022-02-04 9:23 ` Juergen Gross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.