All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Patrick Scharrenberg <pittipatti@web.de>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel@lists.xensource.com,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces
Date: Mon, 7 Feb 2011 16:11:48 +0000	[thread overview]
Message-ID: <19792.6596.96339.883733@mariner.uk.xensource.com> (raw)
In-Reply-To: <201102051726.30996.pittipatti@web.de>

Patrick Scharrenberg writes ("[Xen-devel] [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces"):
> In the two scripts vif-bridge and vif-route the variable containing
> the right interface-name, after an interface was renamed using
> "ifname", is $vif.  Otherwise hotplug can't handle renamed
> interfaces and prevents xm from creating domains.

This seems to be partly reverting 21922:0232bc7c9544 "tools/hotplug,
Use udev rules instead of qemu script to setup the bridge."

I can't exactly follow the logic of 21922 but it seems to me that the
bug is that in the case of an interface of type vif which is later
renamed (by the code around line 75 of vif-common.sh in xen-unstable),
the shell variable dev is not changed.

The change you are proposing would also an effect in the case of
interfaces of type tap and I'm not convinced that in this case it
would do the right thing.

Anthony, Stefano: as the authors of 21922 would you care to comment ?

Ian.

  reply	other threads:[~2011-02-07 16:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-05 16:26 [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces Patrick Scharrenberg
2011-02-07 16:11 ` Ian Jackson [this message]
2011-02-07 17:23   ` Stefano Stabellini
2011-02-07 21:59     ` Patrick Scharrenberg
2011-02-08 11:44       ` Stefano Stabellini
2011-02-08 16:34       ` Ian Jackson
2011-02-09 19:29         ` Patrick Scharrenberg
2011-02-11 18:22           ` [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces [and 1 more messages] Ian Jackson
  -- strict thread matches above, loose matches on Subject: below --
2011-02-05 13:39 [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces Patrick Scharrenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19792.6596.96339.883733@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=pittipatti@web.de \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.