All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Scharrenberg <pittipatti@web.de>
To: xen-devel@lists.xensource.com
Subject: [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces
Date: Sat, 5 Feb 2011 17:26:30 +0100	[thread overview]
Message-ID: <201102051726.30996.pittipatti@web.de> (raw)

In the two scripts vif-bridge and vif-route the variable containing the right 
interface-name, after an interface was renamed using "ifname", is $vif.
Otherwise hotplug can't handle renamed interfaces and prevents xm from 
creating domains.

Signed-off-by: Patrick Scharrenberg <pittipatti@web.de>

---

Please apply to unstable.

In 4.0.x the scripts are correct.
In unstable only vif-route contains the right variables


diff -r e7b31cc0093c tools/hotplug/Linux/vif-bridge
--- a/tools/hotplug/Linux/vif-bridge    Mon Jan 31 17:46:55 2011 +0000
+++ b/tools/hotplug/Linux/vif-bridge    Sat Feb 05 14:11:52 2011 +0100
@@ -81,18 +81,18 @@
 
 case "$command" in
     online)
-        setup_virtual_bridge_port "$dev"
-        add_to_bridge "$bridge" "$dev"
+        setup_virtual_bridge_port "$vif"
+        add_to_bridge "$bridge" "$vif"
         ;;
 
     offline)
-        do_without_error brctl delif "$bridge" "$dev"
-        do_without_error ifconfig "$dev" down
+        do_without_error brctl delif "$bridge" "$vif"
+        do_without_error ifconfig "$vif" down
         ;;
 
     add)
-        setup_virtual_bridge_port "$dev"
-        add_to_bridge "$bridge" "$dev"
+        setup_virtual_bridge_port "$vif"
+        add_to_bridge "$bridge" "$vif"
         ;;
 esac
 
@@ -100,7 +100,7 @@
     handle_iptable
 fi
 
-log debug "Successful vif-bridge $command for $dev, bridge $bridge."
+log debug "Successful vif-bridge $command for $vif, bridge $bridge."
 if [ "$type_if" = vif -a "$command" = "online" ]
 then
   success

             reply	other threads:[~2011-02-05 16:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-05 16:26 Patrick Scharrenberg [this message]
2011-02-07 16:11 ` [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces Ian Jackson
2011-02-07 17:23   ` Stefano Stabellini
2011-02-07 21:59     ` Patrick Scharrenberg
2011-02-08 11:44       ` Stefano Stabellini
2011-02-08 16:34       ` Ian Jackson
2011-02-09 19:29         ` Patrick Scharrenberg
2011-02-11 18:22           ` [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces [and 1 more messages] Ian Jackson
  -- strict thread matches above, loose matches on Subject: below --
2011-02-05 13:39 [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces Patrick Scharrenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102051726.30996.pittipatti@web.de \
    --to=pittipatti@web.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.