From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, Xie Yongji <xieyongji@bytedance.com> Cc: mst@redhat.com, stefanha@redhat.com, parav@nvidia.com, bob.liu@oracle.com, hch@infradead.org, rdunlap@infradead.org, willy@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, bcrl@kvack.org, corbet@lwn.net, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices Date: Wed, 27 Jan 2021 11:33:03 +0800 [thread overview] Message-ID: <1979cffc-240e-a9f9-b0ab-84a1f82ac81e@redhat.com> (raw) In-Reply-To: <20210120110832.oijcmywq7pf7psg3@steredhat> On 2021/1/20 下午7:08, Stefano Garzarella wrote: > On Wed, Jan 20, 2021 at 11:46:38AM +0800, Jason Wang wrote: >> >> On 2021/1/19 下午12:59, Xie Yongji wrote: >>> With VDUSE, we should be able to support all kinds of virtio devices. >>> >>> Signed-off-by: Xie Yongji <xieyongji@bytedance.com> >>> --- >>> drivers/vhost/vdpa.c | 29 +++-------------------------- >>> 1 file changed, 3 insertions(+), 26 deletions(-) >>> >>> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c >>> index 29ed4173f04e..448be7875b6d 100644 >>> --- a/drivers/vhost/vdpa.c >>> +++ b/drivers/vhost/vdpa.c >>> @@ -22,6 +22,7 @@ >>> #include <linux/nospec.h> >>> #include <linux/vhost.h> >>> #include <linux/virtio_net.h> >>> +#include <linux/virtio_blk.h> >>> #include "vhost.h" >>> @@ -185,26 +186,6 @@ static long vhost_vdpa_set_status(struct >>> vhost_vdpa *v, u8 __user *statusp) >>> return 0; >>> } >>> -static int vhost_vdpa_config_validate(struct vhost_vdpa *v, >>> - struct vhost_vdpa_config *c) >>> -{ >>> - long size = 0; >>> - >>> - switch (v->virtio_id) { >>> - case VIRTIO_ID_NET: >>> - size = sizeof(struct virtio_net_config); >>> - break; >>> - } >>> - >>> - if (c->len == 0) >>> - return -EINVAL; >>> - >>> - if (c->len > size - c->off) >>> - return -E2BIG; >>> - >>> - return 0; >>> -} >> >> >> I think we should use a separate patch for this. > > For the vdpa-blk simulator I had the same issues and I'm adding a > .get_config_size() callback to vdpa devices. > > Do you think make sense or is better to remove this check in > vhost/vdpa, delegating the boundaries checks to get_config/set_config > callbacks. A question here. How much value could we gain from get_config_size() consider we can let vDPA parent to validate the length in its get_config(). Thanks > > Thanks, > Stefano >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, Xie Yongji <xieyongji@bytedance.com> Cc: axboe@kernel.dk, corbet@lwn.net, kvm@vger.kernel.org, mst@redhat.com, linux-aio@kvack.org, netdev@vger.kernel.org, rdunlap@infradead.org, willy@infradead.org, virtualization@lists.linux-foundation.org, hch@infradead.org, bob.liu@oracle.com, bcrl@kvack.org, viro@zeniv.linux.org.uk, stefanha@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices Date: Wed, 27 Jan 2021 11:33:03 +0800 [thread overview] Message-ID: <1979cffc-240e-a9f9-b0ab-84a1f82ac81e@redhat.com> (raw) In-Reply-To: <20210120110832.oijcmywq7pf7psg3@steredhat> On 2021/1/20 下午7:08, Stefano Garzarella wrote: > On Wed, Jan 20, 2021 at 11:46:38AM +0800, Jason Wang wrote: >> >> On 2021/1/19 下午12:59, Xie Yongji wrote: >>> With VDUSE, we should be able to support all kinds of virtio devices. >>> >>> Signed-off-by: Xie Yongji <xieyongji@bytedance.com> >>> --- >>> drivers/vhost/vdpa.c | 29 +++-------------------------- >>> 1 file changed, 3 insertions(+), 26 deletions(-) >>> >>> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c >>> index 29ed4173f04e..448be7875b6d 100644 >>> --- a/drivers/vhost/vdpa.c >>> +++ b/drivers/vhost/vdpa.c >>> @@ -22,6 +22,7 @@ >>> #include <linux/nospec.h> >>> #include <linux/vhost.h> >>> #include <linux/virtio_net.h> >>> +#include <linux/virtio_blk.h> >>> #include "vhost.h" >>> @@ -185,26 +186,6 @@ static long vhost_vdpa_set_status(struct >>> vhost_vdpa *v, u8 __user *statusp) >>> return 0; >>> } >>> -static int vhost_vdpa_config_validate(struct vhost_vdpa *v, >>> - struct vhost_vdpa_config *c) >>> -{ >>> - long size = 0; >>> - >>> - switch (v->virtio_id) { >>> - case VIRTIO_ID_NET: >>> - size = sizeof(struct virtio_net_config); >>> - break; >>> - } >>> - >>> - if (c->len == 0) >>> - return -EINVAL; >>> - >>> - if (c->len > size - c->off) >>> - return -E2BIG; >>> - >>> - return 0; >>> -} >> >> >> I think we should use a separate patch for this. > > For the vdpa-blk simulator I had the same issues and I'm adding a > .get_config_size() callback to vdpa devices. > > Do you think make sense or is better to remove this check in > vhost/vdpa, delegating the boundaries checks to get_config/set_config > callbacks. A question here. How much value could we gain from get_config_size() consider we can let vDPA parent to validate the length in its get_config(). Thanks > > Thanks, > Stefano > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-01-27 4:33 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-19 4:59 [RFC v3 00/11] Introduce VDUSE - vDPA Device in Userspace Xie Yongji 2021-01-19 4:59 ` [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases Xie Yongji 2021-01-20 4:24 ` Jason Wang 2021-01-20 4:24 ` Jason Wang 2021-01-20 6:52 ` Yongji Xie 2021-01-27 3:37 ` Jason Wang 2021-01-27 3:37 ` Jason Wang 2021-01-27 9:11 ` Yongji Xie 2021-01-28 3:04 ` Jason Wang 2021-01-28 3:04 ` Jason Wang 2021-01-28 3:08 ` Jens Axboe 2021-01-28 3:08 ` Jens Axboe 2021-01-28 5:12 ` Yongji Xie 2021-01-28 3:52 ` Yongji Xie 2021-01-28 4:31 ` Jason Wang 2021-01-28 4:31 ` Jason Wang 2021-01-28 6:08 ` Yongji Xie 2021-01-19 4:59 ` [RFC v3 02/11] eventfd: Increase the recursion depth of eventfd_signal() Xie Yongji 2021-01-19 4:59 ` [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices Xie Yongji 2021-01-20 3:46 ` Jason Wang 2021-01-20 3:46 ` Jason Wang 2021-01-20 6:46 ` Yongji Xie 2021-01-20 11:08 ` Stefano Garzarella 2021-01-20 11:08 ` Stefano Garzarella 2021-01-27 3:33 ` Jason Wang [this message] 2021-01-27 3:33 ` Jason Wang 2021-01-27 8:57 ` Stefano Garzarella 2021-01-27 8:57 ` Stefano Garzarella 2021-01-28 3:11 ` Jason Wang 2021-01-28 3:11 ` Jason Wang 2021-01-29 15:03 ` Stefano Garzarella 2021-01-30 11:33 ` Yongji Xie 2021-02-01 11:05 ` Stefano Garzarella 2021-02-01 11:05 ` Stefano Garzarella 2021-01-27 8:59 ` Stefano Garzarella 2021-01-27 8:59 ` Stefano Garzarella 2021-01-27 9:05 ` Yongji Xie 2021-01-19 4:59 ` [RFC v3 04/11] vhost-vdpa: protect concurrent access to vhost device iotlb Xie Yongji 2021-01-20 3:44 ` Jason Wang 2021-01-20 3:44 ` Jason Wang 2021-01-20 6:44 ` Yongji Xie 2021-01-19 4:59 ` [RFC v3 05/11] vdpa: shared virtual addressing support Xie Yongji 2021-01-20 5:55 ` Jason Wang 2021-01-20 5:55 ` Jason Wang 2021-01-20 7:10 ` Yongji Xie 2021-01-27 3:43 ` Jason Wang 2021-01-27 3:43 ` Jason Wang 2021-01-19 4:59 ` [RFC v3 06/11] vhost-vdpa: Add an opaque pointer for vhost IOTLB Xie Yongji 2021-01-20 6:24 ` Jason Wang 2021-01-20 6:24 ` Jason Wang 2021-01-20 7:52 ` Yongji Xie 2021-01-27 3:51 ` Jason Wang 2021-01-27 3:51 ` Jason Wang 2021-01-27 9:27 ` Yongji Xie 2021-01-19 5:07 ` [RFC v3 07/11] vdpa: Pass the netlink attributes to ops.dev_add() Xie Yongji 2021-01-19 5:07 ` [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace Xie Yongji 2021-01-19 14:53 ` Jonathan Corbet 2021-01-19 14:53 ` Jonathan Corbet 2021-01-20 2:25 ` Yongji Xie 2021-01-19 17:53 ` Randy Dunlap 2021-01-19 17:53 ` Randy Dunlap 2021-01-20 2:42 ` Yongji Xie 2021-01-26 8:08 ` Jason Wang 2021-01-26 8:08 ` Jason Wang 2021-01-27 8:50 ` Yongji Xie 2021-01-28 4:27 ` Jason Wang 2021-01-28 4:27 ` Jason Wang 2021-01-28 6:03 ` Yongji Xie 2021-01-28 6:14 ` Jason Wang 2021-01-28 6:14 ` Jason Wang 2021-01-28 6:43 ` Yongji Xie 2021-01-26 8:19 ` Jason Wang 2021-01-26 8:19 ` Jason Wang 2021-01-27 8:59 ` Yongji Xie 2021-01-19 5:07 ` [RFC v3 09/11] vduse: Add VDUSE_GET_DEV ioctl Xie Yongji 2021-01-19 5:07 ` [RFC v3 10/11] vduse: grab the module's references until there is no vduse device Xie Yongji 2021-01-26 8:09 ` Jason Wang 2021-01-26 8:09 ` Jason Wang 2021-01-27 8:51 ` Yongji Xie 2021-01-19 5:07 ` [RFC v3 11/11] vduse: Introduce a workqueue for irq injection Xie Yongji 2021-01-26 8:17 ` Jason Wang 2021-01-26 8:17 ` Jason Wang 2021-01-27 9:00 ` Yongji Xie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1979cffc-240e-a9f9-b0ab-84a1f82ac81e@redhat.com \ --to=jasowang@redhat.com \ --cc=axboe@kernel.dk \ --cc=bcrl@kvack.org \ --cc=bob.liu@oracle.com \ --cc=corbet@lwn.net \ --cc=hch@infradead.org \ --cc=kvm@vger.kernel.org \ --cc=linux-aio@kvack.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=parav@nvidia.com \ --cc=rdunlap@infradead.org \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=viro@zeniv.linux.org.uk \ --cc=virtualization@lists.linux-foundation.org \ --cc=willy@infradead.org \ --cc=xieyongji@bytedance.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.