From: Alex Bee <knaerzche@gmail.com> To: Ezequiel Garcia <ezequiel@collabora.com>, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Nicolas Dufresne <nicolas.dufresne@collabora.com> Cc: Hans Verkuil <hverkuil@xs4all.nl>, Philipp Zabel <p.zabel@pengutronix.de>, Heiko Stuebner <heiko@sntech.de>, maccraft123mc@gmail.com, Chris Healy <cphealy@gmail.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Jernej Skrabec <jernej.skrabec@siol.net>, Jonas Karlman <jonas@kwiboo.se>, Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>, kernel@collabora.com Subject: Re: [PATCH 09/12] media: hantro: Enable H.264 on Rockchip VDPU2 Date: Sat, 26 Jun 2021 10:33:53 +0200 [thread overview] Message-ID: <1979d843-129a-8b48-2926-0f50157974ec@gmail.com> (raw) In-Reply-To: <c882d9c4f9eacd9d0f82e6e4ce3b33c383087d8c.camel@collabora.com> Hi Ezequiel, Am 26.06.21 um 02:46 schrieb Ezequiel Garcia: > (Adding Nicolas) > > Hi Alex, > > On Fri, 2021-06-25 at 01:13 +0200, Alex Bee wrote: >> Hi Ezequiel, >> >> Am 24.06.21 um 20:26 schrieb Ezequiel Garcia: >>> Given H.264 support for VDPU2 was just added, let's enable it. >>> For now, this is only enabled on platform that don't have >>> an RKVDEC core, such as RK3328. >> Is there any reason, you do not want to enabe H.264 on RK3399? I know >> H.264 can be done by by rkvdec already, but from what I understand that >> shouldn't be an issue: The first decoder found that meets the >> requirements will be taken. >> > Thanks a lot the review. > > I really doubt userspace stacks are readily supporting that strategy. > > The first decoder device supporting the codec format will be selected, > I doubt features such as profile and levels are checked to decide > which decoder to use. > > I'd rather play safe on the kernel side and avoid offering > two competing devices for the same codec. I wasn't aware of that. Current ffmpeg v4l2_request implementation seems to not do VIDIOC_ENUM_FRAMESIZES - so we might end up being able to decode up to 1920x1088 only if hantro decoder is picked/checked first. Thanks for pointing that out. Alex > Kindly, > Ezequiel >
WARNING: multiple messages have this Message-ID (diff)
From: Alex Bee <knaerzche@gmail.com> To: Ezequiel Garcia <ezequiel@collabora.com>, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Nicolas Dufresne <nicolas.dufresne@collabora.com> Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Jernej Skrabec <jernej.skrabec@siol.net>, Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>, Hans Verkuil <hverkuil@xs4all.nl>, Thierry Reding <thierry.reding@gmail.com>, kernel@collabora.com, Sam Ravnborg <sam@ravnborg.org>, Chris Healy <cphealy@gmail.com>, maccraft123mc@gmail.com Subject: Re: [PATCH 09/12] media: hantro: Enable H.264 on Rockchip VDPU2 Date: Sat, 26 Jun 2021 10:33:53 +0200 [thread overview] Message-ID: <1979d843-129a-8b48-2926-0f50157974ec@gmail.com> (raw) In-Reply-To: <c882d9c4f9eacd9d0f82e6e4ce3b33c383087d8c.camel@collabora.com> Hi Ezequiel, Am 26.06.21 um 02:46 schrieb Ezequiel Garcia: > (Adding Nicolas) > > Hi Alex, > > On Fri, 2021-06-25 at 01:13 +0200, Alex Bee wrote: >> Hi Ezequiel, >> >> Am 24.06.21 um 20:26 schrieb Ezequiel Garcia: >>> Given H.264 support for VDPU2 was just added, let's enable it. >>> For now, this is only enabled on platform that don't have >>> an RKVDEC core, such as RK3328. >> Is there any reason, you do not want to enabe H.264 on RK3399? I know >> H.264 can be done by by rkvdec already, but from what I understand that >> shouldn't be an issue: The first decoder found that meets the >> requirements will be taken. >> > Thanks a lot the review. > > I really doubt userspace stacks are readily supporting that strategy. > > The first decoder device supporting the codec format will be selected, > I doubt features such as profile and levels are checked to decide > which decoder to use. > > I'd rather play safe on the kernel side and avoid offering > two competing devices for the same codec. I wasn't aware of that. Current ffmpeg v4l2_request implementation seems to not do VIDIOC_ENUM_FRAMESIZES - so we might end up being able to decode up to 1920x1088 only if hantro decoder is picked/checked first. Thanks for pointing that out. Alex > Kindly, > Ezequiel >
next prev parent reply other threads:[~2021-06-26 8:33 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-24 18:26 [PATCH 00/12] hantro: Enable H.264 VDPU2 (Odroid Advance Go) Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 01/12] drm/panel: kd35t133: Add panel orientation support Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 18:36 ` Heiko Stübner 2021-06-24 18:36 ` Heiko Stübner 2021-06-24 18:26 ` [PATCH 02/12] arm64: dts: rockchip: Add panel orientation to Odroid Go Advance Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 18:37 ` Heiko Stübner 2021-06-24 18:37 ` Heiko Stübner 2021-06-24 18:44 ` Ezequiel Garcia 2021-06-24 18:44 ` Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 03/12] hantro: vp8: Move noisy WARN_ON to vpu_debug Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 04/12] hantro: Make struct hantro_variant.init() optional Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 05/12] media: hantro: Avoid redundant hantro_get_{dst,src}_buf() calls Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 05/12] media: hantro: Avoid redundant hantro_get_{dst, src}_buf() calls Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 06/12] media: hantro: h264: Move DPB valid and long-term bitmaps Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 07/12] media: hantro: h264: Move reference picture number to a helper Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 08/12] media: hantro: Add H.264 support for Rockchip VDPU2 Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 09/12] media: hantro: Enable H.264 on " Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 23:13 ` Alex Bee 2021-06-24 23:13 ` Alex Bee 2021-06-26 0:46 ` Ezequiel Garcia 2021-06-26 0:46 ` Ezequiel Garcia 2021-06-26 8:33 ` Alex Bee [this message] 2021-06-26 8:33 ` Alex Bee 2021-06-29 12:28 ` Ezequiel Garcia 2021-06-29 12:28 ` Ezequiel Garcia 2021-06-30 11:36 ` Alex Bee 2021-06-30 11:36 ` Alex Bee 2021-06-24 18:26 ` [PATCH 10/12] dt-bindings: media: rockchip-vpu: Add PX30 compatible Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-25 9:21 ` Dafna Hirschfeld 2021-06-25 9:21 ` Dafna Hirschfeld 2021-06-26 0:47 ` Ezequiel Garcia 2021-06-26 0:47 ` Ezequiel Garcia 2021-06-26 8:49 ` Alex Bee 2021-06-26 8:49 ` Alex Bee 2021-06-24 18:26 ` [PATCH 11/12] arm64: dts: rockchip: Add VPU support for the PX30 Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 18:26 ` [PATCH 12/12] media: hantro: Add support for the Rockchip PX30 Ezequiel Garcia 2021-06-24 18:26 ` Ezequiel Garcia 2021-06-24 22:39 ` Alex Bee 2021-06-24 22:39 ` Alex Bee 2021-06-26 0:49 ` Ezequiel Garcia 2021-06-26 0:49 ` Ezequiel Garcia 2021-06-26 9:17 ` [PATCH 00/12] hantro: Enable H.264 VDPU2 (Odroid Advance Go) Alex Bee 2021-06-26 9:17 ` Alex Bee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1979d843-129a-8b48-2926-0f50157974ec@gmail.com \ --to=knaerzche@gmail.com \ --cc=airlied@linux.ie \ --cc=cphealy@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=ezequiel@collabora.com \ --cc=heiko@sntech.de \ --cc=hverkuil@xs4all.nl \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=kernel@collabora.com \ --cc=linux-media@vger.kernel.org \ --cc=maccraft123mc@gmail.com \ --cc=nicolas.dufresne@collabora.com \ --cc=p.zabel@pengutronix.de \ --cc=paul.kocialkowski@bootlin.com \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.