All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Wei Liu <liuw@liuw.name>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] libxl: basic support for virtio disk
Date: Wed, 1 Jun 2011 14:59:15 +0100	[thread overview]
Message-ID: <19942.17843.474817.123371@mariner.uk.xensource.com> (raw)
In-Reply-To: <BANLkTimiDzJLiM++TUR1ysksRjPYjBeu2Q@mail.gmail.com>

Wei Liu writes ("[Xen-devel] Re: [PATCH] libxl: basic support for virtio disk"):
> Revised patch.
> 
> Add code in libxl__device_disk_string_of_backend.
> 
> Upper limit of virtio disk follows scsi.

I'm not sure what you mean here.  Do you mean that Linux only supports
as many virtio disks as it supports scsi disks ?  Is this a
fundamental limitation of the virtio protocol ?

> +                else if (strncmp(disks[i].vdev, "vd", 2) == 0)
> +                    drive = libxl__sprintf
> +                        (gc, "file=%s,if=virtio,index=%d,media=disk,format=%s",
> +                         disks[i].pdev_path, disk, format);

Maybe I'm missing something but this seems not to use the partition
number at all ?

The existing code seems rather broken TBH.

Ian.

  reply	other threads:[~2011-06-01 13:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27  2:26 [PATCH] libxl: basic support for virtio disk Wei Liu
2011-05-27 12:26 ` Stefano Stabellini
2011-05-27 13:23   ` Wei Liu
2011-05-27 15:12     ` Stefano Stabellini
2011-05-30  3:10       ` Wei Liu
2011-05-31 11:37         ` Stefano Stabellini
2011-06-01 11:09           ` Wei Liu
2011-06-01 13:59             ` Ian Jackson [this message]
2011-06-01 14:51               ` Wei Liu
2011-06-02 15:04                 ` Stefano Stabellini
2011-06-02 16:03                   ` Ian Jackson
2011-06-02 16:10                     ` Stefano Stabellini
2011-06-03  1:22                     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19942.17843.474817.123371@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=liuw@liuw.name \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.