All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <liuw@liuw.name>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: Re: [PATCH] libxl: basic support for virtio disk
Date: Fri, 3 Jun 2011 09:22:52 +0800	[thread overview]
Message-ID: <BANLkTikqCyG75CVmMHY-4YtS-Z0KRhuErg@mail.gmail.com> (raw)
In-Reply-To: <19943.46165.598420.601751@mariner.uk.xensource.com>

On Fri, Jun 3, 2011 at 12:03 AM, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] Re: [PATCH] libxl: basic support for virtio disk"):
>> The limitation on the number of partitions is meaningless for virtio and
>> the limitation on the number of disks in arbitrary, as it is arbitrary
>> the current limitation on the number of scsi disks.
>
> So the code in libxl should accept any disk number that it can
> correctly format into an option to qemu, and allow qemu to deal with
> any resulting problems.
>
>> Device names like xvda1, xvda2, etc, are currently supported only with
>> PV guests.
>
> Currently the partition number is ignored.  Nonzero partitions should
> instead then be rejected.
>
>> There is no way to specify a single partition with HVM guests.
>> Considering that this patch is only meant for HVM guest, I think it is
>> correct to leave out the partition number.
>
> It should be checked, not ignored.
>
> Ian.
>

OK. Looks like the disk parsing code in libxl is going through a re-factoring.

I will get back to this patch when your re-factoring is done.

Wei.

      parent reply	other threads:[~2011-06-03  1:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27  2:26 [PATCH] libxl: basic support for virtio disk Wei Liu
2011-05-27 12:26 ` Stefano Stabellini
2011-05-27 13:23   ` Wei Liu
2011-05-27 15:12     ` Stefano Stabellini
2011-05-30  3:10       ` Wei Liu
2011-05-31 11:37         ` Stefano Stabellini
2011-06-01 11:09           ` Wei Liu
2011-06-01 13:59             ` Ian Jackson
2011-06-01 14:51               ` Wei Liu
2011-06-02 15:04                 ` Stefano Stabellini
2011-06-02 16:03                   ` Ian Jackson
2011-06-02 16:10                     ` Stefano Stabellini
2011-06-03  1:22                     ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikqCyG75CVmMHY-4YtS-Z0KRhuErg@mail.gmail.com \
    --to=liuw@liuw.name \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.