* ZRAM 3.10.6 Buffer I/O error
@ 2013-08-12 14:27 Jordi Pujol
2013-08-12 16:39 ` Thomas Backlund
0 siblings, 1 reply; 12+ messages in thread
From: Jordi Pujol @ 2013-08-12 14:27 UTC (permalink / raw)
To: Jiang Liu, linux-kernel
Hello,
zram shows an error when mounting a swap partition,
current version Linux kernel 3.10.6,
previous versions worked, I suppose that latest zram patches have some
problem,
machine is an AMD64 dual core, 4GB RAM
+ modprobe -qb zram num_devices=2
+ echo 104857600 > /sys/block/zram0/disksize
# mkswap /dev/zram0
Setting up swapspace version 1, size = 102396 KiB
no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
# pager /var/log/dmesg
(no more errors shown)
# swapon /dev/zram0
# pager /var/log/dmesg
...
[ 309.300479] Buffer I/O error on device zram0, logical block 25599
[ 309.300491] Buffer I/O error on device zram0, logical block 25599
[ 309.300514] Buffer I/O error on device zram0, logical block 25599
[ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
across:102396k SSFS
full log files and the kernel source are stored in the address:
http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
Kind regards,
Jordi Pujol
Live never ending Tale
GNU/Linux Live forever!
http://livenet.selfip.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-12 14:27 ZRAM 3.10.6 Buffer I/O error Jordi Pujol
@ 2013-08-12 16:39 ` Thomas Backlund
2013-08-13 1:39 ` Minchan Kim
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Thomas Backlund @ 2013-08-12 16:39 UTC (permalink / raw)
To: Jordi Pujol, stable; +Cc: Jiang Liu, linux-kernel
12.08.2013 17:27, Jordi Pujol skrev:
> Hello,
>
> zram shows an error when mounting a swap partition,
> current version Linux kernel 3.10.6,
> previous versions worked, I suppose that latest zram patches have some
> problem,
>
> machine is an AMD64 dual core, 4GB RAM
>
> + modprobe -qb zram num_devices=2
> + echo 104857600 > /sys/block/zram0/disksize
>
> # mkswap /dev/zram0
> Setting up swapspace version 1, size = 102396 KiB
> no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
>
> # pager /var/log/dmesg
> (no more errors shown)
>
> # swapon /dev/zram0
>
> # pager /var/log/dmesg
> ...
> [ 309.300479] Buffer I/O error on device zram0, logical block 25599
> [ 309.300491] Buffer I/O error on device zram0, logical block 25599
> [ 309.300514] Buffer I/O error on device zram0, logical block 25599
> [ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
> across:102396k SSFS
>
> full log files and the kernel source are stored in the address:
>
> http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
>
I think this one should fix it and belongs in 3.10 stable too:
From 75c7caf5a052ffd8db3312fa7864ee2d142890c4 Mon Sep 17 00:00:00 2001
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date: Sat, 22 Jun 2013 14:21:00 +0000
Subject: zram: allow request end to coincide with disksize
Pass valid_io_request() checks if request end coincides with disksize
(end equals bound), only fail if we attempt to read beyond the bound.
mkfs.ext2 produces numerous errors:
[ 2164.632747] quiet_error: 1 callbacks suppressed
[ 2164.633260] Buffer I/O error on device zram0, logical block 153599
[ 2164.633265] lost page write due to I/O error on zram0
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
diff --git a/drivers/staging/zram/zram_drv.c
b/drivers/staging/zram/zram_drv.c
index 7538774..82c7202 100644
--- a/drivers/staging/zram/zram_drv.c
+++ b/drivers/staging/zram/zram_drv.c
@@ -180,7 +180,7 @@ static inline int valid_io_request(struct zram
*zram, struct bio *bio)
end = start + (bio->bi_size >> SECTOR_SHIFT);
bound = zram->disksize >> SECTOR_SHIFT;
/* out of range range */
- if (unlikely(start >= bound || end >= bound || start > end))
+ if (unlikely(start >= bound || end > bound || start > end))
return 0;
/* I/O request is valid */
--
cgit v0.9.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-12 16:39 ` Thomas Backlund
@ 2013-08-13 1:39 ` Minchan Kim
2013-08-13 3:58 ` Greg Kroah-Hartman
2013-08-13 5:13 ` Jordi Pujol
` (2 subsequent siblings)
3 siblings, 1 reply; 12+ messages in thread
From: Minchan Kim @ 2013-08-13 1:39 UTC (permalink / raw)
To: Thomas Backlund
Cc: Jordi Pujol, stable, Jiang Liu, linux-kernel, Greg Kroah-Hartman
Hello,
On Mon, Aug 12, 2013 at 07:39:46PM +0300, Thomas Backlund wrote:
> 12.08.2013 17:27, Jordi Pujol skrev:
> >Hello,
> >
> >zram shows an error when mounting a swap partition,
> >current version Linux kernel 3.10.6,
> >previous versions worked, I suppose that latest zram patches have some
> >problem,
> >
> >machine is an AMD64 dual core, 4GB RAM
> >
> >+ modprobe -qb zram num_devices=2
> >+ echo 104857600 > /sys/block/zram0/disksize
> >
> ># mkswap /dev/zram0
> >Setting up swapspace version 1, size = 102396 KiB
> >no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
> >
> ># pager /var/log/dmesg
> >(no more errors shown)
> >
> ># swapon /dev/zram0
> >
> ># pager /var/log/dmesg
> >...
> >[ 309.300479] Buffer I/O error on device zram0, logical block 25599
> >[ 309.300491] Buffer I/O error on device zram0, logical block 25599
> >[ 309.300514] Buffer I/O error on device zram0, logical block 25599
> >[ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
> >across:102396k SSFS
> >
> >full log files and the kernel source are stored in the address:
> >
> >http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
> >
>
>
> I think this one should fix it and belongs in 3.10 stable too:
Very true. Let's Cc Greg, explicitely.
--
Kind regards,
Minchan Kim
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-13 1:39 ` Minchan Kim
@ 2013-08-13 3:58 ` Greg Kroah-Hartman
2013-08-13 4:33 ` Minchan Kim
0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2013-08-13 3:58 UTC (permalink / raw)
To: Minchan Kim; +Cc: Thomas Backlund, Jordi Pujol, stable, Jiang Liu, linux-kernel
On Tue, Aug 13, 2013 at 10:39:00AM +0900, Minchan Kim wrote:
> Hello,
>
> On Mon, Aug 12, 2013 at 07:39:46PM +0300, Thomas Backlund wrote:
> > 12.08.2013 17:27, Jordi Pujol skrev:
> > >Hello,
> > >
> > >zram shows an error when mounting a swap partition,
> > >current version Linux kernel 3.10.6,
> > >previous versions worked, I suppose that latest zram patches have some
> > >problem,
> > >
> > >machine is an AMD64 dual core, 4GB RAM
> > >
> > >+ modprobe -qb zram num_devices=2
> > >+ echo 104857600 > /sys/block/zram0/disksize
> > >
> > ># mkswap /dev/zram0
> > >Setting up swapspace version 1, size = 102396 KiB
> > >no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
> > >
> > ># pager /var/log/dmesg
> > >(no more errors shown)
> > >
> > ># swapon /dev/zram0
> > >
> > ># pager /var/log/dmesg
> > >...
> > >[ 309.300479] Buffer I/O error on device zram0, logical block 25599
> > >[ 309.300491] Buffer I/O error on device zram0, logical block 25599
> > >[ 309.300514] Buffer I/O error on device zram0, logical block 25599
> > >[ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
> > >across:102396k SSFS
> > >
> > >full log files and the kernel source are stored in the address:
> > >
> > >http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
> > >
> >
> >
> > I think this one should fix it and belongs in 3.10 stable too:
>
> Very true. Let's Cc Greg, explicitely.
-ENOCONTEXT
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-13 3:58 ` Greg Kroah-Hartman
@ 2013-08-13 4:33 ` Minchan Kim
2013-08-13 5:01 ` Thomas Backlund
0 siblings, 1 reply; 12+ messages in thread
From: Minchan Kim @ 2013-08-13 4:33 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Thomas Backlund, Jordi Pujol, stable, Jiang Liu, linux-kernel
Hello Greg,
On Mon, Aug 12, 2013 at 08:58:02PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2013 at 10:39:00AM +0900, Minchan Kim wrote:
> > Hello,
> >
> > On Mon, Aug 12, 2013 at 07:39:46PM +0300, Thomas Backlund wrote:
> > > 12.08.2013 17:27, Jordi Pujol skrev:
> > > >Hello,
> > > >
> > > >zram shows an error when mounting a swap partition,
> > > >current version Linux kernel 3.10.6,
> > > >previous versions worked, I suppose that latest zram patches have some
> > > >problem,
> > > >
> > > >machine is an AMD64 dual core, 4GB RAM
> > > >
> > > >+ modprobe -qb zram num_devices=2
> > > >+ echo 104857600 > /sys/block/zram0/disksize
> > > >
> > > ># mkswap /dev/zram0
> > > >Setting up swapspace version 1, size = 102396 KiB
> > > >no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
> > > >
> > > ># pager /var/log/dmesg
> > > >(no more errors shown)
> > > >
> > > ># swapon /dev/zram0
> > > >
> > > ># pager /var/log/dmesg
> > > >...
> > > >[ 309.300479] Buffer I/O error on device zram0, logical block 25599
> > > >[ 309.300491] Buffer I/O error on device zram0, logical block 25599
> > > >[ 309.300514] Buffer I/O error on device zram0, logical block 25599
> > > >[ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
> > > >across:102396k SSFS
> > > >
> > > >full log files and the kernel source are stored in the address:
> > > >
> > > >http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
> > > >
> > >
> > >
> > > I think this one should fix it and belongs in 3.10 stable too:
> >
> > Very true. Let's Cc Greg, explicitely.
>
> -ENOCONTEXT
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/staging/zram?id=75c7caf5a052ffd8db3312fa7864ee2d142890c4
It seems you already merge "zram:allow request end to conincide with disksize" to stable.
So there is no concern any more.
Thanks.
--
Kind regards,
Minchan Kim
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-13 4:33 ` Minchan Kim
@ 2013-08-13 5:01 ` Thomas Backlund
2013-08-13 5:18 ` Minchan Kim
0 siblings, 1 reply; 12+ messages in thread
From: Thomas Backlund @ 2013-08-13 5:01 UTC (permalink / raw)
To: Minchan Kim
Cc: Greg Kroah-Hartman, Jordi Pujol, stable, Jiang Liu, linux-kernel
Minchan Kim skrev 13.8.2013 07:33:
> Hello Greg,
>
> On Mon, Aug 12, 2013 at 08:58:02PM -0700, Greg Kroah-Hartman wrote:
>> On Tue, Aug 13, 2013 at 10:39:00AM +0900, Minchan Kim wrote:
>>> Hello,
>>>
>>> On Mon, Aug 12, 2013 at 07:39:46PM +0300, Thomas Backlund wrote:
>>>> 12.08.2013 17:27, Jordi Pujol skrev:
>>>>> Hello,
>>>>>
>>>>> zram shows an error when mounting a swap partition,
>>>>> current version Linux kernel 3.10.6,
>>>>> previous versions worked, I suppose that latest zram patches have some
>>>>> problem,
>>>>>
>>>>> machine is an AMD64 dual core, 4GB RAM
>>>>>
>>>>> + modprobe -qb zram num_devices=2
>>>>> + echo 104857600 > /sys/block/zram0/disksize
>>>>>
>>>>> # mkswap /dev/zram0
>>>>> Setting up swapspace version 1, size = 102396 KiB
>>>>> no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
>>>>>
>>>>> # pager /var/log/dmesg
>>>>> (no more errors shown)
>>>>>
>>>>> # swapon /dev/zram0
>>>>>
>>>>> # pager /var/log/dmesg
>>>>> ...
>>>>> [ 309.300479] Buffer I/O error on device zram0, logical block 25599
>>>>> [ 309.300491] Buffer I/O error on device zram0, logical block 25599
>>>>> [ 309.300514] Buffer I/O error on device zram0, logical block 25599
>>>>> [ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
>>>>> across:102396k SSFS
>>>>>
>>>>> full log files and the kernel source are stored in the address:
>>>>>
>>>>> http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
>>>>>
>>>>
>>>>
>>>> I think this one should fix it and belongs in 3.10 stable too:
>>>
>>> Very true. Let's Cc Greg, explicitely.
>>
>> -ENOCONTEXT
>
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/staging/zram?id=75c7caf5a052ffd8db3312fa7864ee2d142890c4
>
> It seems you already merge "zram:allow request end to conincide with disksize" to stable.
> So there is no concern any more.
Nope...
thats master branch wich tracks upstream tree...
it's not in the 3.10 stable as of 3.10.6 (or current stable queue)
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/drivers/staging/zram?h=linux-3.10.y
--
Thomas
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-12 16:39 ` Thomas Backlund
2013-08-13 1:39 ` Minchan Kim
@ 2013-08-13 5:13 ` Jordi Pujol
2013-08-13 5:47 ` Greg KH
2013-08-13 11:07 ` Luis Henriques
3 siblings, 0 replies; 12+ messages in thread
From: Jordi Pujol @ 2013-08-13 5:13 UTC (permalink / raw)
To: Thomas Backlund; +Cc: stable, Jiang Liu, linux-kernel
El Dilluns, 12 d'agost de 2013, a les 19:39:46, Thomas Backlund va escriure:
> /* out of range range */
> - if (unlikely(start >= bound || end >= bound || start > end))
> + if (unlikely(start >= bound || end > bound || start > end))
> return 0;
>
OK, I confirm that this change solves the problem
Thanks,
Jordi Pujol
Live never ending Tale
GNU/Linux Live forever!
http://livenet.selfip.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-13 5:01 ` Thomas Backlund
@ 2013-08-13 5:18 ` Minchan Kim
2013-08-13 5:47 ` Greg Kroah-Hartman
0 siblings, 1 reply; 12+ messages in thread
From: Minchan Kim @ 2013-08-13 5:18 UTC (permalink / raw)
To: Thomas Backlund
Cc: Greg Kroah-Hartman, Jordi Pujol, stable, Jiang Liu, linux-kernel
On Tue, Aug 13, 2013 at 08:01:11AM +0300, Thomas Backlund wrote:
> Minchan Kim skrev 13.8.2013 07:33:
> >Hello Greg,
> >
> >On Mon, Aug 12, 2013 at 08:58:02PM -0700, Greg Kroah-Hartman wrote:
> >>On Tue, Aug 13, 2013 at 10:39:00AM +0900, Minchan Kim wrote:
> >>>Hello,
> >>>
> >>>On Mon, Aug 12, 2013 at 07:39:46PM +0300, Thomas Backlund wrote:
> >>>>12.08.2013 17:27, Jordi Pujol skrev:
> >>>>>Hello,
> >>>>>
> >>>>>zram shows an error when mounting a swap partition,
> >>>>>current version Linux kernel 3.10.6,
> >>>>>previous versions worked, I suppose that latest zram patches have some
> >>>>>problem,
> >>>>>
> >>>>>machine is an AMD64 dual core, 4GB RAM
> >>>>>
> >>>>>+ modprobe -qb zram num_devices=2
> >>>>>+ echo 104857600 > /sys/block/zram0/disksize
> >>>>>
> >>>>># mkswap /dev/zram0
> >>>>>Setting up swapspace version 1, size = 102396 KiB
> >>>>>no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
> >>>>>
> >>>>># pager /var/log/dmesg
> >>>>>(no more errors shown)
> >>>>>
> >>>>># swapon /dev/zram0
> >>>>>
> >>>>># pager /var/log/dmesg
> >>>>>...
> >>>>>[ 309.300479] Buffer I/O error on device zram0, logical block 25599
> >>>>>[ 309.300491] Buffer I/O error on device zram0, logical block 25599
> >>>>>[ 309.300514] Buffer I/O error on device zram0, logical block 25599
> >>>>>[ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
> >>>>>across:102396k SSFS
> >>>>>
> >>>>>full log files and the kernel source are stored in the address:
> >>>>>
> >>>>>http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
> >>>>>
> >>>>
> >>>>
> >>>>I think this one should fix it and belongs in 3.10 stable too:
> >>>
> >>>Very true. Let's Cc Greg, explicitely.
> >>
> >>-ENOCONTEXT
> >
> >https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/staging/zram?id=75c7caf5a052ffd8db3312fa7864ee2d142890c4
> >
> >It seems you already merge "zram:allow request end to conincide with disksize" to stable.
> >So there is no concern any more.
>
> Nope...
>
> thats master branch wich tracks upstream tree...
>
> it's not in the 3.10 stable as of 3.10.6 (or current stable queue)
>
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/drivers/staging/zram?h=linux-3.10.y
Okay, Then, we should explain it to Greg.
While Jiang was fixing a BUG A with [1], [1] made another BUG B.
So, Sergey fixed BUG B with [2]. But unfortunately, [1] was in stable
now but [2] wasn't so [2] should go to the stable to fix BUG B.
[1] 12a7ad3b8, zram: avoid access beyond the zram device
[2] 75c7caf5a, zram: allow request end to coincide with disksize
>
> --
>
> Thomas
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Kind regards,
Minchan Kim
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-13 5:18 ` Minchan Kim
@ 2013-08-13 5:47 ` Greg Kroah-Hartman
2013-08-13 6:03 ` Minchan Kim
0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2013-08-13 5:47 UTC (permalink / raw)
To: Minchan Kim; +Cc: Thomas Backlund, Jordi Pujol, stable, Jiang Liu, linux-kernel
On Tue, Aug 13, 2013 at 02:18:29PM +0900, Minchan Kim wrote:
> On Tue, Aug 13, 2013 at 08:01:11AM +0300, Thomas Backlund wrote:
> > Minchan Kim skrev 13.8.2013 07:33:
> > >Hello Greg,
> > >
> > >On Mon, Aug 12, 2013 at 08:58:02PM -0700, Greg Kroah-Hartman wrote:
> > >>On Tue, Aug 13, 2013 at 10:39:00AM +0900, Minchan Kim wrote:
> > >>>Hello,
> > >>>
> > >>>On Mon, Aug 12, 2013 at 07:39:46PM +0300, Thomas Backlund wrote:
> > >>>>12.08.2013 17:27, Jordi Pujol skrev:
> > >>>>>Hello,
> > >>>>>
> > >>>>>zram shows an error when mounting a swap partition,
> > >>>>>current version Linux kernel 3.10.6,
> > >>>>>previous versions worked, I suppose that latest zram patches have some
> > >>>>>problem,
> > >>>>>
> > >>>>>machine is an AMD64 dual core, 4GB RAM
> > >>>>>
> > >>>>>+ modprobe -qb zram num_devices=2
> > >>>>>+ echo 104857600 > /sys/block/zram0/disksize
> > >>>>>
> > >>>>># mkswap /dev/zram0
> > >>>>>Setting up swapspace version 1, size = 102396 KiB
> > >>>>>no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
> > >>>>>
> > >>>>># pager /var/log/dmesg
> > >>>>>(no more errors shown)
> > >>>>>
> > >>>>># swapon /dev/zram0
> > >>>>>
> > >>>>># pager /var/log/dmesg
> > >>>>>...
> > >>>>>[ 309.300479] Buffer I/O error on device zram0, logical block 25599
> > >>>>>[ 309.300491] Buffer I/O error on device zram0, logical block 25599
> > >>>>>[ 309.300514] Buffer I/O error on device zram0, logical block 25599
> > >>>>>[ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
> > >>>>>across:102396k SSFS
> > >>>>>
> > >>>>>full log files and the kernel source are stored in the address:
> > >>>>>
> > >>>>>http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
> > >>>>>
> > >>>>
> > >>>>
> > >>>>I think this one should fix it and belongs in 3.10 stable too:
> > >>>
> > >>>Very true. Let's Cc Greg, explicitely.
> > >>
> > >>-ENOCONTEXT
> > >
> > >https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/staging/zram?id=75c7caf5a052ffd8db3312fa7864ee2d142890c4
> > >
> > >It seems you already merge "zram:allow request end to conincide with disksize" to stable.
> > >So there is no concern any more.
> >
> > Nope...
> >
> > thats master branch wich tracks upstream tree...
> >
> > it's not in the 3.10 stable as of 3.10.6 (or current stable queue)
> >
> > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/drivers/staging/zram?h=linux-3.10.y
>
> Okay, Then, we should explain it to Greg.
>
> While Jiang was fixing a BUG A with [1], [1] made another BUG B.
> So, Sergey fixed BUG B with [2]. But unfortunately, [1] was in stable
> now but [2] wasn't so [2] should go to the stable to fix BUG B.
>
> [1] 12a7ad3b8, zram: avoid access beyond the zram device
> [2] 75c7caf5a, zram: allow request end to coincide with disksize
Ok, but that's what Thomas's original email to stable@vger.kernel.org
asked for, to apply the 2nd patch above to the stable tree, which I've
already done...
Emailing me directly, with half-of-a-thread causes me nothing but
confusion, as I'm sure you can imagine.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-12 16:39 ` Thomas Backlund
2013-08-13 1:39 ` Minchan Kim
2013-08-13 5:13 ` Jordi Pujol
@ 2013-08-13 5:47 ` Greg KH
2013-08-13 11:07 ` Luis Henriques
3 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2013-08-13 5:47 UTC (permalink / raw)
To: Thomas Backlund; +Cc: Jordi Pujol, stable, Jiang Liu, linux-kernel
On Mon, Aug 12, 2013 at 07:39:46PM +0300, Thomas Backlund wrote:
> 12.08.2013 17:27, Jordi Pujol skrev:
> > Hello,
> >
> > zram shows an error when mounting a swap partition,
> > current version Linux kernel 3.10.6,
> > previous versions worked, I suppose that latest zram patches have some
> > problem,
> >
> > machine is an AMD64 dual core, 4GB RAM
> >
> > + modprobe -qb zram num_devices=2
> > + echo 104857600 > /sys/block/zram0/disksize
> >
> > # mkswap /dev/zram0
> > Setting up swapspace version 1, size = 102396 KiB
> > no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
> >
> > # pager /var/log/dmesg
> > (no more errors shown)
> >
> > # swapon /dev/zram0
> >
> > # pager /var/log/dmesg
> > ...
> > [ 309.300479] Buffer I/O error on device zram0, logical block 25599
> > [ 309.300491] Buffer I/O error on device zram0, logical block 25599
> > [ 309.300514] Buffer I/O error on device zram0, logical block 25599
> > [ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
> > across:102396k SSFS
> >
> > full log files and the kernel source are stored in the address:
> >
> > http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
> >
>
>
> I think this one should fix it and belongs in 3.10 stable too:
>
> From 75c7caf5a052ffd8db3312fa7864ee2d142890c4 Mon Sep 17 00:00:00 2001
> From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Date: Sat, 22 Jun 2013 14:21:00 +0000
> Subject: zram: allow request end to coincide with disksize
Now applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-13 5:47 ` Greg Kroah-Hartman
@ 2013-08-13 6:03 ` Minchan Kim
0 siblings, 0 replies; 12+ messages in thread
From: Minchan Kim @ 2013-08-13 6:03 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Thomas Backlund, Jordi Pujol, stable, Jiang Liu, linux-kernel
On Mon, Aug 12, 2013 at 10:47:12PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2013 at 02:18:29PM +0900, Minchan Kim wrote:
> > On Tue, Aug 13, 2013 at 08:01:11AM +0300, Thomas Backlund wrote:
> > > Minchan Kim skrev 13.8.2013 07:33:
> > > >Hello Greg,
> > > >
> > > >On Mon, Aug 12, 2013 at 08:58:02PM -0700, Greg Kroah-Hartman wrote:
> > > >>On Tue, Aug 13, 2013 at 10:39:00AM +0900, Minchan Kim wrote:
> > > >>>Hello,
> > > >>>
> > > >>>On Mon, Aug 12, 2013 at 07:39:46PM +0300, Thomas Backlund wrote:
> > > >>>>12.08.2013 17:27, Jordi Pujol skrev:
> > > >>>>>Hello,
> > > >>>>>
> > > >>>>>zram shows an error when mounting a swap partition,
> > > >>>>>current version Linux kernel 3.10.6,
> > > >>>>>previous versions worked, I suppose that latest zram patches have some
> > > >>>>>problem,
> > > >>>>>
> > > >>>>>machine is an AMD64 dual core, 4GB RAM
> > > >>>>>
> > > >>>>>+ modprobe -qb zram num_devices=2
> > > >>>>>+ echo 104857600 > /sys/block/zram0/disksize
> > > >>>>>
> > > >>>>># mkswap /dev/zram0
> > > >>>>>Setting up swapspace version 1, size = 102396 KiB
> > > >>>>>no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
> > > >>>>>
> > > >>>>># pager /var/log/dmesg
> > > >>>>>(no more errors shown)
> > > >>>>>
> > > >>>>># swapon /dev/zram0
> > > >>>>>
> > > >>>>># pager /var/log/dmesg
> > > >>>>>...
> > > >>>>>[ 309.300479] Buffer I/O error on device zram0, logical block 25599
> > > >>>>>[ 309.300491] Buffer I/O error on device zram0, logical block 25599
> > > >>>>>[ 309.300514] Buffer I/O error on device zram0, logical block 25599
> > > >>>>>[ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
> > > >>>>>across:102396k SSFS
> > > >>>>>
> > > >>>>>full log files and the kernel source are stored in the address:
> > > >>>>>
> > > >>>>>http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
> > > >>>>>
> > > >>>>
> > > >>>>
> > > >>>>I think this one should fix it and belongs in 3.10 stable too:
> > > >>>
> > > >>>Very true. Let's Cc Greg, explicitely.
> > > >>
> > > >>-ENOCONTEXT
> > > >
> > > >https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/staging/zram?id=75c7caf5a052ffd8db3312fa7864ee2d142890c4
> > > >
> > > >It seems you already merge "zram:allow request end to conincide with disksize" to stable.
> > > >So there is no concern any more.
> > >
> > > Nope...
> > >
> > > thats master branch wich tracks upstream tree...
> > >
> > > it's not in the 3.10 stable as of 3.10.6 (or current stable queue)
> > >
> > > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/drivers/staging/zram?h=linux-3.10.y
> >
> > Okay, Then, we should explain it to Greg.
> >
> > While Jiang was fixing a BUG A with [1], [1] made another BUG B.
> > So, Sergey fixed BUG B with [2]. But unfortunately, [1] was in stable
> > now but [2] wasn't so [2] should go to the stable to fix BUG B.
> >
> > [1] 12a7ad3b8, zram: avoid access beyond the zram device
> > [2] 75c7caf5a, zram: allow request end to coincide with disksize
>
> Ok, but that's what Thomas's original email to stable@vger.kernel.org
> asked for, to apply the 2nd patch above to the stable tree, which I've
> already done...
>
> Emailing me directly, with half-of-a-thread causes me nothing but
> confusion, as I'm sure you can imagine.
Sorry for the noise and I will keep in mind.
Thanks!
--
Kind regards,
Minchan Kim
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ZRAM 3.10.6 Buffer I/O error
2013-08-12 16:39 ` Thomas Backlund
` (2 preceding siblings ...)
2013-08-13 5:47 ` Greg KH
@ 2013-08-13 11:07 ` Luis Henriques
3 siblings, 0 replies; 12+ messages in thread
From: Luis Henriques @ 2013-08-13 11:07 UTC (permalink / raw)
To: Thomas Backlund; +Cc: Jordi Pujol, stable, Jiang Liu, linux-kernel
Thomas Backlund <tmb@mageia.org> writes:
> 12.08.2013 17:27, Jordi Pujol skrev:
>> Hello,
>>
>> zram shows an error when mounting a swap partition,
>> current version Linux kernel 3.10.6,
>> previous versions worked, I suppose that latest zram patches have some
>> problem,
>>
>> machine is an AMD64 dual core, 4GB RAM
>>
>> + modprobe -qb zram num_devices=2
>> + echo 104857600 > /sys/block/zram0/disksize
>>
>> # mkswap /dev/zram0
>> Setting up swapspace version 1, size = 102396 KiB
>> no label, UUID=6c249930-2ba0-46cf-a8c6-766481942b7d
>>
>> # pager /var/log/dmesg
>> (no more errors shown)
>>
>> # swapon /dev/zram0
>>
>> # pager /var/log/dmesg
>> ...
>> [ 309.300479] Buffer I/O error on device zram0, logical block 25599
>> [ 309.300491] Buffer I/O error on device zram0, logical block 25599
>> [ 309.300514] Buffer I/O error on device zram0, logical block 25599
>> [ 345.205887] Adding 102396k swap on /dev/zram0. Priority:-2 extents:1
>> across:102396k SSFS
>>
>> full log files and the kernel source are stored in the address:
>>
>> http://livenet.selfip.com/ftp/debian/zram_3.10.6_IO_error/
>>
>
>
> I think this one should fix it and belongs in 3.10 stable too:
>
> From 75c7caf5a052ffd8db3312fa7864ee2d142890c4 Mon Sep 17 00:00:00 2001
> From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Date: Sat, 22 Jun 2013 14:21:00 +0000
> Subject: zram: allow request end to coincide with disksize
>
> Pass valid_io_request() checks if request end coincides with disksize
> (end equals bound), only fail if we attempt to read beyond the bound.
>
> mkfs.ext2 produces numerous errors:
> [ 2164.632747] quiet_error: 1 callbacks suppressed
> [ 2164.633260] Buffer I/O error on device zram0, logical block 153599
> [ 2164.633265] lost page write due to I/O error on zram0
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
> index 7538774..82c7202 100644
> --- a/drivers/staging/zram/zram_drv.c
> +++ b/drivers/staging/zram/zram_drv.c
> @@ -180,7 +180,7 @@ static inline int valid_io_request(struct zram *zram, struct
> bio *bio)
> end = start + (bio->bi_size >> SECTOR_SHIFT);
> bound = zram->disksize >> SECTOR_SHIFT;
> /* out of range range */
> - if (unlikely(start >= bound || end >= bound || start > end))
> + if (unlikely(start >= bound || end > bound || start > end))
> return 0;
>
> /* I/O request is valid */
> --
> cgit v0.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
I believe this patch should be applied to other stable trees that also
contain commit 12a7ad3b810e77137d0caf97a6dd97591e075b30 ("zram: avoid
access beyond the zram device"). I'm queuing it for the 3.5 kernel.
Cheers,
--
Luis
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-08-13 11:07 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-12 14:27 ZRAM 3.10.6 Buffer I/O error Jordi Pujol
2013-08-12 16:39 ` Thomas Backlund
2013-08-13 1:39 ` Minchan Kim
2013-08-13 3:58 ` Greg Kroah-Hartman
2013-08-13 4:33 ` Minchan Kim
2013-08-13 5:01 ` Thomas Backlund
2013-08-13 5:18 ` Minchan Kim
2013-08-13 5:47 ` Greg Kroah-Hartman
2013-08-13 6:03 ` Minchan Kim
2013-08-13 5:13 ` Jordi Pujol
2013-08-13 5:47 ` Greg KH
2013-08-13 11:07 ` Luis Henriques
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.