* [Patchv2 0/8] DSPBRIDGE: typedef cleanup
@ 2010-02-06 1:21 Hebbar, Shivananda
2010-02-06 9:22 ` Andy Shevchenko
2010-02-24 2:11 ` Omar Ramirez Luna
0 siblings, 2 replies; 4+ messages in thread
From: Hebbar, Shivananda @ 2010-02-06 1:21 UTC (permalink / raw)
To: linux-omap
Resending the patches after updating review comments and also
Fixing some compilation breaks.
These patches remove the typedefs and replace it with normal C types:
Shivananda Hebbar (8)
DSPBRIDGE: typedef cleanup -DSP RTOS
DSPBRIDGE: typedef cleanup -PROCTYPE
DSPBRIDGE: typedef cleanup -PROCFAMILY
DSPBRIDGE: typedef cleanup -DSP_HSTREAM
DSPBRIDGE: typedef cleanup -DSP_HPROCESSOR
DSPBRIDGE: typedef cleanup -DSP_HNODE
DSPBRIDGE: typedef cleanup -BRD_STATUS
DSPBRIDGE: typedef cleanup -CHNL_MODE
arch/arm/plat-omap/include/dspbridge/brddefs.h | 1 -
arch/arm/plat-omap/include/dspbridge/chnldefs.h | 2 -
arch/arm/plat-omap/include/dspbridge/cmm.h | 2 +-
arch/arm/plat-omap/include/dspbridge/dbdefs.h | 18 +---
arch/arm/plat-omap/include/dspbridge/dispdefs.h | 4 +-
arch/arm/plat-omap/include/dspbridge/dmm.h | 2 +-
arch/arm/plat-omap/include/dspbridge/drv.h | 6 +-
arch/arm/plat-omap/include/dspbridge/node.h | 4 +-
arch/arm/plat-omap/include/dspbridge/proc.h | 43 +++++-----
arch/arm/plat-omap/include/dspbridge/wcdioctl.h | 96 +++++++++++-----------
arch/arm/plat-omap/include/dspbridge/wmd.h | 4 +-
arch/arm/plat-omap/include/dspbridge/wmdchnl.h | 2 +-
drivers/dsp/bridge/pmgr/cmm.c | 2 +-
drivers/dsp/bridge/pmgr/dev.c | 6 +-
drivers/dsp/bridge/pmgr/dmm.c | 2 +-
drivers/dsp/bridge/pmgr/wcd.c | 4 +-
drivers/dsp/bridge/rmgr/node.c | 12 ++--
drivers/dsp/bridge/rmgr/proc.c | 56 +++++++-------
drivers/dsp/bridge/rmgr/strm.c | 2 +-
drivers/dsp/bridge/wmd/chnl_sm.c | 8 +-
drivers/dsp/bridge/wmd/tiomap3430.c | 4 +-
21 files changed, 134 insertions(+), 146 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patchv2 0/8] DSPBRIDGE: typedef cleanup
2010-02-06 1:21 [Patchv2 0/8] DSPBRIDGE: typedef cleanup Hebbar, Shivananda
@ 2010-02-06 9:22 ` Andy Shevchenko
2010-02-12 17:54 ` Hebbar, Shivananda
2010-02-24 2:11 ` Omar Ramirez Luna
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2010-02-06 9:22 UTC (permalink / raw)
To: Hebbar, Shivananda; +Cc: linux-omap
On Sat, Feb 6, 2010 at 3:21 AM, Hebbar, Shivananda <x0hebbar@ti.com> wrote:
> Resending the patches after updating review comments and also
> Fixing some compilation breaks.
Sorry for late question, however, I fully agree with HANDLE -> void *,
but why u32 is not normal type for those changes? What do I miss?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [Patchv2 0/8] DSPBRIDGE: typedef cleanup
2010-02-06 9:22 ` Andy Shevchenko
@ 2010-02-12 17:54 ` Hebbar, Shivananda
0 siblings, 0 replies; 4+ messages in thread
From: Hebbar, Shivananda @ 2010-02-12 17:54 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-omap
> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Saturday, February 06, 2010 3:23 AM
> To: Hebbar, Shivananda
> Cc: linux-omap
> Subject: Re: [Patchv2 0/8] DSPBRIDGE: typedef cleanup
>
> On Sat, Feb 6, 2010 at 3:21 AM, Hebbar, Shivananda <x0hebbar@ti.com>
> wrote:
> > Resending the patches after updating review comments and also
> > Fixing some compilation breaks.
>
> Sorry for late question, however, I fully agree with HANDLE -> void *,
> but why u32 is not normal type for those changes? What do I miss?
>
The idea was to remove typedef and while doing so thought int is sufficient to represent the DSPRTOS type hence changed it from u32 to int.
I agree that u32 is a normal type.
--Shivananda
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patchv2 0/8] DSPBRIDGE: typedef cleanup
2010-02-06 1:21 [Patchv2 0/8] DSPBRIDGE: typedef cleanup Hebbar, Shivananda
2010-02-06 9:22 ` Andy Shevchenko
@ 2010-02-24 2:11 ` Omar Ramirez Luna
1 sibling, 0 replies; 4+ messages in thread
From: Omar Ramirez Luna @ 2010-02-24 2:11 UTC (permalink / raw)
To: Hebbar, Shivananda; +Cc: linux-omap, Bhavin Shah, Menon, Nishanth
On 2/5/2010 7:21 PM, Hebbar, Shivananda wrote:
> Resending the patches after updating review comments and also
> Fixing some compilation breaks.
>
> These patches remove the typedefs and replace it with normal C types:
>
> Shivananda Hebbar (8)
>
> DSPBRIDGE: typedef cleanup -DSP RTOS
> DSPBRIDGE: typedef cleanup -PROCTYPE
> DSPBRIDGE: typedef cleanup -PROCFAMILY
> DSPBRIDGE: typedef cleanup -DSP_HSTREAM
> DSPBRIDGE: typedef cleanup -DSP_HPROCESSOR
> DSPBRIDGE: typedef cleanup -DSP_HNODE
> DSPBRIDGE: typedef cleanup -BRD_STATUS
> DSPBRIDGE: typedef cleanup -CHNL_MODE
>
> arch/arm/plat-omap/include/dspbridge/brddefs.h | 1 -
> arch/arm/plat-omap/include/dspbridge/chnldefs.h | 2 -
> arch/arm/plat-omap/include/dspbridge/cmm.h | 2 +-
> arch/arm/plat-omap/include/dspbridge/dbdefs.h | 18 +---
> arch/arm/plat-omap/include/dspbridge/dispdefs.h | 4 +-
> arch/arm/plat-omap/include/dspbridge/dmm.h | 2 +-
> arch/arm/plat-omap/include/dspbridge/drv.h | 6 +-
> arch/arm/plat-omap/include/dspbridge/node.h | 4 +-
> arch/arm/plat-omap/include/dspbridge/proc.h | 43 +++++-----
> arch/arm/plat-omap/include/dspbridge/wcdioctl.h | 96 +++++++++++-----------
> arch/arm/plat-omap/include/dspbridge/wmd.h | 4 +-
> arch/arm/plat-omap/include/dspbridge/wmdchnl.h | 2 +-
> drivers/dsp/bridge/pmgr/cmm.c | 2 +-
> drivers/dsp/bridge/pmgr/dev.c | 6 +-
> drivers/dsp/bridge/pmgr/dmm.c | 2 +-
> drivers/dsp/bridge/pmgr/wcd.c | 4 +-
> drivers/dsp/bridge/rmgr/node.c | 12 ++--
> drivers/dsp/bridge/rmgr/proc.c | 56 +++++++-------
> drivers/dsp/bridge/rmgr/strm.c | 2 +-
> drivers/dsp/bridge/wmd/chnl_sm.c | 8 +-
> drivers/dsp/bridge/wmd/tiomap3430.c | 4 +-
> 21 files changed, 134 insertions(+), 146 deletions(-)
> --
Patch 5 had lots of checkpatch errors, I understand that they were there
before but would be good if they are fixed when touching those lines
(btw they were fixed). For this patch only one "suspect code indent" is
still there because of the original code, it can't be fixed without
changing a big chunk of the file so leaving it as it is (will be
addressed by lindent)
Pushed to dspbridge
- omar
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-02-24 2:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-06 1:21 [Patchv2 0/8] DSPBRIDGE: typedef cleanup Hebbar, Shivananda
2010-02-06 9:22 ` Andy Shevchenko
2010-02-12 17:54 ` Hebbar, Shivananda
2010-02-24 2:11 ` Omar Ramirez Luna
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.