* Re: [PATCH] imx: drop CONFIG_MXC_UART_BASE
2022-04-29 13:10 [PATCH] imx: drop CONFIG_MXC_UART_BASE Peng Fan (OSS)
@ 2022-04-29 12:35 ` Fabio Estevam
2022-04-29 12:43 ` Heiko Schocher
2022-04-29 14:28 ` Soeren Moch
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-04-29 12:35 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Stefano Babic, Heiko Schocher, Peng Fan, Adrian Alonso,
Arkadiusz Karas, Soeren Moch, Marcel Ziswiler, U-Boot-Denx
Hi Peng,
On Fri, Apr 29, 2022 at 9:28 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Since these boards has CONFIG_DM_SERIAL and/or CONFIG_SPL_DM_SERIAL,
> the legacy macro no need to be defined.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Thanks for the cleanup:
Reviewed-by: Fabio Estevam <festevam@denx.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] imx: drop CONFIG_MXC_UART_BASE
2022-04-29 13:10 [PATCH] imx: drop CONFIG_MXC_UART_BASE Peng Fan (OSS)
2022-04-29 12:35 ` Fabio Estevam
@ 2022-04-29 12:43 ` Heiko Schocher
2022-04-29 14:28 ` Soeren Moch
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2022-04-29 12:43 UTC (permalink / raw)
To: Peng Fan (OSS),
sbabic, festevam, Peng Fan, Adrian Alonso, Arkadiusz Karas,
Soeren Moch, Marcel Ziswiler
Cc: u-boot
Hello Peng,
On 29.04.22 15:10, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Since these boards has CONFIG_DM_SERIAL and/or CONFIG_SPL_DM_SERIAL,
> the legacy macro no need to be defined.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> include/configs/aristainetos2.h | 2 --
> include/configs/imx8mm_evk.h | 1 -
> include/configs/imx8mn_evk.h | 1 -
> include/configs/imx8mp_evk.h | 1 -
> include/configs/mx7dsabresd.h | 1 -
> include/configs/somlabs_visionsom_6ull.h | 1 -
> include/configs/tbs2910.h | 1 -
> include/configs/verdin-imx8mm.h | 1 -
> include/configs/verdin-imx8mp.h | 1 -
> 9 files changed, 10 deletions(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] imx: drop CONFIG_MXC_UART_BASE
@ 2022-04-29 13:10 Peng Fan (OSS)
2022-04-29 12:35 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peng Fan (OSS) @ 2022-04-29 13:10 UTC (permalink / raw)
To: sbabic, festevam, Heiko Schocher, Peng Fan, Adrian Alonso,
Arkadiusz Karas, Soeren Moch, Marcel Ziswiler
Cc: u-boot
From: Peng Fan <peng.fan@nxp.com>
Since these boards has CONFIG_DM_SERIAL and/or CONFIG_SPL_DM_SERIAL,
the legacy macro no need to be defined.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
include/configs/aristainetos2.h | 2 --
include/configs/imx8mm_evk.h | 1 -
include/configs/imx8mn_evk.h | 1 -
include/configs/imx8mp_evk.h | 1 -
include/configs/mx7dsabresd.h | 1 -
include/configs/somlabs_visionsom_6ull.h | 1 -
include/configs/tbs2910.h | 1 -
include/configs/verdin-imx8mm.h | 1 -
include/configs/verdin-imx8mp.h | 1 -
9 files changed, 10 deletions(-)
diff --git a/include/configs/aristainetos2.h b/include/configs/aristainetos2.h
index 8ee97f1d4e3..27adae5d6bf 100644
--- a/include/configs/aristainetos2.h
+++ b/include/configs/aristainetos2.h
@@ -14,10 +14,8 @@
#define CONFIG_HOSTNAME "aristainetos2"
#if (CONFIG_SYS_BOARD_VERSION == 5)
-#define CONFIG_MXC_UART_BASE UART2_BASE
#define CONSOLE_DEV "ttymxc1"
#elif (CONFIG_SYS_BOARD_VERSION == 6)
-#define CONFIG_MXC_UART_BASE UART1_BASE
#define CONSOLE_DEV "ttymxc0"
#endif
diff --git a/include/configs/imx8mm_evk.h b/include/configs/imx8mm_evk.h
index 42b78485cfc..7dd66527c3d 100644
--- a/include/configs/imx8mm_evk.h
+++ b/include/configs/imx8mm_evk.h
@@ -68,7 +68,6 @@
#define PHYS_SDRAM 0x40000000
#define PHYS_SDRAM_SIZE 0x80000000 /* 2GB DDR */
-#define CONFIG_MXC_UART_BASE UART2_BASE_ADDR
/* Monitor Command Prompt */
#define CONFIG_SYS_CBSIZE 2048
diff --git a/include/configs/imx8mn_evk.h b/include/configs/imx8mn_evk.h
index 034132225c6..b20e0a5553d 100644
--- a/include/configs/imx8mn_evk.h
+++ b/include/configs/imx8mn_evk.h
@@ -75,7 +75,6 @@
#define PHYS_SDRAM 0x40000000
#define PHYS_SDRAM_SIZE 0x80000000 /* 2GB DDR */
-#define CONFIG_MXC_UART_BASE UART2_BASE_ADDR
/* Monitor Command Prompt */
#define CONFIG_SYS_CBSIZE 2048
diff --git a/include/configs/imx8mp_evk.h b/include/configs/imx8mp_evk.h
index cc8d65cb54e..cbdd490a300 100644
--- a/include/configs/imx8mp_evk.h
+++ b/include/configs/imx8mp_evk.h
@@ -80,7 +80,6 @@
#define PHYS_SDRAM_2 0x100000000
#define PHYS_SDRAM_2_SIZE 0xC0000000 /* 3 GB */
-#define CONFIG_MXC_UART_BASE UART2_BASE_ADDR
/* Monitor Command Prompt */
#define CONFIG_SYS_CBSIZE 2048
diff --git a/include/configs/mx7dsabresd.h b/include/configs/mx7dsabresd.h
index aaad232f0e4..62e62c6701f 100644
--- a/include/configs/mx7dsabresd.h
+++ b/include/configs/mx7dsabresd.h
@@ -12,7 +12,6 @@
#define PHYS_SDRAM_SIZE SZ_1G
-#define CONFIG_MXC_UART_BASE UART1_IPS_BASE_ADDR
#ifdef CONFIG_IMX_BOOTAUX
/* Set to QSPI1 A flash at default */
diff --git a/include/configs/somlabs_visionsom_6ull.h b/include/configs/somlabs_visionsom_6ull.h
index d4761296c75..e6aad386efe 100644
--- a/include/configs/somlabs_visionsom_6ull.h
+++ b/include/configs/somlabs_visionsom_6ull.h
@@ -16,7 +16,6 @@
/* SPL options */
#include "imx6_spl.h"
-#define CONFIG_MXC_UART_BASE UART1_BASE
/* MMC Configs */
#ifdef CONFIG_FSL_USDHC
diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h
index b7a94812f35..7af182524a6 100644
--- a/include/configs/tbs2910.h
+++ b/include/configs/tbs2910.h
@@ -25,7 +25,6 @@
#define CONFIG_SYS_BOOTMAPSZ 0x10000000
/* Serial console */
-#define CONFIG_MXC_UART_BASE UART1_BASE /* select UART1/UART2 */
/* Framebuffer */
#define CONFIG_IMX_HDMI
diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
index da3dc95f9ee..3d7f5a3380e 100644
--- a/include/configs/verdin-imx8mm.h
+++ b/include/configs/verdin-imx8mm.h
@@ -84,7 +84,6 @@
#define PHYS_SDRAM_SIZE SZ_2G /* 2GB DDR */
/* UART */
-#define CONFIG_MXC_UART_BASE UART1_BASE_ADDR
/* Monitor Command Prompt */
#define CONFIG_SYS_CBSIZE SZ_2K
diff --git a/include/configs/verdin-imx8mp.h b/include/configs/verdin-imx8mp.h
index 7b7407752c1..b166e750c27 100644
--- a/include/configs/verdin-imx8mp.h
+++ b/include/configs/verdin-imx8mp.h
@@ -101,7 +101,6 @@
#define PHYS_SDRAM_2_SIZE (SZ_4G + SZ_1G)
/* UART */
-#define CONFIG_MXC_UART_BASE UART3_BASE_ADDR
/* Monitor Command Prompt */
#define CONFIG_SYS_CBSIZE SZ_2K
--
2.36.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] imx: drop CONFIG_MXC_UART_BASE
2022-04-29 13:10 [PATCH] imx: drop CONFIG_MXC_UART_BASE Peng Fan (OSS)
2022-04-29 12:35 ` Fabio Estevam
2022-04-29 12:43 ` Heiko Schocher
@ 2022-04-29 14:28 ` Soeren Moch
2 siblings, 0 replies; 4+ messages in thread
From: Soeren Moch @ 2022-04-29 14:28 UTC (permalink / raw)
To: Peng Fan (OSS),
sbabic, festevam, Heiko Schocher, Peng Fan, Adrian Alonso,
Arkadiusz Karas, Marcel Ziswiler
Cc: u-boot
On 29.04.22 15:10, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Since these boards has CONFIG_DM_SERIAL and/or CONFIG_SPL_DM_SERIAL,
> the legacy macro no need to be defined.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> include/configs/aristainetos2.h | 2 --
> include/configs/imx8mm_evk.h | 1 -
> include/configs/imx8mn_evk.h | 1 -
> include/configs/imx8mp_evk.h | 1 -
> include/configs/mx7dsabresd.h | 1 -
> include/configs/somlabs_visionsom_6ull.h | 1 -
> include/configs/tbs2910.h | 1 -
> include/configs/verdin-imx8mm.h | 1 -
> include/configs/verdin-imx8mp.h | 1 -
> 9 files changed, 10 deletions(-)
>
> diff --git a/include/configs/aristainetos2.h b/include/configs/aristainetos2.h
> index 8ee97f1d4e3..27adae5d6bf 100644
> --- a/include/configs/aristainetos2.h
> +++ b/include/configs/aristainetos2.h
> @@ -14,10 +14,8 @@
> #define CONFIG_HOSTNAME "aristainetos2"
>
> #if (CONFIG_SYS_BOARD_VERSION == 5)
> -#define CONFIG_MXC_UART_BASE UART2_BASE
> #define CONSOLE_DEV "ttymxc1"
> #elif (CONFIG_SYS_BOARD_VERSION == 6)
> -#define CONFIG_MXC_UART_BASE UART1_BASE
> #define CONSOLE_DEV "ttymxc0"
> #endif
>
> diff --git a/include/configs/imx8mm_evk.h b/include/configs/imx8mm_evk.h
> index 42b78485cfc..7dd66527c3d 100644
> --- a/include/configs/imx8mm_evk.h
> +++ b/include/configs/imx8mm_evk.h
> @@ -68,7 +68,6 @@
> #define PHYS_SDRAM 0x40000000
> #define PHYS_SDRAM_SIZE 0x80000000 /* 2GB DDR */
>
> -#define CONFIG_MXC_UART_BASE UART2_BASE_ADDR
>
> /* Monitor Command Prompt */
> #define CONFIG_SYS_CBSIZE 2048
> diff --git a/include/configs/imx8mn_evk.h b/include/configs/imx8mn_evk.h
> index 034132225c6..b20e0a5553d 100644
> --- a/include/configs/imx8mn_evk.h
> +++ b/include/configs/imx8mn_evk.h
> @@ -75,7 +75,6 @@
> #define PHYS_SDRAM 0x40000000
> #define PHYS_SDRAM_SIZE 0x80000000 /* 2GB DDR */
>
> -#define CONFIG_MXC_UART_BASE UART2_BASE_ADDR
>
> /* Monitor Command Prompt */
> #define CONFIG_SYS_CBSIZE 2048
> diff --git a/include/configs/imx8mp_evk.h b/include/configs/imx8mp_evk.h
> index cc8d65cb54e..cbdd490a300 100644
> --- a/include/configs/imx8mp_evk.h
> +++ b/include/configs/imx8mp_evk.h
> @@ -80,7 +80,6 @@
> #define PHYS_SDRAM_2 0x100000000
> #define PHYS_SDRAM_2_SIZE 0xC0000000 /* 3 GB */
>
> -#define CONFIG_MXC_UART_BASE UART2_BASE_ADDR
>
> /* Monitor Command Prompt */
> #define CONFIG_SYS_CBSIZE 2048
> diff --git a/include/configs/mx7dsabresd.h b/include/configs/mx7dsabresd.h
> index aaad232f0e4..62e62c6701f 100644
> --- a/include/configs/mx7dsabresd.h
> +++ b/include/configs/mx7dsabresd.h
> @@ -12,7 +12,6 @@
>
> #define PHYS_SDRAM_SIZE SZ_1G
>
> -#define CONFIG_MXC_UART_BASE UART1_IPS_BASE_ADDR
>
> #ifdef CONFIG_IMX_BOOTAUX
> /* Set to QSPI1 A flash at default */
> diff --git a/include/configs/somlabs_visionsom_6ull.h b/include/configs/somlabs_visionsom_6ull.h
> index d4761296c75..e6aad386efe 100644
> --- a/include/configs/somlabs_visionsom_6ull.h
> +++ b/include/configs/somlabs_visionsom_6ull.h
> @@ -16,7 +16,6 @@
> /* SPL options */
> #include "imx6_spl.h"
>
> -#define CONFIG_MXC_UART_BASE UART1_BASE
>
> /* MMC Configs */
> #ifdef CONFIG_FSL_USDHC
> diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h
> index b7a94812f35..7af182524a6 100644
> --- a/include/configs/tbs2910.h
> +++ b/include/configs/tbs2910.h
> @@ -25,7 +25,6 @@
> #define CONFIG_SYS_BOOTMAPSZ 0x10000000
>
> /* Serial console */
Since the whole section becomes empty, please also remove this comment
and the empty line.
Thanks for the cleanup,
Soeren
> -#define CONFIG_MXC_UART_BASE UART1_BASE /* select UART1/UART2 */
>
> /* Framebuffer */
> #define CONFIG_IMX_HDMI
> diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
> index da3dc95f9ee..3d7f5a3380e 100644
> --- a/include/configs/verdin-imx8mm.h
> +++ b/include/configs/verdin-imx8mm.h
> @@ -84,7 +84,6 @@
> #define PHYS_SDRAM_SIZE SZ_2G /* 2GB DDR */
>
> /* UART */
> -#define CONFIG_MXC_UART_BASE UART1_BASE_ADDR
>
> /* Monitor Command Prompt */
> #define CONFIG_SYS_CBSIZE SZ_2K
> diff --git a/include/configs/verdin-imx8mp.h b/include/configs/verdin-imx8mp.h
> index 7b7407752c1..b166e750c27 100644
> --- a/include/configs/verdin-imx8mp.h
> +++ b/include/configs/verdin-imx8mp.h
> @@ -101,7 +101,6 @@
> #define PHYS_SDRAM_2_SIZE (SZ_4G + SZ_1G)
>
> /* UART */
> -#define CONFIG_MXC_UART_BASE UART3_BASE_ADDR
>
> /* Monitor Command Prompt */
> #define CONFIG_SYS_CBSIZE SZ_2K
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-29 14:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 13:10 [PATCH] imx: drop CONFIG_MXC_UART_BASE Peng Fan (OSS)
2022-04-29 12:35 ` Fabio Estevam
2022-04-29 12:43 ` Heiko Schocher
2022-04-29 14:28 ` Soeren Moch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.