* [PATCH] ARM: dts: exynos/i9100: Fix Bluetooth node
@ 2021-10-30 12:14 ` Paul Cercueil
0 siblings, 0 replies; 4+ messages in thread
From: Paul Cercueil @ 2021-10-30 12:14 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Paul Cercueil
The reset GPIO was marked active-high, which is against what's specified
in the documentation. Mark the reset GPIO as active-low. With this
change, Bluetooth can now be used on the i9100.
Also switch away from using the deprecated 'host-wakeup-gpios' property,
and use a 'host-wakeup' interrupt instead.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
arch/arm/boot/dts/exynos4210-i9100.dts | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts
index 55922176807e..76b1017e05e8 100644
--- a/arch/arm/boot/dts/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/exynos4210-i9100.dts
@@ -827,9 +827,12 @@ bluetooth {
compatible = "brcm,bcm4330-bt";
shutdown-gpios = <&gpl0 4 GPIO_ACTIVE_HIGH>;
- reset-gpios = <&gpl1 0 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpl1 0 GPIO_ACTIVE_LOW>;
device-wakeup-gpios = <&gpx3 1 GPIO_ACTIVE_HIGH>;
- host-wakeup-gpios = <&gpx2 6 GPIO_ACTIVE_HIGH>;
+
+ interrupt-parent = <&gpx2>;
+ interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
+ interrupt-names = "host-wakeup";
};
};
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: exynos/i9100: Fix Bluetooth node
@ 2021-10-30 12:14 ` Paul Cercueil
0 siblings, 0 replies; 4+ messages in thread
From: Paul Cercueil @ 2021-10-30 12:14 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Paul Cercueil
The reset GPIO was marked active-high, which is against what's specified
in the documentation. Mark the reset GPIO as active-low. With this
change, Bluetooth can now be used on the i9100.
Also switch away from using the deprecated 'host-wakeup-gpios' property,
and use a 'host-wakeup' interrupt instead.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
arch/arm/boot/dts/exynos4210-i9100.dts | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts
index 55922176807e..76b1017e05e8 100644
--- a/arch/arm/boot/dts/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/exynos4210-i9100.dts
@@ -827,9 +827,12 @@ bluetooth {
compatible = "brcm,bcm4330-bt";
shutdown-gpios = <&gpl0 4 GPIO_ACTIVE_HIGH>;
- reset-gpios = <&gpl1 0 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpl1 0 GPIO_ACTIVE_LOW>;
device-wakeup-gpios = <&gpx3 1 GPIO_ACTIVE_HIGH>;
- host-wakeup-gpios = <&gpx2 6 GPIO_ACTIVE_HIGH>;
+
+ interrupt-parent = <&gpx2>;
+ interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
+ interrupt-names = "host-wakeup";
};
};
--
2.33.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: exynos/i9100: Fix Bluetooth node
2021-10-30 12:14 ` Paul Cercueil
@ 2021-10-31 21:02 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-10-31 21:02 UTC (permalink / raw)
To: Paul Cercueil, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
On 30/10/2021 14:14, Paul Cercueil wrote:
> The reset GPIO was marked active-high, which is against what's specified
> in the documentation. Mark the reset GPIO as active-low. With this
> change, Bluetooth can now be used on the i9100.
>
> Also switch away from using the deprecated 'host-wakeup-gpios' property,
> and use a 'host-wakeup' interrupt instead.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Thanks for the patch, but please split it into two commits and add a
"Fixes" tag for the "reset-gpios" one.
All rest looks good, nice patch!
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: exynos/i9100: Fix Bluetooth node
@ 2021-10-31 21:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-10-31 21:02 UTC (permalink / raw)
To: Paul Cercueil, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
On 30/10/2021 14:14, Paul Cercueil wrote:
> The reset GPIO was marked active-high, which is against what's specified
> in the documentation. Mark the reset GPIO as active-low. With this
> change, Bluetooth can now be used on the i9100.
>
> Also switch away from using the deprecated 'host-wakeup-gpios' property,
> and use a 'host-wakeup' interrupt instead.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Thanks for the patch, but please split it into two commits and add a
"Fixes" tag for the "reset-gpios" one.
All rest looks good, nice patch!
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-31 21:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-30 12:14 [PATCH] ARM: dts: exynos/i9100: Fix Bluetooth node Paul Cercueil
2021-10-30 12:14 ` Paul Cercueil
2021-10-31 21:02 ` Krzysztof Kozlowski
2021-10-31 21:02 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.