[PATCH] pwoerpc: Enable HTM capability for h_cede_tm testcase

[PATCH] pwoerpc: Enable HTM capability for h_cede_tm testcase

[David Gibson]

The h_cede_tm case is specifically about an edge case with the H_CEDE
hypercall while using hardware transactional memory (HTM).  Current qemu
versions don't enable HTM instructions in guests by default, so we should
explicitly enable them in order to execute this test.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 powerpc/unittests.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg
index 4eda258..af535b7 100644
--- a/powerpc/unittests.cfg
+++ b/powerpc/unittests.cfg
@@ -63,7 +63,7 @@ file = emulator.elf
 [h_cede_tm]
 file = tm.elf
 smp = 2,threads=2
-extra_params = -append "h_cede_tm"
+extra_params = -machine cap-htm=on -append "h_cede_tm"
 groups = nodefault,h_cede_tm
 
 [sprs]
-- 
2.20.1

Re: [PATCH] pwoerpc: Enable HTM capability for h_cede_tm testcase

[Thomas Huth]

On 27/02/2019 03.23, David Gibson wrote:
> The h_cede_tm case is specifically about an edge case with the H_CEDE
> hypercall while using hardware transactional memory (HTM).  Current qemu
> versions don't enable HTM instructions in guests by default, so we should
> explicitly enable them in order to execute this test.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  powerpc/unittests.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg
> index 4eda258..af535b7 100644
> --- a/powerpc/unittests.cfg
> +++ b/powerpc/unittests.cfg
> @@ -63,7 +63,7 @@ file = emulator.elf
>  [h_cede_tm]
>  file = tm.elf
>  smp = 2,threads=2
> -extra_params = -append "h_cede_tm"
> +extra_params = -machine cap-htm=on -append "h_cede_tm"
>  groups = nodefault,h_cede_tm

There is a typo in the subject (which I can fix while applying the
patch), but apart from that:

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] pwoerpc: Enable HTM capability for h_cede_tm testcase

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

On Wed, Feb 27, 2019 at 08:40:12AM +0100, Thomas Huth wrote:
> On 27/02/2019 03.23, David Gibson wrote:
> > The h_cede_tm case is specifically about an edge case with the H_CEDE
> > hypercall while using hardware transactional memory (HTM).  Current qemu
> > versions don't enable HTM instructions in guests by default, so we should
> > explicitly enable them in order to execute this test.
> > 
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
> >  powerpc/unittests.cfg | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg
> > index 4eda258..af535b7 100644
> > --- a/powerpc/unittests.cfg
> > +++ b/powerpc/unittests.cfg
> > @@ -63,7 +63,7 @@ file = emulator.elf
> >  [h_cede_tm]
> >  file = tm.elf
> >  smp = 2,threads=2
> > -extra_params = -append "h_cede_tm"
> > +extra_params = -machine cap-htm=on -append "h_cede_tm"
> >  groups = nodefault,h_cede_tm
> 
> There is a typo in the subject (which I can fix while applying the
> patch), but apart from that:

Oops, sorry.

> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]