[Qemu-devel] [PATCH] MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section

[Qemu-devel] [PATCH] MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section

[Thomas Huth]

The "trace-events" and "qemu-option-trace.texi" files in the top directory
are currently "unmaintained" according to scripts/get_maintainer.pl. They
obviously belong to the Tracing section, so add an entry for them there.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 459e359..e187b1f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1656,6 +1656,8 @@ Tracing
 M: Stefan Hajnoczi <stefanha@redhat.com>
 S: Maintained
 F: trace/
+F: trace-events
+F: qemu-option-trace.texi
 F: scripts/tracetool.py
 F: scripts/tracetool/
 F: docs/devel/tracing.txt
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section

[Philippe Mathieu-Daudé]

Hi Thomas,

On 05/09/2018 01:38 AM, Thomas Huth wrote:
> The "trace-events" and "qemu-option-trace.texi" files in the top directory
> are currently "unmaintained" according to scripts/get_maintainer.pl. They
> obviously belong to the Tracing section, so add an entry for them there.

I agree qemu-option-trace.texi belongs to the Tracing section,
however I think trace-events is not specific to Tracing but belongs to
everybody maintaining a C file in the top directory... Since they'll
need to modify this file.

> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 459e359..e187b1f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1656,6 +1656,8 @@ Tracing
>  M: Stefan Hajnoczi <stefanha@redhat.com>
>  S: Maintained
>  F: trace/
> +F: trace-events

So without "trace-events":
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> +F: qemu-option-trace.texi
>  F: scripts/tracetool.py
>  F: scripts/tracetool/
>  F: docs/devel/tracing.txt
> 

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section

[Thomas Huth]

On 09.05.2018 07:02, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
> 
> On 05/09/2018 01:38 AM, Thomas Huth wrote:
>> The "trace-events" and "qemu-option-trace.texi" files in the top directory
>> are currently "unmaintained" according to scripts/get_maintainer.pl. They
>> obviously belong to the Tracing section, so add an entry for them there.
> 
> I agree qemu-option-trace.texi belongs to the Tracing section,
> however I think trace-events is not specific to Tracing but belongs to
> everybody maintaining a C file in the top directory... Since they'll
> need to modify this file.

Right ... but what do you do if you just want to fix something in the
generic comments of that file? Who's then responsible for picking up the
patch? ... well, updates to comments could maybe go through
qemu-trivial, too, so I'm also fine if we do not list trace-events in
MAINTAINERS. I'll leave this up to Stefan to decide.

 Thomas

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section

[Eric Blake]

On 05/09/2018 12:02 AM, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
> 
> On 05/09/2018 01:38 AM, Thomas Huth wrote:
>> The "trace-events" and "qemu-option-trace.texi" files in the top directory
>> are currently "unmaintained" according to scripts/get_maintainer.pl. They
>> obviously belong to the Tracing section, so add an entry for them there.
> 
> I agree qemu-option-trace.texi belongs to the Tracing section,
> however I think trace-events is not specific to Tracing but belongs to
> everybody maintaining a C file in the top directory... Since they'll
> need to modify this file.

I'd rather hear Stefan's opinion before outright nixing the addition of 
trace-events to his section - personally, I think any patch touching a 
trace-events is fair game for review by the tracing tree, even if it 
ends up going in through another tree.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

On Wed, May 09, 2018 at 06:38:20AM +0200, Thomas Huth wrote:
> The "trace-events" and "qemu-option-trace.texi" files in the top directory
> are currently "unmaintained" according to scripts/get_maintainer.pl. They
> obviously belong to the Tracing section, so add an entry for them there.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)

Thanks for the discussion!

I'm happy to serve as a catch-all for trace-events patches (especially
trace events in unmaintained code).  It is preferrable for trace-events
changes to go via the subsystem, if there is a maintainer.

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]