From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
Cc: Raslan Darawsheh <rasland@mellanox.com>, <stable@dpdk.org>
Subject: Re: [PATCH 2/2] bus/vdev: fix hotplug twice
Date: Mon, 25 Feb 2019 10:50:28 +0300 [thread overview]
Message-ID: <19f468b3-9c2b-af91-58a5-5a23b5744a88@solarflare.com> (raw)
In-Reply-To: <20190221190125.24140-3-thomas@monjalon.net>
On 2/21/19 10:01 PM, Thomas Monjalon wrote:
> From: Raslan Darawsheh <rasland@mellanox.com>
>
> In case vdev was already probed, it shouldn't be probed again,
> and it should return -EEXIST as error.
> There are some checks in vdev_probe() and insert_vdev(),
> but a check was missing in vdev_plug().
> The check is moved in vdev_probe_all_drivers() which is called
> in all code paths.
>
> Fixes: e9d159c3d534 ("eal: allow probing a device again")
> Cc: stable@dpdk.org
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2019-02-25 7:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 19:01 [PATCH 0/2] small fixes for vdev hotplug Thomas Monjalon
2019-02-21 19:01 ` [PATCH 1/2] bus/vdev: fix debug message on probing Thomas Monjalon
2019-02-22 5:06 ` Rami Rosen
2019-02-25 7:45 ` Andrew Rybchenko
2019-02-21 19:01 ` [PATCH 2/2] bus/vdev: fix hotplug twice Thomas Monjalon
2019-02-25 7:50 ` Andrew Rybchenko [this message]
2019-03-05 12:36 ` [PATCH 0/2] small fixes for vdev hotplug Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f468b3-9c2b-af91-58a5-5a23b5744a88@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.