[PATCH 0/4] video: da8xx-fb: numerous bugfixes

[PATCH 0/4] video: da8xx-fb: numerous bugfixes

[Darren Etheridge]

In developing a driver for an HDMI encoder to be attached to the LCD controller
on TI AM335x SoC I ran across a number of bugs in the da8xx-fb.c fbdev driver.
Two of them appear to have been in the driver for a while (02 and 04), one of
them is a deficiency where some LCD controller version 2 features have not been
utilized (03) and the last one was introduced in the last patch series that I
submitted for this driver (01).

These patches do not change the behavior of the AM335x EVM's platforms LCD
panel even though the current values set by the driver are wrong.  I guess LCD
panels (at least the one used on AM335x EVM) must be fairly immune to bad
timings coming from the LCD controller.  However the HDMI encoder simply will
not work without these fixes, and quite possibly other LCD panels could behave
the same way.

These patches apply on top of the patch series called:
"video/da8xx-fb fbdev driver enhance to support TI am335x SoC"
that was submitted by me.

Darren Etheridge (4):
  video: da8xx-fb fixing incorrect porch mappings
  video: da8xx-fb: fixing timing off by one errors
  video: da8xx-fb: support lcdc v2 timing register expansion
  video: da8xx-fb: fix the polarities of the hsync/vsync pulse

 drivers/video/da8xx-fb.c |   35 +++++++++++++++++++++++++----------
 1 files changed, 25 insertions(+), 10 deletions(-)

Re: [PATCH 0/4] video: da8xx-fb: numerous bugfixes

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

Hi,

On 24/08/13 00:52, Darren Etheridge wrote:
> In developing a driver for an HDMI encoder to be attached to the LCD controller
> on TI AM335x SoC I ran across a number of bugs in the da8xx-fb.c fbdev driver.
> Two of them appear to have been in the driver for a while (02 and 04), one of
> them is a deficiency where some LCD controller version 2 features have not been
> utilized (03) and the last one was introduced in the last patch series that I
> submitted for this driver (01).
> 
> These patches do not change the behavior of the AM335x EVM's platforms LCD
> panel even though the current values set by the driver are wrong.  I guess LCD
> panels (at least the one used on AM335x EVM) must be fairly immune to bad
> timings coming from the LCD controller.  However the HDMI encoder simply will
> not work without these fixes, and quite possibly other LCD panels could behave
> the same way.
> 
> These patches apply on top of the patch series called:
> "video/da8xx-fb fbdev driver enhance to support TI am335x SoC"
> that was submitted by me.
> 
> Darren Etheridge (4):
>   video: da8xx-fb fixing incorrect porch mappings
>   video: da8xx-fb: fixing timing off by one errors
>   video: da8xx-fb: support lcdc v2 timing register expansion
>   video: da8xx-fb: fix the polarities of the hsync/vsync pulse
> 
>  drivers/video/da8xx-fb.c |   35 +++++++++++++++++++++++++----------
>  1 files changed, 25 insertions(+), 10 deletions(-)
> 

These look good to me, queuing for 3.12.

There was a space missing between 'if' and '(' in one of the patches, I
fixed that.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

RE: [PATCH 0/4] video: da8xx-fb: numerous bugfixes

[Etheridge, Darren]

> From: Valkeinen, Tomi
> Sent: Friday, August 30, 2013 6:53 AM
> >
> > Darren Etheridge (4):
> >   video: da8xx-fb fixing incorrect porch mappings
> >   video: da8xx-fb: fixing timing off by one errors
> >   video: da8xx-fb: support lcdc v2 timing register expansion
> >   video: da8xx-fb: fix the polarities of the hsync/vsync pulse
> >
> >  drivers/video/da8xx-fb.c |   35 +++++++++++++++++++++++++----------
> >  1 files changed, 25 insertions(+), 10 deletions(-)
> >
> 
> These look good to me, queuing for 3.12.
> 
> There was a space missing between 'if' and '(' in one of the patches, I fixed
> that.
> 
>  Tomi
> 
Tomi,

Thank you.

Darren