[PATCH] ACPICA / Interpreter: Remove redundant newline

[PATCH] ACPICA / Interpreter: Remove redundant newline

[Borislav Petkov]

From: Borislav Petkov <bp@suse.de>

acpi_info() already issues a '\n' so remove it in the call.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Robert Moore <robert.moore@intel.com>
Cc: Lv Zheng <lv.zheng@intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Cc: devel@acpica.org
---
 drivers/acpi/acpica/tbxfload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
index ac71abcd32bb..e7119b7ccd79 100644
--- a/drivers/acpi/acpica/tbxfload.c
+++ b/drivers/acpi/acpica/tbxfload.c
@@ -240,7 +240,7 @@ acpi_status acpi_tb_load_namespace(void)
 	}
 
 	if (!tables_failed) {
-		ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n", tables_loaded));
+		ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded", tables_loaded));
 	} else {
 		ACPI_ERROR((AE_INFO,
 			    "%u table load failures, %u successful",
-- 
2.10.0

RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Moore, Robert]

Is this a big deal?

We do this on purpose for AcpiExec, to make the screen output more readable.


> -----Original Message-----
> From: Borislav Petkov [mailto:bp@alien8.de]
> Sent: Friday, September 9, 2016 9:13 AM
> To: LKML <linux-kernel@vger.kernel.org>
> Cc: Moore, Robert <robert.moore@intel.com>; Zheng, Lv
> <lv.zheng@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>;
> Len Brown <lenb@kernel.org>; linux-acpi@vger.kernel.org;
> devel@acpica.org
> Subject: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> From: Borislav Petkov <bp@suse.de>
> 
> acpi_info() already issues a '\n' so remove it in the call.
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Robert Moore <robert.moore@intel.com>
> Cc: Lv Zheng <lv.zheng@intel.com>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org
> Cc: devel@acpica.org
> ---
>  drivers/acpi/acpica/tbxfload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpica/tbxfload.c
> b/drivers/acpi/acpica/tbxfload.c index ac71abcd32bb..e7119b7ccd79 100644
> --- a/drivers/acpi/acpica/tbxfload.c
> +++ b/drivers/acpi/acpica/tbxfload.c
> @@ -240,7 +240,7 @@ acpi_status acpi_tb_load_namespace(void)
>  	}
> 
>  	if (!tables_failed) {
> -		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded\n", tables_loaded));
> +		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded",
> +tables_loaded));
>  	} else {
>  		ACPI_ERROR((AE_INFO,
>  			    "%u table load failures, %u successful",
> --
> 2.10.0

Re: [Devel] [PATCH] ACPICA / Interpreter: Remove redundant newline

[Moore, Robert]

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

Is this a big deal?

We do this on purpose for AcpiExec, to make the screen output more readable.


> -----Original Message-----
> From: Borislav Petkov [mailto:bp(a)alien8.de]
> Sent: Friday, September 9, 2016 9:13 AM
> To: LKML <linux-kernel(a)vger.kernel.org>
> Cc: Moore, Robert <robert.moore(a)intel.com>; Zheng, Lv
> <lv.zheng(a)intel.com>; Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>;
> Len Brown <lenb(a)kernel.org>; linux-acpi(a)vger.kernel.org;
> devel(a)acpica.org
> Subject: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> From: Borislav Petkov <bp(a)suse.de>
> 
> acpi_info() already issues a '\n' so remove it in the call.
> 
> Signed-off-by: Borislav Petkov <bp(a)suse.de>
> Cc: Robert Moore <robert.moore(a)intel.com>
> Cc: Lv Zheng <lv.zheng(a)intel.com>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki(a)intel.com>
> Cc: Len Brown <lenb(a)kernel.org>
> Cc: linux-acpi(a)vger.kernel.org
> Cc: devel(a)acpica.org
> ---
>  drivers/acpi/acpica/tbxfload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpica/tbxfload.c
> b/drivers/acpi/acpica/tbxfload.c index ac71abcd32bb..e7119b7ccd79 100644
> --- a/drivers/acpi/acpica/tbxfload.c
> +++ b/drivers/acpi/acpica/tbxfload.c
> @@ -240,7 +240,7 @@ acpi_status acpi_tb_load_namespace(void)
>  	}
> 
>  	if (!tables_failed) {
> -		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded\n", tables_loaded));
> +		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded",
> +tables_loaded));
>  	} else {
>  		ACPI_ERROR((AE_INFO,
>  			    "%u table load failures, %u successful",
> --
> 2.10.0

Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Borislav Petkov]

On Fri, Sep 09, 2016 at 06:26:17PM +0000, Moore, Robert wrote:
> Is this a big deal?
> 
> We do this on purpose for AcpiExec, to make the screen output more readable.

Please do not top-post.

What do you mean "big deal"? All other ACPI_INFO calls don't have a "\n"
at the end except this one. How does one "\n" make some output more
readable?

(Btw, I have no idea what AcpiExec is. Grepping the kernel tree doesn't
give any results).

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Moore, Robert]

Well, I never thought I would write a couple lines of code like this, but here is a solution that should make everyone happy.

diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c
index 6a937b1..73ee1a2 100644
--- a/source/components/tables/tbxfload.c
+++ b/source/components/tables/tbxfload.c
@@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
     if (!TablesFailed)
     {
         ACPI_INFO ((
-            "%u ACPI AML tables successfully acquired and loaded\n",
+            "%u ACPI AML tables successfully acquired and loaded",
             TablesLoaded));
     }
     else
@@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
         Status = AE_CTRL_TERMINATE;
     }
 
+#ifdef ACPI_APPLICATION
+    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
+#endif
+
+
 UnlockAndExit:
     (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
     return_ACPI_STATUS (Status);

Re: [Devel] [PATCH] ACPICA / Interpreter: Remove redundant newline

[Moore, Robert]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

Well, I never thought I would write a couple lines of code like this, but here is a solution that should make everyone happy.

diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c
index 6a937b1..73ee1a2 100644
--- a/source/components/tables/tbxfload.c
+++ b/source/components/tables/tbxfload.c
@@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
     if (!TablesFailed)
     {
         ACPI_INFO ((
-            "%u ACPI AML tables successfully acquired and loaded\n",
+            "%u ACPI AML tables successfully acquired and loaded",
             TablesLoaded));
     }
     else
@@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
         Status = AE_CTRL_TERMINATE;
     }
 
+#ifdef ACPI_APPLICATION
+    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
+#endif
+
+
 UnlockAndExit:
     (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
     return_ACPI_STATUS (Status);

RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Moore, Robert]

> Please do not top-post.


You're not going to get a lot of help by scolding me.
Bob




> -----Original Message-----
> From: Borislav Petkov [mailto:bp@alien8.de]
> Sent: Friday, September 9, 2016 11:41 AM
> To: Moore, Robert <robert.moore@intel.com>
> Cc: LKML <linux-kernel@vger.kernel.org>; Zheng, Lv <lv.zheng@intel.com>;
> Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Len Brown
> <lenb@kernel.org>; linux-acpi@vger.kernel.org; devel@acpica.org
> Subject: Re: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> On Fri, Sep 09, 2016 at 06:26:17PM +0000, Moore, Robert wrote:
> > Is this a big deal?
> >
> > We do this on purpose for AcpiExec, to make the screen output more
> readable.
> 
> Please do not top-post.
> 
> What do you mean "big deal"? All other ACPI_INFO calls don't have a "\n"
> at the end except this one. How does one "\n" make some output more
> readable?
> 
> (Btw, I have no idea what AcpiExec is. Grepping the kernel tree doesn't
> give any results).
> 
> --
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.

Re: [Devel] [PATCH] ACPICA / Interpreter: Remove redundant newline

[Moore, Robert]

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]


> Please do not top-post.


You're not going to get a lot of help by scolding me.
Bob




> -----Original Message-----
> From: Borislav Petkov [mailto:bp(a)alien8.de]
> Sent: Friday, September 9, 2016 11:41 AM
> To: Moore, Robert <robert.moore(a)intel.com>
> Cc: LKML <linux-kernel(a)vger.kernel.org>; Zheng, Lv <lv.zheng(a)intel.com>;
> Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>; Len Brown
> <lenb(a)kernel.org>; linux-acpi(a)vger.kernel.org; devel(a)acpica.org
> Subject: Re: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> On Fri, Sep 09, 2016 at 06:26:17PM +0000, Moore, Robert wrote:
> > Is this a big deal?
> >
> > We do this on purpose for AcpiExec, to make the screen output more
> readable.
> 
> Please do not top-post.
> 
> What do you mean "big deal"? All other ACPI_INFO calls don't have a "\n"
> at the end except this one. How does one "\n" make some output more
> readable?
> 
> (Btw, I have no idea what AcpiExec is. Grepping the kernel tree doesn't
> give any results).
> 
> --
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.

Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Borislav Petkov]

On Fri, Sep 09, 2016 at 06:46:20PM +0000, Moore, Robert wrote:
> 
> > Please do not top-post.
> 
> 
> You're not going to get a lot of help by scolding me.

How is "Please do not top-post" scolding you? The stress being on
"Please".

How much more polite can I be?!?

Geez.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Joe Perches]

On Fri, 2016-09-09 at 20:40 +0200, Borislav Petkov wrote:
> On Fri, Sep 09, 2016 at 06:26:17PM +0000, Moore, Robert wrote:
> > Is this a big deal?
> > We do this on purpose for AcpiExec, to make the screen output more readable.
[]
> What do you mean "big deal"? All other ACPI_INFO calls don't have a "\n"
> at the end except this one. How does one "\n" make some output more
> readable?

Blank lines in logging/dmesg generally don't add value.

I would prefer if the unnecessary double parentheses also
were removed in these macro uses and ##__VA_ARGS__ was
used instead.

/*
 * Error reporting. Callers module and line number are inserted by AE_INFO,
 * the plist contains a set of parens to allow variable-length lists.
 * These macros are used for both the debug and non-debug versions of the code.
 */
#define ACPI_INFO(plist)                acpi_info plist
#define ACPI_WARNING(plist)             acpi_warning plist
#define ACPI_EXCEPTION(plist)           acpi_exception plist
#define ACPI_ERROR(plist)               acpi_error plist
#define ACPI_BIOS_WARNING(plist)        acpi_bios_warning plist
#define ACPI_BIOS_ERROR(plist)          acpi_bios_error plist

It would also be good if format/argument verification
was done here and in the non-debug macro variants.

#define ACPI_INFO(plist)
#define ACPI_WARNING(plist)
#define ACPI_EXCEPTION(plist)
#define ACPI_ERROR(plist)
#define ACPI_BIOS_WARNING(plist)
#define ACPI_BIOS_ERROR(plist)

Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Borislav Petkov]

On Fri, Sep 09, 2016 at 06:45:23PM +0000, Moore, Robert wrote:
> Well, I never thought I would write a couple lines of code like this, but here is a solution that should make everyone happy.
> 
> diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c
> index 6a937b1..73ee1a2 100644
> --- a/source/components/tables/tbxfload.c
> +++ b/source/components/tables/tbxfload.c
> @@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
>      if (!TablesFailed)
>      {
>          ACPI_INFO ((
> -            "%u ACPI AML tables successfully acquired and loaded\n",
> +            "%u ACPI AML tables successfully acquired and loaded",
>              TablesLoaded));
>      }
>      else
> @@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
>          Status = AE_CTRL_TERMINATE;
>      }
>  
> +#ifdef ACPI_APPLICATION
> +    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
> +#endif
> +
> +
>  UnlockAndExit:
>      (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
>      return_ACPI_STATUS (Status);

Works for me. A lot of kernel code does stuff like that already:

$ git grep -E "\(\"\\\n\"\)" | wc -l
1550

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Joe Perches]

On Fri, 2016-09-09 at 21:06 +0200, Borislav Petkov wrote:
> Works for me. A lot of kernel code does stuff like that already:
> $ git grep -E "\(\"\\\n\"\)" | wc -l
> 1550

<shrug>  If you want.

and fyi:

Most of those are pr_cont uses for multiple printks to a single
output line terminations.

Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Borislav Petkov]

On Fri, Sep 09, 2016 at 12:15:56PM -0700, Joe Perches wrote:
> Most of those are pr_cont uses for multiple printks to a single
> output line terminations.

Not really:

$ git grep -E "\(\"\\\n\"\)" | grep -i cont | wc -l
185

Regardless, it doesn't really matter what those are.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Zheng, Lv]

The newline is intentional for acpiexec.
So you should fix this issue in acpiexec, aka, in ACPICA upstream.

Thanks
Lv

> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Borislav
> Petkov
> Subject: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> From: Borislav Petkov <bp@suse.de>
> 
> acpi_info() already issues a '\n' so remove it in the call.
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Robert Moore <robert.moore@intel.com>
> Cc: Lv Zheng <lv.zheng@intel.com>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org
> Cc: devel@acpica.org
> ---
>  drivers/acpi/acpica/tbxfload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
> index ac71abcd32bb..e7119b7ccd79 100644
> --- a/drivers/acpi/acpica/tbxfload.c
> +++ b/drivers/acpi/acpica/tbxfload.c
> @@ -240,7 +240,7 @@ acpi_status acpi_tb_load_namespace(void)
>  	}
> 
>  	if (!tables_failed) {
> -		ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n", tables_loaded));
> +		ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded", tables_loaded));
>  	} else {
>  		ACPI_ERROR((AE_INFO,
>  			    "%u table load failures, %u successful",
> --
> 2.10.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Devel] [PATCH] ACPICA / Interpreter: Remove redundant newline

[Zheng, Lv]

[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]

The newline is intentional for acpiexec.
So you should fix this issue in acpiexec, aka, in ACPICA upstream.

Thanks
Lv

> From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On Behalf Of Borislav
> Petkov
> Subject: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> From: Borislav Petkov <bp(a)suse.de>
> 
> acpi_info() already issues a '\n' so remove it in the call.
> 
> Signed-off-by: Borislav Petkov <bp(a)suse.de>
> Cc: Robert Moore <robert.moore(a)intel.com>
> Cc: Lv Zheng <lv.zheng(a)intel.com>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki(a)intel.com>
> Cc: Len Brown <lenb(a)kernel.org>
> Cc: linux-acpi(a)vger.kernel.org
> Cc: devel(a)acpica.org
> ---
>  drivers/acpi/acpica/tbxfload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
> index ac71abcd32bb..e7119b7ccd79 100644
> --- a/drivers/acpi/acpica/tbxfload.c
> +++ b/drivers/acpi/acpica/tbxfload.c
> @@ -240,7 +240,7 @@ acpi_status acpi_tb_load_namespace(void)
>  	}
> 
>  	if (!tables_failed) {
> -		ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n", tables_loaded));
> +		ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded", tables_loaded));
>  	} else {
>  		ACPI_ERROR((AE_INFO,
>  			    "%u table load failures, %u successful",
> --
> 2.10.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Zheng, Lv]

Hi,

> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Moore,
> Robert
> David E <david.e.box@intel.com>
> Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> Well, I never thought I would write a couple lines of code like this, but here is a solution that
> should make everyone happy.
> 
> diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c
> index 6a937b1..73ee1a2 100644
> --- a/source/components/tables/tbxfload.c
> +++ b/source/components/tables/tbxfload.c
> @@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
>      if (!TablesFailed)
>      {
>          ACPI_INFO ((
> -            "%u ACPI AML tables successfully acquired and loaded\n",
> +            "%u ACPI AML tables successfully acquired and loaded",
>              TablesLoaded));
>      }
>      else
> @@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
>          Status = AE_CTRL_TERMINATE;
>      }
> 
> +#ifdef ACPI_APPLICATION
> +    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
> +#endif
> +
> +

IMO, these lines should be in ACPICA upstream, in a file under tools/acpiexec.

Thanks
Lv

>  UnlockAndExit:
>      (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
>      return_ACPI_STATUS (Status);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Zheng, Lv]

Hi,

> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Moore,
> Robert
> David E <david.e.box@intel.com>
> Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> Well, I never thought I would write a couple lines of code like this, but here is a solution that
> should make everyone happy.
> 
> diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c
> index 6a937b1..73ee1a2 100644
> --- a/source/components/tables/tbxfload.c
> +++ b/source/components/tables/tbxfload.c
> @@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
>      if (!TablesFailed)
>      {
>          ACPI_INFO ((
> -            "%u ACPI AML tables successfully acquired and loaded\n",
> +            "%u ACPI AML tables successfully acquired and loaded",
>              TablesLoaded));
>      }
>      else
> @@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
>          Status = AE_CTRL_TERMINATE;
>      }
> 
> +#ifdef ACPI_APPLICATION
> +    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
> +#endif
> +
> +

IMO, these lines should be in ACPICA upstream, in a file under tools/acpiexec.

Thanks
Lv

>  UnlockAndExit:
>      (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
>      return_ACPI_STATUS (Status);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Devel] [PATCH] ACPICA / Interpreter: Remove redundant newline

[Zheng, Lv]

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

Hi,

> From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On Behalf Of Moore,
> Robert
> David E <david.e.box(a)intel.com>
> Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> Well, I never thought I would write a couple lines of code like this, but here is a solution that
> should make everyone happy.
> 
> diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c
> index 6a937b1..73ee1a2 100644
> --- a/source/components/tables/tbxfload.c
> +++ b/source/components/tables/tbxfload.c
> @@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
>      if (!TablesFailed)
>      {
>          ACPI_INFO ((
> -            "%u ACPI AML tables successfully acquired and loaded\n",
> +            "%u ACPI AML tables successfully acquired and loaded",
>              TablesLoaded));
>      }
>      else
> @@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
>          Status = AE_CTRL_TERMINATE;
>      }
> 
> +#ifdef ACPI_APPLICATION
> +    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
> +#endif
> +
> +

IMO, these lines should be in ACPICA upstream, in a file under tools/acpiexec.

Thanks
Lv

>  UnlockAndExit:
>      (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
>      return_ACPI_STATUS (Status);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Zheng, Lv]

Hi,

> From: Joe Perches [mailto:joe@perches.com]
> Subject: Re: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> On Fri, 2016-09-09 at 20:40 +0200, Borislav Petkov wrote:
> > On Fri, Sep 09, 2016 at 06:26:17PM +0000, Moore, Robert wrote:
> > > Is this a big deal?
> > > We do this on purpose for AcpiExec, to make the screen output more readable.
> []
> > What do you mean "big deal"? All other ACPI_INFO calls don't have a "\n"
> > at the end except this one. How does one "\n" make some output more
> > readable?
> 
> Blank lines in logging/dmesg generally don't add value.
> 
> I would prefer if the unnecessary double parentheses also
> were removed in these macro uses and ##__VA_ARGS__ was
> used instead.

Ideally correct.
But __VA_ARGS__ is not portable.
And ACPICA is used in other environment.
I'd prefer to eliminate debugging/logging macros, but implement debugging/logging functions instead.
As stdarg is more portable than __VA_ARGS__.

Thanks and best regards
Lv

> 
> /*
>  * Error reporting. Callers module and line number are inserted by AE_INFO,
>  * the plist contains a set of parens to allow variable-length lists.
>  * These macros are used for both the debug and non-debug versions of the code.
>  */
> #define ACPI_INFO(plist)                acpi_info plist
> #define ACPI_WARNING(plist)             acpi_warning plist
> #define ACPI_EXCEPTION(plist)           acpi_exception plist
> #define ACPI_ERROR(plist)               acpi_error plist
> #define ACPI_BIOS_WARNING(plist)        acpi_bios_warning plist
> #define ACPI_BIOS_ERROR(plist)          acpi_bios_error plist
> 
> It would also be good if format/argument verification
> was done here and in the non-debug macro variants.
> 
> #define ACPI_INFO(plist)
> #define ACPI_WARNING(plist)
> #define ACPI_EXCEPTION(plist)
> #define ACPI_ERROR(plist)
> #define ACPI_BIOS_WARNING(plist)
> #define ACPI_BIOS_ERROR(plist)

Re: [Devel] [PATCH] ACPICA / Interpreter: Remove redundant newline

[Zheng, Lv]

[-- Attachment #1: Type: text/plain, Size: 1963 bytes --]

Hi,

> From: Joe Perches [mailto:joe(a)perches.com]
> Subject: Re: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> On Fri, 2016-09-09 at 20:40 +0200, Borislav Petkov wrote:
> > On Fri, Sep 09, 2016 at 06:26:17PM +0000, Moore, Robert wrote:
> > > Is this a big deal?
> > > We do this on purpose for AcpiExec, to make the screen output more readable.
> []
> > What do you mean "big deal"? All other ACPI_INFO calls don't have a "\n"
> > at the end except this one. How does one "\n" make some output more
> > readable?
> 
> Blank lines in logging/dmesg generally don't add value.
> 
> I would prefer if the unnecessary double parentheses also
> were removed in these macro uses and ##__VA_ARGS__ was
> used instead.

Ideally correct.
But __VA_ARGS__ is not portable.
And ACPICA is used in other environment.
I'd prefer to eliminate debugging/logging macros, but implement debugging/logging functions instead.
As stdarg is more portable than __VA_ARGS__.

Thanks and best regards
Lv

> 
> /*
>  * Error reporting. Callers module and line number are inserted by AE_INFO,
>  * the plist contains a set of parens to allow variable-length lists.
>  * These macros are used for both the debug and non-debug versions of the code.
>  */
> #define ACPI_INFO(plist)                acpi_info plist
> #define ACPI_WARNING(plist)             acpi_warning plist
> #define ACPI_EXCEPTION(plist)           acpi_exception plist
> #define ACPI_ERROR(plist)               acpi_error plist
> #define ACPI_BIOS_WARNING(plist)        acpi_bios_warning plist
> #define ACPI_BIOS_ERROR(plist)          acpi_bios_error plist
> 
> It would also be good if format/argument verification
> was done here and in the non-debug macro variants.
> 
> #define ACPI_INFO(plist)
> #define ACPI_WARNING(plist)
> #define ACPI_EXCEPTION(plist)
> #define ACPI_ERROR(plist)
> #define ACPI_BIOS_WARNING(plist)
> #define ACPI_BIOS_ERROR(plist)

Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Borislav Petkov]

On Wed, Sep 14, 2016 at 03:09:25AM +0000, Zheng, Lv wrote:
> The newline is intentional for acpiexec.
> So you should fix this issue in acpiexec, aka, in ACPICA upstream.

If you elaborate as to from where I get the sources and against which
branch/version/...?, I can try to send you a patch.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Moore, Robert]

> -----Original Message-----
> From: Zheng, Lv
> Sent: Tuesday, September 13, 2016 8:11 PM
> To: Moore, Robert <robert.moore@intel.com>; Moore, Robert
> <robert.moore@intel.com>; Borislav Petkov <bp@alien8.de>; LKML <linux-
> kernel@vger.kernel.org>
> Cc: linux-acpi@vger.kernel.org; devel@acpica.org; Wysocki, Rafael J
> <rafael.j.wysocki@intel.com>; Box, David E <david.e.box@intel.com>
> Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> Hi,
> 
> > From: linux-acpi-owner@vger.kernel.org
> > [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Moore, Robert
> > David E <david.e.box@intel.com>
> > Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> >
> > Well, I never thought I would write a couple lines of code like this,
> > but here is a solution that should make everyone happy.
> >
> > diff --git a/source/components/tables/tbxfload.c
> > b/source/components/tables/tbxfload.c
> > index 6a937b1..73ee1a2 100644
> > --- a/source/components/tables/tbxfload.c
> > +++ b/source/components/tables/tbxfload.c
> > @@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
> >      if (!TablesFailed)
> >      {
> >          ACPI_INFO ((
> > -            "%u ACPI AML tables successfully acquired and loaded\n",
> > +            "%u ACPI AML tables successfully acquired and loaded",
> >              TablesLoaded));
> >      }
> >      else
> > @@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
> >          Status = AE_CTRL_TERMINATE;
> >      }
> >
> > +#ifdef ACPI_APPLICATION
> > +    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n")); #endif
> > +
> > +
> 
[Moore, Robert] 

I have no problem with this, I just want to get it over with.
It is not a big deal, let's leave it at that and not make it a big issue.





> IMO, these lines should be in ACPICA upstream, in a file under
> tools/acpiexec.
> 
> Thanks
> Lv
> 
> >  UnlockAndExit:
> >      (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
> >      return_ACPI_STATUS (Status);
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi"
> > in the body of a message to majordomo@vger.kernel.org More majordomo
> > info at  http://vger.kernel.org/majordomo-info.html

Re: [Devel] [PATCH] ACPICA / Interpreter: Remove redundant newline

[Moore, Robert]

[-- Attachment #1: Type: text/plain, Size: 2263 bytes --]



> -----Original Message-----
> From: Zheng, Lv
> Sent: Tuesday, September 13, 2016 8:11 PM
> To: Moore, Robert <robert.moore(a)intel.com>; Moore, Robert
> <robert.moore(a)intel.com>; Borislav Petkov <bp(a)alien8.de>; LKML <linux-
> kernel(a)vger.kernel.org>
> Cc: linux-acpi(a)vger.kernel.org; devel(a)acpica.org; Wysocki, Rafael J
> <rafael.j.wysocki(a)intel.com>; Box, David E <david.e.box(a)intel.com>
> Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> Hi,
> 
> > From: linux-acpi-owner(a)vger.kernel.org
> > [mailto:linux-acpi-owner(a)vger.kernel.org] On Behalf Of Moore, Robert
> > David E <david.e.box(a)intel.com>
> > Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> >
> > Well, I never thought I would write a couple lines of code like this,
> > but here is a solution that should make everyone happy.
> >
> > diff --git a/source/components/tables/tbxfload.c
> > b/source/components/tables/tbxfload.c
> > index 6a937b1..73ee1a2 100644
> > --- a/source/components/tables/tbxfload.c
> > +++ b/source/components/tables/tbxfload.c
> > @@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
> >      if (!TablesFailed)
> >      {
> >          ACPI_INFO ((
> > -            "%u ACPI AML tables successfully acquired and loaded\n",
> > +            "%u ACPI AML tables successfully acquired and loaded",
> >              TablesLoaded));
> >      }
> >      else
> > @@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
> >          Status = AE_CTRL_TERMINATE;
> >      }
> >
> > +#ifdef ACPI_APPLICATION
> > +    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n")); #endif
> > +
> > +
> 
[Moore, Robert] 

I have no problem with this, I just want to get it over with.
It is not a big deal, let's leave it at that and not make it a big issue.





> IMO, these lines should be in ACPICA upstream, in a file under
> tools/acpiexec.
> 
> Thanks
> Lv
> 
> >  UnlockAndExit:
> >      (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
> >      return_ACPI_STATUS (Status);
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi"
> > in the body of a message to majordomo(a)vger.kernel.org More majordomo
> > info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Zheng, Lv]

Hi,

> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Borislav
> Petkov
> Subject: Re: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> On Wed, Sep 14, 2016 at 03:09:25AM +0000, Zheng, Lv wrote:
> > The newline is intentional for acpiexec.
> > So you should fix this issue in acpiexec, aka, in ACPICA upstream.
> 
> If you elaborate as to from where I get the sources and against which
> branch/version/...?, I can try to send you a patch.

You can obtain a local copy of acpica.git via:
$ git clone https://github.com/acpica/acpica

The fix patch should only be sent to devel@acpica.org.
And you'll see it in Linux upstream after an acpica release cycle.

Regards
Lv

> 
> --
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.
> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Devel] [PATCH] ACPICA / Interpreter: Remove redundant newline

[Zheng, Lv]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Hi,

> From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On Behalf Of Borislav
> Petkov
> Subject: Re: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> On Wed, Sep 14, 2016 at 03:09:25AM +0000, Zheng, Lv wrote:
> > The newline is intentional for acpiexec.
> > So you should fix this issue in acpiexec, aka, in ACPICA upstream.
> 
> If you elaborate as to from where I get the sources and against which
> branch/version/...?, I can try to send you a patch.

You can obtain a local copy of acpica.git via:
$ git clone https://github.com/acpica/acpica

The fix patch should only be sent to devel(a)acpica.org.
And you'll see it in Linux upstream after an acpica release cycle.

Regards
Lv

> 
> --
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.
> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

[Borislav Petkov]

On Mon, Sep 19, 2016 at 09:30:44AM +0000, Zheng, Lv wrote:
> You can obtain a local copy of acpica.git via:
> $ git clone https://github.com/acpica/acpica
> 
> The fix patch should only be sent to devel@acpica.org.
> And you'll see it in Linux upstream after an acpica release cycle.

No need, Robert did it already:

1d435008fd9e ("Update an info message during table load phase.")

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

[PATCH] acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file

[Lv Zheng]

> No need, Robert did it already:
> 
> 1d435008fd9e ("Update an info message during table load phase.")

Not exactly what I meant. I meant the following on top of the above
mentioned commit. As the newline is an acpiexec specific logic, it should
be kept in acpiexec, shouldn't be left polluting a common file. Lv Zheng.

Signed-off-by: Lv Zheng <lv.zheng@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Len Brown <len.brown@intel.com>
Cc: <linux-acpi@vger.kernel.org>
--
Index: acpica/source/components/tables/tbxfload.c
===================================================================
--- acpica.orig/source/components/tables/tbxfload.c
+++ acpica/source/components/tables/tbxfload.c
@@ -348,11 +348,6 @@ AcpiTbLoadNamespace (
         Status = AE_CTRL_TERMINATE;
     }
 
-#ifdef ACPI_APPLICATION
-    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
-#endif
-
-
 UnlockAndExit:
     (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
     return_ACPI_STATUS (Status);
Index: acpica/source/tools/acpiexec/aetables.c
===================================================================
--- acpica.orig/source/tools/acpiexec/aetables.c
+++ acpica/source/tools/acpiexec/aetables.c
@@ -625,6 +625,7 @@ AeLoadTables (
 
     Status = AcpiLoadTables ();
     ACPI_CHECK_OK (AcpiLoadTables, Status);
+    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
 
     /*
      * Test run-time control method installation. Do it twice to test code

[PATCH] acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file

[Lv Zheng]

> No need, Robert did it already:
> 
> 1d435008fd9e ("Update an info message during table load phase.")

Not exactly what I meant. I meant the following on top of the above
mentioned commit. As the newline is an acpiexec specific logic, it should
be kept in acpiexec, shouldn't be left polluting a common file. Lv Zheng.

Signed-off-by: Lv Zheng <lv.zheng@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Len Brown <len.brown@intel.com>
Cc: <linux-acpi@vger.kernel.org>
--
Index: acpica/source/components/tables/tbxfload.c
===================================================================
--- acpica.orig/source/components/tables/tbxfload.c
+++ acpica/source/components/tables/tbxfload.c
@@ -348,11 +348,6 @@ AcpiTbLoadNamespace (
         Status = AE_CTRL_TERMINATE;
     }
 
-#ifdef ACPI_APPLICATION
-    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
-#endif
-
-
 UnlockAndExit:
     (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
     return_ACPI_STATUS (Status);
Index: acpica/source/tools/acpiexec/aetables.c
===================================================================
--- acpica.orig/source/tools/acpiexec/aetables.c
+++ acpica/source/tools/acpiexec/aetables.c
@@ -625,6 +625,7 @@ AeLoadTables (
 
     Status = AcpiLoadTables ();
     ACPI_CHECK_OK (AcpiLoadTables, Status);
+    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
 
     /*
      * Test run-time control method installation. Do it twice to test code

[Devel] [PATCH] acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file

[Lv Zheng]

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

> No need, Robert did it already:
> 
> 1d435008fd9e ("Update an info message during table load phase.")

Not exactly what I meant. I meant the following on top of the above
mentioned commit. As the newline is an acpiexec specific logic, it should
be kept in acpiexec, shouldn't be left polluting a common file. Lv Zheng.

Signed-off-by: Lv Zheng <lv.zheng(a)intel.com>
To: Borislav Petkov <bp(a)alien8.de>
Cc: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com>
Cc: Rafael J. Wysocki <rjw(a)rjwysocki.net>
Cc: Len Brown <len.brown(a)intel.com>
Cc: <linux-acpi(a)vger.kernel.org>
--
Index: acpica/source/components/tables/tbxfload.c
===================================================================
--- acpica.orig/source/components/tables/tbxfload.c
+++ acpica/source/components/tables/tbxfload.c
@@ -348,11 +348,6 @@ AcpiTbLoadNamespace (
         Status = AE_CTRL_TERMINATE;
     }
 
-#ifdef ACPI_APPLICATION
-    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
-#endif
-
-
 UnlockAndExit:
     (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
     return_ACPI_STATUS (Status);
Index: acpica/source/tools/acpiexec/aetables.c
===================================================================
--- acpica.orig/source/tools/acpiexec/aetables.c
+++ acpica/source/tools/acpiexec/aetables.c
@@ -625,6 +625,7 @@ AeLoadTables (
 
     Status = AcpiLoadTables ();
     ACPI_CHECK_OK (AcpiLoadTables, Status);
+    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
 
     /*
      * Test run-time control method installation. Do it twice to test code

[PATCH] acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file

[Lv Zheng]

> No need, Robert did it already:
> 
> 1d435008fd9e ("Update an info message during table load phase.")

Not exactly what I meant. I meant the following on top of the above
mentioned commit. As the newline is an acpiexec specific logic, it should
be kept in acpiexec, shouldn't be left polluting a common file. Lv Zheng.

Signed-off-by: Lv Zheng <lv.zheng@intel.com>
--
Index: acpica/source/components/tables/tbxfload.c
===================================================================
--- acpica.orig/source/components/tables/tbxfload.c
+++ acpica/source/components/tables/tbxfload.c
@@ -348,11 +348,6 @@ AcpiTbLoadNamespace (
         Status = AE_CTRL_TERMINATE;
     }
 
-#ifdef ACPI_APPLICATION
-    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
-#endif
-
-
 UnlockAndExit:
     (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
     return_ACPI_STATUS (Status);
Index: acpica/source/tools/acpiexec/aetables.c
===================================================================
--- acpica.orig/source/tools/acpiexec/aetables.c
+++ acpica/source/tools/acpiexec/aetables.c
@@ -625,6 +625,7 @@ AeLoadTables (
 
     Status = AcpiLoadTables ();
     ACPI_CHECK_OK (AcpiLoadTables, Status);
+    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
 
     /*
      * Test run-time control method installation. Do it twice to test code

[PATCH] acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file

[Lv Zheng]

> No need, Robert did it already:
> 
> 1d435008fd9e ("Update an info message during table load phase.")

Not exactly what I meant. I meant the following on top of the above
mentioned commit. As the newline is an acpiexec specific logic, it should
be kept in acpiexec, shouldn't be left polluting a common file. Lv Zheng.

Signed-off-by: Lv Zheng <lv.zheng@intel.com>
--
Index: acpica/source/components/tables/tbxfload.c
===================================================================
--- acpica.orig/source/components/tables/tbxfload.c
+++ acpica/source/components/tables/tbxfload.c
@@ -348,11 +348,6 @@ AcpiTbLoadNamespace (
         Status = AE_CTRL_TERMINATE;
     }
 
-#ifdef ACPI_APPLICATION
-    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
-#endif
-
-
 UnlockAndExit:
     (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
     return_ACPI_STATUS (Status);
Index: acpica/source/tools/acpiexec/aetables.c
===================================================================
--- acpica.orig/source/tools/acpiexec/aetables.c
+++ acpica/source/tools/acpiexec/aetables.c
@@ -625,6 +625,7 @@ AeLoadTables (
 
     Status = AcpiLoadTables ();
     ACPI_CHECK_OK (AcpiLoadTables, Status);
+    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
 
     /*
      * Test run-time control method installation. Do it twice to test code

[Devel] [PATCH] acpiexec: Move an acpiexec specific purposed new line to acpiexec specific file

[Lv Zheng]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

> No need, Robert did it already:
> 
> 1d435008fd9e ("Update an info message during table load phase.")

Not exactly what I meant. I meant the following on top of the above
mentioned commit. As the newline is an acpiexec specific logic, it should
be kept in acpiexec, shouldn't be left polluting a common file. Lv Zheng.

Signed-off-by: Lv Zheng <lv.zheng(a)intel.com>
--
Index: acpica/source/components/tables/tbxfload.c
===================================================================
--- acpica.orig/source/components/tables/tbxfload.c
+++ acpica/source/components/tables/tbxfload.c
@@ -348,11 +348,6 @@ AcpiTbLoadNamespace (
         Status = AE_CTRL_TERMINATE;
     }
 
-#ifdef ACPI_APPLICATION
-    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
-#endif
-
-
 UnlockAndExit:
     (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
     return_ACPI_STATUS (Status);
Index: acpica/source/tools/acpiexec/aetables.c
===================================================================
--- acpica.orig/source/tools/acpiexec/aetables.c
+++ acpica/source/tools/acpiexec/aetables.c
@@ -625,6 +625,7 @@ AeLoadTables (
 
     Status = AcpiLoadTables ();
     ACPI_CHECK_OK (AcpiLoadTables, Status);
+    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
 
     /*
      * Test run-time control method installation. Do it twice to test code