* [U-Boot] [PATCH] nand: fix nand read.option parsing
@ 2013-02-07 21:34 Harvey Chapman
2013-02-23 0:52 ` [U-Boot] " Scott Wood
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Chapman @ 2013-02-07 21:34 UTC (permalink / raw)
To: u-boot
"nand read.part addr off size" would be treated as "nand read.raw addr off 1"
It now fails as intended stating "Unknown nand command suffix '.part'"
Signed-off-by: Harvey Chapman <hchapman@3gfp.com>
---
common/cmd_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_nand.c b/common/cmd_nand.c
index 1568594..495610c 100644
--- a/common/cmd_nand.c
+++ b/common/cmd_nand.c
@@ -608,7 +608,7 @@ static int do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
size_t rwsize;
ulong pagecount = 1;
int read;
- int raw;
+ int raw = 0;
if (argc < 4)
goto usage;
--
1.7.10.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1089 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130207/81638637/attachment.bin>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] nand: fix nand read.option parsing
2013-02-07 21:34 [U-Boot] [PATCH] nand: fix nand read.option parsing Harvey Chapman
@ 2013-02-23 0:52 ` Scott Wood
0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2013-02-23 0:52 UTC (permalink / raw)
To: u-boot
On Thu, Feb 07, 2013 at 11:34:44AM -0000, Harvey Chapman wrote:
> "nand read.part addr off size" would be treated as "nand read.raw addr off 1"
> It now fails as intended stating "Unknown nand command suffix '.part'"
>
> Signed-off-by: Harvey Chapman <hchapman@3gfp.com>
>
> ---
> common/cmd_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/cmd_nand.c b/common/cmd_nand.c
> index 1568594..495610c 100644
> --- a/common/cmd_nand.c
> +++ b/common/cmd_nand.c
> @@ -608,7 +608,7 @@ static int do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> size_t rwsize;
> ulong pagecount = 1;
> int read;
> - int raw;
> + int raw = 0;
>
> if (argc < 4)
> goto usage;
This patch is whitespace mangled. Applied manually to u-boot-nand-flash,
but next time please make sure your mailer does not alter the patch at
all (consider using git send-email).
-Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-23 0:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-07 21:34 [U-Boot] [PATCH] nand: fix nand read.option parsing Harvey Chapman
2013-02-23 0:52 ` [U-Boot] " Scott Wood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.