From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: "target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v6 14/33] target: Avoid that target drivers hang if a command is aborted
Date: Tue, 21 Feb 2017 18:58:44 +0000 [thread overview]
Message-ID: <1D08B61A9CF0974AA09887BE32D889DA0AC669@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> (raw)
In-Reply-To: 1487626736.19491.37.camel@haakon3.risingtidesystems.com
On 02/20/2017 01:38 PM, Nicholas A. Bellinger wrote:
> However, looking at transport_generic_free_cmd() in the context of
> ib_srpt and ib_isert, I don't see how this scenario can ever happen in
> as-is in upstream code.
>
> Namely, all of the transport_generic_free_cmd() callers in ib_srpt and
> ib_isert pass wait_for_tasks = false. And the only time
> transport_generic_free_cmd() will block is when wait_for_tasks = true,
> or when wait_for_tasks = true && abort = true.
>
> So as-is in upstream, how can transport_generic_free_cmd() ever block
> when wait_for_tasks = false..?
I will check the other patches in this series for changes that trigger a
call to wait_for_completion() if wait_for_tasks == false.
Bart.
next prev parent reply other threads:[~2017-02-21 19:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170215002612.14566-1-bart.vanassche@sandisk.com>
2017-02-15 0:25 ` [PATCH v6 14/33] target: Avoid that target drivers hang if a command is aborted Bart Van Assche
2017-02-20 21:38 ` Nicholas A. Bellinger
2017-02-21 18:58 ` Bart Van Assche [this message]
2017-03-02 5:21 ` Nicholas A. Bellinger
2017-03-02 5:24 ` Bart Van Assche
2017-03-02 7:02 ` Nicholas A. Bellinger
2017-02-15 0:25 ` [PATCH v6 15/33] target: Avoid circular waits between LUN resets Bart Van Assche
2017-02-20 22:32 ` Nicholas A. Bellinger
2017-02-15 0:25 ` [PATCH v6 19/33] target: Avoid that LUN reset sporadically triggers data corruption Bart Van Assche
2017-02-20 23:52 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1D08B61A9CF0974AA09887BE32D889DA0AC669@ULS-OP-MBXIP03.sdcorp.global.sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=nab@linux-iscsi.org \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.