All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	Matt Fleming <matt@codeblueprint.co.uk>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-efi@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Hock Leong Kweh <hock.leong.kweh@intel.com>,
	Borislav Petkov <bp@alien8.de>,
	Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v2 0/3] efi: add support for non-standard capsule headers
Date: Thu, 20 Apr 2017 16:27:06 +0100	[thread overview]
Message-ID: <1a10da6c-9342-c52a-71b7-669d189f17a2@nexus-software.ie> (raw)
In-Reply-To: <cover.1492626781.git.jan.kiszka@siemens.com>



On 19/04/17 19:32, Jan Kiszka wrote:
> This picks up the patches Ard send before in [1], including the
> "left-over" patches 6..8.
>
> As Ard suggested, I've taken updated patches 6 and 7 of him from [2]
> which address reviewer comments. Furthermore, I've changed patch 8 to
> factor out the Quark quirk logic from the overloaded
> efi_capsule_setup_info as requested by Matt and also applied Andy's
> suggestion to have a quirk dispatcher table with callbacks.
>
> Tested successfully on the IOT2040 - still without a working Galileo
> board.
>
> Jan
>
> [1] http://www.spinics.net/lists/linux-efi/msg11194.html
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=quark-capsule
>
> Cc: Matt Fleming <matt@codeblueprint.co.uk>
>
> Ard Biesheuvel (2):
>   efi/capsule-loader: Redirect calls to efi_capsule_setup_info via weak
>     alias
>   efi/capsule-loader: Use page addresses rather than struct page
>     pointers
>
> Jan Kiszka (1):
>   efi/capsule: Add support for Quark security header
>
>  arch/x86/platform/efi/quirks.c        | 137 ++++++++++++++++++++++++++++++++++
>  drivers/firmware/efi/Kconfig          |   9 +++
>  drivers/firmware/efi/capsule-loader.c |  66 ++++++++--------
>  drivers/firmware/efi/capsule.c        |   7 +-
>  include/linux/efi.h                   |  14 +++-
>  5 files changed, 197 insertions(+), 36 deletions(-)
>

Still looks good, nothing's broken on Galileo.

Please feel free to add my

Tested-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>

To your patches

WARNING: multiple messages have this Message-ID (diff)
From: Bryan O'Donoghue <pure.logic-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org>
To: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>,
	Matt Fleming
	<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
	Ard Biesheuvel
	<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Andy Shevchenko
	<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Hock Leong Kweh
	<hock.leong.kweh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
	Sascha Weisenberger
	<sascha.weisenberger-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2 0/3] efi: add support for non-standard capsule headers
Date: Thu, 20 Apr 2017 16:27:06 +0100	[thread overview]
Message-ID: <1a10da6c-9342-c52a-71b7-669d189f17a2@nexus-software.ie> (raw)
In-Reply-To: <cover.1492626781.git.jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>



On 19/04/17 19:32, Jan Kiszka wrote:
> This picks up the patches Ard send before in [1], including the
> "left-over" patches 6..8.
>
> As Ard suggested, I've taken updated patches 6 and 7 of him from [2]
> which address reviewer comments. Furthermore, I've changed patch 8 to
> factor out the Quark quirk logic from the overloaded
> efi_capsule_setup_info as requested by Matt and also applied Andy's
> suggestion to have a quirk dispatcher table with callbacks.
>
> Tested successfully on the IOT2040 - still without a working Galileo
> board.
>
> Jan
>
> [1] http://www.spinics.net/lists/linux-efi/msg11194.html
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=quark-capsule
>
> Cc: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
>
> Ard Biesheuvel (2):
>   efi/capsule-loader: Redirect calls to efi_capsule_setup_info via weak
>     alias
>   efi/capsule-loader: Use page addresses rather than struct page
>     pointers
>
> Jan Kiszka (1):
>   efi/capsule: Add support for Quark security header
>
>  arch/x86/platform/efi/quirks.c        | 137 ++++++++++++++++++++++++++++++++++
>  drivers/firmware/efi/Kconfig          |   9 +++
>  drivers/firmware/efi/capsule-loader.c |  66 ++++++++--------
>  drivers/firmware/efi/capsule.c        |   7 +-
>  include/linux/efi.h                   |  14 +++-
>  5 files changed, 197 insertions(+), 36 deletions(-)
>

Still looks good, nothing's broken on Galileo.

Please feel free to add my

Tested-by: Bryan O'Donoghue <pure.logic-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org>

To your patches

  parent reply	other threads:[~2017-04-20 15:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 18:32 [PATCH v2 0/3] efi: add support for non-standard capsule headers Jan Kiszka
2017-04-19 18:32 ` Jan Kiszka
2017-04-19 18:33 ` [PATCH v2 1/3] efi/capsule-loader: Redirect calls to efi_capsule_setup_info via weak alias Jan Kiszka
2017-04-19 18:33   ` Jan Kiszka
2017-04-19 18:33 ` [PATCH v2 2/3] efi/capsule-loader: Use page addresses rather than struct page pointers Jan Kiszka
2017-04-19 18:33 ` [PATCH v2 3/3] efi/capsule: Add support for Quark security header Jan Kiszka
2017-04-19 18:33   ` Jan Kiszka
2017-04-19 21:17   ` Andy Shevchenko
2017-04-19 21:17     ` Andy Shevchenko
2017-04-20  9:48 ` [PATCH v2 0/3] efi: add support for non-standard capsule headers Bryan O'Donoghue
2017-04-20 15:27 ` Bryan O'Donoghue [this message]
2017-04-20 15:27   ` Bryan O'Donoghue
2017-04-25 15:00 ` Matt Fleming
2017-04-25 15:00   ` Matt Fleming
2017-04-25 15:01   ` Ard Biesheuvel
2017-04-25 15:01     ` Ard Biesheuvel
2017-04-25 15:07     ` Bryan O'Donoghue
2017-04-25 15:08       ` Ard Biesheuvel
2017-04-25 15:08         ` Ard Biesheuvel
2017-04-27 12:46         ` Bryan O'Donoghue
2017-04-27 12:46           ` Bryan O'Donoghue
2017-04-27 12:42           ` Ard Biesheuvel
2017-04-27 12:42             ` Ard Biesheuvel
2017-05-18 10:31             ` Ard Biesheuvel
2017-05-18 10:31               ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a10da6c-9342-c52a-71b7-669d189f17a2@nexus-software.ie \
    --to=pure.logic@nexus-software.ie \
    --cc=andy.shevchenko@gmail.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bp@alien8.de \
    --cc=hock.leong.kweh@intel.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=sascha.weisenberger@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.