* [PATCH 0/2] reset: Add ast2600 support @ 2019-11-26 2:22 ` Joel Stanley 0 siblings, 0 replies; 8+ messages in thread From: Joel Stanley @ 2019-11-26 2:22 UTC (permalink / raw) To: Lee Jones, Rob Herring, Philipp Zabel Cc: Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed This series adds ast2600 support to the reset-simple driver, and updates the device tree documentation for the LPC bindings. Brad Bishop (1): reset: simple: Add AST2600 compatibility string Joel Stanley (1): dt-bindings: mfd: Add ast2600 to ASPEED LPC Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++-- drivers/reset/reset-simple.c | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) -- 2.24.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/2] reset: Add ast2600 support @ 2019-11-26 2:22 ` Joel Stanley 0 siblings, 0 replies; 8+ messages in thread From: Joel Stanley @ 2019-11-26 2:22 UTC (permalink / raw) To: Lee Jones, Rob Herring, Philipp Zabel Cc: Andrew Jeffery, devicetree, linux-aspeed, linux-arm-kernel This series adds ast2600 support to the reset-simple driver, and updates the device tree documentation for the LPC bindings. Brad Bishop (1): reset: simple: Add AST2600 compatibility string Joel Stanley (1): dt-bindings: mfd: Add ast2600 to ASPEED LPC Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++-- drivers/reset/reset-simple.c | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC 2019-11-26 2:22 ` Joel Stanley @ 2019-11-26 2:22 ` Joel Stanley -1 siblings, 0 replies; 8+ messages in thread From: Joel Stanley @ 2019-11-26 2:22 UTC (permalink / raw) To: Lee Jones, Rob Herring, Philipp Zabel Cc: Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed The AST2600 has the same LPC layout as previous generation SoCs. Signed-off-by: Joel Stanley <joel@jms.id.au> --- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt index 86446074e206..bef07c3b1a3e 100644 --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt @@ -46,6 +46,7 @@ Required properties - compatible: One of: "aspeed,ast2400-lpc", "simple-mfd" "aspeed,ast2500-lpc", "simple-mfd" + "aspeed,ast2600-lpc", "simple-mfd" - reg: contains the physical address and length values of the Aspeed LPC memory region. @@ -64,6 +65,7 @@ BMC Node - compatible: One of: "aspeed,ast2400-lpc-bmc" "aspeed,ast2500-lpc-bmc" + "aspeed,ast2600-lpc-bmc" - reg: contains the physical address and length values of the H8S/2168-compatible LPC controller memory region @@ -128,6 +130,7 @@ Required properties: - compatible: One of: "aspeed,ast2400-lpc-ctrl"; "aspeed,ast2500-lpc-ctrl"; + "aspeed,ast2600-lpc-ctrl"; - reg: contains offset/length values of the host interface controller memory regions @@ -168,6 +171,7 @@ Required properties: - compatible: One of: "aspeed,ast2400-lhc"; "aspeed,ast2500-lhc"; + "aspeed,ast2600-lhc"; - reg: contains offset/length values of the LHC memory regions. In the AST2400 and AST2500 there are two regions. @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to modify this configuration. Required properties: - - compatible: "aspeed,ast2500-lpc-reset" or - "aspeed,ast2400-lpc-reset" + - compatible: One of: + "aspeed,ast2400-lhc"; + "aspeed,ast2500-lhc"; + "aspeed,ast2600-lhc"; + - reg: offset and length of the IP in the LHC memory region - #reset-controller indicates the number of reset cells expected -- 2.24.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC @ 2019-11-26 2:22 ` Joel Stanley 0 siblings, 0 replies; 8+ messages in thread From: Joel Stanley @ 2019-11-26 2:22 UTC (permalink / raw) To: Lee Jones, Rob Herring, Philipp Zabel Cc: Andrew Jeffery, devicetree, linux-aspeed, linux-arm-kernel The AST2600 has the same LPC layout as previous generation SoCs. Signed-off-by: Joel Stanley <joel@jms.id.au> --- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt index 86446074e206..bef07c3b1a3e 100644 --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt @@ -46,6 +46,7 @@ Required properties - compatible: One of: "aspeed,ast2400-lpc", "simple-mfd" "aspeed,ast2500-lpc", "simple-mfd" + "aspeed,ast2600-lpc", "simple-mfd" - reg: contains the physical address and length values of the Aspeed LPC memory region. @@ -64,6 +65,7 @@ BMC Node - compatible: One of: "aspeed,ast2400-lpc-bmc" "aspeed,ast2500-lpc-bmc" + "aspeed,ast2600-lpc-bmc" - reg: contains the physical address and length values of the H8S/2168-compatible LPC controller memory region @@ -128,6 +130,7 @@ Required properties: - compatible: One of: "aspeed,ast2400-lpc-ctrl"; "aspeed,ast2500-lpc-ctrl"; + "aspeed,ast2600-lpc-ctrl"; - reg: contains offset/length values of the host interface controller memory regions @@ -168,6 +171,7 @@ Required properties: - compatible: One of: "aspeed,ast2400-lhc"; "aspeed,ast2500-lhc"; + "aspeed,ast2600-lhc"; - reg: contains offset/length values of the LHC memory regions. In the AST2400 and AST2500 there are two regions. @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to modify this configuration. Required properties: - - compatible: "aspeed,ast2500-lpc-reset" or - "aspeed,ast2400-lpc-reset" + - compatible: One of: + "aspeed,ast2400-lhc"; + "aspeed,ast2500-lhc"; + "aspeed,ast2600-lhc"; + - reg: offset and length of the IP in the LHC memory region - #reset-controller indicates the number of reset cells expected -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC 2019-11-26 2:22 ` Joel Stanley @ 2019-11-27 23:16 ` Andrew Jeffery -1 siblings, 0 replies; 8+ messages in thread From: Andrew Jeffery @ 2019-11-27 23:16 UTC (permalink / raw) To: Joel Stanley, Lee Jones, Rob Herring, Philipp Zabel Cc: devicetree, linux-arm-kernel, linux-aspeed On Tue, 26 Nov 2019, at 12:52, Joel Stanley wrote: > The AST2600 has the same LPC layout as previous generation SoCs. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > index 86446074e206..bef07c3b1a3e 100644 > --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > @@ -46,6 +46,7 @@ Required properties > - compatible: One of: > "aspeed,ast2400-lpc", "simple-mfd" > "aspeed,ast2500-lpc", "simple-mfd" > + "aspeed,ast2600-lpc", "simple-mfd" > > - reg: contains the physical address and length values of the Aspeed > LPC memory region. > @@ -64,6 +65,7 @@ BMC Node > - compatible: One of: > "aspeed,ast2400-lpc-bmc" > "aspeed,ast2500-lpc-bmc" > + "aspeed,ast2600-lpc-bmc" > > - reg: contains the physical address and length values of the > H8S/2168-compatible LPC controller memory region > @@ -128,6 +130,7 @@ Required properties: > - compatible: One of: > "aspeed,ast2400-lpc-ctrl"; > "aspeed,ast2500-lpc-ctrl"; > + "aspeed,ast2600-lpc-ctrl"; > > - reg: contains offset/length values of the host interface controller > memory regions > @@ -168,6 +171,7 @@ Required properties: > - compatible: One of: > "aspeed,ast2400-lhc"; > "aspeed,ast2500-lhc"; > + "aspeed,ast2600-lhc"; > > - reg: contains offset/length values of the LHC memory regions. In the > AST2400 and AST2500 there are two regions. > @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to > modify this configuration. > > Required properties: > > - - compatible: "aspeed,ast2500-lpc-reset" or > - "aspeed,ast2400-lpc-reset" > + - compatible: One of: > + "aspeed,ast2400-lhc"; > + "aspeed,ast2500-lhc"; > + "aspeed,ast2600-lhc"; This doesn't look right, you've removed the reset compatibles. It looks like copy/paste from the hunk before. > + > - reg: offset and length of the IP in the LHC memory region > - #reset-controller indicates the number of reset cells expected > > -- > 2.24.0 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC @ 2019-11-27 23:16 ` Andrew Jeffery 0 siblings, 0 replies; 8+ messages in thread From: Andrew Jeffery @ 2019-11-27 23:16 UTC (permalink / raw) To: Joel Stanley, Lee Jones, Rob Herring, Philipp Zabel Cc: devicetree, linux-aspeed, linux-arm-kernel On Tue, 26 Nov 2019, at 12:52, Joel Stanley wrote: > The AST2600 has the same LPC layout as previous generation SoCs. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > index 86446074e206..bef07c3b1a3e 100644 > --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > @@ -46,6 +46,7 @@ Required properties > - compatible: One of: > "aspeed,ast2400-lpc", "simple-mfd" > "aspeed,ast2500-lpc", "simple-mfd" > + "aspeed,ast2600-lpc", "simple-mfd" > > - reg: contains the physical address and length values of the Aspeed > LPC memory region. > @@ -64,6 +65,7 @@ BMC Node > - compatible: One of: > "aspeed,ast2400-lpc-bmc" > "aspeed,ast2500-lpc-bmc" > + "aspeed,ast2600-lpc-bmc" > > - reg: contains the physical address and length values of the > H8S/2168-compatible LPC controller memory region > @@ -128,6 +130,7 @@ Required properties: > - compatible: One of: > "aspeed,ast2400-lpc-ctrl"; > "aspeed,ast2500-lpc-ctrl"; > + "aspeed,ast2600-lpc-ctrl"; > > - reg: contains offset/length values of the host interface controller > memory regions > @@ -168,6 +171,7 @@ Required properties: > - compatible: One of: > "aspeed,ast2400-lhc"; > "aspeed,ast2500-lhc"; > + "aspeed,ast2600-lhc"; > > - reg: contains offset/length values of the LHC memory regions. In the > AST2400 and AST2500 there are two regions. > @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to > modify this configuration. > > Required properties: > > - - compatible: "aspeed,ast2500-lpc-reset" or > - "aspeed,ast2400-lpc-reset" > + - compatible: One of: > + "aspeed,ast2400-lhc"; > + "aspeed,ast2500-lhc"; > + "aspeed,ast2600-lhc"; This doesn't look right, you've removed the reset compatibles. It looks like copy/paste from the hunk before. > + > - reg: offset and length of the IP in the LHC memory region > - #reset-controller indicates the number of reset cells expected > > -- > 2.24.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] reset: simple: Add AST2600 compatibility string 2019-11-26 2:22 ` Joel Stanley @ 2019-11-26 2:22 ` Joel Stanley -1 siblings, 0 replies; 8+ messages in thread From: Joel Stanley @ 2019-11-26 2:22 UTC (permalink / raw) To: Lee Jones, Rob Herring, Philipp Zabel Cc: Brad Bishop, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed From: Brad Bishop <bradleyb@fuzziesquirrel.com> The AST2600 SoC contains the same LPC register set as the AST2500. Reviewed-by: Andrew Jeffery <andrew@aj.id.au> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Signed-off-by: Joel Stanley <joel@jms.id.au> --- drivers/reset/reset-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c index 067e7e7b34f1..795c9063fe7b 100644 --- a/drivers/reset/reset-simple.c +++ b/drivers/reset/reset-simple.c @@ -125,6 +125,7 @@ static const struct of_device_id reset_simple_dt_ids[] = { .data = &reset_simple_active_low }, { .compatible = "aspeed,ast2400-lpc-reset" }, { .compatible = "aspeed,ast2500-lpc-reset" }, + { .compatible = "aspeed,ast2600-lpc-reset" }, { .compatible = "bitmain,bm1880-reset", .data = &reset_simple_active_low }, { .compatible = "snps,dw-high-reset" }, -- 2.24.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] reset: simple: Add AST2600 compatibility string @ 2019-11-26 2:22 ` Joel Stanley 0 siblings, 0 replies; 8+ messages in thread From: Joel Stanley @ 2019-11-26 2:22 UTC (permalink / raw) To: Lee Jones, Rob Herring, Philipp Zabel Cc: Andrew Jeffery, devicetree, Brad Bishop, linux-aspeed, linux-arm-kernel From: Brad Bishop <bradleyb@fuzziesquirrel.com> The AST2600 SoC contains the same LPC register set as the AST2500. Reviewed-by: Andrew Jeffery <andrew@aj.id.au> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Signed-off-by: Joel Stanley <joel@jms.id.au> --- drivers/reset/reset-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c index 067e7e7b34f1..795c9063fe7b 100644 --- a/drivers/reset/reset-simple.c +++ b/drivers/reset/reset-simple.c @@ -125,6 +125,7 @@ static const struct of_device_id reset_simple_dt_ids[] = { .data = &reset_simple_active_low }, { .compatible = "aspeed,ast2400-lpc-reset" }, { .compatible = "aspeed,ast2500-lpc-reset" }, + { .compatible = "aspeed,ast2600-lpc-reset" }, { .compatible = "bitmain,bm1880-reset", .data = &reset_simple_active_low }, { .compatible = "snps,dw-high-reset" }, -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-27 23:14 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-26 2:22 [PATCH 0/2] reset: Add ast2600 support Joel Stanley 2019-11-26 2:22 ` Joel Stanley 2019-11-26 2:22 ` [PATCH 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC Joel Stanley 2019-11-26 2:22 ` Joel Stanley 2019-11-27 23:16 ` Andrew Jeffery 2019-11-27 23:16 ` Andrew Jeffery 2019-11-26 2:22 ` [PATCH 2/2] reset: simple: Add AST2600 compatibility string Joel Stanley 2019-11-26 2:22 ` Joel Stanley
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.