From: Kuogee Hsieh <quic_khsieh@quicinc.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>, Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>, <airlied@linux.ie>, <bjorn.andersson@linaro.org>, <daniel@ffwll.ch>, <dianders@chromium.org>, <dri-devel@lists.freedesktop.org>, <robdclark@gmail.com>, <sean@poorly.run>, <vkoul@kernel.org>, <quic_aravindh@quicinc.com>, <quic_sbillaka@quicinc.com>, <freedreno@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table Date: Fri, 24 Jun 2022 18:02:50 -0700 [thread overview] Message-ID: <1a2e7574-8f78-d48e-a189-020ffcd39f60@quicinc.com> (raw) In-Reply-To: <CAA8EJppZdyutyNBG+OFinickQoDxg0i4GwbaNQubo_LSRWNh4w@mail.gmail.com> On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote: > On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> On Sat, 25 Jun 2022 at 03:23, Kuogee Hsieh <quic_khsieh@quicinc.com> wrote: >>> On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote: >>>> On Sat, 25 Jun 2022 at 03:19, Kuogee Hsieh <quic_khsieh@quicinc.com> wrote: >>>>> How can I have eDP call dpu_encoder_init() before DP calls with >>>>> _dpu_kms_initialize_displayport()? >>>> Why do you want to do it? They are two different encoders. >>> eDP is primary display which in normal case should be bring up first if >>> DP is also presented. >> I do not like the concept of primary display. It is the user, who must >> decide which display is primary to him. I have seen people using just >> external monitors and ignoring built-in eDP completely.from >> Also, why does the bring up order matters here? What do you gain by >> bringing up eDP before the DP? > I should probably rephrase my question to be more clear. How does > changing the order of DP vs eDP bringup help you 'to fix screen > corruption'. it did fix the primary display correction issue if edp go first and i do not know the root cause yet. We are still investigating it. However I do think currently msm_dp_config sc7280_dp_cfg has issues need be addressed. >
WARNING: multiple messages have this Message-ID (diff)
From: Kuogee Hsieh <quic_khsieh@quicinc.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: vkoul@kernel.org, quic_sbillaka@quicinc.com, dianders@chromium.org, airlied@linux.ie, freedreno@lists.freedesktop.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, agross@kernel.org, linux-arm-msm@vger.kernel.org, quic_aravindh@quicinc.com, Stephen Boyd <swboyd@chromium.org>, sean@poorly.run, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table Date: Fri, 24 Jun 2022 18:02:50 -0700 [thread overview] Message-ID: <1a2e7574-8f78-d48e-a189-020ffcd39f60@quicinc.com> (raw) In-Reply-To: <CAA8EJppZdyutyNBG+OFinickQoDxg0i4GwbaNQubo_LSRWNh4w@mail.gmail.com> On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote: > On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> On Sat, 25 Jun 2022 at 03:23, Kuogee Hsieh <quic_khsieh@quicinc.com> wrote: >>> On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote: >>>> On Sat, 25 Jun 2022 at 03:19, Kuogee Hsieh <quic_khsieh@quicinc.com> wrote: >>>>> How can I have eDP call dpu_encoder_init() before DP calls with >>>>> _dpu_kms_initialize_displayport()? >>>> Why do you want to do it? They are two different encoders. >>> eDP is primary display which in normal case should be bring up first if >>> DP is also presented. >> I do not like the concept of primary display. It is the user, who must >> decide which display is primary to him. I have seen people using just >> external monitors and ignoring built-in eDP completely.from >> Also, why does the bring up order matters here? What do you gain by >> bringing up eDP before the DP? > I should probably rephrase my question to be more clear. How does > changing the order of DP vs eDP bringup help you 'to fix screen > corruption'. it did fix the primary display correction issue if edp go first and i do not know the root cause yet. We are still investigating it. However I do think currently msm_dp_config sc7280_dp_cfg has issues need be addressed. >
next prev parent reply other threads:[~2022-06-25 1:03 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-24 17:15 [PATCH v1 0/3] fix primary corruption issue Kuogee Hsieh 2022-06-24 17:15 ` Kuogee Hsieh 2022-06-24 17:15 ` [PATCH v1 1/3] drm/msm/dp: move struc of msm_display_info to msm_drv.h Kuogee Hsieh 2022-06-24 17:15 ` Kuogee Hsieh 2022-06-24 21:40 ` Doug Anderson 2022-06-24 21:40 ` Doug Anderson 2022-06-24 21:50 ` Kuogee Hsieh 2022-06-24 21:50 ` Kuogee Hsieh 2022-06-24 23:45 ` Dmitry Baryshkov 2022-06-24 23:45 ` Dmitry Baryshkov 2022-06-24 23:41 ` Dmitry Baryshkov 2022-06-24 23:41 ` Dmitry Baryshkov 2022-06-24 17:15 ` [PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table Kuogee Hsieh 2022-06-24 17:15 ` Kuogee Hsieh 2022-06-24 20:00 ` Stephen Boyd 2022-06-24 20:00 ` Stephen Boyd 2022-06-24 21:17 ` Kuogee Hsieh 2022-06-24 21:17 ` Kuogee Hsieh 2022-06-24 21:40 ` Stephen Boyd 2022-06-24 21:40 ` Stephen Boyd 2022-06-24 21:49 ` Kuogee Hsieh 2022-06-24 21:49 ` Kuogee Hsieh 2022-06-24 22:19 ` Stephen Boyd 2022-06-24 22:19 ` Stephen Boyd 2022-06-24 22:53 ` Kuogee Hsieh 2022-06-24 22:53 ` Kuogee Hsieh 2022-06-24 23:12 ` Stephen Boyd 2022-06-24 23:12 ` Stephen Boyd 2022-06-24 23:30 ` Kuogee Hsieh 2022-06-24 23:30 ` Kuogee Hsieh 2022-06-24 23:45 ` Stephen Boyd 2022-06-24 23:45 ` Stephen Boyd 2022-06-24 23:53 ` Dmitry Baryshkov 2022-06-24 23:53 ` Dmitry Baryshkov 2022-06-24 23:56 ` Kuogee Hsieh 2022-06-24 23:56 ` Kuogee Hsieh 2022-06-25 0:03 ` Abhinav Kumar 2022-06-25 0:03 ` Abhinav Kumar 2022-06-25 0:11 ` Stephen Boyd 2022-06-25 0:11 ` Stephen Boyd 2022-06-25 0:23 ` Stephen Boyd 2022-06-25 0:23 ` Stephen Boyd 2022-06-25 1:15 ` Abhinav Kumar 2022-06-25 1:15 ` Abhinav Kumar 2022-06-25 0:11 ` Dmitry Baryshkov 2022-06-25 0:11 ` Dmitry Baryshkov 2022-06-25 0:19 ` Kuogee Hsieh 2022-06-25 0:19 ` Kuogee Hsieh 2022-06-25 0:21 ` Dmitry Baryshkov 2022-06-25 0:21 ` Dmitry Baryshkov 2022-06-25 0:23 ` Kuogee Hsieh 2022-06-25 0:23 ` Kuogee Hsieh 2022-06-25 0:28 ` Dmitry Baryshkov 2022-06-25 0:28 ` Dmitry Baryshkov 2022-06-25 0:46 ` Dmitry Baryshkov 2022-06-25 0:46 ` Dmitry Baryshkov 2022-06-25 1:02 ` Kuogee Hsieh [this message] 2022-06-25 1:02 ` Kuogee Hsieh 2022-06-25 1:15 ` Stephen Boyd 2022-06-25 1:15 ` Stephen Boyd 2022-06-27 15:33 ` Kuogee Hsieh 2022-06-27 15:33 ` Kuogee Hsieh 2022-06-27 15:38 ` Dmitry Baryshkov 2022-06-27 15:38 ` Dmitry Baryshkov 2022-06-27 15:49 ` Kuogee Hsieh 2022-06-27 15:49 ` Kuogee Hsieh 2022-06-25 1:23 ` Abhinav Kumar 2022-06-25 1:23 ` Abhinav Kumar 2022-06-25 8:48 ` Dmitry Baryshkov 2022-06-25 8:48 ` Dmitry Baryshkov 2022-06-27 23:20 ` Doug Anderson 2022-06-27 23:20 ` Doug Anderson 2022-06-28 15:22 ` Kuogee Hsieh 2022-06-28 15:22 ` Kuogee Hsieh 2022-06-24 23:25 ` Dmitry Baryshkov 2022-06-24 23:25 ` Dmitry Baryshkov 2022-06-24 17:15 ` [PATCH v1 3/3] drm/msm/dp: place edp at head of drm bridge chain to fix screen corruption Kuogee Hsieh 2022-06-24 17:15 ` Kuogee Hsieh 2022-06-24 23:56 ` Dmitry Baryshkov 2022-06-24 23:56 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1a2e7574-8f78-d48e-a189-020ffcd39f60@quicinc.com \ --to=quic_khsieh@quicinc.com \ --cc=agross@kernel.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dianders@chromium.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_aravindh@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.