From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: neil.armstrong@linaro.org, Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic subnodes compatibles
Date: Thu, 29 Sep 2022 11:12:25 +0200 [thread overview]
Message-ID: <1a3c6766-9be5-1e55-95eb-bc9656e5c9a3@linaro.org> (raw)
In-Reply-To: <6ed642ea-424d-49ed-eb30-e09588720373@linaro.org>
On 29/09/2022 10:29, Neil Armstrong wrote:
> Hi,
>
> On 28/09/2022 20:03, Krzysztof Kozlowski wrote:
>> On 28/09/2022 11:14, Neil Armstrong wrote:
>>> The PMIC is an PM8018, but was compatible with the PM8921. Both compatibles
>>> was left but it makes no sense anymore the leave both.
>>
>> Why? It makes sense for backwards compatibility. If you think it does
>> not make sense, please say why.
>
> We had the same debate at submission 7y ago, some of the pm8018 new compatible
> were rejected in bindings & drivers so I left both...
>
> As of today only the pwrkey bindings is missing, so should I resubmit the pm8018-pwrkey bidings and
> drop the pm8921-pwrkey compatible ?
~7 years ago here:
https://lore.kernel.org/all/20160624220748.GB11719@dtor-ws/
you proposed to add something entirely different than we have here now
and than we talk about.
In that thread you correctly wrote:
"My point of view is that the devicetree describes the hardware and need
to have SoC specific compatible string since it describes the actual
silicon, and drivers must make sure to handle all the SoC or family
variants using the compatible string and the match data."
but implemented it entirely different. Maybe you refer to different mail
thread, I don't know, but that one is indeed wrong.
The DTS looks correct unless you have some real argument that it is not.
How this should be fixed? First, drop bogus entries from drivers, then
document proper compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-29 9:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:14 [PATCH v1 0/7] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-09-28 9:14 ` [PATCH v1 1/7] dt-bindings: arm: qcom: document the swir,mangoh-green-wp8548 board Neil Armstrong
2022-09-28 17:53 ` Krzysztof Kozlowski
2022-09-29 8:20 ` Neil Armstrong
2022-09-28 9:14 ` [PATCH v1 2/7] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
2022-09-28 17:55 ` Krzysztof Kozlowski
2022-09-29 8:24 ` Neil Armstrong
2022-09-28 9:14 ` [PATCH v1 3/7] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
2022-09-28 17:56 ` Krzysztof Kozlowski
2022-09-28 9:14 ` [PATCH v1 4/7] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
2022-09-28 17:58 ` Krzysztof Kozlowski
2022-09-28 9:14 ` [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic subnodes compatibles Neil Armstrong
2022-09-28 18:03 ` Krzysztof Kozlowski
2022-09-29 8:29 ` Neil Armstrong
2022-09-29 9:12 ` Krzysztof Kozlowski [this message]
2022-09-29 10:56 ` Neil Armstrong
2022-09-29 11:12 ` Krzysztof Kozlowski
2022-09-29 11:39 ` Neil Armstrong
2022-09-29 11:47 ` Krzysztof Kozlowski
2022-09-29 11:59 ` Neil Armstrong
2022-09-29 12:02 ` Krzysztof Kozlowski
2022-09-29 12:21 ` Neil Armstrong
2022-09-29 12:27 ` Krzysztof Kozlowski
2022-09-29 12:48 ` Neil Armstrong
2022-09-30 7:33 ` Krzysztof Kozlowski
2022-09-28 9:14 ` [PATCH v1 6/7] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
2022-09-28 9:14 ` [PATCH v1 7/7] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
2022-09-28 18:05 ` Krzysztof Kozlowski
2022-09-29 8:19 ` Neil Armstrong
2022-09-29 9:05 ` Krzysztof Kozlowski
2022-09-29 10:58 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a3c6766-9be5-1e55-95eb-bc9656e5c9a3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.