From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic subnodes compatibles
Date: Thu, 29 Sep 2022 13:59:50 +0200 [thread overview]
Message-ID: <3fa19362-118b-232e-0baf-ee365fa2f2e2@linaro.org> (raw)
In-Reply-To: <f54377f0-a152-9367-1b06-f49df7466282@linaro.org>
On 29/09/2022 13:47, Krzysztof Kozlowski wrote:
> On 29/09/2022 13:39, Neil Armstrong wrote:
>>>>> The DTS looks correct unless you have some real argument that it is not.
>>>>>
>>>>> How this should be fixed? First, drop bogus entries from drivers, then
>>>>> document proper compatibles.
>>>>
>>>> What do you mean ? There's no point to keep the PM8921 compatibles, the gpio
>>>
>>> I asked at beginning - why? Why there is no point to keep them?
>>
>> Because the HW is an PM8018 and the addition of the PM8921 was for policy/organization/struggling-to-make-dt-merged-before-clear-dt-policy/...
>> so you say I should modify the Bindings to reflect the actual "pm8018", "pm8921" situation instead of changing the DT even if incorrect ?
>
> Yes, this is what I already wrote:
>
> "How this should be fixed? First, drop bogus entries from drivers, then
> document proper compatibles."
>
>>>> and PMIC bindings already enforces to only have the PM8018 compatible.
>>>
>>> That is just partial argument because binding does not match DTS. So
>>> something is not correct. Why do you assume bindings are correct?
>>
>> Because bindings accurately reflects HW and DT doesn't.
>
> That's not really an answer... Bindings are correct because they are
> correct? What is exactly correct in the bindings? How they reflect the
> HW in a proper way, while DTS does not?
>
> Or let's focus on actual hardware - what are the properties of the
> hardware which indicate that DTS is wrong?
The actual PMIC is an PM8018
>
> Best regards,
> Krzysztof
>
Neil
next prev parent reply other threads:[~2022-09-29 12:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:14 [PATCH v1 0/7] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-09-28 9:14 ` [PATCH v1 1/7] dt-bindings: arm: qcom: document the swir,mangoh-green-wp8548 board Neil Armstrong
2022-09-28 17:53 ` Krzysztof Kozlowski
2022-09-29 8:20 ` Neil Armstrong
2022-09-28 9:14 ` [PATCH v1 2/7] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
2022-09-28 17:55 ` Krzysztof Kozlowski
2022-09-29 8:24 ` Neil Armstrong
2022-09-28 9:14 ` [PATCH v1 3/7] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
2022-09-28 17:56 ` Krzysztof Kozlowski
2022-09-28 9:14 ` [PATCH v1 4/7] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
2022-09-28 17:58 ` Krzysztof Kozlowski
2022-09-28 9:14 ` [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic subnodes compatibles Neil Armstrong
2022-09-28 18:03 ` Krzysztof Kozlowski
2022-09-29 8:29 ` Neil Armstrong
2022-09-29 9:12 ` Krzysztof Kozlowski
2022-09-29 10:56 ` Neil Armstrong
2022-09-29 11:12 ` Krzysztof Kozlowski
2022-09-29 11:39 ` Neil Armstrong
2022-09-29 11:47 ` Krzysztof Kozlowski
2022-09-29 11:59 ` Neil Armstrong [this message]
2022-09-29 12:02 ` Krzysztof Kozlowski
2022-09-29 12:21 ` Neil Armstrong
2022-09-29 12:27 ` Krzysztof Kozlowski
2022-09-29 12:48 ` Neil Armstrong
2022-09-30 7:33 ` Krzysztof Kozlowski
2022-09-28 9:14 ` [PATCH v1 6/7] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
2022-09-28 9:14 ` [PATCH v1 7/7] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
2022-09-28 18:05 ` Krzysztof Kozlowski
2022-09-29 8:19 ` Neil Armstrong
2022-09-29 9:05 ` Krzysztof Kozlowski
2022-09-29 10:58 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fa19362-118b-232e-0baf-ee365fa2f2e2@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.