All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liang He <windhl@126.com>, linux@armlinux.org.uk, heiko@sntech.de
Cc: linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm: mach-rockchip: (pm) Add missing of_node_put()
Date: Wed, 22 Jun 2022 11:00:11 +0200	[thread overview]
Message-ID: <1a450b67-1e37-1eac-5906-910cb4deefdf@kernel.org> (raw)
In-Reply-To: <20220616021713.3973472-1-windhl@126.com>

On 16/06/2022 04:17, Liang He wrote:
> In rockchip_suspend_init(), of_find_matching_node_and_match() will
> return a node pointer with refcount incremented. We should use
> of_node_put() in fail path or when it is not used anymore.
> 
> Signed-off-by: Liang He <windhl@126.com>
> ---
>  changelog:
> 
>  v2: (1) use real name for Sob (2) use goto-label patch style
>  v1: add of_node_put() for each return
> 

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.



[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/


Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liang He <windhl@126.com>, linux@armlinux.org.uk, heiko@sntech.de
Cc: linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm: mach-rockchip: (pm) Add missing of_node_put()
Date: Wed, 22 Jun 2022 11:00:11 +0200	[thread overview]
Message-ID: <1a450b67-1e37-1eac-5906-910cb4deefdf@kernel.org> (raw)
In-Reply-To: <20220616021713.3973472-1-windhl@126.com>

On 16/06/2022 04:17, Liang He wrote:
> In rockchip_suspend_init(), of_find_matching_node_and_match() will
> return a node pointer with refcount incremented. We should use
> of_node_put() in fail path or when it is not used anymore.
> 
> Signed-off-by: Liang He <windhl@126.com>
> ---
>  changelog:
> 
>  v2: (1) use real name for Sob (2) use goto-label patch style
>  v1: add of_node_put() for each return
> 

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.



[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/


Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liang He <windhl@126.com>, linux@armlinux.org.uk, heiko@sntech.de
Cc: linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm: mach-rockchip: (pm) Add missing of_node_put()
Date: Wed, 22 Jun 2022 11:00:11 +0200	[thread overview]
Message-ID: <1a450b67-1e37-1eac-5906-910cb4deefdf@kernel.org> (raw)
In-Reply-To: <20220616021713.3973472-1-windhl@126.com>

On 16/06/2022 04:17, Liang He wrote:
> In rockchip_suspend_init(), of_find_matching_node_and_match() will
> return a node pointer with refcount incremented. We should use
> of_node_put() in fail path or when it is not used anymore.
> 
> Signed-off-by: Liang He <windhl@126.com>
> ---
>  changelog:
> 
>  v2: (1) use real name for Sob (2) use goto-label patch style
>  v1: add of_node_put() for each return
> 

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.



[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-06-22  9:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  2:17 [PATCH v2] arm: mach-rockchip: (pm) Add missing of_node_put() Liang He
2022-06-16  2:17 ` Liang He
2022-06-16  2:17 ` Liang He
2022-06-17 17:10 ` Heiko Stuebner
2022-06-17 17:10   ` Heiko Stuebner
2022-06-17 17:10   ` Heiko Stuebner
2022-06-18  2:43   ` Liang He
2022-06-18  2:43     ` Liang He
2022-06-18  2:43     ` Liang He
2022-06-22  9:00 ` Krzysztof Kozlowski [this message]
2022-06-22  9:00   ` Krzysztof Kozlowski
2022-06-22  9:00   ` Krzysztof Kozlowski
2022-06-22 13:10   ` Heiko Stuebner
2022-06-22 13:10     ` Heiko Stuebner
2022-06-22 13:10     ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a450b67-1e37-1eac-5906-910cb4deefdf@kernel.org \
    --to=krzk@kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=windhl@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.