* [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register()
@ 2013-02-08 5:39 Jingoo Han
2013-02-08 10:28 ` Tomasz Figa
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jingoo Han @ 2013-02-08 5:39 UTC (permalink / raw)
To: 'Kukjin Kim'
Cc: 'Linus Walleij',
linux-samsung-soc, 'Thomas Abraham', 'Jingoo Han'
This patch removes duplicated line of samsung_pinctrl_register(),
because the number of pins is redundantly assigned twice.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pinctrl/pinctrl-samsung.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
index 294bcdd..3d5cf63 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -716,7 +716,6 @@ static int samsung_pinctrl_register(struct platform_device *pdev,
}
ctrldesc->pins = pindesc;
ctrldesc->npins = drvdata->ctrl->nr_pins;
- ctrldesc->npins = drvdata->ctrl->nr_pins;
/* dynamically populate the pin number and pin name for pindesc */
for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++, pdesc++)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register()
2013-02-08 5:39 [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register() Jingoo Han
@ 2013-02-08 10:28 ` Tomasz Figa
2013-02-08 22:44 ` Kukjin Kim
2013-02-10 19:17 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2013-02-08 10:28 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Kukjin Kim', 'Linus Walleij',
linux-samsung-soc, 'Thomas Abraham'
On Friday 08 of February 2013 14:39:30 Jingoo Han wrote:
> This patch removes duplicated line of samsung_pinctrl_register(),
> because the number of pins is redundantly assigned twice.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pinctrl/pinctrl-samsung.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-samsung.c
> b/drivers/pinctrl/pinctrl-samsung.c index 294bcdd..3d5cf63 100644
> --- a/drivers/pinctrl/pinctrl-samsung.c
> +++ b/drivers/pinctrl/pinctrl-samsung.c
> @@ -716,7 +716,6 @@ static int samsung_pinctrl_register(struct
> platform_device *pdev, }
> ctrldesc->pins = pindesc;
> ctrldesc->npins = drvdata->ctrl->nr_pins;
> - ctrldesc->npins = drvdata->ctrl->nr_pins;
>
> /* dynamically populate the pin number and pin name for pindesc */
> for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++,
pdesc++)
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register()
2013-02-08 5:39 [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register() Jingoo Han
2013-02-08 10:28 ` Tomasz Figa
@ 2013-02-08 22:44 ` Kukjin Kim
2013-02-10 19:17 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2013-02-08 22:44 UTC (permalink / raw)
To: 'Jingoo Han'
Cc: 'Linus Walleij', linux-samsung-soc, 'Thomas Abraham'
Jingoo Han wrote:
>
> This patch removes duplicated line of samsung_pinctrl_register(),
> because the number of pins is redundantly assigned twice.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
- Kukjin
> ---
> drivers/pinctrl/pinctrl-samsung.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-
> samsung.c
> index 294bcdd..3d5cf63 100644
> --- a/drivers/pinctrl/pinctrl-samsung.c
> +++ b/drivers/pinctrl/pinctrl-samsung.c
> @@ -716,7 +716,6 @@ static int samsung_pinctrl_register(struct
> platform_device *pdev,
> }
> ctrldesc->pins = pindesc;
> ctrldesc->npins = drvdata->ctrl->nr_pins;
> - ctrldesc->npins = drvdata->ctrl->nr_pins;
>
> /* dynamically populate the pin number and pin name for pindesc */
> for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++,
pdesc++)
> --
> 1.7.2.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register()
2013-02-08 5:39 [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register() Jingoo Han
2013-02-08 10:28 ` Tomasz Figa
2013-02-08 22:44 ` Kukjin Kim
@ 2013-02-10 19:17 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-02-10 19:17 UTC (permalink / raw)
To: Jingoo Han; +Cc: Kukjin Kim, linux-samsung-soc, Thomas Abraham
On Fri, Feb 8, 2013 at 6:39 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> This patch removes duplicated line of samsung_pinctrl_register(),
> because the number of pins is redundantly assigned twice.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied with the Reviewed-by/Acked-by tags from
the maintainers.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-10 19:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-08 5:39 [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register() Jingoo Han
2013-02-08 10:28 ` Tomasz Figa
2013-02-08 22:44 ` Kukjin Kim
2013-02-10 19:17 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.