From: Chris Packham <Chris.Packham@alliedtelesis.co.nz> To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "wambui.karugax@gmail.com" <wambui.karugax@gmail.com>, "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>, "fw@strlen.de" <fw@strlen.de>, "bobdc9664@seznam.cz" <bobdc9664@seznam.cz>, "aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>, "willy@infradead.org" <willy@infradead.org>, "yuehaibing@huawei.com" <yuehaibing@huawei.com>, "linux@roeck-us.net" <linux@roeck-us.net>, "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>, "brandonbonaby94@gmail.com" <brandonbonaby94@gmail.com>, "sandro@volery.com" <sandro@volery.com>, "paulburton@kernel.org" <paulburton@kernel.org>, "ddaney@caviumnetworks.com" <ddaney@caviumnetworks.com>, "ynezz@true.cz" <ynezz@true.cz>, "julia.lawall@lip6.fr" <julia.lawall@lip6.fr>, "ivalery111@gmail.com" <ivalery111@gmail.com>, "davem@davemloft.net" <davem@davemloft.net>, "geert@linux-m68k.org" <geert@linux-m68k.org> Subject: Re: [PATCH 1/2] staging: octeon: delete driver Date: Tue, 4 Feb 2020 20:06:14 +0000 [thread overview] Message-ID: <1a90dc4c62c482ed6a44de70962996b533d6f627.camel@alliedtelesis.co.nz> (raw) In-Reply-To: <20200204070927.GA966981@kroah.com> On Tue, 2020-02-04 at 07:09 +0000, gregkh@linuxfoundation.org wrote: > On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote: > > I'll pipe up on this thread too > > > > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote: > > > On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote: > > > > This driver has been in the tree since 2009 with no real movement to get > > > > it out. Now it is starting to cause build issues and other problems for > > > > people who want to fix coding style problems, but can not actually build > > > > it. > > > > > > > > As nothing is happening here, just delete the module entirely. > > > > > > > > Reported-by: Guenter Roeck <linux@roeck-us.net> > > > > Cc: David Daney <ddaney@caviumnetworks.com> > > > > Cc: "David S. Miller" <davem@davemloft.net> > > > > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> > > > > Cc: Guenter Roeck <linux@roeck-us.net> > > > > Cc: YueHaibing <yuehaibing@huawei.com> > > > > Cc: Aaro Koskinen <aaro.koskinen@iki.fi> > > > > Cc: Wambui Karuga <wambui.karugax@gmail.com> > > > > Cc: Julia Lawall <julia.lawall@lip6.fr> > > > > Cc: Florian Westphal <fw@strlen.de> > > > > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > > > > Cc: Branden Bonaby <brandonbonaby94@gmail.com> > > > > Cc: "Petr Štetiar" <ynezz@true.cz> > > > > Cc: Sandro Volery <sandro@volery.com> > > > > Cc: Paul Burton <paulburton@kernel.org> > > > > Cc: Dan Carpenter <dan.carpenter@oracle.com> > > > > Cc: Giovanni Gherdovich <bobdc9664@seznam.cz> > > > > Cc: Valery Ivanov <ivalery111@gmail.com> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > Acked-by: Guenter Roeck <linux@roeck-us.net> > > > > Please can we keep this driver. We do have platforms using it and we > > would like it to stay around. > > > > Clearly we'll need to sort things out to a point where they build > > successfully. We've been hoping to see this move out of staging ever > > since we selected Cavium as a vendor. > > Great, can you send me a patchset that reverts this and fixes the build > issues and accept maintainership of the code? > Yep will do. On Tue, 2020-02-04 at 10:21 +0300, Dan Carpenter wrote: > My advice is to delete all the COMPILE_TEST code. That stuff was a > constant source of confusion and headaches. I was also going to suggest this. Since the COMPILE_TEST has been a source of trouble I was going to propose dropping the || COMPILE_TEST from the Kconfig for the octeon drivers.
WARNING: multiple messages have this Message-ID (diff)
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz> To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>, "brandonbonaby94@gmail.com" <brandonbonaby94@gmail.com>, "julia.lawall@lip6.fr" <julia.lawall@lip6.fr>, "paulburton@kernel.org" <paulburton@kernel.org>, "aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>, "yuehaibing@huawei.com" <yuehaibing@huawei.com>, "fw@strlen.de" <fw@strlen.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "willy@infradead.org" <willy@infradead.org>, "ddaney@caviumnetworks.com" <ddaney@caviumnetworks.com>, "bobdc9664@seznam.cz" <bobdc9664@seznam.cz>, "sandro@volery.com" <sandro@volery.com>, "geert@linux-m68k.org" <geert@linux-m68k.org>, "linux@roeck-us.net" <linux@roeck-us.net>, "ivalery111@gmail.com" <ivalery111@gmail.com>, "ynezz@true.cz" <ynezz@true.cz>, "davem@davemloft.net" <davem@davemloft.net>, "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>, "wambui.karugax@gmail.com" <wambui.karugax@gmail.com> Subject: Re: [PATCH 1/2] staging: octeon: delete driver Date: Tue, 4 Feb 2020 20:06:14 +0000 [thread overview] Message-ID: <1a90dc4c62c482ed6a44de70962996b533d6f627.camel@alliedtelesis.co.nz> (raw) In-Reply-To: <20200204070927.GA966981@kroah.com> On Tue, 2020-02-04 at 07:09 +0000, gregkh@linuxfoundation.org wrote: > On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote: > > I'll pipe up on this thread too > > > > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote: > > > On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote: > > > > This driver has been in the tree since 2009 with no real movement to get > > > > it out. Now it is starting to cause build issues and other problems for > > > > people who want to fix coding style problems, but can not actually build > > > > it. > > > > > > > > As nothing is happening here, just delete the module entirely. > > > > > > > > Reported-by: Guenter Roeck <linux@roeck-us.net> > > > > Cc: David Daney <ddaney@caviumnetworks.com> > > > > Cc: "David S. Miller" <davem@davemloft.net> > > > > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> > > > > Cc: Guenter Roeck <linux@roeck-us.net> > > > > Cc: YueHaibing <yuehaibing@huawei.com> > > > > Cc: Aaro Koskinen <aaro.koskinen@iki.fi> > > > > Cc: Wambui Karuga <wambui.karugax@gmail.com> > > > > Cc: Julia Lawall <julia.lawall@lip6.fr> > > > > Cc: Florian Westphal <fw@strlen.de> > > > > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > > > > Cc: Branden Bonaby <brandonbonaby94@gmail.com> > > > > Cc: "Petr Štetiar" <ynezz@true.cz> > > > > Cc: Sandro Volery <sandro@volery.com> > > > > Cc: Paul Burton <paulburton@kernel.org> > > > > Cc: Dan Carpenter <dan.carpenter@oracle.com> > > > > Cc: Giovanni Gherdovich <bobdc9664@seznam.cz> > > > > Cc: Valery Ivanov <ivalery111@gmail.com> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > Acked-by: Guenter Roeck <linux@roeck-us.net> > > > > Please can we keep this driver. We do have platforms using it and we > > would like it to stay around. > > > > Clearly we'll need to sort things out to a point where they build > > successfully. We've been hoping to see this move out of staging ever > > since we selected Cavium as a vendor. > > Great, can you send me a patchset that reverts this and fixes the build > issues and accept maintainership of the code? > Yep will do. On Tue, 2020-02-04 at 10:21 +0300, Dan Carpenter wrote: > My advice is to delete all the COMPILE_TEST code. That stuff was a > constant source of confusion and headaches. I was also going to suggest this. Since the COMPILE_TEST has been a source of trouble I was going to propose dropping the || COMPILE_TEST from the Kconfig for the octeon drivers. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-02-04 20:06 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-10 9:15 [PATCH 1/2] staging: octeon: delete driver Greg Kroah-Hartman 2019-12-10 9:15 ` Greg Kroah-Hartman 2019-12-10 9:15 ` [PATCH 2/2] staging: octeon-usb: delete the octeon usb host controller driver Greg Kroah-Hartman 2019-12-10 9:15 ` Greg Kroah-Hartman 2019-12-10 19:31 ` Aaro Koskinen 2019-12-10 19:31 ` Aaro Koskinen 2019-12-10 20:19 ` Greg Kroah-Hartman 2019-12-10 20:19 ` Greg Kroah-Hartman 2019-12-10 21:27 ` Aaro Koskinen 2019-12-10 21:27 ` Aaro Koskinen 2019-12-11 7:42 ` Greg Kroah-Hartman 2019-12-11 7:42 ` Greg Kroah-Hartman 2020-02-04 4:06 ` Chris Packham 2020-02-04 4:06 ` Chris Packham 2020-02-04 7:15 ` gregkh 2020-02-04 7:15 ` gregkh 2020-02-04 7:21 ` Dan Carpenter 2020-02-04 7:21 ` Dan Carpenter 2019-12-10 10:42 ` [PATCH 1/2] staging: octeon: delete driver Guenter Roeck 2019-12-10 10:42 ` Guenter Roeck 2020-02-04 4:02 ` Chris Packham 2020-02-04 4:02 ` Chris Packham 2020-02-04 7:09 ` gregkh 2020-02-04 7:09 ` gregkh 2020-02-04 20:06 ` Chris Packham [this message] 2020-02-04 20:06 ` Chris Packham 2020-02-04 20:31 ` Matthew Wilcox 2020-02-04 20:31 ` Matthew Wilcox 2020-02-04 22:53 ` gregkh 2020-02-04 22:53 ` gregkh 2020-02-05 3:34 ` Dan Carpenter 2020-02-05 3:34 ` Dan Carpenter 2020-02-05 3:44 ` Matthew Wilcox 2020-02-05 3:44 ` Matthew Wilcox 2020-02-05 3:56 ` Guenter Roeck 2020-02-05 3:56 ` Guenter Roeck 2020-02-05 9:03 ` Geert Uytterhoeven 2020-02-05 9:03 ` Geert Uytterhoeven 2020-02-05 13:52 ` Guenter Roeck 2020-02-05 13:52 ` Guenter Roeck 2020-02-06 8:18 ` Geert Uytterhoeven 2020-02-06 8:18 ` Geert Uytterhoeven 2020-02-04 20:57 ` [SPAM] " Guenter Roeck 2019-12-10 11:40 ` Sandro Volery 2019-12-10 11:40 ` Sandro Volery 2019-12-10 12:01 ` Greg Kroah-Hartman 2019-12-10 12:01 ` Greg Kroah-Hartman 2019-12-10 12:54 ` Sandro Volery 2019-12-10 12:54 ` Sandro Volery 2019-12-10 19:46 ` Aaro Koskinen 2019-12-10 19:46 ` Aaro Koskinen 2019-12-10 20:15 ` Guenter Roeck 2019-12-10 20:15 ` Guenter Roeck 2019-12-10 21:48 ` Aaro Koskinen 2019-12-10 21:48 ` Aaro Koskinen 2019-12-10 22:48 ` Guenter Roeck 2019-12-10 22:48 ` Guenter Roeck 2019-12-11 7:22 ` Dan Carpenter 2019-12-11 7:22 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1a90dc4c62c482ed6a44de70962996b533d6f627.camel@alliedtelesis.co.nz \ --to=chris.packham@alliedtelesis.co.nz \ --cc=aaro.koskinen@iki.fi \ --cc=bobdc9664@seznam.cz \ --cc=brandonbonaby94@gmail.com \ --cc=dan.carpenter@oracle.com \ --cc=davem@davemloft.net \ --cc=ddaney@caviumnetworks.com \ --cc=devel@driverdev.osuosl.org \ --cc=fw@strlen.de \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=ivalery111@gmail.com \ --cc=julia.lawall@lip6.fr \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=paulburton@kernel.org \ --cc=sandro@volery.com \ --cc=wambui.karugax@gmail.com \ --cc=willy@infradead.org \ --cc=ynezz@true.cz \ --cc=yuehaibing@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.