All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] pinctrl: bcm2835: Add support for all BCM2711 GPIOs
Date: Wed, 29 Jan 2020 14:56:14 +0100	[thread overview]
Message-ID: <1aca11e7f66c0ebfc9499097d7c40a1835a80224.camel@suse.de> (raw)
In-Reply-To: <1580148908-4863-1-git-send-email-stefan.wahren@i2se.com>

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

On Mon, 2020-01-27 at 19:15 +0100, Stefan Wahren wrote:
> The BCM2711 supports 58 GPIOs [1] by using the existing BCM2835 GPIO registers
> completely. So there is no need to change the binding.
> 
> Patch 1 and 2 prepare the pinctrl driver to be extended to 58 GPIOs in Patch
> 3.
> I didn't want to squash them in order to make review as easy as possible.
> The final patch 4 assigns all SoC GPIOs a label as we already did for
> the older Raspberry Pi boards.
> 
> [1] - https://github.com/raspberrypi/linux/issues/3101#issuecomment-573092294
> 
> Stefan Wahren (4):
>   pinctrl: bcm2835: Drop unused define
>   pinctrl: bcm2835: Refactor platform data
>   pinctrl: bcm2835: Add support for all GPIOs on BCM2711
>   ARM: dts: bcm2711-rpi-4-b: Add SoC GPIO labels
> 
>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts |  74 ++++++++++++++++++++++++
>  drivers/pinctrl/bcm/pinctrl-bcm2835.c | 106 ++++++++++++++++++++++++++-------
> -
>  2 files changed, 156 insertions(+), 24 deletions(-)

Overall this looks good to me (modulo the small comments). I also gave it a go
on RPi4 and RPi3b without issues.

Regards,
Nicolas


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>
Cc: linux-gpio@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] pinctrl: bcm2835: Add support for all BCM2711 GPIOs
Date: Wed, 29 Jan 2020 14:56:14 +0100	[thread overview]
Message-ID: <1aca11e7f66c0ebfc9499097d7c40a1835a80224.camel@suse.de> (raw)
In-Reply-To: <1580148908-4863-1-git-send-email-stefan.wahren@i2se.com>


[-- Attachment #1.1: Type: text/plain, Size: 1142 bytes --]

On Mon, 2020-01-27 at 19:15 +0100, Stefan Wahren wrote:
> The BCM2711 supports 58 GPIOs [1] by using the existing BCM2835 GPIO registers
> completely. So there is no need to change the binding.
> 
> Patch 1 and 2 prepare the pinctrl driver to be extended to 58 GPIOs in Patch
> 3.
> I didn't want to squash them in order to make review as easy as possible.
> The final patch 4 assigns all SoC GPIOs a label as we already did for
> the older Raspberry Pi boards.
> 
> [1] - https://github.com/raspberrypi/linux/issues/3101#issuecomment-573092294
> 
> Stefan Wahren (4):
>   pinctrl: bcm2835: Drop unused define
>   pinctrl: bcm2835: Refactor platform data
>   pinctrl: bcm2835: Add support for all GPIOs on BCM2711
>   ARM: dts: bcm2711-rpi-4-b: Add SoC GPIO labels
> 
>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts |  74 ++++++++++++++++++++++++
>  drivers/pinctrl/bcm/pinctrl-bcm2835.c | 106 ++++++++++++++++++++++++++-------
> -
>  2 files changed, 156 insertions(+), 24 deletions(-)

Overall this looks good to me (modulo the small comments). I also gave it a go
on RPi4 and RPi3b without issues.

Regards,
Nicolas


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-01-29 13:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 18:15 [RFC PATCH 0/4] pinctrl: bcm2835: Add support for all BCM2711 GPIOs Stefan Wahren
2020-01-27 18:15 ` Stefan Wahren
2020-01-27 18:15 ` [RFC PATCH 1/4] pinctrl: bcm2835: Drop unused define Stefan Wahren
2020-01-27 18:15   ` Stefan Wahren
2020-02-14 10:46   ` Linus Walleij
2020-02-14 10:46     ` Linus Walleij
2020-01-27 18:15 ` [RFC PATCH 2/4] pinctrl: bcm2835: Refactor platform data Stefan Wahren
2020-01-27 18:15   ` Stefan Wahren
2020-01-28  9:44   ` Nicolas Saenz Julienne
2020-01-28  9:44     ` Nicolas Saenz Julienne
2020-01-29 13:52   ` Nicolas Saenz Julienne
2020-01-29 13:52     ` Nicolas Saenz Julienne
2020-01-27 18:15 ` [RFC PATCH 3/4] pinctrl: bcm2835: Add support for all GPIOs on BCM2711 Stefan Wahren
2020-01-27 18:15   ` Stefan Wahren
2020-01-27 18:15 ` [RFC PATCH 4/4] ARM: dts: bcm2711-rpi-4-b: Add SoC GPIO labels Stefan Wahren
2020-01-27 18:15   ` Stefan Wahren
2020-01-28 10:05   ` Nicolas Saenz Julienne
2020-01-28 10:05     ` Nicolas Saenz Julienne
2020-01-29 13:53   ` Nicolas Saenz Julienne
2020-01-29 13:53     ` Nicolas Saenz Julienne
2020-01-28 10:17 ` [RFC PATCH 0/4] pinctrl: bcm2835: Add support for all BCM2711 GPIOs Nicolas Saenz Julienne
2020-01-28 10:17   ` Nicolas Saenz Julienne
2020-01-29 13:56 ` Nicolas Saenz Julienne [this message]
2020-01-29 13:56   ` Nicolas Saenz Julienne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1aca11e7f66c0ebfc9499097d7c40a1835a80224.camel@suse.de \
    --to=nsaenzjulienne@suse.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.