* [PATCH] gc: fix some sparse 'symbol not declared' warnings
@ 2020-07-09 0:23 Ramsay Jones
2020-07-09 11:21 ` Derrick Stolee
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2020-07-09 0:23 UTC (permalink / raw)
To: Derrick Stolee; +Cc: GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Derrick,
If you need to re-roll your 'ds/maintenance' branch, could you please
squash this into the relevant patches. The first hunk should be squashed
into commit a138b8ff61 (maintenance: create basic maintenance runner,
2020-07-07) and the second hunk into commit aca963ff39 (maintenance:
initialize task array and hashmap, 2020-07-07).
Thanks!
ATB,
Ramsay Jones
builtin/gc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/gc.c b/builtin/gc.c
index c3531561c2..de029d687b 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -716,7 +716,7 @@ static const char * const builtin_maintenance_usage[] = {
NULL
};
-struct maintenance_opts {
+static struct maintenance_opts {
int auto_flag;
int quiet;
int tasks_selected;
@@ -1297,9 +1297,9 @@ static int task_entry_cmp(const void *unused_cmp_data,
return strcasecmp(e1->name, name ? name : e2->name);
}
-struct maintenance_task *tasks[MAX_NUM_TASKS];
-int num_tasks;
-struct hashmap task_map;
+static struct maintenance_task *tasks[MAX_NUM_TASKS];
+static int num_tasks;
+static struct hashmap task_map;
static int compare_tasks_by_selection(const void *a_, const void *b_)
{
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gc: fix some sparse 'symbol not declared' warnings
2020-07-09 0:23 [PATCH] gc: fix some sparse 'symbol not declared' warnings Ramsay Jones
@ 2020-07-09 11:21 ` Derrick Stolee
0 siblings, 0 replies; 2+ messages in thread
From: Derrick Stolee @ 2020-07-09 11:21 UTC (permalink / raw)
To: Ramsay Jones, Derrick Stolee; +Cc: GIT Mailing-list
On 7/8/2020 8:23 PM, Ramsay Jones wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Derrick,
>
> If you need to re-roll your 'ds/maintenance' branch, could you please
> squash this into the relevant patches. The first hunk should be squashed
> into commit a138b8ff61 (maintenance: create basic maintenance runner,
> 2020-07-07) and the second hunk into commit aca963ff39 (maintenance:
> initialize task array and hashmap, 2020-07-07).
Can do, thanks! Sorry for the disruption.
-Stolee
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-09 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 0:23 [PATCH] gc: fix some sparse 'symbol not declared' warnings Ramsay Jones
2020-07-09 11:21 ` Derrick Stolee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.