From: "liuyuntao (F)" <liuyuntao12@huawei.com> To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: Russell King <linux@armlinux.org.uk>, Andrew Davis <afd@ti.com>, Andrew Morton <akpm@linux-foundation.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Jonathan Corbet <corbet@lwn.net>, Mike Rapoport <rppt@kernel.org>, Eric DeVolder <eric.devolder@oracle.com>, Rob Herring <robh@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Linus Walleij <linus.walleij@linaro.org> Subject: Re: [PATCH -next] arm32: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION Date: Thu, 22 Feb 2024 19:32:03 +0800 [thread overview] Message-ID: <1ae25437-b190-418d-a4e0-aa17d6de59bf@huawei.com> (raw) In-Reply-To: <f5326293-b446-49e5-9cc0-78c9009af136@app.fastmail.com> On 2024/2/22 17:52, Arnd Bergmann wrote: > On Wed, Feb 21, 2024, at 16:51, Arnd Bergmann wrote: >> I have given your patch some build testing with random >> configurations in my build setup and it seems to work >> fine with gcc/binutils, but unfortunately I came across >> a link failure using clang/lld: > > I ran into another bug now, this time with CONFIG_XIP_KERNEL=y: > > no __ex_table in file: vmlinux > Failed to sort kernel tables > make[4]: *** [scripts/Makefile.vmlinux:37: vmlinux] Error 1 > > Essentially you have to modify arch/arm/kernel/vmlinux-xip.lds.S > the same way as vmlinux.lds.S: > Thanks a lot. I didn't consider this situation. I will take your advice. Thanks again. > --- a/arch/arm/kernel/vmlinux-xip.lds.S > +++ b/arch/arm/kernel/vmlinux-xip.lds.S > @@ -63,7 +63,7 @@ SECTIONS > . = ALIGN(4); > __ex_table : AT(ADDR(__ex_table) - LOAD_OFFSET) { > __start___ex_table = .; > - ARM_MMU_KEEP(*(__ex_table)) > + ARM_MMU_KEEP(KEEP(*(__ex_table))) > __stop___ex_table = .; > } > > @@ -83,7 +83,7 @@ SECTIONS > } > .init.arch.info : { > __arch_info_begin = .; > - *(.arch.info.init) > + KEEP(*(.arch.info.init)) > __arch_info_end = .; > } > .init.tagtable : { > > > The pv_table is not needed for XIP_KERNEL=y because that > requires not patching the kernel. > > Arnd
WARNING: multiple messages have this Message-ID (diff)
From: "liuyuntao (F)" <liuyuntao12@huawei.com> To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: Russell King <linux@armlinux.org.uk>, Andrew Davis <afd@ti.com>, Andrew Morton <akpm@linux-foundation.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Jonathan Corbet <corbet@lwn.net>, Mike Rapoport <rppt@kernel.org>, Eric DeVolder <eric.devolder@oracle.com>, Rob Herring <robh@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Linus Walleij <linus.walleij@linaro.org> Subject: Re: [PATCH -next] arm32: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION Date: Thu, 22 Feb 2024 19:32:03 +0800 [thread overview] Message-ID: <1ae25437-b190-418d-a4e0-aa17d6de59bf@huawei.com> (raw) In-Reply-To: <f5326293-b446-49e5-9cc0-78c9009af136@app.fastmail.com> On 2024/2/22 17:52, Arnd Bergmann wrote: > On Wed, Feb 21, 2024, at 16:51, Arnd Bergmann wrote: >> I have given your patch some build testing with random >> configurations in my build setup and it seems to work >> fine with gcc/binutils, but unfortunately I came across >> a link failure using clang/lld: > > I ran into another bug now, this time with CONFIG_XIP_KERNEL=y: > > no __ex_table in file: vmlinux > Failed to sort kernel tables > make[4]: *** [scripts/Makefile.vmlinux:37: vmlinux] Error 1 > > Essentially you have to modify arch/arm/kernel/vmlinux-xip.lds.S > the same way as vmlinux.lds.S: > Thanks a lot. I didn't consider this situation. I will take your advice. Thanks again. > --- a/arch/arm/kernel/vmlinux-xip.lds.S > +++ b/arch/arm/kernel/vmlinux-xip.lds.S > @@ -63,7 +63,7 @@ SECTIONS > . = ALIGN(4); > __ex_table : AT(ADDR(__ex_table) - LOAD_OFFSET) { > __start___ex_table = .; > - ARM_MMU_KEEP(*(__ex_table)) > + ARM_MMU_KEEP(KEEP(*(__ex_table))) > __stop___ex_table = .; > } > > @@ -83,7 +83,7 @@ SECTIONS > } > .init.arch.info : { > __arch_info_begin = .; > - *(.arch.info.init) > + KEEP(*(.arch.info.init)) > __arch_info_end = .; > } > .init.tagtable : { > > > The pv_table is not needed for XIP_KERNEL=y because that > requires not patching the kernel. > > Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-22 11:32 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-20 8:15 [PATCH -next] arm32: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION Yuntao Liu 2024-02-20 8:15 ` Yuntao Liu 2024-02-20 8:40 ` Arnd Bergmann 2024-02-20 8:40 ` Arnd Bergmann 2024-02-20 9:53 ` liuyuntao (F) 2024-02-20 9:53 ` liuyuntao (F) 2024-02-21 15:51 ` Arnd Bergmann 2024-02-21 15:51 ` Arnd Bergmann 2024-02-22 9:52 ` Arnd Bergmann 2024-02-22 9:52 ` Arnd Bergmann 2024-02-22 11:32 ` liuyuntao (F) [this message] 2024-02-22 11:32 ` liuyuntao (F) 2024-02-22 11:24 ` liuyuntao (F) 2024-02-22 11:24 ` liuyuntao (F) 2024-02-22 16:04 ` Arnd Bergmann 2024-02-22 16:04 ` Arnd Bergmann 2024-02-23 1:39 ` liuyuntao (F) 2024-02-23 1:39 ` liuyuntao (F) 2024-02-23 6:32 ` Arnd Bergmann 2024-02-23 6:32 ` Arnd Bergmann 2024-02-27 8:06 ` liuyuntao (F) 2024-02-27 8:06 ` liuyuntao (F) 2024-03-07 3:09 ` liuyuntao (F) 2024-03-07 3:09 ` liuyuntao (F) 2024-03-07 7:29 ` Arnd Bergmann 2024-03-07 7:29 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1ae25437-b190-418d-a4e0-aa17d6de59bf@huawei.com \ --to=liuyuntao12@huawei.com \ --cc=afd@ti.com \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=corbet@lwn.net \ --cc=eric.devolder@oracle.com \ --cc=geert+renesas@glider.be \ --cc=kirill.shutemov@linux.intel.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=robh@kernel.org \ --cc=rppt@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.