From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Luis Chamberlain <mcgrof@kernel.org>,
Aaron Tomlin <atomlin@redhat.com>,
Michal Suchanek <msuchanek@suse.de>
Cc: "cl@linux.com" <cl@linux.com>,
"pmladek@suse.com" <pmladek@suse.com>,
"mbenes@suse.cz" <mbenes@suse.cz>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"jeyu@kernel.org" <jeyu@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
"atomlin@atomlin.com" <atomlin@atomlin.com>,
"ghalat@redhat.com" <ghalat@redhat.com>,
"allen.lkml@gmail.com" <allen.lkml@gmail.com>,
"void@manifault.com" <void@manifault.com>,
"joe@perches.com" <joe@perches.com>
Subject: Re: [RFC PATCH v4 00/13] module: core code clean up
Date: Thu, 3 Feb 2022 18:01:21 +0000 [thread overview]
Message-ID: <1ae3a950-8c1e-a212-e557-8f112a16457d@csgroup.eu> (raw)
In-Reply-To: <Yfsf2SGELhQ71Ovo@bombadil.infradead.org>
Le 03/02/2022 à 01:20, Luis Chamberlain a écrit :
> On Sun, Jan 30, 2022 at 09:32:01PM +0000, Aaron Tomlin wrote:
>> Hi Luis,
>>
>> As per your suggestion [1], this is an attempt to refactor and split
>> optional code out of core module support code into separate components.
>> This version is based on branch mcgrof/modules-next since a97ac8cb24a3/or
>> modules-5.17-rc1. Please let me know your thoughts.
>>
>> Changes since v1 [2]:
>
I have another comment: I think patch 5 should be dropped.
Having something behave based on a CONFIG_ARCH_HAS_SOMETHING item is
wrong. It is not because a plateform selects
CONFIG_ARCH_HAS_STRICT_MODULE_RWX that the module core should behave
differentely than with other platforms as far as the user has not
selected CONFIG_STRICT_MODULE_RWX.
And the topic here is wrong. It is a coincidence if making that stuff
depend on CONFIG_ARCH_HAS_STRICT_MODULE_RWX works. This is just because
the only architectures that do the module allocation without Exec flag
are architectures that have also selected
CONFIG_ARCH_HAS_STRICT_MODULE_RWX. But it should also work on other
architectures.
I don't know exactly what was the motivation for commit 93651f80dcb6
("modules: fix compile error if don't have strict module rwx") at the
first place but it is just wrong and we should fix it.
module_enable_x() should work just fine regardless of
CONFIG_ARCH_HAS_STRICT_MODULE_RWX.
Thanks
Christophe
next prev parent reply other threads:[~2022-02-03 18:01 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 21:32 [RFC PATCH v4 00/13] module: core code clean up Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 01/13] module: Move all into module/ Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 02/13] module: Simple refactor in preparation for split Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 03/13] module: Move livepatch support to a separate file Aaron Tomlin
2022-01-30 23:50 ` kernel test robot
2022-02-08 11:42 ` Petr Mladek
2022-02-08 15:18 ` Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 04/13] module: Move latched RB-tree " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 05/13] module: Move arch strict rwx " Aaron Tomlin
2022-01-30 23:50 ` kernel test robot
2022-01-30 21:32 ` [RFC PATCH v4 06/13] module: Move " Aaron Tomlin
2022-01-31 0:30 ` kernel test robot
2022-01-30 21:32 ` [RFC PATCH v4 07/13] module: Move extra signature support out of core code Aaron Tomlin
2022-02-09 14:28 ` Miroslav Benes
2022-02-09 14:37 ` Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 08/13] module: Move kmemleak support to a separate file Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 09/13] module: Move kallsyms support into " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 10/13] module: Move procfs " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 11/13] module: Move sysfs " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 12/13] module: Move kdb_modules list out of core code Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 13/13] module: Move version support into a separate file Aaron Tomlin
2022-01-31 0:41 ` kernel test robot
2022-02-01 16:44 ` [RFC PATCH v4 00/13] module: core code clean up Allen
2022-02-05 20:33 ` Aaron Tomlin
2022-02-02 2:44 ` Luis Chamberlain
2022-02-06 14:40 ` Aaron Tomlin
2022-02-03 0:20 ` Luis Chamberlain
2022-02-03 7:48 ` Christophe Leroy
2022-02-06 14:45 ` Aaron Tomlin
2022-02-03 18:01 ` Christophe Leroy [this message]
2022-02-06 16:54 ` Aaron Tomlin
2022-02-07 16:46 ` Aaron Tomlin
2022-02-07 17:17 ` Christophe Leroy
2022-02-07 18:01 ` Aaron Tomlin
2022-02-08 7:50 ` Christophe Leroy
2022-02-08 10:05 ` Aaron Tomlin
2022-02-03 18:15 ` Christophe Leroy
2022-02-06 16:57 ` Aaron Tomlin
2022-02-03 19:43 ` Michal Suchánek
2022-02-03 20:13 ` Luis Chamberlain
2022-02-03 20:10 ` Luis Chamberlain
2022-02-06 17:00 ` Aaron Tomlin
2022-02-06 14:42 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ae3a950-8c1e-a212-e557-8f112a16457d@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=atomlin@atomlin.com \
--cc=atomlin@redhat.com \
--cc=cl@linux.com \
--cc=ghalat@redhat.com \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=msuchanek@suse.de \
--cc=pmladek@suse.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.