All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Tomlin <atomlin@redhat.com>
To: Petr Mladek <pmladek@suse.com>
Cc: mcgrof@kernel.org, cl@linux.com, mbenes@suse.cz,
	akpm@linux-foundation.org, jeyu@kernel.org,
	linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
	live-patching@vger.kernel.org, atomlin@atomlin.com,
	ghalat@redhat.com, allen.lkml@gmail.com, void@manifault.com,
	joe@perches.com
Subject: Re: [RFC PATCH v4 03/13] module: Move livepatch support to a separate file
Date: Tue, 8 Feb 2022 15:18:53 +0000	[thread overview]
Message-ID: <20220208151853.avy4e7sgyutuempk@ava.usersys.com> (raw)
In-Reply-To: <YgJXEhiwn5B4Psxa@alley>

On Tue 2022-02-08 12:42 +0100, Petr Mladek wrote:
> This should go to internal.h.
> 
> Alternative is to move both is_livepatch_module() and
> set_livepatch_module() into include/linux/livepatch.h.
> 
> I do not have strong opinion.

Hi Petr,

Firstly, thank you for your feedback.

In my opinion, I believe is_livepatch_module() should remain as it may
continue to be used externally i.e., outside of kernel/module/; albeit,
indeed set_livepatch_module() should be moved to kernel/module/internal.h
given its use is exclusive to core code.


Kind regards,

-- 
Aaron Tomlin


  reply	other threads:[~2022-02-08 15:19 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-30 21:32 [RFC PATCH v4 00/13] module: core code clean up Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 01/13] module: Move all into module/ Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 02/13] module: Simple refactor in preparation for split Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 03/13] module: Move livepatch support to a separate file Aaron Tomlin
2022-01-30 23:50   ` kernel test robot
2022-02-08 11:42   ` Petr Mladek
2022-02-08 15:18     ` Aaron Tomlin [this message]
2022-01-30 21:32 ` [RFC PATCH v4 04/13] module: Move latched RB-tree " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 05/13] module: Move arch strict rwx " Aaron Tomlin
2022-01-30 23:50   ` kernel test robot
2022-01-30 21:32 ` [RFC PATCH v4 06/13] module: Move " Aaron Tomlin
2022-01-31  0:30   ` kernel test robot
2022-01-30 21:32 ` [RFC PATCH v4 07/13] module: Move extra signature support out of core code Aaron Tomlin
2022-02-09 14:28   ` Miroslav Benes
2022-02-09 14:37     ` Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 08/13] module: Move kmemleak support to a separate file Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 09/13] module: Move kallsyms support into " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 10/13] module: Move procfs " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 11/13] module: Move sysfs " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 12/13] module: Move kdb_modules list out of core code Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 13/13] module: Move version support into a separate file Aaron Tomlin
2022-01-31  0:41   ` kernel test robot
2022-02-01 16:44 ` [RFC PATCH v4 00/13] module: core code clean up Allen
2022-02-05 20:33   ` Aaron Tomlin
2022-02-02  2:44 ` Luis Chamberlain
2022-02-06 14:40   ` Aaron Tomlin
2022-02-03  0:20 ` Luis Chamberlain
2022-02-03  7:48   ` Christophe Leroy
2022-02-06 14:45     ` Aaron Tomlin
2022-02-03 18:01   ` Christophe Leroy
2022-02-06 16:54     ` Aaron Tomlin
2022-02-07 16:46     ` Aaron Tomlin
2022-02-07 17:17       ` Christophe Leroy
2022-02-07 18:01         ` Aaron Tomlin
2022-02-08  7:50           ` Christophe Leroy
2022-02-08 10:05             ` Aaron Tomlin
2022-02-03 18:15   ` Christophe Leroy
2022-02-06 16:57     ` Aaron Tomlin
2022-02-03 19:43   ` Michal Suchánek
2022-02-03 20:13     ` Luis Chamberlain
2022-02-03 20:10   ` Luis Chamberlain
2022-02-06 17:00     ` Aaron Tomlin
2022-02-06 14:42   ` Aaron Tomlin
2022-01-31 12:45 [RFC PATCH v4 01/13] module: Move all into module/ Aaron Tomlin
2022-01-31 12:45 ` [RFC PATCH v4 03/13] module: Move livepatch support to a separate file Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220208151853.avy4e7sgyutuempk@ava.usersys.com \
    --to=atomlin@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=allen.lkml@gmail.com \
    --cc=atomlin@atomlin.com \
    --cc=cl@linux.com \
    --cc=ghalat@redhat.com \
    --cc=jeyu@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mcgrof@kernel.org \
    --cc=pmladek@suse.com \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.