* [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
@ 2018-06-14 23:39 Philippe Mathieu-Daudé
2018-06-15 3:44 ` Richard Henderson
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-06-14 23:39 UTC (permalink / raw)
To: Emilio G . Cota, Richard Henderson, Paolo Bonzini,
Mark Cave-Ayland, Hervé Poussineau
Cc: Philippe Mathieu-Daudé, qemu-devel
On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
in the 3C0H-3CFH range, thus I/O base used by the parallel
device clashes, and since a4cb773928e the VGA is not
working:
(qemu) info mtree
address-space: memory
0000000000000000-ffffffffffffffff (prio 0, i/o): system
00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
...
00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
^^^ ^^^^^^^^
00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
^^^
00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
...
As there is no particular reason to use this base address
(introduced in 7bea0dd434e), change to 378H which is the
default on PC machines.
Reported-by: Emilio G. Cota <cota@braap.org>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html
hw/isa/smc37c669-superio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/isa/smc37c669-superio.c b/hw/isa/smc37c669-superio.c
index aa233c6967..64466a9373 100644
--- a/hw/isa/smc37c669-superio.c
+++ b/hw/isa/smc37c669-superio.c
@@ -37,7 +37,7 @@ static bool is_parallel_enabled(ISASuperIODevice *sio, uint8_t index)
static uint16_t get_parallel_iobase(ISASuperIODevice *sio, uint8_t index)
{
- return 0x3bc;
+ return 0x378;
}
static unsigned int get_parallel_irq(ISASuperIODevice *sio, uint8_t index)
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
2018-06-14 23:39 [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H Philippe Mathieu-Daudé
@ 2018-06-15 3:44 ` Richard Henderson
2018-06-15 7:25 ` Mark Cave-Ayland
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2018-06-15 3:44 UTC (permalink / raw)
To: Philippe Mathieu-Daudé,
Emilio G . Cota, Richard Henderson, Paolo Bonzini,
Mark Cave-Ayland, Hervé Poussineau
Cc: qemu-devel
On 06/14/2018 01:39 PM, Philippe Mathieu-Daudé wrote:
> On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
> in the 3C0H-3CFH range, thus I/O base used by the parallel
> device clashes, and since a4cb773928e the VGA is not
> working:
>
> (qemu) info mtree
> address-space: memory
> 0000000000000000-ffffffffffffffff (prio 0, i/o): system
> 00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
> ...
> 00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
> 00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
> 00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
> ^^^ ^^^^^^^^
> 00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
> ^^^
> 00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
> 00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
> ...
>
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.
>
> Reported-by: Emilio G. Cota <cota@braap.org>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
2018-06-14 23:39 [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H Philippe Mathieu-Daudé
2018-06-15 3:44 ` Richard Henderson
@ 2018-06-15 7:25 ` Mark Cave-Ayland
2018-06-15 13:20 ` Emilio G. Cota
2018-06-17 5:50 ` Richard Henderson
3 siblings, 0 replies; 5+ messages in thread
From: Mark Cave-Ayland @ 2018-06-15 7:25 UTC (permalink / raw)
To: Philippe Mathieu-Daudé,
Emilio G . Cota, Richard Henderson, Paolo Bonzini,
Hervé Poussineau
Cc: qemu-devel
On 15/06/18 00:39, Philippe Mathieu-Daudé wrote:
> On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
> in the 3C0H-3CFH range, thus I/O base used by the parallel
> device clashes, and since a4cb773928e the VGA is not
> working:
>
> (qemu) info mtree
> address-space: memory
> 0000000000000000-ffffffffffffffff (prio 0, i/o): system
> 00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
> ...
> 00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
> 00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
> 00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
> ^^^ ^^^^^^^^
> 00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
> ^^^
> 00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
> 00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
> ...
>
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.
>
> Reported-by: Emilio G. Cota <cota@braap.org>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html
>
> hw/isa/smc37c669-superio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/isa/smc37c669-superio.c b/hw/isa/smc37c669-superio.c
> index aa233c6967..64466a9373 100644
> --- a/hw/isa/smc37c669-superio.c
> +++ b/hw/isa/smc37c669-superio.c
> @@ -37,7 +37,7 @@ static bool is_parallel_enabled(ISASuperIODevice *sio, uint8_t index)
>
> static uint16_t get_parallel_iobase(ISASuperIODevice *sio, uint8_t index)
> {
> - return 0x3bc;
> + return 0x378;
> }
>
> static unsigned int get_parallel_irq(ISASuperIODevice *sio, uint8_t index)
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
2018-06-14 23:39 [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H Philippe Mathieu-Daudé
2018-06-15 3:44 ` Richard Henderson
2018-06-15 7:25 ` Mark Cave-Ayland
@ 2018-06-15 13:20 ` Emilio G. Cota
2018-06-17 5:50 ` Richard Henderson
3 siblings, 0 replies; 5+ messages in thread
From: Emilio G. Cota @ 2018-06-15 13:20 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Richard Henderson, Paolo Bonzini, Mark Cave-Ayland,
Hervé Poussineau, qemu-devel
On Thu, Jun 14, 2018 at 20:39:35 -0300, Philippe Mathieu-Daudé wrote:
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.
Tested-by: Emilio G. Cota <cota@braap.org>
Thanks,
Emilio
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
2018-06-14 23:39 [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2018-06-15 13:20 ` Emilio G. Cota
@ 2018-06-17 5:50 ` Richard Henderson
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2018-06-17 5:50 UTC (permalink / raw)
To: Philippe Mathieu-Daudé,
Emilio G . Cota, Richard Henderson, Paolo Bonzini,
Mark Cave-Ayland, Hervé Poussineau
Cc: qemu-devel
On 06/14/2018 01:39 PM, Philippe Mathieu-Daudé wrote:
> On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
> in the 3C0H-3CFH range, thus I/O base used by the parallel
> device clashes, and since a4cb773928e the VGA is not
> working:
>
> (qemu) info mtree
> address-space: memory
> 0000000000000000-ffffffffffffffff (prio 0, i/o): system
> 00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
> ...
> 00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
> 00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
> 00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
> ^^^ ^^^^^^^^
> 00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
> ^^^
> 00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
> 00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
> ...
>
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.
>
> Reported-by: Emilio G. Cota <cota@braap.org>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html
>
> hw/isa/smc37c669-superio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Queued to tgt-axp.
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-17 5:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-14 23:39 [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H Philippe Mathieu-Daudé
2018-06-15 3:44 ` Richard Henderson
2018-06-15 7:25 ` Mark Cave-Ayland
2018-06-15 13:20 ` Emilio G. Cota
2018-06-17 5:50 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.