[PATCH resend] meta/classes: add class to test for unsatisfied RRECOMMENDS

[PATCH resend] meta/classes: add class to test for unsatisfied RRECOMMENDS

[Jose Alarcon]

The do_rootfs log contains a number of unsatisfied package
recommendations. At the moment those are only visible when
reviewing the rootfs log.

This class adds an extra check to surface any unsatisfied
recommendation  as WARNINGS to the build output.

Signed-off-by: Jose Alarcon <jose.alarcon@ge.com>
---
 meta/classes/rootfs-check-recommends.bbclass | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta/classes/rootfs-check-recommends.bbclass

diff --git a/meta/classes/rootfs-check-recommends.bbclass b/meta/classes/rootfs-check-recommends.bbclass
new file mode 100644
index 0000000..351e438
--- /dev/null
+++ b/meta/classes/rootfs-check-recommends.bbclass
@@ -0,0 +1,21 @@
+#
+# This bbclass adds an extra check to surface any unsatisfied
+# recommendation (RRECOMMENDS) as WARNINGS to the build output.
+#
+# To enable, use INHERIT in conf/distro/distro.conf:
+#
+#       INHERIT += "rootfs-check-recommends"
+#
+
+python log_check_recommends() {
+    log_path = d.expand("${T}/log.do_rootfs")
+    with open(log_path, 'r') as log:
+        for line in log:
+            if 'log_check' in line:
+                continue
+
+            if 'unsatisfied recommendation for' in line:
+                bb.warn('[log_check] %s: %s' % (d.getVar('PN', True), line))
+}
+
+do_rootfs[postfuncs] += "log_check_recommends "
-- 
2.10.1

Re: [PATCH resend] meta/classes: add class to test for unsatisfied RRECOMMENDS

[Richard Purdie]

On Fri, 2017-08-25 at 09:43 +0300, Jose Alarcon wrote:
> The do_rootfs log contains a number of unsatisfied package
> recommendations. At the moment those are only visible when
> reviewing the rootfs log.
> 
> This class adds an extra check to surface any unsatisfied
> recommendation  as WARNINGS to the build output.
> 
> Signed-off-by: Jose Alarcon <jose.alarcon@ge.com>
> ---
>  meta/classes/rootfs-check-recommends.bbclass | 21
> +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 meta/classes/rootfs-check-recommends.bbclass

This looks like it would be a better fit for rootfs-
postcommands.bbclass?

We want to try and avoid too many classes if we can help it.

Cheers,

Richard

Re: EXT: Re: [PATCH resend] meta/classes: add class to test for unsatisfied RRECOMMENDS

[Jose Alarcon]

On 25.08.2017 15:29, Richard Purdie wrote:
> On Fri, 2017-08-25 at 09:43 +0300, Jose Alarcon wrote:
>> The do_rootfs log contains a number of unsatisfied package
>> recommendations. At the moment those are only visible when
>> reviewing the rootfs log.
>>
>> This class adds an extra check to surface any unsatisfied
>> recommendation  as WARNINGS to the build output.
>>
>> Signed-off-by: Jose Alarcon <jose.alarcon@ge.com>
>> ---
>>  meta/classes/rootfs-check-recommends.bbclass | 21
>> +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>  create mode 100644 meta/classes/rootfs-check-recommends.bbclass
> This looks like it would be a better fit for rootfs-
> postcommands.bbclass?

Thanks. I sent a new patch with this check done in rootfs-postcommands
class.

Cheers,

--
Jose

Re: EXT: Re: [PATCH resend] meta/classes: add class to test for unsatisfied RRECOMMENDS

[Jose Alarcon]

On 26.08.2017 14:27, Jose Alarcon wrote:
>
> On 25.08.2017 15:29, Richard Purdie wrote:
>> On Fri, 2017-08-25 at 09:43 +0300, Jose Alarcon wrote:
>>> The do_rootfs log contains a number of unsatisfied package
>>> recommendations. At the moment those are only visible when
>>> reviewing the rootfs log.
>>>
>>> This class adds an extra check to surface any unsatisfied
>>> recommendation  as WARNINGS to the build output.
>>>
>>> Signed-off-by: Jose Alarcon <jose.alarcon@ge.com>
>>> ---
>>>  meta/classes/rootfs-check-recommends.bbclass | 21
>>> +++++++++++++++++++++
>>>  1 file changed, 21 insertions(+)
>>>  create mode 100644 meta/classes/rootfs-check-recommends.bbclass
>> This looks like it would be a better fit for rootfs-
>> postcommands.bbclass?
> Thanks. I sent a new patch with this check done in rootfs-postcommands
> class.

New patch with the check done in rootfs-postcommands here:
https://patchwork.openembedded.org/series/8521/#

The reason why I implemented this as a class in the first place was that
we don't want to modify upstream layers and there is no way to append a
bbclass.
So I created a new class in our own layer instead. But for upstreaming
it is true that rootfs-postcommands is a better fit.

Thanks,

--
Jose