All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output
@ 2019-10-30 18:58 ` neil
  0 siblings, 0 replies; 8+ messages in thread
From: neil-Zmh7m9nwg1oHZynSCUjJ3A @ 2019-10-30 18:58 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Neil Mayhew

From: Neil Mayhew <neil@neil.mayhew.name>

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index a52f0b13a2c8..f802c784e6f6 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -4114,8 +4114,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
 		result = MODE_OK;
 	else
 		DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
-			      mode->vdisplay,
 			      mode->hdisplay,
+			      mode->vdisplay,
 			      mode->clock,
 			      dc_result);
 
-- 
2.23.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output
@ 2019-10-30 18:58 ` neil
  0 siblings, 0 replies; 8+ messages in thread
From: neil @ 2019-10-30 18:58 UTC (permalink / raw)
  To: amd-gfx; +Cc: Neil Mayhew

From: Neil Mayhew <neil@neil.mayhew.name>

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index a52f0b13a2c8..f802c784e6f6 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -4114,8 +4114,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
 		result = MODE_OK;
 	else
 		DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
-			      mode->vdisplay,
 			      mode->hdisplay,
+			      mode->vdisplay,
 			      mode->clock,
 			      dc_result);
 
-- 
2.23.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output
@ 2019-11-01 15:13     ` Harry Wentland
  0 siblings, 0 replies; 8+ messages in thread
From: Harry Wentland @ 2019-11-01 15:13 UTC (permalink / raw)
  To: neil-Zmh7m9nwg1oHZynSCUjJ3A, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

On 2019-10-30 2:58 p.m., neil@neil.mayhew.name wrote:
> From: Neil Mayhew <neil@neil.mayhew.name>

This requires your Signed-off-by. See [1].

With that fixed your change looks good and is
Reviewed-by: Harry Wentland <harry.wentland@amd.com>

You can simply reply to this email with your Signed-off-by and I can add
it when merging, or you can send a v2 patch with your Signed-off-by.

[1]
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Harry

> 
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index a52f0b13a2c8..f802c784e6f6 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -4114,8 +4114,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
>  		result = MODE_OK;
>  	else
>  		DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
> -			      mode->vdisplay,
>  			      mode->hdisplay,
> +			      mode->vdisplay,
>  			      mode->clock,
>  			      dc_result);
>  
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output
@ 2019-11-01 15:13     ` Harry Wentland
  0 siblings, 0 replies; 8+ messages in thread
From: Harry Wentland @ 2019-11-01 15:13 UTC (permalink / raw)
  To: neil, amd-gfx

On 2019-10-30 2:58 p.m., neil@neil.mayhew.name wrote:
> From: Neil Mayhew <neil@neil.mayhew.name>

This requires your Signed-off-by. See [1].

With that fixed your change looks good and is
Reviewed-by: Harry Wentland <harry.wentland@amd.com>

You can simply reply to this email with your Signed-off-by and I can add
it when merging, or you can send a v2 patch with your Signed-off-by.

[1]
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Harry

> 
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index a52f0b13a2c8..f802c784e6f6 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -4114,8 +4114,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
>  		result = MODE_OK;
>  	else
>  		DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
> -			      mode->vdisplay,
>  			      mode->hdisplay,
> +			      mode->vdisplay,
>  			      mode->clock,
>  			      dc_result);
>  
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output
@ 2019-11-01 15:47         ` Neil Mayhew
  0 siblings, 0 replies; 8+ messages in thread
From: Neil Mayhew @ 2019-11-01 15:47 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

On 2019-11-01 9:13 a.m., Harry Wentland wrote:
> On 2019-10-30 2:58 p.m., neil@neil.mayhew.name wrote:
>> From: Neil Mayhew <neil@neil.mayhew.name>
> This requires your Signed-off-by. See [1].
>
> With that fixed your change looks good and is
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> You can simply reply to this email with your Signed-off-by and I can add
> it when merging, or you can send a v2 patch with your Signed-off-by.

Signed-off-by: Neil Mayhew <neil@neil.mayhew.name>

Thanks, Harry.

> [1]
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>
> Harry
>
>> ---
>>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index a52f0b13a2c8..f802c784e6f6 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -4114,8 +4114,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
>>  		result = MODE_OK;
>>  	else
>>  		DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
>> -			      mode->vdisplay,
>>  			      mode->hdisplay,
>> +			      mode->vdisplay,
>>  			      mode->clock,
>>  			      dc_result);
>>  
>>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output
@ 2019-11-01 15:47         ` Neil Mayhew
  0 siblings, 0 replies; 8+ messages in thread
From: Neil Mayhew @ 2019-11-01 15:47 UTC (permalink / raw)
  To: amd-gfx

On 2019-11-01 9:13 a.m., Harry Wentland wrote:
> On 2019-10-30 2:58 p.m., neil@neil.mayhew.name wrote:
>> From: Neil Mayhew <neil@neil.mayhew.name>
> This requires your Signed-off-by. See [1].
>
> With that fixed your change looks good and is
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> You can simply reply to this email with your Signed-off-by and I can add
> it when merging, or you can send a v2 patch with your Signed-off-by.

Signed-off-by: Neil Mayhew <neil@neil.mayhew.name>

Thanks, Harry.

> [1]
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>
> Harry
>
>> ---
>>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index a52f0b13a2c8..f802c784e6f6 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -4114,8 +4114,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
>>  		result = MODE_OK;
>>  	else
>>  		DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
>> -			      mode->vdisplay,
>>  			      mode->hdisplay,
>> +			      mode->vdisplay,
>>  			      mode->clock,
>>  			      dc_result);
>>  
>>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output
@ 2019-11-01 20:30             ` Harry Wentland
  0 siblings, 0 replies; 8+ messages in thread
From: Harry Wentland @ 2019-11-01 20:30 UTC (permalink / raw)
  To: Neil Mayhew, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

On 2019-11-01 11:47 a.m., Neil Mayhew wrote:
> On 2019-11-01 9:13 a.m., Harry Wentland wrote:
>> On 2019-10-30 2:58 p.m., neil@neil.mayhew.name wrote:
>>> From: Neil Mayhew <neil@neil.mayhew.name>
>> This requires your Signed-off-by. See [1].
>>
>> With that fixed your change looks good and is
>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>>
>> You can simply reply to this email with your Signed-off-by and I can add
>> it when merging, or you can send a v2 patch with your Signed-off-by.
> 
> Signed-off-by: Neil Mayhew <neil@neil.mayhew.name>
> 

Thanks and thanks for your fix. Applied.

Harry

> Thanks, Harry.
> 
>> [1]
>> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>>
>> Harry
>>
>>> ---
>>>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> index a52f0b13a2c8..f802c784e6f6 100644
>>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> @@ -4114,8 +4114,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
>>>  		result = MODE_OK;
>>>  	else
>>>  		DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
>>> -			      mode->vdisplay,
>>>  			      mode->hdisplay,
>>> +			      mode->vdisplay,
>>>  			      mode->clock,
>>>  			      dc_result);
>>>  
>>>
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output
@ 2019-11-01 20:30             ` Harry Wentland
  0 siblings, 0 replies; 8+ messages in thread
From: Harry Wentland @ 2019-11-01 20:30 UTC (permalink / raw)
  To: Neil Mayhew, amd-gfx

On 2019-11-01 11:47 a.m., Neil Mayhew wrote:
> On 2019-11-01 9:13 a.m., Harry Wentland wrote:
>> On 2019-10-30 2:58 p.m., neil@neil.mayhew.name wrote:
>>> From: Neil Mayhew <neil@neil.mayhew.name>
>> This requires your Signed-off-by. See [1].
>>
>> With that fixed your change looks good and is
>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>>
>> You can simply reply to this email with your Signed-off-by and I can add
>> it when merging, or you can send a v2 patch with your Signed-off-by.
> 
> Signed-off-by: Neil Mayhew <neil@neil.mayhew.name>
> 

Thanks and thanks for your fix. Applied.

Harry

> Thanks, Harry.
> 
>> [1]
>> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>>
>> Harry
>>
>>> ---
>>>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> index a52f0b13a2c8..f802c784e6f6 100644
>>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> @@ -4114,8 +4114,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
>>>  		result = MODE_OK;
>>>  	else
>>>  		DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
>>> -			      mode->vdisplay,
>>>  			      mode->hdisplay,
>>> +			      mode->vdisplay,
>>>  			      mode->clock,
>>>  			      dc_result);
>>>  
>>>
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-11-01 20:30 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 18:58 [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output neil-Zmh7m9nwg1oHZynSCUjJ3A
2019-10-30 18:58 ` neil
     [not found] ` <20191030185837.8766-1-neil-Zmh7m9nwg1oHZynSCUjJ3A@public.gmane.org>
2019-11-01 15:13   ` Harry Wentland
2019-11-01 15:13     ` Harry Wentland
     [not found]     ` <e970ad7b-3ca6-a6a4-ebf0-83b5f6b3b153-5C7GfCeVMHo@public.gmane.org>
2019-11-01 15:47       ` Neil Mayhew
2019-11-01 15:47         ` Neil Mayhew
     [not found]         ` <1b3d267d-7d0a-1fbb-44c5-89d1695e3733-Zmh7m9nwg1oHZynSCUjJ3A@public.gmane.org>
2019-11-01 20:30           ` Harry Wentland
2019-11-01 20:30             ` Harry Wentland

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.