[PATCH v2 0/2] Staging: vchi: Add license id and change int type

[PATCH v2 0/2] Staging: vchi: Add license id and change int type

[andrealmeid at riseup.net]

From: Andr? Almeida <andrealmeid@riseup.net>

Fix the following checkpatch issues:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
CHECK: Prefer kernel type 's32' over 'int32_t'

Changes in v2:
- Splits commits in a patch set
- Fixes licenses in SPDX identifier
- Adds a more descriptive commit message

v1: https://www.spinics.net/lists/arm-kernel/msg685603.html

Andr? Almeida (2):
  staging: vchi: change type 'int32_t' to 's32'
  stagin: vchi: Add SPDX-License-Identifier

 drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.19.1

[PATCH v2 1/2] staging: vchi: change type 'int32_t' to 's32'

[andrealmeid at riseup.net]

From: Andr? Almeida <andrealmeid@riseup.net>

As one can see in a typedef at linux/types.h:103, s32 and int32_t are
both a 32 bits signed integer. s32 is preferred because it is defined
by the kernel maintainers and it prevents portability issues. Changed
to meet checkpatch criteria.

Signed-off-by: Andr? Almeida <andrealmeid@riseup.net>

---
 drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
index 198bd076b666..40c760d493a1 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
@@ -36,7 +36,7 @@
 
 #include <linux/types.h>
 
-typedef int32_t VCHI_MEM_HANDLE_T;
+typedef s32 VCHI_MEM_HANDLE_T;
 #define VCHI_MEM_HANDLE_INVALID 0
 
 #endif
-- 
2.19.1

[PATCH v2 2/2] stagin: vchi: Add SPDX-License-Identifier

[andrealmeid at riseup.net]

From: Andr? Almeida <andrealmeid@riseup.net>

As pointed by Stefan Wahren in v1, this file is dual licensed
as GPL-2 and BSD-3.

Using multiple license representation as shown here [1].

[1] https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf

Signed-off-by: Andr? Almeida <andrealmeid@riseup.net>

---

 drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
index 40c760d493a1..5c780ec49ff7 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) */
 /**
  * Copyright (c) 2010-2012 Broadcom. All rights reserved.
  *
-- 
2.19.1

[PATCH v2 2/2] stagin: vchi: Add SPDX-License-Identifier

[Stefan Wahren]

Hi Andre,

Am 13.11.2018 um 01:37 schrieb andrealmeid at riseup.net:
> From: Andr? Almeida <andrealmeid@riseup.net>
>
> As pointed by Stefan Wahren in v1, this file is dual licensed
> as GPL-2 and BSD-3.

please avoid references to old versions in the commit log, because after
applying this patch the context get lost.

Looks like you missed my comment about removal of the license text.
Please look at this example:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20181113&id=bb1e67793f3ee42449f60c2288096da01199443e

Best regards

>
> Using multiple license representation as shown here [1].
>
> [1] https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf
>
> Signed-off-by: Andr? Almeida <andrealmeid@riseup.net>
>
> ---
>
>  drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
> index 40c760d493a1..5c780ec49ff7 100644
> --- a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
> +++ b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) */
>  /**
>   * Copyright (c) 2010-2012 Broadcom. All rights reserved.
>   *

[PATCH v2 0/2] Staging: vchi: Add license id and change int type

[Stefan Wahren]

Hi Andre,

Am 13.11.2018 um 01:37 schrieb andrealmeid at riseup.net:
> From: Andr? Almeida <andrealmeid@riseup.net>
>
> Fix the following checkpatch issues:
>
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> CHECK: Prefer kernel type 's32' over 'int32_t'
>
> Changes in v2:
> - Splits commits in a patch set
> - Fixes licenses in SPDX identifier
> - Adds a more descriptive commit message
>
> v1: https://www.spinics.net/lists/arm-kernel/msg685603.html
>
> Andr? Almeida (2):
>   staging: vchi: change type 'int32_t' to 's32'
>   stagin: vchi: Add SPDX-License-Identifier
>
>  drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
sorry i didn't noticed this before my Ack, but Nicolas wants to remove
the whole file in his patch series.

Stefan