From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Make 'replication_state' an enum
Date: Tue, 21 Mar 2017 12:52:22 -0500 [thread overview]
Message-ID: <1b5a71f6-6038-ac18-a3af-b2b75a4fd8ae@redhat.com> (raw)
In-Reply-To: <20170317021739.16877-1-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
On 03/16/2017 09:17 PM, Fam Zheng wrote:
> BDRVReplicationState.replication_state is a name with a bit of
> duplication, plus it could be an enum like BDRVReplicationState.mode,
> which is be more readable and also more straightforward in a debuuger.
With the followup commit message cleanups,
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Rename it, and improve the type while at it.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/replication.c | 44 ++++++++++++++++++++++----------------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-21 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 2:17 [Qemu-devel] [PATCH] block: Make 'replication_state' an enum Fam Zheng
2017-03-17 4:08 ` Fam Zheng
2017-03-21 17:52 ` Eric Blake [this message]
2017-04-23 9:12 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b5a71f6-6038-ac18-a3af-b2b75a4fd8ae@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.