[PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

[PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

[Kukjin Kim]

Fix the values of S3C6400_EPLL_MDIV_MASK, S3C6400_EPLL_PDIV_MASK, and
S3C6400_EPLL_SDIV_MASK.

Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
 arch/arm/plat-s3c64xx/include/plat/pll.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/plat-s3c64xx/include/plat/pll.h b/arch/arm/plat-s3c64xx/include/plat/pll.h
index 90bbd72..3a59d3b 100644
--- a/arch/arm/plat-s3c64xx/include/plat/pll.h
+++ b/arch/arm/plat-s3c64xx/include/plat/pll.h
@@ -37,9 +37,9 @@ static inline unsigned long s3c6400_get_pll(unsigned long baseclk,
 	return (unsigned long)fvco;
 }
 
-#define S3C6400_EPLL_MDIV_MASK	((1 << (23-16)) - 1)
-#define S3C6400_EPLL_PDIV_MASK	((1 << (13-8)) - 1)
-#define S3C6400_EPLL_SDIV_MASK	((1 << (2-0)) - 1)
+#define S3C6400_EPLL_MDIV_MASK	((1 << (23-16+1)) - 1)
+#define S3C6400_EPLL_PDIV_MASK	((1 << (13-8+1)) - 1)
+#define S3C6400_EPLL_SDIV_MASK	((1 << (2-0+1)) - 1)
 #define S3C6400_EPLL_MDIV_SHIFT	(16)
 #define S3C6400_EPLL_PDIV_SHIFT	(8)
 #define S3C6400_EPLL_SDIV_SHIFT	(0)
-- 
1.5.3.4

Re: [PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

[jassi brar]

On Thu, Oct 1, 2009 at 6:22 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> -#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16)) - 1)
> -#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8)) - 1)
> -#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0)) - 1)
> +#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16+1)) - 1)
> +#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8+1)) - 1)
> +#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0+1)) - 1)
>  #define S3C6400_EPLL_MDIV_SHIFT        (16)
>  #define S3C6400_EPLL_PDIV_SHIFT        (8)
>  #define S3C6400_EPLL_SDIV_SHIFT        (0)

dunno it it's a problem but please checkout it out ....
http://git.kernel.org/?p=linux/kernel/git/broonie/sound-2.6.git;a=blob;f=arch/arm/plat-s3c64xx/include/plat/pll.h;h=90bbd72fdc4ef356b177722625c384f9fb2e474f;hb=for-2.6.33
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] S3C64xx: Fix S3C6400_EPLL_ MDIV_MASK, PDIV_MASK, and SDIV_MASK value

[jassi brar]

On Thu, Oct 1, 2009 at 7:42 PM, jassi brar <jassisinghbrar@gmail.com> wrote:
> On Thu, Oct 1, 2009 at 6:22 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> -#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16)) - 1)
>> -#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8)) - 1)
>> -#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0)) - 1)
>> +#define S3C6400_EPLL_MDIV_MASK ((1 << (23-16+1)) - 1)
>> +#define S3C6400_EPLL_PDIV_MASK ((1 << (13-8+1)) - 1)
>> +#define S3C6400_EPLL_SDIV_MASK ((1 << (2-0+1)) - 1)
>>  #define S3C6400_EPLL_MDIV_SHIFT        (16)
>>  #define S3C6400_EPLL_PDIV_SHIFT        (8)
>>  #define S3C6400_EPLL_SDIV_SHIFT        (0)
>
> dunno it it's a problem but please checkout it out ....
> http://git.kernel.org/?p=linux/kernel/git/broonie/sound-2.6.git;a=blob;f=arch/arm/plat-s3c64xx/include/plat/pll.h;h=90bbd72fdc4ef356b177722625c384f9fb2e474f;hb=for-2.6.33
Never mind. The patch seems fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html