[PATCH]: Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

[PATCH]: Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

[Maurus Cuelenaere]

This patch removes the duplicated s3c_dma_has_circular() definition and so fixes
compilation for S3C64xx.

Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>

---
 arch/arm/mach-s3c6400/include/mach/dma.h |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-s3c6400/include/mach/dma.h
b/arch/arm/mach-s3c6400/include/mach/dma.h
index 004edab..b7e5494 100644
--- a/arch/arm/mach-s3c6400/include/mach/dma.h
+++ b/arch/arm/mach-s3c6400/include/mach/dma.h
@@ -58,14 +58,6 @@ enum dma_ch {
 	DMACH_MAX		/* the end */
 };

-static __inline__ int s3c_dma_has_circular(void)
-{
-	/* we will be supporting ciruclar buffers as soon as we have DMA
-	 * engine support.
-	 */
-	return 1;
-}
-
 #define S3C2410_DMAF_CIRCULAR		(1 << 0)

 static inline bool s3c_dma_has_circular(void)
-- 
1.6.3.3

[PATCH]: Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

[Ben Dooks]

On Tue, Nov 03, 2009 at 11:35:30PM +0100, Maurus Cuelenaere wrote:
> This patch removes the duplicated s3c_dma_has_circular() definition and so fixes
> compilation for S3C64xx.

removing the wrong one, we've submitted the necessary circular buffer
updates to allow the audio to work without causing it to lose buffers.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

[PATCH]: Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

[Maurus Cuelenaere]

Op 03-11-09 23:39, Ben Dooks schreef:
> On Tue, Nov 03, 2009 at 11:35:30PM +0100, Maurus Cuelenaere wrote:
>    
>> This patch removes the duplicated s3c_dma_has_circular() definition and so fixes
>> compilation for S3C64xx.
>>      
> removing the wrong one, we've submitted the necessary circular buffer
> updates to allow the audio to work without causing it to lose buffers.
>    

Ah, should I resubmit a patch which removes the other one?

Regards,
Maurus Cuelenaere

[PATCH]: Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

[Ben Dooks]

On Tue, Nov 03, 2009 at 11:43:17PM +0100, Maurus Cuelenaere wrote:
> Op 03-11-09 23:39, Ben Dooks schreef:
>> On Tue, Nov 03, 2009 at 11:35:30PM +0100, Maurus Cuelenaere wrote:
>>    
>>> This patch removes the duplicated s3c_dma_has_circular() definition and so fixes
>>> compilation for S3C64xx.
>>>      
>> removing the wrong one, we've submitted the necessary circular buffer
>> updates to allow the audio to work without causing it to lose buffers.
>>    
>
> Ah, should I resubmit a patch which removes the other one?

yes.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

[PATCH]: Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

[jassi brar]

On Wed, Nov 4, 2009 at 8:06 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Tue, Nov 03, 2009 at 11:43:17PM +0100, Maurus Cuelenaere wrote:
>> Op 03-11-09 23:39, Ben Dooks schreef:
>>> On Tue, Nov 03, 2009 at 11:35:30PM +0100, Maurus Cuelenaere wrote:
>>>
>>>> This patch removes the duplicated s3c_dma_has_circular() definition and so fixes
>>>> compilation for S3C64xx.
>>>>
>>> removing the wrong one, we've submitted the necessary circular buffer
>>> updates to allow the audio to work without causing it to lose buffers.
>>>
>>
>> Ah, should I resubmit a patch which removes the other one?
>
> yes.
but, then we will have 'bool' version for s3c2410 and 'int' type for s3c64xx.