All of lore.kernel.org
 help / color / mirror / Atom feed
From: jassi brar <jassisinghbrar@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
	Jassi Brar <jassi.brar@samsung.com>,
	ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org,
	lrg@slimlogic.co.uk
Subject: Re: [PATCH 3/3] ARM: SMDK64XX: Enable AC97 device
Date: Tue, 26 Jan 2010 19:52:45 +0900	[thread overview]
Message-ID: <1b68c6791001260252t7f43cb97n710381508040f7d4@mail.gmail.com> (raw)
In-Reply-To: <20100126101921.GE15759@rakim.wolfsonmicro.main>

On Tue, Jan 26, 2010 at 7:19 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Jan 26, 2010 at 02:51:41PM +0900, jassisinghbrar@gmail.com wrote:
>> From: Jassi Brar <jassi.brar@samsung.com>
>>
>> Implementing basic support for Playback/Capture by SMDK's AC97
>> controller with WM9713 codec, this patch adds the ALSA machine
>> driver for AC97 device.
>
> Might be better to split this into an arch/arm patch and a sound/soc
> patch - they don't appear to depend on each other so it'd ease merging.
ok, will do.

>> +static int smdk_hifi_hw_params(struct snd_pcm_substream *substream,
>> +                             struct snd_pcm_hw_params *params)
>> +{
>> +     /* CAPTURE - Stereo LineIn
>> +      * Currently there is no other way to change ACLink-In slots
>> +      * of Wm9713, so we make do with this call.
>> +      */
>> +     /* Slots-3,4*/
>> +     soc_ac97_ops.write(NULL, 0x5c, 0);
>> +
>> +     return 0;
>> +}
>
> This one needs a bit more explanation - why are you changing the AC97
> slot?  Is this a general problem with the S3C AC97 controller?  It'd
> also be better to use the symbolic register name rather than a number.
It is no problem.
wm9713 can be configured to place data in one of four possible pair of slots
3-4 or 6-9 or 7-8 or 10-11. This call ensures the selected pair is 3-4(standard
and compatible with Samsung AC97 controllers). Though we don't need to
explicitly set this if we drop mic dai_link.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: jassisinghbrar@gmail.com (jassi brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: SMDK64XX: Enable AC97 device
Date: Tue, 26 Jan 2010 19:52:45 +0900	[thread overview]
Message-ID: <1b68c6791001260252t7f43cb97n710381508040f7d4@mail.gmail.com> (raw)
In-Reply-To: <20100126101921.GE15759@rakim.wolfsonmicro.main>

On Tue, Jan 26, 2010 at 7:19 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Jan 26, 2010 at 02:51:41PM +0900, jassisinghbrar at gmail.com wrote:
>> From: Jassi Brar <jassi.brar@samsung.com>
>>
>> Implementing basic support for Playback/Capture by SMDK's AC97
>> controller with WM9713 codec, this patch adds the ALSA machine
>> driver for AC97 device.
>
> Might be better to split this into an arch/arm patch and a sound/soc
> patch - they don't appear to depend on each other so it'd ease merging.
ok, will do.

>> +static int smdk_hifi_hw_params(struct snd_pcm_substream *substream,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? struct snd_pcm_hw_params *params)
>> +{
>> + ? ? /* CAPTURE - Stereo LineIn
>> + ? ? ?* Currently there is no other way to change ACLink-In slots
>> + ? ? ?* of Wm9713, so we make do with this call.
>> + ? ? ?*/
>> + ? ? /* Slots-3,4*/
>> + ? ? soc_ac97_ops.write(NULL, 0x5c, 0);
>> +
>> + ? ? return 0;
>> +}
>
> This one needs a bit more explanation - why are you changing the AC97
> slot? ?Is this a general problem with the S3C AC97 controller? ?It'd
> also be better to use the symbolic register name rather than a number.
It is no problem.
wm9713 can be configured to place data in one of four possible pair of slots
3-4 or 6-9 or 7-8 or 10-11. This call ensures the selected pair is 3-4(standard
and compatible with Samsung AC97 controllers). Though we don't need to
explicitly set this if we drop mic dai_link.

  reply	other threads:[~2010-01-26 10:52 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26  5:51 [PATCH 1/3] ARM: S3C64XX: Add AC97 platform resources jassisinghbrar
2010-01-26  5:51 ` jassisinghbrar at gmail.com
2010-01-26  5:51 ` [PATCH 2/3] ASoC: AC97: S3C: Add controller driver jassisinghbrar
2010-01-26  5:51   ` jassisinghbrar at gmail.com
2010-01-26  5:51   ` [PATCH 3/3] ARM: SMDK64XX: Enable AC97 device jassisinghbrar
2010-01-26  5:51     ` jassisinghbrar at gmail.com
2010-01-26 10:19     ` Mark Brown
2010-01-26 10:19       ` Mark Brown
2010-01-26 10:52       ` jassi brar [this message]
2010-01-26 10:52         ` jassi brar
2010-01-26 10:59         ` Mark Brown
2010-01-26 10:59           ` Mark Brown
2010-01-26  7:32   ` [PATCH 2/3] ASoC: AC97: S3C: Add controller driver jassi brar
2010-01-26  7:32     ` jassi brar
2010-01-26 10:53     ` Mark Brown
2010-01-26 10:53       ` Mark Brown
2010-01-26 11:49       ` jassi brar
2010-01-26 11:49         ` jassi brar
2010-01-26 10:23   ` Ben Dooks
2010-01-26 10:23     ` Ben Dooks
2010-01-26 11:03     ` jassi brar
2010-01-26 11:03       ` jassi brar
2010-01-26 11:09       ` Mark Brown
2010-01-26 11:09         ` Mark Brown
2010-01-26 11:57         ` jassi brar
2010-01-26 11:57           ` jassi brar
2010-01-26 12:04           ` Mark Brown
2010-01-26 12:04             ` Mark Brown
2010-01-27  2:45       ` jassi brar
2010-01-27  2:45         ` jassi brar
2010-01-27 10:25         ` Mark Brown
2010-01-27 10:25           ` Mark Brown
2010-01-26 10:47   ` Mark Brown
2010-01-26 10:47     ` Mark Brown
2010-01-26 11:17     ` jassi brar
2010-01-26 11:17       ` jassi brar
2010-01-26 11:52       ` Mark Brown
2010-01-26 11:52         ` Mark Brown
2010-01-26 12:11         ` jassi brar
2010-01-26 12:11           ` jassi brar
2010-01-26 13:00           ` Mark Brown
2010-01-26 13:00             ` Mark Brown
2010-01-26 10:12 ` [PATCH 1/3] ARM: S3C64XX: Add AC97 platform resources Mark Brown
2010-01-26 10:12   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b68c6791001260252t7f43cb97n710381508040f7d4@mail.gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ben-linux@fluff.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jassi.brar@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.